Commit Graph
4942 Commits
Author SHA1 Message Date
Sameh Khamis 2004cad9d0 Merge pull request #1844 from bilawalsidhu/samehkhamis/sfc-credits
Vue: the credits line and its Data attribution list are a single-file component
2026-11-19 02:33:50 -08:00
Sameh KhamisandManjunath Paparaju b5fcc39bc0 Add the changelog entry for #1844
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 02:14:22 -08:00
Sameh Khamis d6439ce3f0 Merge remote-tracking branch 'origin/main' into samehkhamis/sfc-credits
# Conflicts:
#	docs/VUE-MIGRATION.md
2026-11-19 02:14:22 -08:00
Sameh Khamis c851825119 Merge pull request #1843 from bilawalsidhu/samehkhamis/kit-dialog
Vue kit: UiDialog for the Data Library and scene sharing dialogs
2026-11-19 02:13:56 -08:00
Sameh KhamisandManjunath Paparaju 0b06bc6645 Vue: the credits line and its Data attribution list are a single-file component
mountCreditsView() keeps its signature and stays the owner: it computes the
credits shown once each, keeps the list's open state and its focus, takes the
expand and close clicks and Escape, and renders CreditsView synchronously
(as the weather readout is rendered), so focus moves as soon as a change
returns. The view teleports the line and the list to the end of the body, as
the script appended them, so the page's rules that select them as children
of the body still apply; CreditItem draws one credit (its logo or its text,
only its linked words linked, links and logos kept only for a safe scheme).

The ids, classes, roles, aria attributes and text are unchanged. The list's
close button is a UiCloseButton with bare, keeping the browser's padding, so
it only gains the kit's classes, which carry no rules. The expand button
stays a plain button: its words are its content, which a UiButton slot would
not word again when the owner renders a new locale. The list's items are
keyed by credit, so a link that keeps its place keeps focus through a
redraw; one that goes still hands focus to the close button.

New tests: the line and list follow the locale, and they are the last of the
body with the kit's close button.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 01:58:47 -08:00
Sameh KhamisandManjunath Paparaju 7c858d96ee Add the changelog entry for #1843
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 01:54:17 -08:00
Sameh Khamis 7c925f610d Merge remote-tracking branch 'origin/main' into samehkhamis/kit-dialog 2026-11-19 01:54:17 -08:00
Sameh Khamis c17eda4118 Merge pull request #1842 from bilawalsidhu/samehkhamis/kit-checkbox
Vue kit: UiCheckbox for the Visual, voice, Data Library and welcome checkboxes
2026-11-19 01:48:03 -08:00
Sameh KhamisandManjunath Paparaju d55f696514 Add the changelog entry for #1842
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 01:32:05 -08:00
Sameh Khamis 29e38b6198 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-checkbox 2026-11-19 01:31:58 -08:00
Sameh Khamis fc9d59f258 Merge pull request #1841 from bilawalsidhu/samehkhamis/kit-search-field
Vue kit: UiSearchField for the Context and Layer Finder searches
2026-11-19 01:31:48 -08:00
Sameh KhamisandManjunath Paparaju 1f34210f71 Vue kit: a late close event no longer shuts a reopened dialog; a scene sharing dialog the browser closes closes through its owner; the opened timing test can fail
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 01:21:10 -08:00
Sameh KhamisandManjunath Paparaju ec4a5b6afe Vue kit: UiDialog for the Data Library and scene sharing dialogs
UiDialog is a native <dialog> its owner opens and closes with open: true
opens it with showModal() (on mount, for one mounted open), false closes
it, and unmounting closes it. Each change is applied once the content has
rendered and then emitted as opened or closed, so the Data Library still
focuses its search field on open and returns focus to Browse on close.
Escape's cancel is prevented and emitted as dismiss; backdropDismiss makes
a click on the dialog itself a dismiss too, as the Data Library's was. When
the browser closes the dialog on its own while open is still true,
browserClose tells the owner, as the Data Library's close listener did;
closing on unmount reports nothing. A DOM without showModal() leaves it
closed. Attributes, classes, styles and listeners go to the dialog, and
element is exposed.

The two dialogs share no declarations, so there are no kit rules.
dialogs.test.mjs fails if a view writes a <dialog> by hand; the panels drawn
as role="dialog" are other controls.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 01:16:46 -08:00
Sameh Khamis 31ed97043a Merge remote-tracking branch 'origin/main' into samehkhamis/kit-search-field
# Conflicts:
#	docs/VUE-MIGRATION.md
2026-11-19 01:10:34 -08:00
Sameh KhamisandManjunath Paparaju 2d7b7be890 Vue kit: UiCheckbox for the Visual, voice, Data Library and welcome checkboxes
UiCheckbox is a label wrapping a native checkbox and its words; trailing
puts the box after them, as the Visual panel's rows have it. v-model shows
the value and emits the checked state, and change is emitted with its event;
without a modelValue the box is the browser's own, as the welcome card's
"Don't show this again" is. restore puts the box back to modelValue once a
change has rendered without the owner taking it, which is what the voice
panel's v-checked directive did for a refused preference. Attributes go to
the label; inputId and inputAttrs to the box.

checkbox.css holds the centred flex row, moved out of the two labels that
hold only a checkbox (first-run.css, library.css) and loaded before them.
Each box keeps its skin's size, margin and accent colour. checkboxes.test.mjs
fails if a view writes a checkbox by hand; Story Explore's filters are not
converted yet.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 01:05:12 -08:00
Sameh Khamis fb49418851 Merge pull request #1840 from bilawalsidhu/samehkhamis/kit-close-button
Vue kit: UiCloseButton for every close button in the views
2026-11-19 00:57:23 -08:00
Sameh KhamisandManjunath Paparaju b3e6c265e8 Add the changelog entry for #1841
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 00:48:57 -08:00
Sameh Khamis f09e9ce6eb Merge branch 'main' into samehkhamis/kit-close-button 2026-11-19 00:43:52 -08:00
Sameh KhamisandManjunath Paparaju 52dd576769 Vue kit: UiSearchField for the Context and Layer Finder searches
UiSearchField is the search glyph, a search input with v-model and, with
clearLabel, a UiCloseButton shown while text is typed that clears and
refocuses. tag is div or label; attributes go to the frame, and inputId,
inputClass, autocomplete and spellcheck to the input. Escape stops at the
input and is emitted with its event; focus() focuses the input.

search-field.css holds the declarations both skins had in common (the
frame's flex row, the input's min-width, border and background), moved out
of context-dock.css and layer-finder.css and loaded before them. The
browser's cancel button stays each skin's own.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 00:42:51 -08:00
Sameh Khamis 3235e404da Merge pull request #1839 from bilawalsidhu/samehkhamis/kit-styles
Vue kit: the kit's classes carry Core's standard looks
2026-11-19 00:29:03 -08:00
Sameh KhamisandManjunath Paparaju 2418e43545 Vue kit: bare is for skins that set their own padding; pin the CCTV and Inspector close load order; changelog for #1840
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 00:26:29 -08:00
Sameh KhamisandManjunath Paparaju 1711b4b456 Vue kit: UiCloseButton for every close button in the views
UiCloseButton is a UiButton with a fixed glyph (× or the Material close
symbol through UiIcon), a required accessible label and no tip unless the
site passes a title. Attributes and classes pass through, so each site keeps
its id, feature class, data and aria attributes, and its look.

Its kit class, ui-close-button (close-button.css, loaded before the feature
stylesheets), is Core's common look: a bare glyph with no padding, border
or background of its own, and a pointer. The guide's close button shares
the rule, and the copies of those declarations leave the feature rules.
`bare` leaves the look off for Street Level's and the space mission's close
buttons, whose skins keep the browser's padding. UiIcon takes size null to
leave the glyph's size to the stylesheet.

The sixteen hand-written close, dismiss and clear buttons in the SFCs are
now UiCloseButtons; closeButtons.test.mjs pins that none remain.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 00:19:33 -08:00
Sameh Khamis c58f9fbdc6 Merge branch 'main' into samehkhamis/kit-styles 2026-11-19 00:17:02 -08:00
Sameh KhamisandManjunath Paparaju 0d3c3325d4 Vue kit: compact styles the action variant only, tone is accent or danger, a disabled icon button dims; pin the inherited type
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 23:51:16 -08:00
Sameh Khamis 5f71ee0273 Merge pull request #1837 from bilawalsidhu/samehkhamis/rail-and-hud-cleanup
Keep the panel rails clear of an obstacle across the middle of a short window
2026-11-18 23:48:06 -08:00
Sameh KhamisandManjunath Paparaju 4114ea1a05 Add the changelog entry for #1839
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 23:45:02 -08:00
Sameh KhamisandManjunath Paparaju 9f8a4cb39d Vue kit: the kit's classes wear Core's standard looks
UiButton gains styled variants beside the unstyled default ghost:
action (the gev-action-button surface, tone="danger" and size="compact"),
primary (that surface with the scene panel's main-action accent) and icon
(the panel collapse toggle's square glyph button). A pressed styled button
looks as a hovered one does. UiChip wears the read-only chip (now chip.css,
shared with the news chips), UiEmpty the one-line empty state (now
empty-state.css, shared with the news readout), and UiBadge and UiSegmented
carry their skins through the kit's own classes too.

Every kit selector shares one selector list with the Core skin it comes
from, in skins loaded before the feature stylesheets, so no rule is copied
and feature classes still win. The app renders as before: the voice card
chip and the Recent Imagery and Authoring empty states keep their own type
by inheriting it, and the dock pin buttons drop variant="icon", which they
never wore. kitStyles.test.mjs pins the shared rules.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 23:42:55 -08:00
Sameh Khamis 6502028fbe Merge branch 'main' into samehkhamis/rail-and-hud-cleanup 2026-11-18 23:33:51 -08:00
Sameh KhamisandManjunath Paparaju c1e58b72b9 fix(ui): any positive room counts when a midpoint band asks for no minimum
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 23:26:22 -08:00
Sameh KhamisandManjunath Paparaju fd64a78aca test(ui): pin the midpoint band's exact minimum, and correct a test comment
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 23:26:10 -08:00
Sameh Khamis 9977154606 Merge pull request #1838 from bilawalsidhu/samehkhamis/nearby-places-fixes
Prefer a nearby small place over a far namesake, and bound the place tiles a lookup reads
2026-11-18 23:15:55 -08:00
Sameh KhamisandManjunath Paparaju 10dbd2f937 fix(ui): a side of a midpoint block thinner than 8% of the window holds no panel; pin the lower merge edge
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 23:14:26 -08:00
Sameh KhamisandManjunath Paparaju 378df7b613 fix(ui): neighbours exactly two gaps from a midpoint obstacle join its block, and the band beside it stays inside the rail's own edges
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 23:02:10 -08:00
Sameh KhamisandManjunath Paparaju 81df2c8c42 fix(ui): the left rail's panels use all the room it counted above an obstacle across the middle
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 23:01:47 -08:00
Sameh KhamisandManjunath Paparaju 50824c9a65 test(places): pin the pack build-date rule and a nearer village beating a namesake inside a wide search
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 22:54:53 -08:00
Sameh KhamisandManjunath Paparaju 98a100ed7e fix(ui): rails count the obstacles beside those across the middle, and read them as before when neither side has room
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 22:51:42 -08:00
Sameh KhamisandManjunath Paparaju 75e345aa07 fix(places): small places stop at 500 km even in tiles that reach past it
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 22:44:36 -08:00
Sameh KhamisandManjunath Paparaju d2797dbad2 fix(places): keep the places index's build date only when every tile is unchanged; say the 500 km cap is for wide lookups
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 22:44:12 -08:00
Sameh KhamisandManjunath Paparaju ecb7e7cd68 Add the changelog entry for #1838
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 22:41:36 -08:00
Sameh KhamisandManjunath Paparaju feedd88614 fix(ui): rails take obstacles across the middle together, so their order never picks the side
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 22:39:29 -08:00
Sameh KhamisandManjunath Paparaju a2c86c0fed fix(places): a rebuild writes its files before removing stale tiles, and keeps the build date when nothing changed
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 22:34:59 -08:00
Sameh KhamisandManjunath Paparaju 30ec362c13 fix(places): look for small places within 500 km, so a whole-globe view reads only the tiles near its centre
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 22:34:59 -08:00
Sameh KhamisandManjunath Paparaju f414df97eb fix(places): a small place in view comes before a far bigger namesake
findPlace looked at the detail tiles only when no city had the typed name,
so a village called Paris in view lost to Paris, France. With
includeSmallPlaces it now reads the places near the view as well and takes
the nearest place of the name there, city or not. With none near, the
largest city of the name still wins.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 22:34:59 -08:00
Sameh KhamisandManjunath Paparaju 31a7b6a0a5 Add the changelog entry for #1837
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 22:32:50 -08:00
Sameh KhamisandManjunath Paparaju 8b055a1423 fix(ui): panel rails keep clear of an obstacle across the middle of the window
An obstacle that crossed the middle of the window (the World Timeline, the
voice control or a card in a window under about 520px tall) was neither
above nor below it, so neither rail counted it and panels could be laid out
over it. Such an obstacle now puts the panels on whichever side of it has
more room. When neither side has room, the rails keep their existing
minimum (the right rail's empty band, the left rail's minimum lane height).

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 22:32:40 -08:00
Sameh Khamis ec1fc6bc09 Merge pull request #1831 from bilawalsidhu/samehkhamis/omnibar-reading-fixes
Read more Omnibar lines the way they are meant
2026-11-18 22:26:52 -08:00
Sameh Khamis edf595f69f Merge branch 'main' into samehkhamis/omnibar-reading-fixes 2026-11-18 22:14:08 -08:00
Sameh Khamis 0534dcebf6 Merge pull request #1830 from bilawalsidhu/samehkhamis/place-privacy-2
Keep spelled-out emails, IP addresses, recovery phrases and lower-case codes from the place service
2026-11-18 22:13:59 -08:00
Sameh Khamis f6f1ee2a3a Merge branch 'main' into samehkhamis/place-privacy-2 2026-11-18 22:02:01 -08:00
Sameh Khamis e9fd19acb3 Merge pull request #1829 from bilawalsidhu/samehkhamis/space-missions-fixes
Finish the Space Missions shutdown, and let label clicks reach every layer
2026-11-18 22:01:51 -08:00