Merge remote-tracking branch 'origin/main' into samehkhamis/sfc-credits

# Conflicts:
#	docs/VUE-MIGRATION.md
This commit is contained in:
Sameh Khamis committed 2026-11-19 02:14:22 -08:00
commit d6439ce3f0
7 files changed
+21 -4

No files matched your search

+3
View File
@@ -0,0 +1,3 @@
- Every close, dismiss and clear button in the views is now one kit
component, `UiCloseButton`, with the same look and behaviour as before
(manjunath22466, samehkhamis, #1840).
+3
View File
@@ -0,0 +1,3 @@
- The Context panel search and the Layer Finder search are now one kit
component, `UiSearchField`, with the same look and behaviour as before
(manjunath22466, samehkhamis, #1841).
+4
View File
@@ -0,0 +1,4 @@
- The Visual panel's toggles, the voice settings, the Data Library's
"available only" box and the welcome screen's "Don't show this again" are
now one kit component, `UiCheckbox`, with the same look and behaviour as
before (manjunath22466, samehkhamis, #1842).
+5
View File
@@ -0,0 +1,5 @@
- The Data Library and scene sharing dialogs are now one kit component,
`UiDialog`. A scene sharing dialog the browser closes on its own now
cancels through its owner, so the next share is not blocked, and a late
close event no longer shuts a dialog opened again since (manjunath22466,
samehkhamis, #1843).
+2 -2
View File
@@ -53,7 +53,7 @@ never copied:
| `UiButton` `variant="action"` | the action surface (`gev-action-button`); `tone="danger"` hovers red, `size="compact"` is the shot-row footprint (on this variant only) | `src/ui/styles/action-button.css` |
| `UiButton` `variant="primary"` | the action surface with a group's main-action accent | `src/ui/styles/action-button.css` |
| `UiButton` `variant="icon"` | the 22px square glyph button of a panel's collapse toggle | `src/ui/styles/controls.css` |
| `UiCloseButton` | a close, dismiss or clear button: a bare glyph (× with `glyph="times"`, the Material `close` symbol with `glyph="icon"`) with no padding, border or background of its own and a pointer; the site's feature class sets size, colour, hover and any surface, and `bare` leaves the look off for a skin that keeps the browser's padding | `src/ui/styles/close-button.css` |
| `UiCloseButton` | a close, dismiss or clear button: a bare glyph (× with `glyph="times"`, the Material `close` symbol with `glyph="icon"`) with no padding, border or background of its own and a pointer; the site's feature class sets size, colour, hover and any surface, and `bare` leaves the look off for a skin that sets its own padding and border | `src/ui/styles/close-button.css` |
| `UiSearchField` | a search field: the Material `search` glyph and a search input in a flex row, the input bare (no border or background, free to shrink); the site's feature classes set the frame's size, surface and focus ring and the input's type and outline, and the browser's own cancel button is left to each skin | `src/ui/styles/search-field.css` |
| `UiCheckbox` | a checkbox: a label wrapping a native box and its words in a centred flex row; the box keeps each site's size, margin and accent colour, and the site's feature class sets the row's gap, direction and colour | `src/ui/styles/checkbox.css` |
| `UiDialog` | none: a native modal `<dialog>`; the site's feature class or inline style draws it | — |
@@ -108,7 +108,7 @@ no tip unless the site passes a `title`; attributes and classes pass through,
so each site keeps its id, feature class and look. Every close, dismiss and
clear button in the views is one (`src/ui/kit/closeButtons.test.mjs` pins
it); Street Level's and the space mission's keep `bare`, since their skins
keep the browser's padding, and so does the credits list's. The close
set their own padding and border, and so does the credits list's. The close
buttons built in script (the Quebec CCTV overlay, the guide) are not
converted yet.
`UiSearchField` takes `v-model`, a required `label` (the input's
+2 -2
View File
@@ -11,8 +11,8 @@ import UiIcon from './UiIcon.vue';
// Core's common look, a bare glyph: no padding, border or background of its
// own, and a pointer. Its rule selects one class and loads before the
// feature stylesheets, so a feature rule still sets the size, colour, hover
// and any surface. `bare` leaves the kit look off, for a button whose skin
// keeps the browser's own padding.
// and any surface. `bare` leaves the kit look off, for a button whose own
// skin sets its padding and border.
const props = defineProps({
/** The accessible name (aria-label). */
label: { type: String, required: true },
+2
View File
@@ -229,6 +229,8 @@ test('the kit’s skins load before the feature stylesheets that restyle them',
['.ui-close-button,', '.entity-card__close {'],
['.ui-close-button,', '.context-search__clear {'],
['.ui-close-button,', '.key-setup-close {'],
['.ui-close-button,', '.cctv-popup__close {'],
['.ui-close-button,', '.view-context__live-off {'],
['.ui-close-button,', '.gev-guide-close {'],
['.ui-search-field {', '.context-search {'],
['.ui-search-field {', '.layer-finder__field {'],