mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-19 09:42:21 +00:00
Vue kit: bare is for skins that set their own padding; pin the CCTV and Inspector close load order; changelog for #1840
Co-authored-by: Manjunath Paparaju <[email protected]>
This commit is contained in:
1 parent
1711b4b456
commit
2418e43545
4 files changed
+9
-4
No files matched your search
@@ -0,0 +1,3 @@
|
||||
- Every close, dismiss and clear button in the views is now one kit
|
||||
component, `UiCloseButton`, with the same look and behaviour as before
|
||||
(manjunath22466, samehkhamis, #1840).
|
||||
@@ -53,7 +53,7 @@ never copied:
|
||||
| `UiButton` `variant="action"` | the action surface (`gev-action-button`); `tone="danger"` hovers red, `size="compact"` is the shot-row footprint (on this variant only) | `src/ui/styles/action-button.css` |
|
||||
| `UiButton` `variant="primary"` | the action surface with a group's main-action accent | `src/ui/styles/action-button.css` |
|
||||
| `UiButton` `variant="icon"` | the 22px square glyph button of a panel's collapse toggle | `src/ui/styles/controls.css` |
|
||||
| `UiCloseButton` | a close, dismiss or clear button: a bare glyph (× with `glyph="times"`, the Material `close` symbol with `glyph="icon"`) with no padding, border or background of its own and a pointer; the site's feature class sets size, colour, hover and any surface, and `bare` leaves the look off for a skin that keeps the browser's padding | `src/ui/styles/close-button.css` |
|
||||
| `UiCloseButton` | a close, dismiss or clear button: a bare glyph (× with `glyph="times"`, the Material `close` symbol with `glyph="icon"`) with no padding, border or background of its own and a pointer; the site's feature class sets size, colour, hover and any surface, and `bare` leaves the look off for a skin that sets its own padding and border | `src/ui/styles/close-button.css` |
|
||||
| `UiChip` | the read-only chip (a pill of uppercase mono text); `selected` takes the accent | `src/ui/styles/chip.css` |
|
||||
| `UiEmpty` | the one-line empty state (dim mono text), its hint on a line below | `src/ui/styles/empty-state.css` |
|
||||
| `UiBadge` | the read-only badge (`gev-status-badge`) | `src/ui/styles/status-badge.css` |
|
||||
@@ -105,7 +105,7 @@ no tip unless the site passes a `title`; attributes and classes pass through,
|
||||
so each site keeps its id, feature class and look. Every close, dismiss and
|
||||
clear button in the views is one (`src/ui/kit/closeButtons.test.mjs` pins
|
||||
it); Street Level's and the space mission's keep `bare`, since their skins
|
||||
keep the browser's padding. The close buttons built in script (credits, the
|
||||
set their own padding and border. The close buttons built in script (credits, the
|
||||
Quebec CCTV overlay, the guide) are not converted yet.
|
||||
`UiSlider` keeps the native range input rather than drawing a
|
||||
`role="slider"` track, so Core's keyboard, form behaviour and styling stay;
|
||||
|
||||
@@ -11,8 +11,8 @@ import UiIcon from './UiIcon.vue';
|
||||
// Core's common look, a bare glyph: no padding, border or background of its
|
||||
// own, and a pointer. Its rule selects one class and loads before the
|
||||
// feature stylesheets, so a feature rule still sets the size, colour, hover
|
||||
// and any surface. `bare` leaves the kit look off, for a button whose skin
|
||||
// keeps the browser's own padding.
|
||||
// and any surface. `bare` leaves the kit look off, for a button whose own
|
||||
// skin sets its padding and border.
|
||||
const props = defineProps({
|
||||
/** The accessible name (aria-label). */
|
||||
label: { type: String, required: true },
|
||||
|
||||
@@ -165,6 +165,8 @@ test('the kit’s skins load before the feature stylesheets that restyle them',
|
||||
['.ui-close-button,', '.entity-card__close {'],
|
||||
['.ui-close-button,', '.context-search__clear {'],
|
||||
['.ui-close-button,', '.key-setup-close {'],
|
||||
['.ui-close-button,', '.cctv-popup__close {'],
|
||||
['.ui-close-button,', '.view-context__live-off {'],
|
||||
['.ui-close-button,', '.gev-guide-close {'],
|
||||
]) {
|
||||
assert.ok(
|
||||
|
||||
Reference in new issue
Block a user