Sameh Khamis and Manjunath Paparaju
2a0e21774b
Street Level photo viewer: fresh elements per mount, and one viewer drawn
...
Fixes from review of the move to StreetLevelPhotoViewer:
- Each mount and each panorama canvas now takes a key no viewer reuses,
and the view keys its root by the mount. Before, switching KartaView and
Panoramax in one tick let Vue patch the old viewer's canvas, whose
destroyed renderer had lost its context, into the new one, so 360°
photos fell back to their front view.
- Of the viewers mounting in the host, the view draws the one mounted
last, by mount key (photoViewers.js, which subscribePhotoViewer() now
uses), whatever order they present in. A viewer still mounting when a
later one is drawn is superseded: it unmounts and its mount fails as
closed, rather than staying pending and being drawn once the later one
goes.
- A panorama's first image is uploaded once the view has drawn its canvas
shown (the view hands the canvas back on every draw), so it is never
sized into a hidden canvas.
- The tests' fake view now draws as Vue does: once per tick with the final
value, keeping elements while their keys are unchanged and handing every
element back on each draw. StreetLevelPhotoViewer.test.mjs covers the
switch in one tick and the overtaken mount with the real view.
- The guard test's check that the photo viewer writes no DOM covers
inserting, moving, removing and replacing elements, attributes, classes,
styles and the hidden, disabled and text properties.
Co-authored-by: Manjunath Paparaju <[email protected] >
2026-11-19 13:52:36 -08:00
..
2026-11-03 14:32:03 +00:00
2026-11-03 18:05:11 +00:00
2026-10-16 11:01:25 +01:00
2026-11-09 00:24:22 +01:00
2026-10-20 13:56:44 +04:00
2026-10-30 19:02:47 +05:30
2026-09-28 19:07:57 -05:00
2026-10-20 13:56:44 +04:00
2026-11-08 19:45:01 -08:00
2026-10-02 18:29:42 -07:00
2026-11-11 16:06:22 +01:00
2026-08-24 17:02:16 -05:00
2026-11-08 15:55:13 -08:00
2026-11-18 22:54:53 -08:00
2026-10-30 20:47:20 +05:30
2026-11-09 23:06:26 -08:00
2026-09-24 16:25:55 +05:30
2026-11-08 19:35:30 -08:00
2026-09-10 23:01:51 -07:00
2026-11-07 17:53:55 +00:00
2026-09-14 07:35:38 -07:00
2026-10-19 23:23:52 +01:00
2026-11-03 22:36:27 -08:00
2026-09-15 07:26:32 -07:00
2026-11-19 13:52:36 -08:00
2026-10-30 16:11:48 -07:00
2026-10-13 18:54:58 -04:00
2026-09-11 15:08:23 -07:00
2026-11-17 19:44:56 +04:00
2026-11-12 12:26:45 +00:00
2026-11-13 07:16:25 -08:00
2026-09-28 19:07:57 -05:00
2026-09-28 19:07:57 -05:00
2026-09-14 21:12:01 -07:00
2026-09-24 16:25:55 +05:30
2026-09-14 07:35:38 -07:00
2026-10-30 19:02:47 +05:30
2026-11-19 13:52:36 -08:00
2026-11-03 22:01:08 +05:30
2026-10-16 15:28:39 -07:00
2026-08-31 17:49:45 -05:00
2026-08-31 17:49:45 -05:00
2026-08-31 17:49:45 -05:00
2026-09-14 19:34:23 -05:00
2026-10-19 17:02:06 +01:00
2026-09-14 07:35:38 -07:00
2026-10-21 15:22:00 +02:00
2026-11-09 11:34:18 -08:00
2026-10-02 15:12:37 -06:00
2026-09-28 19:07:57 -05:00
2026-11-06 16:32:49 -08:00
2026-09-11 17:03:35 -07:00
2026-09-10 23:08:26 -07:00
2026-10-07 22:41:29 +04:00
2026-08-24 17:02:16 -05:00
2026-08-24 17:02:16 -05:00
2026-10-14 15:36:35 -07:00
2026-11-13 17:46:43 +00:00
2026-11-08 08:35:12 -08:00
2026-10-20 15:12:33 +01:00
2026-10-22 19:26:09 -07:00
2026-11-18 16:03:51 -08:00
2026-11-15 17:03:09 -08:00
2026-11-10 20:03:28 -08:00
2026-11-12 22:37:34 +00:00
2026-11-15 17:03:09 -08:00
2026-09-15 16:53:26 -07:00
2026-09-15 19:16:49 -07:00
2026-09-15 17:59:53 -07:00
2026-11-16 20:12:10 +05:30
2026-10-28 14:35:01 +00:00
2026-11-08 04:40:30 -08:00
2026-11-09 20:36:03 -08:00
2026-11-17 15:09:54 -08:00
2026-10-22 18:09:37 -07:00
2026-10-22 19:08:10 -07:00
2026-10-14 14:48:53 -07:00
2026-11-19 02:45:21 -08:00
2026-11-18 17:00:10 -08:00
2026-11-18 17:00:10 -08:00
2026-09-10 23:08:26 -07:00
2026-10-11 13:52:30 -07:00
2026-08-24 17:02:16 -05:00
2026-08-31 17:49:45 -05:00
2026-09-10 23:08:26 -07:00
2026-10-11 13:52:30 -07:00
2026-11-09 20:36:03 -08:00
2026-11-18 15:47:27 -08:00
2026-10-13 23:48:21 +02:00
2026-11-15 17:03:09 -08:00
2026-11-09 15:50:53 -08:00
2026-11-09 15:50:53 -08:00
2026-11-09 23:42:15 -08:00
2026-11-15 16:34:05 -08:00
2026-11-13 14:14:42 -08:00
2026-09-10 23:08:26 -07:00
2026-11-03 14:57:31 -08:00
2026-11-08 12:13:29 -08:00
2026-11-08 12:13:29 -08:00
2026-09-28 19:07:57 -05:00
2026-10-25 03:15:11 +01:00
2026-11-12 19:05:44 -08:00
2026-11-12 19:05:44 -08:00
2026-11-02 16:43:49 +00:00
2026-09-24 16:25:55 +05:30
2026-10-20 14:37:57 +01:00
2026-11-01 13:43:57 -08:00
2026-10-31 12:11:35 -07:00
2026-11-15 17:03:09 -08:00
2026-09-28 19:07:57 -05:00
2026-09-16 12:14:15 +05:30
2026-10-30 19:02:47 +05:30
2026-10-03 23:10:32 -07:00
2026-11-03 14:57:31 -08:00
2026-10-30 22:41:07 -07:00
2026-11-09 20:36:03 -08:00
2026-11-18 16:03:51 -08:00
2026-10-14 15:36:35 -07:00
2026-11-16 13:30:22 -08:00
2026-10-31 18:37:14 -07:00
2026-11-18 15:47:27 -08:00
2026-11-18 15:47:27 -08:00
2026-11-13 14:14:42 -08:00
2026-11-17 15:09:54 -08:00
2026-11-18 15:47:27 -08:00
2026-11-16 13:41:09 -08:00
2026-11-18 17:00:10 -08:00
2026-11-10 20:03:28 -08:00
2026-11-09 12:11:42 -08:00
2026-11-08 01:55:08 -08:00
2026-10-14 14:48:53 -07:00
2026-11-07 23:16:11 -08:00
2026-09-13 14:47:26 -07:00
2026-11-07 23:16:11 -08:00
2026-10-14 14:48:53 -07:00
2026-10-23 12:12:27 +01:00
2026-11-10 11:30:59 -08:00
2026-11-08 21:44:22 -08:00
2026-10-20 14:07:13 +01:00
2026-10-14 15:36:35 -07:00
2026-11-08 21:44:22 -08:00
2026-11-15 17:03:09 -08:00
2026-11-18 16:03:51 -08:00
2026-10-31 20:28:24 -07:00
2026-10-22 19:08:10 -07:00
2026-09-10 23:08:26 -07:00
2026-09-11 14:43:13 -07:00
2026-11-15 17:03:09 -08:00
2026-11-15 17:03:09 -08:00
2026-10-30 17:47:52 -07:00
2026-10-04 23:03:09 +05:00
2026-09-28 21:19:23 -05:00
2026-11-06 00:23:42 +00:00
2026-09-15 12:05:01 -07:00
2026-10-31 23:51:47 -07:00
2026-09-22 17:45:39 -05:00
2026-10-22 18:09:37 -07:00
2026-10-20 14:37:05 +01:00
2026-09-22 17:45:39 -05:00
2026-11-09 18:51:30 -08:00
2026-11-19 19:18:31 +00:00
2026-08-24 17:02:16 -05:00
2026-11-04 14:21:48 -08:00
2026-11-05 16:17:12 -05:00
2026-11-03 16:17:34 +00:00
2026-11-02 07:06:14 -08:00
2026-11-18 18:58:07 -08:00
2026-10-20 15:12:32 +01:00
2026-11-07 19:44:15 -08:00
2026-09-28 21:19:23 -05:00
2026-11-18 22:54:53 -08:00
2026-10-30 20:47:20 +05:30