mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-05 19:04:02 +00:00
fix(app): Navara attributions clear of the panels; QA waits for tiles
Navara's attribution list is capped at 120 px, and the shell's data credits register after the map's, so Google's copyright lines come first and stay visible while the card no longer covers the left panels. qa-engine-shell polls engine.surface.tilesLoaded() (true for 1.5 s, up to 90 s) before judging the picture and prints the load time per engine; "wheel zoom stops above the ground" is a hard check on both engines (height >= 20 m; on Navara >= 20 m above the sampled surface), and the Navara known gap is gone.
This commit is contained in:
1 parent
8270172086
commit
b65dbab709
2 files changed
+10
-7
No files matched your search
@@ -61,10 +61,6 @@ export async function createNavaraScene({
|
||||
// The tools install the governor on this engine; it goes before the engine.
|
||||
defer(() => uninstallRenderGovernor(engine));
|
||||
signal.throwIfAborted();
|
||||
registerDataCredits(
|
||||
engine,
|
||||
(credits ?? DATA_CREDITS).filter(({ key }) => SHELL_CREDIT_KEYS.has(key)),
|
||||
);
|
||||
loaderStatus.textContent = 'Initializing systems...';
|
||||
const mapStackController = new MapController(null, {
|
||||
requestRender: governorRequestRender,
|
||||
@@ -83,6 +79,12 @@ export async function createNavaraScene({
|
||||
silent: true,
|
||||
});
|
||||
signal.throwIfAborted();
|
||||
// After the map's own credits, so Google's copyright lines come first in
|
||||
// Navara's attribution card.
|
||||
registerDataCredits(
|
||||
engine,
|
||||
(credits ?? DATA_CREDITS).filter(({ key }) => SHELL_CREDIT_KEYS.has(key)),
|
||||
);
|
||||
return {
|
||||
viewer: null,
|
||||
engine,
|
||||
|
||||
@@ -418,14 +418,15 @@
|
||||
|
||||
/* The experimental Navara engine (?engine=navara) shows its attributions in
|
||||
its own card, fixed bottom-right over the location tray. Keep it on the
|
||||
left, above the HUD's coordinate lines and below the left panel rail. */
|
||||
left, above the HUD's coordinate lines and clear of the left panel rail:
|
||||
the list is capped (Google's lines come first; the rest scrolls). */
|
||||
body .navara-attr-dock {
|
||||
right: auto;
|
||||
left: 16px;
|
||||
bottom: 176px;
|
||||
align-items: flex-start;
|
||||
}
|
||||
body .navara-attr-card {
|
||||
max-height: 290px;
|
||||
body .navara-attr-list {
|
||||
max-height: 120px;
|
||||
overflow: auto;
|
||||
}
|
||||
Reference in new issue
Block a user