mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-04 10:24:02 +00:00
docs(cctv): the media-fetch log line drops the error text on purpose
The comment claimed "Keep the detail in the log" while the line it introduces carries none, so the next reader would have read the omission as an oversight and added the errno back. Detail-free is the deliberate choice: a media-fetch failure names the camera's upstream host, and these lines get pasted into issues. Say that, and say why the catch at the bottom of this file may still log its error text.
This commit is contained in:
1 parent
92350b8412
commit
3308569edd
1 file changed
+6
-1
@@ -311,7 +311,12 @@ export function cctvProxy({ sourceRoot = process.cwd() } = {}) {
|
||||
// GET /api/cctv/health serializes `message`, and the CCTV panel
|
||||
// renders it as a status label, so the raw error would leave the
|
||||
// server by a different door than the sanitized body below and
|
||||
// land on screen. Keep the detail in the log.
|
||||
// land on screen.
|
||||
//
|
||||
// The log line drops the text too, unlike the catch at the bottom
|
||||
// of this file: a media-fetch failure names the camera's upstream
|
||||
// host, and these lines get pasted into issues. The status codes
|
||||
// below carry the diagnosis — 504 for a timeout, 502 otherwise.
|
||||
console.warn('[CCTV Proxy] media fetch failed');
|
||||
setHealth(cameraId, {
|
||||
status: 'degraded',
|
||||
|
||||
Reference in new issue
Block a user