From 3308569edde13b6aa911ab20983ff4b4cd354d63 Mon Sep 17 00:00:00 2001 From: Pedro Lobato <69770518+Lob26@users.noreply.github.com> Date: Tue, 15 Sep 2026 12:06:11 -0500 Subject: [PATCH] docs(cctv): the media-fetch log line drops the error text on purpose The comment claimed "Keep the detail in the log" while the line it introduces carries none, so the next reader would have read the omission as an oversight and added the errno back. Detail-free is the deliberate choice: a media-fetch failure names the camera's upstream host, and these lines get pasted into issues. Say that, and say why the catch at the bottom of this file may still log its error text. --- server/providers/cctv.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/server/providers/cctv.js b/server/providers/cctv.js index 69512e7c5..85cece004 100644 --- a/server/providers/cctv.js +++ b/server/providers/cctv.js @@ -311,7 +311,12 @@ export function cctvProxy({ sourceRoot = process.cwd() } = {}) { // GET /api/cctv/health serializes `message`, and the CCTV panel // renders it as a status label, so the raw error would leave the // server by a different door than the sanitized body below and - // land on screen. Keep the detail in the log. + // land on screen. + // + // The log line drops the text too, unlike the catch at the bottom + // of this file: a media-fetch failure names the camera's upstream + // host, and these lines get pasted into issues. The status codes + // below carry the diagnosis — 504 for a timeout, 502 otherwise. console.warn('[CCTV Proxy] media fetch failed'); setHealth(cameraId, { status: 'degraded',