A point of an arrow, route or area outside the view frustum was not
sampled and stood in at 0 m, so a partly visible arrow could hide, point
at the wrong place or vanish behind the eye. Such points are sampled again
within the 32-sample budget and the one-second retry, as on main; lone
points outside the view still skip sampling. The 0 m stand-in exceptions
are removed. Also from review: shared viewPlanes for transit and the
renderer, a −430..9000 m segment test against the view planes, tighter
tests and shorter docs.
Main moved the screen annotation renderer onto the renderer ports, so the
height culling now goes through them too: the frustum test uses
frustumPlanes/sphereOutside from src/geo/frustum.js on the camera pose,
the horizon tests use the query port's isOccluded, and the file imports no
Cesium. The sampling tests run on main's scene doubles with their
assertions unchanged; the outside-frustum step turns the test camera
instead of stubbing the culling volume.
An endpoint outside the frustum is not sampled and projects at its 0 m
stand-in height. The horizon test then judged that stand-in, so an arrow
whose far end lies beyond the sea-level horizon but above it at its real
height disappeared with its label. Such an endpoint now skips the point
horizon test; the height-range test still drops endpoints that are
provably hidden, and settled or in-frustum anchors keep the point test.
Adds a regression with a real frustum and occluder (camera 100 m up, far
end 56 km away on 100 m terrain). CURRENT-STATE and the changelog now say
the 32-sample budget applies per projection pass, and the redundant helper
comment in the test is gone.
- When F or a panel's collapse button folds a panel that holds the focus,
the focus moves to that panel's visible rail entry. The same happens when
opening Data Layers folds a peer panel that held it, and in Cockpit the
focus moves to Contact's expand button when that card folds.
- The `shownBy: 'active'` rail gate is gone: nothing removes `.active` from
Data Layers any more, so a rail entry now follows `panel.hidden`.
- CURRENT-STATE says what F does, and the panel catalog comment no longer
says F toggles `.active`.
Focusing a mission does nothing in the cockpit, so the layer row's arrows
select the next mission without moving the camera, as its label and dot
already do.
Co-authored-by: Manjunath Paparaju <[email protected]>
The cockpit holds the camera: the mission dot, like its label, selects the
mission there without flying to it, and a mission picked in the cockpit is
not flown to when the active satellite lookup returns.
Co-authored-by: Manjunath Paparaju <[email protected]>
Under the card-on-top rule a mission label is the card on top for the
cockpit too, so the label no longer steps aside there: it selects its
mission without moving the camera the cockpit holds. Tests and docs no
longer claim a covered click reaches what lies under the label, and the
busy-restore note says an explicit Satellites action lets the saved state
go.
Co-authored-by: Manjunath Paparaju <[email protected]>
Main's single click rule (the card or label on top takes the click, read
once per click through clickCard and isUnderOtherCard in
src/data/pickRegistry.js) covers a click on a Space Missions label: a
mission marker label is an interactive world-overlay entry, so the
host's hit test names it as the card on top for every other layer. The
per-layer label guards in CCTV, Drone Airspace, FIRMS, Ghost Maps, News,
Perimeters, Shipwrecks, Vessels, Wildlife Sightings, ALPR, Local ADS-B
and the cockpit orbital focus are dropped for main's versions.
The mission-label tests are kept on main's API: fakeInputUnderLabel now
also names the label as the card on top, and each test shows a click on
the label never acts on the card, camera, vessel, fire, reader, aircraft
or report under it, and leaves the selection as it is. A launches test
checks that a mission label is interactive and is the card on top for
every other layer. Docs, changelog and the dispatcher's `overlay` note
describe the merged behaviour.
Co-authored-by: Manjunath Paparaju <[email protected]>
Resolves conflicts with main: a world focus target's own range past its
framed radius replaces the kind's range (#1832), so a quake asks for its
own range only past M6 and the earthquake framing stays its floor; FIRMS
keeps main's marker stand-in under the card-on-top rule; launches keep
main's label click and also read the card on top through the pick
registry.
Review fixes for #1781:
- One rule for cards: the world-overlay host hands its hit test to the
pick registry, and every click handler reads the topmost interactive
card or label once per click (`clickCard`, `isUnderOtherCard` in
src/data/pickRegistry.js), so all handlers agree in any listener order.
A layer whose own card or label is on top acts on it whatever is drawn
under it; a layer under another layer's card neither acts nor treats
the click as empty space (a tracked aircraft stays tracked, a selection
stays selected); Context names nothing under a card. A selected news
card over a vessel no longer opens the link and selects the vessel.
- With one rule, the per-owner arbitration options are no longer read
and are removed: `passive`, `expanded` and `declinesClick` pick owners,
`rememberClickPickActions`, `isActedOnByOtherLayer`, card backgrounds
and `cardKeepsClick`. The dispatcher is unchanged from main.
- A drag that ends on a quake disc, label or card does nothing; opening
the USGS page or clearing the selection needs a clean click.
- A click on the map under another layer's card opens no Street Level
ground image.
- A CCTV card that is going away is still not the scene under it.
- Docs and changelog describe the new rule.
setMarkerStandIn takes an optional focusRangeM(record): when a click on a fire the stand-in draws moves the camera there, it stands off that many metres instead of the usual fire framing. A world focus request may carry its own rangeM; past the framed radius it replaces the kind's range.