Commit Graph
19 Commits
Author SHA1 Message Date
German Khokhlov b2f746cdb2 Merge remote-tracking branch 'origin/main' into fix/places-no-store-on-errors 2026-11-20 13:48:55 +04:00
German Khokhlov 01d4a3f454 CCTV Street View budget: key the client before the camera wait, share the default
- The /frame handler reads the client's network key (IPv6 /64) before it
  awaits the camera, so a client that drops the connection is still
  charged to its own window instead of the shared fallback key.
- The budget is charged only after the Google key and finite catalog
  coordinates are confirmed, and the key is read once.
- Places and the CCTV window share one default (GOOGLE_DEFAULT_PER_MIN).
- Tests: the catalog-only test checks heading/fov/pitch from the query at
  the catalog location; the budget test covers unknown ids, forwarded
  requests and /64 grouping; a real-socket test covers a dropped
  connection. The duplicate pose test is removed.
- .env.example, SECURITY.md, CURRENT-STATE and the changelog fragment
  describe the separate per-IP window, the catalog position and the
  placeholder for seed cameras.
2026-11-20 11:31:14 +04:00
German Khokhlov 67bead9eb9 test(places): pin no-store on every refusal path and reuse the catch
Tests now check Cache-Control on the proxy's own 400, 405, 429 and
transport 502, a geocode 503 with ZERO_RESULTS on both geocode routes,
and an upstream 429 with an HTML body on both Places routes; the geocode
status cases move to the geocode suite and cover reverse-geocode too.
An unreadable Places 200 now throws into the existing catch instead of
repeating its 502 reply. Comments and the CURRENT-STATE rule are shorter
and match the code.
2026-11-20 03:36:48 +04:00
German Khokhlov 31b6b25d8b fix(places): make no-store the default and refuse an unreadable Places 200
Every Google route now sets no-store right after the same-site gate and
switches to private, max-age=300 only on a confirmed answer, so the
proxy's own 400, 405, 429 and 502 replies are no longer left without a
header. Both Places routes answer an unreadable 200 body with 502 instead
of caching an empty result, as the geocode routes already did. The test
pins the allowlist with OVER_DAILY_LIMIT and UNKNOWN_ERROR and covers the
unreadable and empty Places bodies; the changelog fragment is shorter.
2026-11-19 18:29:24 +04:00
Said Turksever 078a6c0db0 CCTV Street View fallback: own per-IP Google budget inside the cctv package boundary 2026-11-06 11:51:34 +00:00
Said Turksever 7af0453f34 CCTV Street View fallback: catalog cameras only, at their catalog position, inside the Google budget 2026-11-06 11:51:34 +00:00
Rudy Celekli 2e2f756468 fix(places): don't let the browser cache a refused Google answer
The Places and Geocoding proxies sent Cache-Control: private,
max-age=300 whatever Google answered. A 403 from a key without the
Places API, or a geocode REQUEST_DENIED / OVER_QUERY_LIMIT (which
Google sends as HTTP 200), was then replayed from the browser cache for
five minutes after the key was fixed. Refusals are now no-store.
2026-11-04 22:13:01 -05:00
Niccolò Saggese e2ce7fa38e Merge remote-tracking branch 'upstream/main' into fix/363-geocode-proxy
# Conflicts:
#	SECURITY.md
#	server/providers/places/google.js
2026-10-05 09:26:08 +02:00
Sameh KhamisandClaude Opus 5.5 9b4ccbff62 fix(server): gate Google text search against cross-site requests
/api/google/text-search spends the same Google quota as nearby-places but
was not behind the cross-site gate. It now refuses cross-site requests
before calling Google, and a test covers both paid Google routes.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-02 20:16:39 -07:00
bb74071dc2 fix(server): throttle the cost-bearing proxies by default
The OpenAI endpoints (/api/realtime/token, /api/openai/hud-summary) now
allow 30 requests per minute per client IP and the Google Places endpoints
120, the caps the Pinokio build already ships. GEV_RATELIMIT_OPENAI_PER_MIN
and GEV_RATELIMIT_GOOGLE_PER_MIN still override them and exactly 0 disables
them; an unreadable value falls back to the default rather than to
unlimited.

Salvaged from #683 onto current main.

Co-authored-by: Sameh Khamis <[email protected]>
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 19:57:29 -07:00
7aa9bbd3be fix(server): gate cost/log endpoints against cross-site requests and ship a full CSP
The cost-bearing endpoints (/api/realtime/token, /api/openai/hud-summary,
/api/google/nearby-places) and the voice debug log refuse cross-site browser
requests: a foreign or opaque Origin, a Sec-Fetch-Site other than
same-origin/none, or proxy forwarding headers. Loopback tools without an
Origin and the LAN opt-in keep working. The dev and preview servers send one
shared Content-Security-Policy, and embed-mode framing rewrites only the
frame-ancestors directive of it.

Salvaged from #242 onto current main.

Co-authored-by: Sameh Khamis <[email protected]>
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-10-02 19:56:42 -07:00
Niccolò Saggese 771c9e5632 fix(search): bound and sanitize the geocode proxy
- reject blank viewport-bias components before Number() reads them as 0
- give the upstream call a 10s deadline and a 256 KiB capped body read
- return fixed public text on failure instead of the upstream message
2026-09-21 11:56:33 +02:00
Niccolò Saggese c5b1d41cba fix(search): geocode through the server, not the browser
- Google's Geocoding web service refuses referrer-restricted keys, so the
  browser call forced GOOGLE_MAPS_API_KEY to ship unrestricted
- add /api/google/geocode and /api/google/reverse-geocode, using the server
  key like Places and Street View already do
- the browser key now needs the Map Tiles API only
2026-09-21 11:30:49 +02:00
Sameh Khamis 8b36c28b06 refactor: compose configurable geocoding and route services 2026-09-13 21:23:13 -07:00
Sameh Khamis 24d2582516 fix(cctv): release snapshot readers and verify provider error paths 2026-09-12 16:37:04 -07:00
Bilawal Sidhu 3d956177ab fix(providers): validate before limiting and tighten capped image reads
Apply shared Places validation, owned image chunks, and response-header deadline tests to the provider modules.
2026-09-12 16:35:11 -07:00
Prajwal Raj 3b19af4076 fix: reject out-of-range coordinates in Google text search
Adapt the coordinate bounds check contributed in public PR #46 to the Places provider.
2026-09-12 16:33:51 -07:00
Sameh Khamis 7e6d89d8f5 style: format extracted place and route modules 2026-09-11 19:57:22 -07:00
Sameh Khamis 2793d7a8df refactor: extract place-search and routing provider modules 2026-09-11 19:56:48 -07:00