The separate layer test built a fake viewer with the old Cesium interface,
which fails on current main. Move it into src/data/infrastructure.test.mjs on
the fake ground renderer and input port, with one table and one parse of
dams.geojsonl for both checks. Compare source_url exactly and check
retrieved_at, and cover the dams attribution and both new records in the
find_infrastructure tests.
Also trim the dataset README section (keep both dams as polygons), drop the
outdated "does not refresh or relicense" sentence, keep provenance out of the
License cell, rename the changelog fragment after the change, and restore the
accent in the test name.
Every hand-written button in the Cockpit HUD (CockpitView, the utility
strip, the briefing and Contact cards, the signal rows, the orbital view
and the bridge radar) is a ghost UiButton that keeps its id, classes,
data and aria attributes, title and listeners, so the Cockpit controller
and the cockpit stylesheets still find it. Radio's Enable, the briefing's
Auto and the Contact card's Weather are pressed toggles written as
:pressed="Boolean(...)". Every Material Symbols span (the rim pointers,
reticle, heading caret, vision and card chevrons, panel glyphs, the
contact and route arrows, the rail and view switcher glyphs) is a UiIcon
with :size="null", so the cockpit rules still size it.
The orbital view's focus hand-off reads each UiButton ref's $el. The
heading caret's rule now reads `.cockpit-compass .cockpit-heading-caret`
so it still outranks kit.css's `.ui-icon` display and line height, which
load after cockpit.css. The Cockpit markup test reads the Reset and Exit
buttons' attributes in any order.
src/ui/kit/cockpitControls.test.mjs pins it: no hand-written button,
Material span, select, checkbox or range in the Cockpit views, the kit
counts per file, the pressed toggles and the caret rule.
Co-authored-by: Manjunath Paparaju <[email protected]>
Every hand-written <button> in the locale picker, phone tab bar, globe
actions (Clear, Share, Reset) and compass, imagery divider handle, scene
sharing dialog, layer group index, title logo, Exit clean view, the HUD's
cockpit entry, News card face, rail card header, layer row toggle, credits
line's Data attribution and the camera calibration chips is a ghost
UiButton keeping its id, classes, data-*, aria-* and listeners. Their
Material Symbols spans (tab icons, globe actions, compass needle, cockpit
entry, celestial ring sun and moon) are UiIcons with :size="null".
The Omnibar guide's extra rings, one per further target of a step, are now
drawn by OmnibarGuide.vue from view.subRings instead of being built in
script; startGuide() still reads them from the rendered tree and sets
their boxes each frame.
A UiButton's slot renders inside the button, so under an owner that
patches synchronously (News cards, rail cards, the credits line, the
Omnibar guide's Skip, Offer and Next) a change the button's attributes do
not carry would land a tick late. Those slots are given under a named
condition that is always true (v-if="redrawWithView"), which Vue redraws
with the view.
src/ui/kit/smallSurfacesControls.test.mjs pins it; docs/VUE-MIGRATION.md
describes the surface and the conditional slot.
Co-authored-by: Manjunath Paparaju <[email protected]>
The command dock's six style buttons, its two tray toggles, Location's
collapse and the search toggle are ghost UiButtons. The style buttons are
pressed toggles with `active` as their pressed class (Normal is pressed
until a style is published), so they now carry aria-pressed.
The Context panel's two tabs, Contacts, the cockpit entry and SEARCH
NEARBY SITES are ghost UiButtons; the tabs and Contacts stay role="tab"
controls with aria-selected and their own active class. The view context
it shows while nothing is picked (an off layer's worldwide tile, an
item's row, the place and layer chips and Ask GEV) is on the kit too; the
worldwide tile is a div or a UiButton rather than a dynamic component.
Every Material glyph in the three templates is a UiIcon with
:size="null", so the site rules still size them; an item's motion glyph
keeps role="img" and its name, with the kit's aria-hidden taken off.
src/ui/kit/commandDockControls.test.mjs pins it; the markup tests that
matched the old button source or class text read the kit's markup, and
docs/VUE-MIGRATION.md describes the surface.
Co-authored-by: Manjunath Paparaju <[email protected]>
docs/VUE-MIGRATION.md says every select is a UiSelect, every close button
a UiCloseButton and (nearly) every pressed toggle a UiButton. Make those
true in code, correct the sentences that were not, and pin them.
Selects: Story Explore's sort, the chat's layer picker and a layer row's
range ends are UiSelects. The range ends take `hold`, since the layer
panel repaints the row on a later frame.
Close buttons: the space mission replay's Cancel is a bare UiCloseButton.
An imported file's row actions (show or hide, fly to, remove) are icon
UiButtons drawing the icon the file import names, so Remove stays one of
them; the presenter's `pressed` is now a boolean.
Pressed toggles: the tilt-map button, the scene action buttons, the chat
and voice panels' dock (and its minimize), the Context header's search
and expand, Recent Imagery's day chips, SWAP and ZOOM IN, the rail row
lists and the rail cards' action chips are UiButtons with `pressed` (and
`pressed-class="active"` where their active class came from the same
state). Their Material glyphs, and the rail chips' icons, are UiIcons
with `:size="null"`. Bhote Koshi's cinematic button keeps the attributes
its layer writes, and Explore's story cards stay role="button" elements.
Docs: the kit list gains UiPanelToggle and UiPanelEdge; the pressed-toggle,
chips, Stories search fields, role="dialog", close button, range and
source-reading-tests sentences now say what the code does.
Tests: src/ui/kit/viewControls.test.mjs walks every .vue outside the kit
and fails on a raw select, a hand-written aria-pressed on a button,
UiButton or role="button" element (outside the two documented
exceptions), or a hand-written close glyph button. closeButtons.test.mjs
also catches a × inside a span.
Co-authored-by: Manjunath Paparaju <[email protected]>
Acaray was stored as a LineString, which the Dams layer skips: it got no
marker, label, card or analyst record. Store the closed way as a polygon
(counter-clockwise ring from the same nine nodes) and add a layer test for
both Paraguay dams.
Also tidy the dataset README (drop the landing-order notes and the analyst
record count, note why the Yacyretá marker sits over the reservoir), keep one
credited changelog bullet, credit the OpenStreetMap API next to Open
Infrastructure Map, and drop "other" from the Three Gorges mission.
Every button in the Stories entry, its popup and toast, Explore and the
Story screen (header, rail, timeline and context panel) is a ghost
UiButton that keeps its id, classes and listeners. Explore's topic chips
and map pins, the Context button and Expand map are pressed toggles in
place of hand-written aria-pressed. The Filter, Minimise, Expand card and
Back buttons are reached through the UiButton's root where code focuses
them or checks what a click landed on. Explore's filter options are
UiCheckboxes that keep their fopt label. The views' glyphs stay inline
SVG, since no Material symbol the page loads draws them the same; the
search fields keep their own markup and their SVG clear buttons are ghost
UiButtons. A guard test pins it, and the migration notes say so.
Co-authored-by: Manjunath Paparaju <[email protected]>
Search, Filter, the filter menu's Status and Category options and the
bar's two clear chips are ghost UiButtons. Search and the options are
pressed toggles in place of hand-written aria-pressed; the options take
active as their pressed class, while Search keeps its own active binding,
which also stays on while a query is typed. Escape in the menu still gives
focus back to the Filter button, now through the UiButton's root. Every
Material glyph in it is a UiIcon sized by layer-finder.css. A guard test
pins it, and the migration notes say so.
Co-authored-by: Manjunath Paparaju <[email protected]>
The four preview buttons (Photos, Route, 3D, Cockpit view) are pressed
toggles with the active class, and Follow is one with its own on class,
in place of hand-written aria-pressed. The cockpit entry, Fly to, Ask GEV,
the camera preview's bigger-view and More info buttons and the nearby
lists' rows are ghost UiButtons. Every Material glyph on the card, in the
camera preview and in the nearby lists is a UiIcon sized by the card's own
rules. Ask GEV's chat bubble stays inline SVG, since no Material symbol the
page loads draws it. A guard test pins it, and the migration notes say so.
Co-authored-by: Manjunath Paparaju <[email protected]>
- When F or a panel's collapse button folds a panel that holds the focus,
the focus moves to that panel's visible rail entry. The same happens when
opening Data Layers folds a peer panel that held it, and in Cockpit the
focus moves to Contact's expand button when that card folds.
- The `shownBy: 'active'` rail gate is gone: nothing removes `.active` from
Data Layers any more, so a rail entry now follows `panel.hidden`.
- CURRENT-STATE says what F does, and the panel catalog comment no longer
says F toggles `.active`.
HUD, Clean UI, Bloom, Sharpen and Reset to default are ghost UiButtons;
HUD, Bloom and Sharpen are pressed toggles with the active class, as
Sonar, 3D and Celestial already were. The Scope, Celestial, sky,
application-row and Reset glyphs are UiIcons sized by the panel's own
rules. The toggles' text glyphs stay plain spans, since they are
characters rather than Material symbols. A guard test pins it, and the
initial-markup test allows the kit classes beside the toggle's own. The
migration notes no longer claim every pressed toggle is a UiButton.
Co-authored-by: Manjunath Paparaju <[email protected]>