Commit Graph
2797 Commits
Author SHA1 Message Date
Theerayut BoonkirdandClaude Opus 5 88f6e8bcf8 fix: treat AIS "not available" speed and course as unknown
ITU-R M.1371 encodes speed over ground in 0.1-knot units and course over
ground in 0.1-degree units, reserving the top code of each field for "not
available": SOG 1023 reaches us as 102.3 knots and COG 3600 as 360 degrees.
Both are finite, so numberValue passed them through as ordinary readings and
every consumer — vessel cards, the HUD, voice analyst queries — treated a
missing measurement as a real one.

Observed on a live AISStream feed of 3,062 vessels: exactly 3 records at
102.3 knots with no reading anywhere between 40 and 102.3, and 404 records
at exactly 360 degrees. One Dutch rescue boat moored at its station carried
both sentinels at once, so an analyst summary reported a maximum speed of
102.3 knots — faster than any vessel afloat.

Filter both at the store, where AISStream messages are decoded, so the
sentinels never enter the cache. Heading already had this treatment through
normalizedHeading with its own separate sentinel of 511.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-09-18 00:41:06 +01:00
ulihhhh 7a3af0c129 Merge upstream main into feature/catalonia-cctv-cameras to resolve PR #595 conflicts
# Conflicts:
#	CHANGELOG.md
2026-09-17 12:11:10 +02:00
bassem chagra 5f27f6edf4 fix(cctv): surface heading confidence — estimated bearings are now visible
Every pack sets headingConfidence on each camera, but nothing consumed it:
a bearing synthesized by fallbackHeadingFromId (a hash of the id string,
no geographic input) rendered exactly like a surveyed one — 2,827 of 3,997
cameras in a default catalog. Fixes #639.

Two consumers, plus a passthrough:

- HUD: the heading token is tagged when the bearing is synthetic —
  `HDG 194° (ESTIMATED)` — so a hash never reads as a measured facing.
- Wireframe: a low-confidence camera draws its coverage frustum with dashed
  polylines instead of solid ones. Colors, widths, and the active/idle
  emphasis are unchanged; the dash is the only signal.
- Public camera state gains `headingConfidence` (the raw pack flag) and
  `headingEstimated` (the derived bit) so UI consumers never re-derive it.

A human-vouched pose always wins over the pack flag: a manually saved
calibration (calSource:'manual') or a curated catalog entry
(poseSource:'curated') is never presented as estimated, mirroring the CAL
badge states in calibration.js.

- src/layers/cctv/headingConfidence.js: pure helpers (isHeadingEstimated,
  headingHudToken)
- src/layers/cctv/headingConfidence.test.mjs: confidence normalization,
  calibration/curation overrides, HUD token formatting
- src/layers/cctv/presentation.js: HUD token + public-state passthrough
- src/layers/cctv/rendering.js: dashed materials for estimated bearings
2026-09-17 10:20:26 +02:00
SurefireStudios 4b161ea7af docs: point contributors at the per-feature regression gates (#271)
CONTRIBUTING.md named only npm run build, npm test and npm run test:track,
so a contributor following it literally never learns that most features
have a dedicated gate in scripts/qa-*.mjs. Today 25 of the 40 gates are
not named in CURRENT-STATE.md either, so for those there was nothing in
the written guide to find them by.

Point at the directory rather than transcribing a list that would go stale
the same way: every gate already opens with a comment saying what it
asserts and how to run it, so `ls scripts/qa-*.mjs` plus the script header
is the canonical, self-maintaining reference.

Also state plainly that CI runs neither test:track nor any qa gate, since
that is what makes running them locally matter.
2026-09-16 14:35:31 -07:00
Sameh Khamis 0d41b6be54 Merge pull request #626 from bilawalsidhu/fix/vessel-partial-feed-status
fix: distinguish partial vessel snapshots from stale data
2026-09-16 11:57:56 -07:00
Sameh Khamis a25ee64209 fix: distinguish partial vessel snapshots from stale data 2026-09-16 11:52:26 -07:00
cyberspace-cs 0dcb02c6da docs: add Contributing link to top navigation bar
Make the contribution guide discoverable from the README's main
navigation alongside Quick Start, Under the Hood, and Keys & Costs.
2026-09-17 00:06:33 +08:00
Sameh Khamis 531ef52ca4 Merge pull request #600 from manjunath22466/fix/pinokio-nepal-media-fallback
fix: prevent Nepal media from opening external browsers in Pinokio
2026-09-16 08:41:06 -07:00
Ashfaq dadaaf1f27 Merge remote-tracking branch 'origin/fix/antimeridian-traffic-bounds' 2026-09-16 20:02:45 +05:30
Ashfaq 830c372c12 fix: keep clamped traffic bounds monotonic across the antimeridian
The previous fix wrapped the span correctly but normalized the
returned west/east back into [-180, 180), which re-inverts the box
whenever it crosses the antimeridian (west > east again). Downstream
consumers (getBoundsCenter, boundsOverlap) assume west <= east and
silently misbehave on an inverted box: the fetch center lands on the
opposite side of the planet, and the overlap gate never skips a
re-fetch.

Drop the normalization and leave west/east unnormalized instead, so
the box stays monotonic. The only remaining edge case (coordinates
outside the conventional range reaching the Overpass query builder)
is a visible, separate problem rather than a silently wrong center.

Addresses review feedback on #392.
2026-09-16 20:02:26 +05:30
onionviolet 9c638fa290 refactor(geo): define shared distance contract 2026-09-16 08:48:31 -04:00
ulihhhhandClaude Sonnet 5 25f90692cf Merge upstream main into feature/catalonia-cctv-cameras to resolve PR #595 conflicts
Upstream added Director, Transit/GTFS-Realtime and Bhote Koshi scene work
in the same window; the only real conflict was two adjacent CHANGELOG
entries, resolved by keeping both.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-09-16 10:34:16 +02:00
manjunath22466 621d186de1 fix: scope Nepal media playback to explicit scene actions 2026-09-16 12:14:15 +05:30
manjunath22466 cf0b9927de Merge public main into Nepal media follow-up 2026-09-16 10:40:29 +05:30
Sameh Khamis a65d9d85f1 Merge pull request #616 from bilawalsidhu/feat/director-sharing
Add Director authoring, import previews and scene bundles
2026-09-15 20:19:57 -07:00
Sameh Khamis 078fc290ec Add Director authoring, import previews and scene bundles 2026-09-15 20:15:32 -07:00
Sameh Khamis 62f66c4b86 Merge pull request #614 from bilawalsidhu/feat/director-interactions
feat: add declarative Director feature actions
2026-09-15 19:20:40 -07:00
Sameh Khamis 80027756ef feat: add declarative Director feature actions 2026-09-15 19:16:49 -07:00
Sameh Khamis a30c42322c Merge pull request #613 from bilawalsidhu/feat/director-data-packs
Director: add bounded scene data packs and geographic placement
2026-09-15 18:05:57 -07:00
Sameh Khamis f558a240d1 Release failed asset responses and refuse cancelled requests 2026-09-15 18:01:39 -07:00
Sameh Khamis 92526e9a92 feat(director): add bounded scene data packs and placement 2026-09-15 17:59:53 -07:00
Sameh Khamis 4436d7f18e Merge pull request #612 from bilawalsidhu/feat/director-camera-directions
Add Director camera anchors and authored moves
2026-09-15 17:01:53 -07:00
Sameh Khamis 13c0b8d1bc feat(director): add authored camera directions and anchors 2026-09-15 16:53:26 -07:00
Sameh Khamis 0ea10468ea Merge pull request #611 from bilawalsidhu/feat/director-documents
Validate scene documents and preserve saved edits
2026-09-15 16:24:11 -07:00
Sameh Khamis 18300e7e00 feat(director): validate scene documents and preserve saved edits 2026-09-15 16:20:36 -07:00
Sameh Khamis c894d7b920 Merge pull request #610 from bilawalsidhu/refactor/director-timing
Separate Director timing, clocks and scene-pack presentation
2026-09-15 15:46:57 -07:00
Sameh Khamis 8a3c4868b0 refactor(director): separate timing clocks and scene pack presentation 2026-09-15 15:41:42 -07:00
Reloded 976efed6dc feat(cctv): add Lithuania Eismoinfo road cameras 2026-09-16 00:14:46 +03:00
Sameh Khamis 5728dec24d Merge pull request #604 from bilawalsidhu/refactor/realtime-owners
refactor(voice): separate Realtime session ownership
2026-09-15 12:33:30 -07:00
Sameh Khamis e82e0a149f test: resolve the terrain fixture through its dependency 2026-09-15 12:29:18 -07:00
Sameh Khamis a6f9c3d82a Merge remote-tracking branch 'origin/main' into refactor/realtime-owners
# Conflicts:
#	CHANGELOG.md
2026-09-15 12:21:32 -07:00
Bilawal Sidhu 50d3672a00 fix(transit): keep parked vehicles pointed along their course while the camera orbits (#603)
## Changes

Follow-up to #596 from the owner's look: a parked transit vehicle turned with the camera. Moving vehicles project their world course into screen space on every camera change, but a vehicle that had never moved on screen could have no display course and was skipped by that pass, leaving its billboard at a screen-anchored angle; rotation invalidation also relied on camera events that a pose change without a revision could miss. Now every visible vehicle with any usable course (derived, held, or the feed's reported bearing) is re-projected at the existing 5 Hz cadence on camera pose changes. Moving playback and the 120°/s course limiter are unchanged.

## How it was verified

- `npm run format:check` (861 files), `npm run check:boundaries` (109 groups), `npm test` (4,068 passing), `npm run build` clean; tracking regression 109/109 in a real browser on Google 3D tiles.
- Node tests: a stationary vehicle with a held course, and one with only a reported bearing, under a camera at heading 0° then 90° yield screen rotations 90° apart.
- Browser harness (`scripts/qa-transit.mjs`, keyed on Google 3D tiles): a parked scripted vehicle orbited by 90° rotates 90.000° on screen; a moving vehicle's rotation still matches its rendered travel; both checks fail on main and pass here. Full keyed run: 201 pass; the nine failures are the per-frame allocation gate already recorded as a follow-up and threshold-edge readability lines on the Boston matrix, both unchanged from #596.
2026-09-15 14:15:27 -05:00
Sameh Khamis e7970c50b7 fix(voice): discard continuations from closed conversations 2026-09-15 12:13:35 -07:00
Sameh Khamis aa6804802c Merge remote-tracking branch 'origin/main' into refactor/realtime-owners 2026-09-15 12:05:07 -07:00
Sameh Khamis cc9a080f2d refactor(voice): separate Realtime state and resource owners 2026-09-15 12:05:01 -07:00
Bilawal Sidhu 0bb61f53c6 fix(transit): keep the real silhouettes under sensor presets, make the selected trail visible, put Transit in Movement (#596)
## Changes

Follow-up to #587 after the owner's first look at the merged transit layer on Google 3D tiles.

- **Sensor presets keep the real silhouettes.** Under NVG, thermal (white-hot, black-hot, Ironbow) and noir, vehicles are the same silhouettes as in normal view, filled opaque white with a 2 px dark halo, at the CRT display sizes (26 px fleet, 39 px selected). The solid rounded "signature" bodies are gone.
- **The selected vehicle's trail is visible.** The retained history is now draped onto 3D tiles and terrain (`GroundPolylinePrimitive`, `ClassificationType.BOTH`, the way the traffic heat-lines are drawn), 3 px core over a 5 px dark backing, per-segment age colour, a short draped head clipped to the sprite. Two defects kept it off screen before: Cesium's per-instance attribute getters return copies, so the renderer's show/colour edits were discarded, and a marker did not recover after the camera jumped to it, which hid the trail with it. Trail geometry is now prepared on selection independent of floor resolution and marker visibility; sparse long intervals (rail) keep a bounded marker corridor instead of dropping the interval; classification survives map-source changes.
- **Transit sits in the Movement panel group** between Street Traffic and Bike Share (the panel orders by `PANEL_GROUPS`, not by catalog order; the catalog is moved too).

## How it was verified

- `npm run format:check` (854 files), `npm run check:boundaries`, `npm test` (4,062 passing), `npm run build` clean; tracking regression 109/109 in a real browser on Google 3D tiles.
- Browser harness (`scripts/qa-transit.mjs`), keyed on Google 3D tiles and keyless: keyed 194 pass, with the trail pixel check passing at 300, 600 and 900 m; the remaining keyed failures are the per-frame allocation gate already recorded as a follow-up from #587 (CPU and frame time within budget), four readability lines at threshold edges, and the card-anchor check now counting frames where the selected marker is legitimately off screen; keyless 193 pass with the remaining misses being threshold edges on the thin tram silhouette (centre 0.83–0.88 against 0.85) and one bus ring 0.28 against 0.25 on a pure-white roof.
- New harness checks: `Google 3D selected trail visible at 6 of 8 projected samples` (repeated off/on framebuffer captures at 300/600/900 m, samples outside the sprite footprint, a background-change negative control; fails on main, passes here), a camera-arrival check (select a moving vehicle, `setView` onto it, marker shown and trail body drawn within 2 s), `PANEL_ORDER` pinned, raster tests comparing every sensor raster's mask and aspect ratio to the normal silhouette.
- Direct look on a keyed build: a live CapMetro bus at 30 m/s selected through the layer API draws its draped trail along the highway lane (harness capture `keyed-600m-trail-visible.jpg`).
- Adversarial review by Codex Astra before the last two fix passes (stack-switch classification, marker corridor under the vertex cap, pixel-gate loophole), all three fixed with regressions.

Docs: `docs/CURRENT-STATE.md` and `CHANGELOG.md` updated in this PR. No data-source changes.
2026-09-15 13:26:41 -05:00
manjunath22466 94f83c59de fix: prevent Nepal media from opening external browsers in Pinokio 2026-09-15 23:54:07 +05:30
Sameh Khamis cd22ca3559 Merge pull request #599 from bilawalsidhu/refactor/application-shell-owners
refactor: separate application shell state and lifecycle owners
2026-09-15 11:21:34 -07:00
Sameh Khamis bfefa875e1 refactor: separate application shell state and lifecycle owners 2026-09-15 11:17:10 -07:00
Sameh Khamis 81b82da056 Merge pull request #597 from bilawalsidhu/refactor/director-playback
Extract reusable Director scene playback
2026-09-15 10:20:11 -07:00
Sameh Khamis 9f7adf71f6 refactor: extract reusable Director playback 2026-09-15 10:15:12 -07:00
Pedro Lobato 3308569edd docs(cctv): the media-fetch log line drops the error text on purpose
The comment claimed "Keep the detail in the log" while the line it introduces
carries none, so the next reader would have read the omission as an oversight
and added the errno back.

Detail-free is the deliberate choice: a media-fetch failure names the camera's
upstream host, and these lines get pasted into issues. Say that, and say why
the catch at the bottom of this file may still log its error text.
2026-09-15 12:06:11 -05:00
Pedro Lobato 92350b8412 Merge remote-tracking branch 'origin/main' into fix/sanitize-openai-proxy-errors
# Conflicts:
#	CHANGELOG.md
2026-09-15 11:58:25 -05:00
Pedro Lobato 4fd168ff3c Merge remote-tracking branch 'origin/main' into fix/realtime-debug-log-hardening
# Conflicts:
#	CHANGELOG.md
2026-09-15 11:49:03 -05:00
Pedro Lobato fa9af39e7b fix(terrain): bound the client terrain-height cache with LRU eviction
The in-memory cache in the terrain-height resolver had no eviction, so a
session retained every coordinate it ever resolved for the lifetime of the
page. The 5-decimal rounding documented in the file header makes repeated
visits to one place share a key, but it does not bound how many distinct
places a session visits.

Cap it at 20 000 entries, overridable per instance so the bound is testable
without minting twenty thousand coordinates. Eviction is least-recently-used
rather than insertion-ordered because revisits here are spatial: the cell the
camera is parked on must not be dropped for having been resolved early.

The bound sits far above a city-scale session at the ~111 m floor grid, so
normal use never evicts and issues no additional proxy requests. Batch results
are assembled from what the call resolved, so eviction during a large batch
cannot report a just-resolved point as unresolved.
2026-09-15 11:33:56 -05:00
ulihhhhandClaude Sonnet 5 ffbe98b4ac test(format-scope): register cctvCataloniaSource.test.mjs for format:check
Mechanical addition per CONTRIBUTING.md, following the existing per-pack
test-file entries (cctvCalgary.test.mjs, cctvNswSource.test.mjs, etc.).

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-09-15 18:07:40 +02:00
ulihhhhandClaude Sonnet 5 ae661db7ab feat(cctv): add Catalonia (Servei Català de Trànsit) as a keyless CCTV source pack
One WFS/GML XML feed (~135 cameras) aggregating three publishers under a
`font` field: SCT's own highway cameras plus hotlinked Barcelona (IMI) and
Terrassa municipal cameras. Frame URLs are checked against a small host
allowlist rather than one pinned origin, and every non-SCT camera carries
its real owner as a `credit` shown beside the shared provider. The feed
carries no compass heading, so every camera loads at low heading confidence
(same as TfL and Fintraffic), and ground elevation is primed per publisher
rather than one flat prior.

SCT's own frame link needed a workaround: RenderService always 302s to a
second endpoint (TransitCamera) on a Location the upstream hardcodes as
plain http even when requested over https — refused by fetchWithinHost's
same-origin (scheme-included) redirect policy, by design (stops an upstream
steering a host-pinned request into a plaintext downgrade). Separately,
mct.gencat.cat's TLS setup fails the handshake with Node's fetch outright
(ERR_SSL_WRONG_SIGNATURE_TYPE) even though other HTTP clients complete it.
The loader builds the TransitCamera URL itself, over plain http, from
RenderService's sctidcam id, instead of registering the broken upstream
link — the only transport this host actually serves to this runtime.

Verified against the live feed and the production fetch path
(fetchCctvImageFromUpstream): all 135 cameras return real image bytes, 0
false positives. Ambient-card refresh cadence added to src/data/cctvLod.js
(3 minutes), matching the upstream update rate measured empirically (no
change inside 64s, changed within ~90-150s) — the same cadence already used
for Caltrans/TfL/Ontario/TxDOT.

CCTV_CATALONIA_MAX_SOURCES sets the cap and CCTV_CATALONIA_ENABLED=0 turns
the pack off. No overlap with any existing pack (checked catalog.js and the
git history for Spain/Catalonia/Barcelona coverage: none exists).

Verified before this commit: format, check:boundaries, unit suite (3692
tests), and build all green.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-09-15 18:07:40 +02:00
Sameh Khamis 2746ec753c Merge pull request #593 from bilawalsidhu/refactor/semantic-map-features
refactor: separate map feature queries and source records
2026-09-15 08:50:36 -07:00
Sameh Khamis fd6106ee01 Merge current main into map-feature refactoring 2026-09-15 08:41:34 -07:00
Sameh Khamis 9e27a0e7cd test: wait for destination traffic after camera changes 2026-09-15 08:40:58 -07:00