Commit Graph
5071 Commits
Author SHA1 Message Date
Sameh KhamisandManjunath Paparaju e6f21777ba Street Level photo viewer: keyless ranking, closed waits, a moved canvas
Review follow-ups to the previous commit:

- photoViewers.js ranks a presentation without a mountKey as mounted when
  it began presenting (after the latest key seen, before any later mount),
  so a photo viewer mounting while a keyless one shows is drawn and the
  keyless one superseded; supersede is queued whenever more than one
  presents after any change, not only when the pick changes.
- A panorama's open still waiting on a draw when the last view leaves
  fails as closed and leaves no photo shown, instead of uploading to a
  canvas never drawn. A mount waiting on its first draw then also fails as
  closed and is unmounted, so a view subscribing later sees nothing.
- A view handing back another canvas element than the renderer's drops
  the renderer and draws the panorama again on the new one, as after a
  lost context.
- The guard test allows a .src write in loadImage only on the one `image`
  binding, created by new Image() and never rebound or shadowed, and
  refuses `(expr).src =` and bracket property writes anywhere.
- The test fakes' shared view is reset before each test
  (resetPhotoView), so a viewer left by an earlier test is neither drawn
  with nor superseded by a later test's.

Nothing changes in the running app.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 16:04:21 -08:00
Sameh KhamisandManjunath Paparaju 33ac0545ef Street Level photo viewer: settle opens, a gapless picker, a stated contract
Follow-ups to the photo viewer's move to a Vue view (#1868):

- A panorama's open waits for a draw of the canvas counted from before it
  is shown, so a view that draws at once inside its listener no longer
  leaves the open pending; and when the last view unsubscribes, an open
  waiting on a draw goes on instead of hanging.
- photoViewers.js supersedes the mounts not drawn on a microtask, after
  the winning presentation has reached every subscriber: a second
  subscriber sees the earlier mount, then the later one, never null
  between.
- A presentation without a mountKey counts as the latest mount (among
  several without, the one that began presenting last), and one without
  actions or supersede is passed over without throwing. Both fields are
  documented on ViewerAdapter.subscribeView in registry.js and in the
  store's comment.
- The guard test also refuses .width, .height, .ariaLabel, .id and .value
  writes in photoViewer.js, and .src writes outside loadImage, where only
  the off-page Image it creates may take one.
- The test fakes draw every viewer through one shared view behind
  photoViewers.js's picker, as the application does, so provider and
  layer tests see supersede.

Nothing changes in the running app.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 15:48:50 -08:00
German Khokhlov 12dc0de20d Merge pull request #1360 from ch-bas/feat/alpr-model-specs
feat(alpr): show datasheet specs for mapped ALPR camera models
2026-11-20 03:29:51 +04:00
German Khokhlov aa5ab7d387 Merge branch 'main' into feat/alpr-model-specs 2026-11-20 03:17:38 +04:00
Sameh Khamis 644f8cf3f0 Merge pull request #1866 from bilawalsidhu/samehkhamis/no-focus-zoom
A phone no longer zooms the page when a text field gets focus
2026-11-19 15:16:03 -08:00
Sameh Khamis efc03a3f6e Merge branch 'main' into samehkhamis/no-focus-zoom 2026-11-19 15:01:04 -08:00
Sameh Khamis b57d50fe18 Merge pull request #1868 from bilawalsidhu/samehkhamis/kit-sweep-photo-globe
Vue kit: Street Level's photo viewer is a Vue view
2026-11-19 14:57:16 -08:00
Sameh Khamis c2e5ed271e Merge branch 'main' into samehkhamis/no-focus-zoom 2026-11-19 14:48:02 -08:00
Sameh Khamis cc73059f2b Merge branch 'main' into samehkhamis/kit-sweep-photo-globe 2026-11-19 14:45:25 -08:00
German Khokhlov 99ba768c49 Merge pull request #1808 from bilawalsidhu/german/cctv-camera-counts
Show how many cameras a thinned CCTV marker stands for
2026-11-20 02:43:00 +04:00
Sameh Khamis e4df80cb09 Merge branch 'main' into samehkhamis/no-focus-zoom 2026-11-19 14:32:41 -08:00
Sameh KhamisandManjunath Paparaju 9c6152911a Add the changelog entry for #1868
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 14:31:45 -08:00
German Khokhlov 374efbedc1 Merge branch 'main' into german/cctv-camera-counts 2026-11-20 02:29:12 +04:00
Sameh Khamis 848d528316 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-photo-globe
# Conflicts:
#	docs/VUE-MIGRATION.md
#	scripts/format-scope.json
2026-11-19 14:25:42 -08:00
Sameh Khamis 1e049c5eec Merge pull request #1865 from bilawalsidhu/samehkhamis/kit-sweep-bhote-koshi
Vue kit: Bhote Koshi's buttons and media cards are kit controls and a view
2026-11-19 14:25:37 -08:00
Sameh Khamis 03301082fe Add the changelog entry for #1866 2026-11-19 14:17:31 -08:00
Sameh Khamis 340f3b59ab fix(ui): a phone no longer zooms the page when a text field gets focus
iPhone Safari zooms the page in whenever a text field under 16 px gets focus,
and every field in the app is under 16 px, so tapping the search box left the
page zoomed in with its buttons out of reach. The viewport now has a maximum
scale of 1, as map pages usually do: the map handles pinch zoom itself, and
iPhones still let a pinch zoom the page.
2026-11-19 14:17:23 -08:00
Sameh KhamisandManjunath Paparaju 017f1988df Add the changelog entry for #1865
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 14:11:41 -08:00
Sameh Khamis 36ef856ca2 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-bhote-koshi
# Conflicts:
#	scripts/format-scope.json
2026-11-19 14:07:36 -08:00
Sameh Khamis e02f6c6e39 Merge pull request #1864 from bilawalsidhu/samehkhamis/kit-sweep-missions-radio
Vue kit: missions', Contacts', Radio's and key setup's buttons and glyphs are kit controls
2026-11-19 14:07:24 -08:00
German Khokhlov b322ac1df9 Merge remote-tracking branch 'origin/main' into german/cctv-camera-counts 2026-11-20 02:02:08 +04:00
German Khokhlov aba4c9e533 fix(cctv): keep a clicked group in frame and let counts take clicks over plain fills
- The flight after a count click checks the frame on both axes and at the
  height of the highest mount, so a group on a slope or in a very wide
  window stays in view; when it cannot, it flies to the nearest cell with
  two or more cameras, never to a lone camera that joined the count.
- A count takes a click over a background fill no layer owns (earthquake
  discs, fire perimeters), and still yields to a scene item another layer
  registered.
- A count crossing the HUD edge refreshes the view only when the active
  icon or a lone camera depends on it, and never mid-motion, so panning no
  longer runs extra full view passes.
- A count restored at the HUD edge keeps the lone cameras its outline
  covers, and leaves the others as icons.
2026-11-20 02:02:06 +04:00
Sameh KhamisandManjunath Paparaju 92010a3b5e Add the changelog entry for #1864
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 13:55:11 -08:00
Sameh KhamisandManjunath Paparaju 2a0e21774b Street Level photo viewer: fresh elements per mount, and one viewer drawn
Fixes from review of the move to StreetLevelPhotoViewer:

- Each mount and each panorama canvas now takes a key no viewer reuses,
  and the view keys its root by the mount. Before, switching KartaView and
  Panoramax in one tick let Vue patch the old viewer's canvas, whose
  destroyed renderer had lost its context, into the new one, so 360°
  photos fell back to their front view.
- Of the viewers mounting in the host, the view draws the one mounted
  last, by mount key (photoViewers.js, which subscribePhotoViewer() now
  uses), whatever order they present in. A viewer still mounting when a
  later one is drawn is superseded: it unmounts and its mount fails as
  closed, rather than staying pending and being drawn once the later one
  goes.
- A panorama's first image is uploaded once the view has drawn its canvas
  shown (the view hands the canvas back on every draw), so it is never
  sized into a hidden canvas.
- The tests' fake view now draws as Vue does: once per tick with the final
  value, keeping elements while their keys are unchanged and handing every
  element back on each draw. StreetLevelPhotoViewer.test.mjs covers the
  switch in one tick and the overtaken mount with the real view.
- The guard test's check that the photo viewer writes no DOM covers
  inserting, moving, removing and replacing elements, attributes, classes,
  styles and the hidden, disabled and text properties.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 13:52:36 -08:00
Sameh Khamis 0f6db03e12 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-missions-radio
# Conflicts:
#	docs/VUE-MIGRATION.md
#	scripts/format-scope.json
2026-11-19 13:50:26 -08:00
Sameh Khamis 6f339b5377 Merge pull request #1863 from bilawalsidhu/samehkhamis/kit-sweep-draw
Vue kit: Draw's and Import's buttons and glyphs are kit controls
2026-11-19 13:50:22 -08:00
Sameh KhamisandManjunath Paparaju 13e8ceab1c Add the changelog entry for #1863
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 13:36:31 -08:00
Sameh KhamisandManjunath Paparaju 766364f691 Vue kit: Street Level's photo viewer is a view with kit buttons
The photo viewer KartaView and Panoramax share (photoViewer.js) no longer
builds its root, picture, panorama canvas and ‹ › buttons in script. It
presents them through subscribeView(), which the street-level layer
gathers in subscribePhotoViewer(); the application shell publishes that
to the gev-street-level-photo store, and StreetLevelPhotoViewer, beside
the Street Level panel in the layer panels, teleports the viewer into the
viewer host with the same classes, data attributes, labels and order. Its
‹ and › are ghost UiButtons. The view forwards keys, pointers, wheel, the
step clicks and a lost WebGL context to the viewer and hands each element
back: the canvas the panorama is drawn on (a fresh, keyed one after a lost
context, which an open now waits for), and the frame, picture, root and
buttons the viewer measures and keeps focus with. The viewer keeps every
decision: loading, upgrades, size limits, keys, drag, pinch, zoom, Esc on
the viewer's box and focus when a step button disables. The street-level
layer still needs no Vue; with no view subscribed these photos cannot
mount, which docs/VUE-MIGRATION.md records.

The provider and viewer tests draw the viewer with a fake view in
kartaViewFakes.mjs; StreetLevelPhotoViewer.test.mjs runs the real view on
a page, and streetLevelPhotoControls.test.mjs pins the kit controls. The
panel page's lost-graphics notice in globePanelRuntime.js stays built in
script, as the document now says.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 13:33:58 -08:00
Sameh Khamis 25cbd124d5 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-draw
# Conflicts:
#	docs/VUE-MIGRATION.md
2026-11-19 13:29:56 -08:00
Sameh Khamis cbb108d40c Merge pull request #1862 from bilawalsidhu/samehkhamis/kit-sweep-chat-voice
Vue kit: the chat panel's and voice control's buttons and glyphs are kit controls
2026-11-19 13:29:53 -08:00
Sameh Khamis b95c913130 Merge branch 'main' into samehkhamis/kit-sweep-chat-voice 2026-11-19 13:16:28 -08:00
Sameh KhamisandManjunath Paparaju d93d430516 Test that the Bhote Koshi cinematic button is pressed while it owns the camera
The event layer's tests now check the button's pressed state: true once a replay claims the camera, false once the operator releases it. Before, only the panel view's test covered it, with hand-built records.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 13:08:25 -08:00
Sameh Khamis 9423a26487 Merge pull request #1861 from bilawalsidhu/samehkhamis/bare-address-defaults
A bare address starts with the default layers
2026-11-19 13:08:14 -08:00
Sameh Khamis e3a1223090 Merge branch 'main' into samehkhamis/kit-sweep-chat-voice 2026-11-19 13:03:17 -08:00
Sameh KhamisandManjunath Paparaju 545beaee87 Vue kit: Bhote Koshi's buttons and media cards are kit controls and a view
The reconstruction panel's buttons (previous and next beat, Play, Play
scene, Cinematic, Full story, Open original, Lower gorge, the field
reports and Open public map) are ghost UiButtons that keep their
data-action hooks. Cinematic is a pressed toggle: the event layer now
presents its state as the record's `pressed` instead of writing an
aria-pressed attribute, so it is no longer an exception in
viewControls.test.mjs; bhote-koshi.css still reads aria-pressed, so it
takes no pressed class.

The embedded media cards (frame, leader line, title, status, original
link) and the hidden YouTube preload are drawn by BhoteKoshiMediaCards,
which bhoteKoshiEmbeddedMedia.js renders into its overlay root with h()
and render() on every change and on a locale change, in place of the
markup it built with createElement and innerHTML. Placement after each
frame, provider loading, preloads, timers and teardown are unchanged. The
script still builds the SDK script and preconnect tags, the overlay root
and the Facebook player node, which is warmed hidden before its card
exists and carried loaded into the card, where the SDK replaces it.

bhoteKoshiControls.test.mjs pins it; the media tests run on a DOM.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 13:01:28 -08:00
Sameh Khamis 488a980315 Merge branch 'main' into samehkhamis/bare-address-defaults 2026-11-19 12:54:40 -08:00
Sameh Khamis dbf9046566 Merge pull request #1857 from bilawalsidhu/fix/zoom-freeze-under-icons
fix(render): wheel zoom no longer stalls with an icon under the canvas centre
2026-11-19 12:54:35 -08:00
Sameh KhamisandManjunath Paparaju abb3741b24 Add the changelog entry for #1862
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 12:46:21 -08:00
Sameh Khamis 222c152360 Merge branch 'main' into fix/zoom-freeze-under-icons 2026-11-19 12:41:34 -08:00
Sameh Khamis 21fde3829f Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-chat-voice
# Conflicts:
#	docs/VUE-MIGRATION.md
#	scripts/format-scope.json
2026-11-19 12:40:01 -08:00
Sameh KhamisandManjunath Paparaju 14b6d1cc13 Vue kit: missions', Contacts', Radio's and key setup's buttons and glyphs are kit controls
The Space Missions panel's buttons (a mission's roster row, FOCUS, the
replay's pause, PREV, NEXT and SHOW ALL / DESELECT, beside REPLAY ASCENT
and the two closes that already were), the Contacts panel's PREV, FOCUS,
NEXT and contact rows, the Radio panel's PREV, PLAY, NEXT and STOP, the
RTL-SDR card's Locate, Change device, Tune and the two seeks, and the key
setup's POWER UP chip, REMOVE, voice auth toggle and SAVE KEYS are ghost
UiButtons keeping their ids, classes, data-*, aria-*, titles and
listeners. PLAY and Locate keep their own active class (their words
change with their state), so they gain no aria-pressed. The chip's bolt
is a UiIcon with :size="null", so provider-settings.css still sizes it.

The card's FM frequency stays a native number field (the kit has none)
and the radio tuner's range stays native, as documented. None of these
owners renders synchronously, so no slot needs redrawWithView.

src/ui/kit/missionsRadioControls.test.mjs pins it; docs/VUE-MIGRATION.md
describes the surface and no longer calls the key setup chip a plain
button. radioPanel.test.mjs reads PLAY's Core classes without the kit's.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 12:27:40 -08:00
Sameh Khamis a9487a0683 Add the changelog entry for #1861 2026-11-19 12:26:41 -08:00
Sameh Khamis db1736266b fix(share): a bare address starts with the default layers
Layer choices saved in local storage were restored whenever the address carried
no link, so clearing the address and loading the bare URL brought the last
session's layers back and there was no way to a reset view. Start-up no longer
reads them: a link restores what its hash carries, and a bare address starts
from the defaults.
2026-11-19 12:26:32 -08:00
Sameh KhamisandManjunath Paparaju 35fb3684ba Vue kit: Draw's and Import's buttons and glyphs are kit controls
UTILITIES ▸ Draw and Import no longer hand-write a button or a Material
Symbols span. Clear and Import are ghost UiButtons (Draw already was), and
the Draw and Import glyphs are UiIcons that keep pp-icon, with
:size="null" so controls.css still sizes them. Draw's five colour swatches
(in the toolbar and in a drawn shape's row) are ghost UiButtons that keep
role="radio", aria-checked and their own active class; they are not
pressed toggles. A drawn shape's row (its swatch, show/hide, the
application's row actions and fly to) is on the kit too, beside the remove
UiCloseButton it already had; its glyphs are UiIcons with :size="null".
Show/hide keeps naming itself Show … / Hide … rather than becoming a
pressed toggle.

Template refs that now hold a component reach the button through $el:
the swatches' arrow-key focus and Import's focus fallback when the last
imported file goes.

The Street Level panel's controls were already kit controls (its ⤢ ⤡ and
⚠ are text characters), so its template is unchanged; the new guard test
pins it with Draw and Import.

src/ui/kit/drawControls.test.mjs pins it: no hand-written button, select,
checkbox, range or Material span in DrawControls, DrawSwatches,
DrawMarkList, GeoImport or StreetLevelPanel; the kit counts per file;
Draw a pressed toggle with active; the swatches radios rather than
pressed; :size="null" on every glyph; and the $el refs.
docs/VUE-MIGRATION.md describes the surface.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 12:24:55 -08:00
Sameh KhamisandManjunath Paparaju 8359a23e9d Vue kit: the chat panel's and voice control's buttons and glyphs are kit controls
Every hand-written button in the AI chat panel (Settings, the quick
prompts, an attachment's remove, Attach layer, Attach a file, Expand
conversation, the command suggestions, Expand chat, Add attachment and
Send / Stop reply) and in the voice control (Open AI chat, Back to chat,
Back to voice, the Preview and Settings tabs and the error tray's
DISMISS) is a ghost UiButton keeping its id, classes, aria and data
attributes, title and listeners. The Settings and tab Material glyphs are
UiIcons with :size="null", so voice-cost.css and voice-card.css still
size them. The tabs keep role="tab" and aria-selected; DISMISS is a text
button, so it stays a UiButton rather than a UiCloseButton. The inline
SVG glyphs, the message box, the file picker and the minutes field stay
as they are.

src/ui/kit/chatVoiceControls.test.mjs pins it: no hand-written button or
Material span in the chat, voice, voice card, panel layout and visualizer
templates, kit counts per file, the pressed toggles through :pressed, the
icons' :size="null", the native fields left, and no button built in script
by the voice modules. docs/VUE-MIGRATION.md describes the surface.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 12:19:06 -08:00
Sameh Khamis bcc25be07a Merge pull request #1859 from bilawalsidhu/samehkhamis/changelog-pr-numbers
Fill in the pull request numbers of two changelog entries
2026-11-19 12:17:52 -08:00
Sameh Khamis 648c5136a3 Fill in the pull request numbers of two changelog entries 2026-11-19 12:04:19 -08:00
Sameh Khamis 4770ae2535 Merge pull request #1858 from bilawalsidhu/samehkhamis/kit-sweep-cockpit
Vue kit: the Cockpit's buttons and glyphs are kit controls
2026-11-19 12:02:24 -08:00
Sameh KhamisandManjunath Paparaju 350135b8ad Add the changelog entry for #1858
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 11:20:24 -08:00
Said Turksever 0fd9a7ed57 docs(changelog): zoom freeze under icons (#1857) 2026-11-19 19:19:03 +00:00