The picker no longer keeps a hidden, disabled copy of the opening camera.
That copy could be re-picked with ArrowDown on a closed list, could show
twice in the iOS picker, and left Firefox without an accessible value.
The list now selects the camera's own option, as before. A native list
sends no change for the option it already shows, so FOCUS (or NEAREST,
when that camera is the nearest) keeps the shown camera. Closing the list
without a choice keeps automatic selection.
The centred Display/Radio row now applies only inside the phone shell
(720 px and below) on flight and bridge views; satellite and provider
cockpits, narrow short windows (under 390x450) and very short windows
(under 240 px) keep main's right-anchored place, so the row no longer
lands on the desktop rail, orbital zoom, LOOK AHEAD, Reset or the Stories
button. The row sizes to its launchers instead of spanning the width.
The first-visit Stories announcement stays hidden and unread while
Cockpit is open: a Stories tap that Cockpit refuses no longer marks it
seen, so it shows again after Exit.
The unit tests and the Cockpit QA cover the phone boundary, glyph and
side taps, the destination cue, short and narrow windows and the
announcement's return.
- The /frame handler reads the client's network key (IPv6 /64) before it
awaits the camera, so a client that drops the connection is still
charged to its own window instead of the shared fallback key.
- The budget is charged only after the Google key and finite catalog
coordinates are confirmed, and the key is read once.
- Places and the CCTV window share one default (GOOGLE_DEFAULT_PER_MIN).
- Tests: the catalog-only test checks heading/fov/pitch from the query at
the catalog location; the budget test covers unknown ids, forwarded
requests and /64 grouping; a real-socket test covers a dropped
connection. The duplicate pose test is removed.
- .env.example, SECURITY.md, CURRENT-STATE and the changelog fragment
describe the separate per-IP window, the catalog position and the
placeholder for seed cameras.
A grounded row with no altitude fell back to the aircraft's sticky
altitude, which straight after a landing is still the approach height.
Military contacts then hung there for as long as they stayed on the
ground (the grounded floor only ever raises a height); civil contacts
held it until the ground cell under them warmed, which for a contact far
from the viewer is never. The 3D model is ground-snapped on its own, so
the plane dropped when the model took over.
A grounded contact with no altitude now uses only an altitude it gave
on the ground, else the ground fallback. Labels, the tracked readout
and the follow distance read "On the ground" / no flight level instead
of the approach altitude.
The bar takes the dock's floor and the dock, with the search field, rises by
the bar's height while it shows, as the dock does outside the search layout.
The bar no longer hides while search results or the chat and voice panels
open, since they open upward from the dock and no longer cover it.
An imagery spec and a raster shell take an optional `shows`, such as
'clouds' or 'radar'. Drawing never depends on it; a renderer may use it
to tell such a layer apart. The weather layer sets it for every product,
'clouds' for both cloud products.
The check recorded a canvas that stayed blank until its first 20 ms paint
tick, so on a loaded runner the video's opening frames were dark and the
pixel early in the segment read (28, 54) instead of red: main failed once
after #1872 and passed on the runs around it.
esbuild compiles an optional method call reached through an optional chain
(`a?.b?.()`) in a parameter's default, for browsers it lowers optional
chaining for (Chrome and Edge before 91), into code that reads a variable out
of its scope. The weather shell's texture limit was read that way, so every
satellite frame threw a ReferenceError in the built app and the layer showed
"Weather imagery unavailable"; the leader and card reveal took their default
time the same way. A test now refuses the form anywhere under src/.
On a phone the field kept 60px on its right for the language picker even
where the application shows none, so it sat left of centre. It now keeps
16px either side, and leaves the picker its room only while it is there.
A canvas the panorama moved off (a second view drew its own) is no longer
ignored for good: its draws are counted, so an open waiting on one goes on,
and once a single view is left its canvas is taken back. Before, after the
second view left, the next 360° open waited forever and the panorama stayed
on the departed view's canvas.
A mount whose view unmounts it inside its first draw now fails as closed,
as every other unmounted mount does, rather than with a TypeError.
Both found in review; each new test fails without its fix.
Co-authored-by: Manjunath Paparaju <[email protected]>
Second review follow-ups:
- A mount woken without being drawn unmounts only its own presentation:
an earlier mount overtaken by a second mount of the same viewer fails
as closed and leaves the second one mounted and presented.
- A mount whose last view left fails only if no view has subscribed
since; one subscribed in the same tick draws it.
- Mount keys come from photoViewers.js's nextViewKey(), and a keyless
presentation is stamped from the same counter when any picker first
sees it, kept until it presents null: its rank no longer depends on the
picker's lifetime or the order it subscribes in.
- A canvas handed back while a panorama's open waits on its draw takes
the panorama: the open builds its renderer there instead of falling
back to the front view. A canvas the panorama moved off is not moved
back to, so two views drawing their own cannot take it in turns.
- The guard test also refuses compound writes (+=, ||=, ??=, &&=…),
destructuring writes to properties, Object.assign (other than onto a
new Error), Object.defineProperty and Reflect.set, and a catch binding
that shadows loadImage's image.
Nothing changes in the running app.
Co-authored-by: Manjunath Paparaju <[email protected]>
Review follow-ups to the previous commit:
- photoViewers.js ranks a presentation without a mountKey as mounted when
it began presenting (after the latest key seen, before any later mount),
so a photo viewer mounting while a keyless one shows is drawn and the
keyless one superseded; supersede is queued whenever more than one
presents after any change, not only when the pick changes.
- A panorama's open still waiting on a draw when the last view leaves
fails as closed and leaves no photo shown, instead of uploading to a
canvas never drawn. A mount waiting on its first draw then also fails as
closed and is unmounted, so a view subscribing later sees nothing.
- A view handing back another canvas element than the renderer's drops
the renderer and draws the panorama again on the new one, as after a
lost context.
- The guard test allows a .src write in loadImage only on the one `image`
binding, created by new Image() and never rebound or shadowed, and
refuses `(expr).src =` and bracket property writes anywhere.
- The test fakes' shared view is reset before each test
(resetPhotoView), so a viewer left by an earlier test is neither drawn
with nor superseded by a later test's.
Nothing changes in the running app.
Co-authored-by: Manjunath Paparaju <[email protected]>