Commit Graph
5024 Commits
Author SHA1 Message Date
German Khokhlov b6d5d7373f Check that the Tarktee body-failure tests close the sibling request 2026-11-20 03:39:06 +04:00
Said Turksever 64c04feb3b Merge branch 'main' into codex/cctv-shared-batch-20261019 2026-11-19 19:19:36 +00:00
Sameh Khamis 00901b8c9c Merge pull request #1856 from bilawalsidhu/samehkhamis/kit-sweep-small-surfaces
Vue kit: the small surfaces' buttons and glyphs are kit controls
2026-11-19 11:08:38 -08:00
Said Turksever 0b84226e4a Merge branch 'main' into codex/cctv-shared-batch-20261019 2026-11-19 19:01:52 +00:00
Sameh KhamisandManjunath Paparaju 765869bcb2 Add the changelog entry for #1856
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 10:52:21 -08:00
Sameh Khamis a739584b64 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-small-surfaces
# Conflicts:
#	scripts/format-scope.json
2026-11-19 10:44:16 -08:00
Sameh KhamisandManjunath Paparaju 40cbe52782 Vue kit: the small surfaces' buttons and glyphs are kit controls
Every hand-written <button> in the locale picker, phone tab bar, globe
actions (Clear, Share, Reset) and compass, imagery divider handle, scene
sharing dialog, layer group index, title logo, Exit clean view, the HUD's
cockpit entry, News card face, rail card header, layer row toggle, credits
line's Data attribution and the camera calibration chips is a ghost
UiButton keeping its id, classes, data-*, aria-* and listeners. Their
Material Symbols spans (tab icons, globe actions, compass needle, cockpit
entry, celestial ring sun and moon) are UiIcons with :size="null".

The Omnibar guide's extra rings, one per further target of a step, are now
drawn by OmnibarGuide.vue from view.subRings instead of being built in
script; startGuide() still reads them from the rendered tree and sets
their boxes each frame.

A UiButton's slot renders inside the button, so under an owner that
patches synchronously (News cards, rail cards, the credits line, the
Omnibar guide's Skip, Offer and Next) a change the button's attributes do
not carry would land a tick late. Those slots are given under a named
condition that is always true (v-if="redrawWithView"), which Vue redraws
with the view.

src/ui/kit/smallSurfacesControls.test.mjs pins it; docs/VUE-MIGRATION.md
describes the surface and the conditional slot.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 10:44:16 -08:00
Sameh Khamis 2796c2547b Merge pull request #1855 from bilawalsidhu/samehkhamis/kit-sweep-command-dock
Vue kit: the command dock's and Context's buttons and glyphs are kit controls
2026-11-19 10:43:30 -08:00
Sameh KhamisandManjunath Paparaju 4b57d22244 Add the changelog entry for #1855
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 10:28:03 -08:00
Sameh KhamisandManjunath Paparaju f9ca76df98 Vue kit: the command dock's and Context's buttons and glyphs are kit controls
The command dock's six style buttons, its two tray toggles, Location's
collapse and the search toggle are ghost UiButtons. The style buttons are
pressed toggles with `active` as their pressed class (Normal is pressed
until a style is published), so they now carry aria-pressed.

The Context panel's two tabs, Contacts, the cockpit entry and SEARCH
NEARBY SITES are ghost UiButtons; the tabs and Contacts stay role="tab"
controls with aria-selected and their own active class. The view context
it shows while nothing is picked (an off layer's worldwide tile, an
item's row, the place and layer chips and Ask GEV) is on the kit too; the
worldwide tile is a div or a UiButton rather than a dynamic component.
Every Material glyph in the three templates is a UiIcon with
:size="null", so the site rules still size them; an item's motion glyph
keeps role="img" and its name, with the kit's aria-hidden taken off.

src/ui/kit/commandDockControls.test.mjs pins it; the markup tests that
matched the old button source or class text read the kit's markup, and
docs/VUE-MIGRATION.md describes the surface.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 10:08:57 -08:00
Said Turksever 1e3f8053e1 Merge remote-tracking branch 'origin/main' into pr1266 2026-11-19 18:06:58 +00:00
Said Turksever 75f1a3c181 Frame the port-drawn gizmo in the CCTV QA drag fixture and share the catalog-pair reader
The drag-fixture framing looked the gizmo up in viewer.entities, which main no
longer populates, so it did nothing and five drag checks stayed inconclusive.
It now reads the arrow from the layer's drawn state and records the framed
shaft length as a check.

Tarktee and Lithuania read their two catalogs through one helper,
readCatalogsTogether, so both get the shared deadline, sibling abort and the
release of a response that arrives after the other feed failed.

An Ontario error response has its body released, and tests pin the refused
redirect and system-code log labels.
2026-11-19 18:06:58 +00:00
Sameh Khamis e705fdea82 Merge pull request #1854 from bilawalsidhu/samehkhamis/kit-doc-claims
Vue kit: the docs' every-control claims hold, and a scan of every view pins them
2026-11-19 09:41:04 -08:00
Sameh KhamisandManjunath Paparaju 8547bcda08 Add the changelog entry for #1854
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 08:06:32 -08:00
Sameh KhamisandManjunath Paparaju 1e70e15ceb Vue kit: the docs' every-control claims hold, and a scan of every view pins them
docs/VUE-MIGRATION.md says every select is a UiSelect, every close button
a UiCloseButton and (nearly) every pressed toggle a UiButton. Make those
true in code, correct the sentences that were not, and pin them.

Selects: Story Explore's sort, the chat's layer picker and a layer row's
range ends are UiSelects. The range ends take `hold`, since the layer
panel repaints the row on a later frame.

Close buttons: the space mission replay's Cancel is a bare UiCloseButton.
An imported file's row actions (show or hide, fly to, remove) are icon
UiButtons drawing the icon the file import names, so Remove stays one of
them; the presenter's `pressed` is now a boolean.

Pressed toggles: the tilt-map button, the scene action buttons, the chat
and voice panels' dock (and its minimize), the Context header's search
and expand, Recent Imagery's day chips, SWAP and ZOOM IN, the rail row
lists and the rail cards' action chips are UiButtons with `pressed` (and
`pressed-class="active"` where their active class came from the same
state). Their Material glyphs, and the rail chips' icons, are UiIcons
with `:size="null"`. Bhote Koshi's cinematic button keeps the attributes
its layer writes, and Explore's story cards stay role="button" elements.

Docs: the kit list gains UiPanelToggle and UiPanelEdge; the pressed-toggle,
chips, Stories search fields, role="dialog", close button, range and
source-reading-tests sentences now say what the code does.

Tests: src/ui/kit/viewControls.test.mjs walks every .vue outside the kit
and fails on a raw select, a hand-written aria-pressed on a button,
UiButton or role="button" element (outside the two documented
exceptions), or a hand-written close glyph button. closeButtons.test.mjs
also catches a × inside a span.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 07:56:34 -08:00
German Khokhlov bdd92663d6 Cancel the Tarktee sibling on a body failure and settle review notes
Each Tarktee DATEX feed now reads its body as soon as its headers arrive, so a
failed or oversized body aborts the other request at once instead of waiting
for its headers up to the shared 30 s deadline. Status and redirect errors
name the feed again.

Ontario failures log the error class and system code, never the key-bearing
URL or upstream text. DATA_SOURCES.md and the camera licence field use the
Open Government Licence – Ontario statement the credit shows, and a test pins
that credit.

The focus-release rendering test now uses main's icon renderer and its
isVideoFeedCamera contract. The Tarktee cancellation tests disable the 30 s
deadline and time out after 2 s, so a regression fails fast instead of passing
late or hanging; a duplicated older test and an unused import are gone.

This PR's notes move into changelog.d/1266-cctv-shared-fix-batch.md: the 1133
fragment described main's tracking probe and terrain check, not this branch.
2026-11-19 18:59:04 +04:00
German Khokhlov d7db1090fd Merge main and resolve the CCTV batch conflicts
Main released #1228 and #1233 and deleted their changelog fragments, so they
stay deleted here. Main also rewrote the tracking arrival probe in
scripts/track-regression.mjs, which supersedes this branch's version; main's
file is kept unchanged.
2026-11-19 17:56:23 +04:00
Sameh Khamis 5dbd73b4e9 Merge pull request #1852 from bilawalsidhu/samehkhamis/kit-sweep-stories
Vue kit: the Stories views' buttons are UiButtons and Explore's filters UiCheckboxes
2026-11-19 05:24:33 -08:00
Sameh KhamisandManjunath Paparaju f821c31a36 Add the changelog entry for #1852
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 05:04:48 -08:00
Sameh Khamis e9f69d90a2 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-stories
# Conflicts:
#	docs/VUE-MIGRATION.md
2026-11-19 05:04:48 -08:00
Sameh Khamis 42559db10b Merge pull request #1851 from bilawalsidhu/samehkhamis/kit-sweep-layer-finder
Vue kit: the layer finder's buttons and glyphs are kit controls
2026-11-19 05:04:24 -08:00
Sameh Khamis 7faf14c6a1 Merge branch 'main' into samehkhamis/kit-sweep-layer-finder 2026-11-19 04:49:01 -08:00
German Khokhlov 12d208bae1 Merge pull request #1598 from bilawalsidhu/fix/shortcuts-modifier-keys
fix(ui): F collapses the Data Layers panel like its button and keeps focus
2026-11-19 16:47:54 +04:00
German Khokhlov 379afa03db Merge branch 'main' into fix/shortcuts-modifier-keys 2026-11-19 16:34:45 +04:00
Sameh KhamisandManjunath Paparaju e2ff789a29 Add the changelog entry for #1851
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 04:32:21 -08:00
Sameh Khamis 7ba6d86485 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-layer-finder
# Conflicts:
#	docs/VUE-MIGRATION.md
#	scripts/format-scope.json
2026-11-19 04:32:21 -08:00
Sameh Khamis 0293e74846 Merge pull request #1850 from bilawalsidhu/samehkhamis/kit-sweep-entity-card
Vue kit: the entity card's buttons and glyphs are kit controls
2026-11-19 04:32:05 -08:00
German Khokhlov 39f8068f31 Merge branch 'main' into fix/shortcuts-modifier-keys 2026-11-19 16:22:00 +04:00
Sameh KhamisandManjunath Paparaju b31da304d3 Add the changelog entry for #1850
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 04:13:10 -08:00
Sameh Khamis 66446a7cae Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-entity-card
# Conflicts:
#	docs/VUE-MIGRATION.md
#	scripts/format-scope.json
2026-11-19 04:13:10 -08:00
Sameh Khamis 6cecc973a1 Merge pull request #1849 from bilawalsidhu/samehkhamis/kit-sweep-display
Vue kit: the Visual panel's buttons and glyphs are kit controls
2026-11-19 04:12:51 -08:00
German Khokhlov b3724c7bac Merge branch 'main' into fix/shortcuts-modifier-keys 2026-11-19 16:11:04 +04:00
Sameh KhamisandManjunath Paparaju 2c7a1b8014 Vue kit: the Stories views' buttons are UiButtons and Explore's filters UiCheckboxes
Every button in the Stories entry, its popup and toast, Explore and the
Story screen (header, rail, timeline and context panel) is a ghost
UiButton that keeps its id, classes and listeners. Explore's topic chips
and map pins, the Context button and Expand map are pressed toggles in
place of hand-written aria-pressed. The Filter, Minimise, Expand card and
Back buttons are reached through the UiButton's root where code focuses
them or checks what a click landed on. Explore's filter options are
UiCheckboxes that keep their fopt label. The views' glyphs stay inline
SVG, since no Material symbol the page loads draws them the same; the
search fields keep their own markup and their SVG clear buttons are ghost
UiButtons. A guard test pins it, and the migration notes say so.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 03:54:40 -08:00
Sameh KhamisandManjunath Paparaju b383259752 Add the changelog entry for #1849
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 03:54:11 -08:00
Sameh Khamis e9261d4586 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-display
# Conflicts:
#	docs/VUE-MIGRATION.md
#	scripts/format-scope.json
2026-11-19 03:54:07 -08:00
Sameh Khamis 3703165373 Merge pull request #1848 from bilawalsidhu/samehkhamis/kit-sweep-welcome
Vue kit: the welcome card's buttons and glyphs are kit controls
2026-11-19 03:51:41 -08:00
Sameh KhamisandManjunath Paparaju fd32997d88 Add the changelog entry for #1848
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 03:32:10 -08:00
Sameh Khamis af6520b9ee Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-welcome
# Conflicts:
#	docs/VUE-MIGRATION.md
#	scripts/format-scope.json
2026-11-19 03:32:10 -08:00
Sameh Khamis d7d11b068b Merge pull request #1847 from bilawalsidhu/samehkhamis/kit-sweep-omnibar
Vue kit: the Omnibar's mic, strip chips and glyphs are kit controls
2026-11-19 03:31:46 -08:00
Sameh KhamisandManjunath Paparaju ca504fa8f6 Vue kit: the Layer Finder's buttons are UiButtons and its glyphs UiIcons
Search, Filter, the filter menu's Status and Category options and the
bar's two clear chips are ghost UiButtons. Search and the options are
pressed toggles in place of hand-written aria-pressed; the options take
active as their pressed class, while Search keeps its own active binding,
which also stays on while a query is typed. Escape in the menu still gives
focus back to the Filter button, now through the UiButton's root. Every
Material glyph in it is a UiIcon sized by layer-finder.css. A guard test
pins it, and the migration notes say so.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 03:21:08 -08:00
Sameh KhamisandManjunath Paparaju 93e775a038 Add the changelog entry for #1847
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 03:14:29 -08:00
Sameh Khamis 1ef0aaa5cd Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-omnibar 2026-11-19 03:14:23 -08:00
Sameh Khamis ba89f273dc Merge pull request #1846 from bilawalsidhu/samehkhamis/sfc-omnibar-guide
Vue: the Omnibar's guided walk is a single-file component
2026-11-19 03:14:15 -08:00
Sameh KhamisandManjunath Paparaju bd944ecd04 Vue kit: the entity card's buttons are UiButtons and its glyphs UiIcons
The four preview buttons (Photos, Route, 3D, Cockpit view) are pressed
toggles with the active class, and Follow is one with its own on class,
in place of hand-written aria-pressed. The cockpit entry, Fly to, Ask GEV,
the camera preview's bigger-view and More info buttons and the nearby
lists' rows are ghost UiButtons. Every Material glyph on the card, in the
camera preview and in the nearby lists is a UiIcon sized by the card's own
rules. Ask GEV's chat bubble stays inline SVG, since no Material symbol the
page loads draws it. A guard test pins it, and the migration notes say so.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 03:05:09 -08:00
German Khokhlov c7df3c6798 Hand focus to a rail entry when a panel folds it away
- When F or a panel's collapse button folds a panel that holds the focus,
  the focus moves to that panel's visible rail entry. The same happens when
  opening Data Layers folds a peer panel that held it, and in Cockpit the
  focus moves to Contact's expand button when that card folds.
- The `shownBy: 'active'` rail gate is gone: nothing removes `.active` from
  Data Layers any more, so a rail entry now follows `panel.hidden`.
- CURRENT-STATE says what F does, and the panel catalog comment no longer
  says F toggles `.active`.
2026-11-19 15:00:17 +04:00
Sameh KhamisandManjunath Paparaju 1393a025b4 Vue kit: the Visual panel's buttons are UiButtons and its glyphs UiIcons
HUD, Clean UI, Bloom, Sharpen and Reset to default are ghost UiButtons;
HUD, Bloom and Sharpen are pressed toggles with the active class, as
Sonar, 3D and Celestial already were. The Scope, Celestial, sky,
application-row and Reset glyphs are UiIcons sized by the panel's own
rules. The toggles' text glyphs stay plain spans, since they are
characters rather than Material symbols. A guard test pins it, and the
initial-markup test allows the kit classes beside the toggle's own. The
migration notes no longer claim every pressed toggle is a UiButton.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 02:58:41 -08:00
Sameh KhamisandManjunath Paparaju b5ce363df0 Add the changelog entry for #1846
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 02:54:56 -08:00
Sameh Khamis c99c87d1f2 Merge remote-tracking branch 'origin/main' into samehkhamis/sfc-omnibar-guide
# Conflicts:
#	docs/VUE-MIGRATION.md
2026-11-19 02:54:56 -08:00
Sameh Khamis 05976ecd06 Merge pull request #1845 from bilawalsidhu/samehkhamis/sfc-quebec-cctv
Vue: the Quebec CCTV overlay is a single-file component
2026-11-19 02:54:13 -08:00
Sameh KhamisandManjunath Paparaju 5301a0af8d Vue kit: the welcome card's buttons are UiButtons and its glyphs UiIcons
SKIP, the three start tiles, BROWSE STORIES, BACK and the main NEXT /
ENTER GOD MODE action are ghost UiButtons; the start tiles are pressed
toggles, and the others keep aria-disabled so they stay focusable while
the card is busy. The tile, tip, Stories and arrow glyphs are UiIcons
sized by first-run.css. God mode's preview globe and callouts stay inline
SVG drawings. A guard test pins it, the dismiss markup pin allows the kit
classes, and the first-run mutation anchors follow the new tile markup.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 02:45:21 -08:00