Commit Graph
1016 Commits
Author SHA1 Message Date
Said TurkseverandClaude Opus 5.5 b645a767c8 Street Level: Panoramax review follow-ups (gekh, #1134)
Image loading (photoViewer.js)
- One AbortController per open: a new open, close or unmount stops the
  previous photo's first and sharper downloads (an <img> by src = '').
  A collapsed viewer never falls back to the original; Panoramax's flat
  fallback is the thumbnail. A superseded open resolves quietly.
- Flat HD tracked as "loading" and "shown" apart: a discarded response no
  longer blocks later upgrades, and resizes while it loads ask once.
- No upgrade of the photo still shown while another opens.
- Size limits before decoding: imageSize.js reads JPEG/PNG/WebP/GIF
  headers; more than 64 MP or 16,384 px a side is refused undecoded, an
  <img> that decodes larger is refused and let go, flat HD needs a known
  width of at most 8,192 px, and panoramas always decode with a resize.

Panoramax provider
- Retry-After parsed as seconds or an HTTP date; the browser cannot read
  it here, so busy answers back off 5 s doubling to 300 s, reset once
  answered.
- Headers timed, then the body by an idle timeout (15 s of silence), so a
  slow link still gets its megabyte tiles.
- Cones centre only on the picture shown (onShowing), never on a late
  lookup; lookups nobody waits for are aborted (shared, refcounted).
- onReopen: a GPU reset redraws in the viewer, not through the core.
- Cones draw the home z15 tile at once and add neighbours as they arrive;
  a neighbour that failed is not counted as drawn.
- Coverage tiles decode in ~8 ms slices (a 2 MB z10 tile over Paris was
  one ~85-200 ms task); sorted by measured length without a Map.
- Box search asks for 20, not 100 (the API returns them nearest first).
- looksLikeEmail checks every '@'; creatorOf de-duplicates with a Set.

lineCoverage.js
- A redraw while a swap still builds keeps what is on screen (the swap's
  old lines and its ready new ones) and drops only the unready ones.

Tests for each (mutation-checked), two vacuous tests made real, the
cones' pictures lane and readable()'s busy/timeout paths covered; the
fixture's box search is nearest first. Docs: README filters and share
links, CHANGELOG HD wording, CURRENT-STATE.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-15 16:55:59 +01:00
Said TurkseverandClaude Opus 5.5 e3bc431f9a fix(street-level): review follow-ups — shares judged against the last draw; refused pictures stay refused
From the maintainer review of #1134 (approve with follow-ups):
- lineCoverage: a share is judged against the cap the tile was last drawn
  with, not against later shares that redrew nothing, so small increases
  add up (a retained tile stayed at 100 points after its share grew to
  116). A rebuild's measuring pass no longer counts as a draw.
- photoViewer: a picture refused for its size (bytes, streamed bytes or
  decoded side) is marked `tooLarge`, and the viewer never loads that file
  again by any path; the flat fallback had retried an oversized SD file
  through an <img>, which has no size limit.
- Regressions for both: cumulative share growth below the threshold, and a
  refused SD panorama that is not fetched again as a flat photo.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-15 16:08:18 +01:00
Said TurkseverandClaude Opus 5.5 de83e1c17f Merge upstream/main into pr/panoramax
CHANGELOG: keep both new [Unreleased] entries (Panoramax, and the
emergency-transponder highlight from #856).

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-15 12:57:53 +01:00
Mazeyar Moeini Feizabadi d9ff718359 Merge pull request #1108 from bilawalsidhu/codex/hal-522-trial
Integrate GNSS integrity and aircraft emergency highlighting
2026-10-15 13:54:51 +02:00
Mazeyar Moeini Feizabadi 65239ed110 Merge current main into GNSS integration candidate 2026-10-15 13:46:45 +02:00
Sameh Khamis f0a1b22dc8 Merge pull request #1047 from rudycelekli/contrib/gods-026-map-subscription-ownership-20261011-reviewed
fix(maps): stop delivering settled state to detached subscribers
2026-10-14 21:28:08 -07:00
Sameh Khamis 56ca8fd922 Merge branch 'main' into contrib/gods-026-map-subscription-ownership-20261011-reviewed
# Conflicts:
#	CHANGELOG.md
2026-10-14 21:11:47 -07:00
Sameh Khamis 871523593f Merge pull request #1046 from rudycelekli/contrib/gods-025-asset-stream-cancellation-20261011-reviewed
fix(director): reject cancellation during the final asset stream read
2026-10-14 21:11:42 -07:00
Sameh Khamis 20730e5ec5 Merge branch 'main' into contrib/gods-025-asset-stream-cancellation-20261011-reviewed
# Conflicts:
#	CHANGELOG.md
2026-10-14 19:54:24 -07:00
Rudy Mizrahi CelekliandSameh Khamis fd5a1ef856 fix(tools): keep results when a timestamp is outside Date's range (#1045)
isoTime returned toISOString() for any finite number, which throws past ±8.64e15 ms, so one bad record (e.g. a bike-share last_reported) failed the whole tool answer. Such timestamps are now null. The voice analyst's result rows had the same conversion and get the same guard.

Co-authored-by: Sameh Khamis <[email protected]>
2026-10-14 19:54:17 -07:00
Sameh Khamis 84bfba8d39 Merge pull request #1044 from rudycelekli/contrib/gods-023-firms-coordinate-evidence-20261011-reviewed
fix(firms): reject missing and out-of-range detection coordinates
2026-10-14 19:43:39 -07:00
Sameh Khamis b9fa0eedcc fix(maps): stop all delivery once the controller is destroyed
A listener could destroy the controller and re-subscribe one still pending in
the snapshot, which then ran. Delivery now stops at destruction and a destroyed
controller takes no listeners. Adds ordering tests for adds, duplicates and
re-adds during delivery, and moves the current-state note after the section
intro.
2026-10-14 19:23:46 -07:00
Sameh Khamis bf4edb5bdb fix(director): discard an asset cancelled during reader cleanup
The finally block awaits reader.cancel(), so a cancel arriving there still let
the bytes return. Rechecks the signal after cleanup, with a test that keeps the
caller's abort reason, and wraps the current-state note.
2026-10-14 19:23:12 -07:00
Sameh Khamis 6a7b89e436 test(firms): cover both coordinate bounds and blank values on each axis
Documents the adapter's skip rule and cross-references the two checks, which
sit in separate packages (provider parser and fire layer).
2026-10-14 19:21:57 -07:00
Sameh Khamis 69a84c47a1 Merge branch 'main' into contrib/gods-026-map-subscription-ownership-20261011-reviewed
# Conflicts:
#	CHANGELOG.md
2026-10-14 19:21:11 -07:00
Sameh Khamis d42f5d4fd2 Merge branch 'main' into contrib/gods-025-asset-stream-cancellation-20261011-reviewed
# Conflicts:
#	CHANGELOG.md
2026-10-14 19:21:10 -07:00
Sameh Khamis 493b154a6b Merge branch 'main' into contrib/gods-023-firms-coordinate-evidence-20261011-reviewed
# Conflicts:
#	CHANGELOG.md
2026-10-14 19:21:08 -07:00
Sameh Khamis 7661cd349c Merge pull request #1040 from rudycelekli/contrib/gods-019-terrain-warm-batch-lru-20261011-reviewed
fix(terrain): refresh cache recency when resolving warm batches
2026-10-14 19:02:26 -07:00
Sameh Khamis 2b53af71ab Merge branch 'main' into contrib/gods-019-terrain-warm-batch-lru-20261011-reviewed
# Conflicts:
#	CHANGELOG.md
2026-10-14 18:54:35 -07:00
Sameh Khamis fc798969ec Merge pull request #1036 from rudycelekli/contrib/gods-015-imagery-box-missing-edge-20261011-reviewed
fix(recent-imagery): reject absent box edges instead of inventing zero degrees
2026-10-14 18:54:24 -07:00
Sameh Khamis 4a2c6ff7f6 Merge branch 'main' into contrib/gods-015-imagery-box-missing-edge-20261011-reviewed 2026-10-14 18:44:19 -07:00
Sameh Khamis 197e5ee855 Merge pull request #1032 from rudycelekli/contrib/gods-011-street-level-unique-tiles-20261011-reviewed
fix(street-level): deduplicate overlapping dateline tile halves
2026-10-14 18:43:48 -07:00
Rudy CelekliandClaude Sonnet 5.5 1f83897d77 docs: separate CHANGELOG bullets after rebase
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
2026-10-14 20:13:26 -04:00
Rudy CelekliandClaude Sonnet 5.5 e225f0851b docs: separate CHANGELOG bullets after rebase
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
2026-10-14 20:13:15 -04:00
Rudy Celekli bbbdd0aeba docs: address maintainer review for PR #1047 2026-10-14 20:12:42 -04:00
Rudy Celekli 5889d35327 fix(maps): stop delivering settled state to detached subscribers 2026-10-14 20:12:42 -04:00
Rudy Celekli 04b712910d docs: address maintainer review for PR #1046 2026-10-14 20:12:40 -04:00
Rudy Celekli cd7c23b36f fix(director): reject cancellation during the final asset stream read 2026-10-14 20:12:40 -04:00
Rudy CelekliandClaude Sonnet 5.5 e26a715b04 docs: separate CHANGELOG bullets after rebase
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
2026-10-14 20:12:33 -04:00
Rudy Celekli 5a14a06a52 docs: address maintainer review for PR #1044 2026-10-14 20:12:08 -04:00
Rudy Celekli 8b68ff8412 fix(firms): reject missing and out-of-range detection coordinates 2026-10-14 20:12:08 -04:00
Rudy CelekliandClaude Sonnet 5.5 d861f24d3e docs: separate CHANGELOG bullets after rebase
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
2026-10-14 20:11:57 -04:00
Sameh Khamis b4aa61d6ef fix(terrain): keep a batch's warm points when its own fetches evict them
A warm entry could be evicted by the same call's later fetches and then
reported unresolved. The call now remembers warm hits as it does fetched ones.
Moves the batch LRU test beside the existing cache tests and folds the docs
note into the section's eviction paragraph.
2026-10-14 20:11:50 -04:00
Rudy Celekli 07757a3cae docs: address maintainer review for PR #1040 2026-10-14 20:11:49 -04:00
Rudy Celekli 9f56e9df98 fix(terrain): refresh cache recency when resolving warm batches 2026-10-14 20:11:49 -04:00
Sameh Khamis 6ffbf7f524 fix(imagery): refuse blank box edges at every conversion
Share-link integers and Cesium radians were converted before normalizeBox
checked them, so a blank edge still became 0°. Edges are now accepted only as
numbers or non-blank numeric strings, which also refuses [] and {}. Tests cover
all four edges through validateBox, dequantizeBox, boxFromRectangle and
searchHls.
2026-10-14 20:11:39 -04:00
Rudy Celekli 9c9c80a7ed docs: address review scope and feature placement for #1036 2026-10-14 20:11:20 -04:00
Rudy Celekli c5ac24b600 fix(recent-imagery): reject absent box edges instead of inventing zero degrees 2026-10-14 20:11:19 -04:00
Sameh Khamis 7e6ab49815 Merge branch 'main' into contrib/gods-011-street-level-unique-tiles-20261011-reviewed
# Conflicts:
#	CHANGELOG.md
2026-10-14 17:03:46 -07:00
Sameh Khamis 0265ad4c19 Merge pull request #1030 from rudycelekli/contrib/gods-009-route-cap-truthfulness-20261011-reviewed
fix(directions): report truncation only when a maneuver was actually omitted
2026-10-14 17:03:41 -07:00
Sameh Khamis 84714030c8 test: show a capped overview no longer holds repeat tiles
Adds a case that fails before de-duplication (a 24-slot overview held repeats
and reported itself truncated) and says why the date-line halves overlap.
2026-10-14 16:35:47 -07:00
Sameh Khamis 51d335b1db test: check the route cap at exactly 200 turns
The existing "route that fits" case used 199 steps, which is how the
off-by-one went unnoticed. Folds the docs note into the existing cap sentence
and makes the changelog entry specific.
2026-10-14 16:35:10 -07:00
Sameh Khamis c07b71a443 Merge branch 'main' into contrib/gods-011-street-level-unique-tiles-20261011-reviewed
# Conflicts:
#	CHANGELOG.md
2026-10-14 16:34:46 -07:00
Sameh Khamis 7cc6199245 Merge branch 'main' into contrib/gods-009-route-cap-truthfulness-20261011-reviewed
# Conflicts:
#	CHANGELOG.md
2026-10-14 16:34:45 -07:00
Sameh Khamis 81cf437ee5 Merge pull request #1027 from rudycelekli/contrib/gods-006-weather-missing-observations-20261011-reviewed
fix(weather): keep absent observations unknown instead of reporting clear skies
2026-10-14 16:14:00 -07:00
Sameh Khamis 2befda5286 Merge branch 'main' into contrib/gods-006-weather-missing-observations-20261011-reviewed
# Conflicts:
#	CHANGELOG.md
2026-10-14 16:03:41 -07:00
Sameh Khamis 58f4a71f22 Merge pull request #1026 from rudycelekli/contrib/gods-005-tool-schema-codepoints-20261011-reviewed
fix(tools): enforce string schema lengths by Unicode code point
2026-10-14 16:03:36 -07:00
Sameh Khamis 47a35f9816 Merge branch 'main' into contrib/gods-005-tool-schema-codepoints-20261011-reviewed
# Conflicts:
#	CHANGELOG.md
2026-10-14 15:54:52 -07:00
Sameh Khamis 1d9d7c71d5 Merge pull request #1023 from rudycelekli/contrib/gods-002-director-dateline-seek-20261011-reviewed
fix(director): seek camera longitude across the shortest dateline arc
2026-10-14 15:48:41 -07:00
Sameh Khamis e2ceed95a4 Merge branch 'main' into contrib/gods-002-director-dateline-seek-20261011-reviewed 2026-10-14 15:38:47 -07:00