Commit Graph
5124 Commits
Author SHA1 Message Date
German Khokhlov 881473cdd2 Merge remote-tracking branch 'origin/main' into german/recent-imagery-auto-successor 2026-11-20 11:15:13 +04:00
Sameh Khamis 346269f509 Merge pull request #1877 from bilawalsidhu/samehkhamis/grounded-military-height
Keep a landed aircraft on the ground, not at its approach height
2026-11-19 21:04:06 -08:00
Sameh Khamis 763b892716 Merge branch 'main' into samehkhamis/grounded-military-height 2026-11-19 20:49:31 -08:00
Sameh Khamis 40b1a4d276 Merge pull request #1876 from bilawalsidhu/samehkhamis/omnibar-above-timeline
The search dock sits above the World Timeline on desktop
2026-11-19 20:44:16 -08:00
Sameh Khamis 22275814fb Merge branch 'main' into samehkhamis/grounded-military-height 2026-11-19 20:34:59 -08:00
Sameh Khamis 91dee5dabe Merge remote-tracking branch 'origin/main' into samehkhamis/omnibar-above-timeline 2026-11-19 20:32:04 -08:00
Sameh Khamis fd88631c87 Merge pull request #1875 from bilawalsidhu/samehkhamis/imagery-shows
Weather imagery and shells say what they show
2026-11-19 20:24:17 -08:00
Sameh Khamis 2dd26de768 Add the changelog entry for #1877 2026-11-19 20:22:43 -08:00
Sameh Khamis 9b10489454 Keep a landed aircraft on the ground, not at its approach height
A grounded row with no altitude fell back to the aircraft's sticky
altitude, which straight after a landing is still the approach height.
Military contacts then hung there for as long as they stayed on the
ground (the grounded floor only ever raises a height); civil contacts
held it until the ground cell under them warmed, which for a contact far
from the viewer is never. The 3D model is ground-snapped on its own, so
the plane dropped when the model took over.

A grounded contact with no altitude now uses only an altitude it gave
on the ground, else the ground fallback. Labels, the tracked readout
and the follow distance read "On the ground" / no flight level instead
of the approach altitude.
2026-11-19 20:22:33 -08:00
Sameh Khamis 1cc06c021a Changelog entry for #1876 2026-11-19 20:16:34 -08:00
Sameh Khamis 893bc5b5f3 The search dock sits above the World Timeline on desktop
The bar takes the dock's floor and the dock, with the search field, rises by
the bar's height while it shows, as the dock does outside the search layout.
The bar no longer hides while search results or the chat and voice panels
open, since they open upward from the dock and no longer cover it.
2026-11-19 20:15:49 -08:00
Sameh Khamis 65778a173c Merge branch 'main' into samehkhamis/imagery-shows 2026-11-19 20:09:35 -08:00
Sameh Khamis 20620e89bf Merge pull request #1874 from bilawalsidhu/samehkhamis/video-check-starts-red
globe.imagery.video: paint the test video red before recording starts
2026-11-19 19:49:16 -08:00
Sameh Khamis f07f40271d Changelog: #1875 2026-11-19 19:45:30 -08:00
Sameh Khamis edd51d58fd Weather imagery and shells say what they show
An imagery spec and a raster shell take an optional `shows`, such as
'clouds' or 'radar'. Drawing never depends on it; a renderer may use it
to tell such a layer apart. The weather layer sets it for every product,
'clouds' for both cloud products.
2026-11-19 19:45:20 -08:00
Sameh Khamis 11cfc560d8 Merge branch 'main' into samehkhamis/video-check-starts-red 2026-11-19 19:34:09 -08:00
Sameh Khamis fe3182d664 Merge pull request #1873 from bilawalsidhu/samehkhamis/weather-texture-size
Read the weather texture limit and reveal time in the body, not a parameter default
2026-11-19 19:22:03 -08:00
Sameh Khamis c9a78153ac globe.imagery.video: paint the test video red before recording starts
The check recorded a canvas that stayed blank until its first 20 ms paint
tick, so on a loaded runner the video's opening frames were dark and the
pixel early in the segment read (28, 54) instead of red: main failed once
after #1872 and passed on the runs around it.
2026-11-19 19:21:10 -08:00
Sameh Khamis e3a17c527b Parameter defaults test: name the forms that break, and read single-file components and .mjs modules too 2026-11-19 19:02:10 -08:00
Sameh Khamis 3e6d2165fd Changelog: #1873 2026-11-19 18:59:36 -08:00
Sameh Khamis 84b60a92e0 Read the weather texture limit and the reveal time in the body, not in a parameter default
esbuild compiles an optional method call reached through an optional chain
(`a?.b?.()`) in a parameter's default, for browsers it lowers optional
chaining for (Chrome and Edge before 91), into code that reads a variable out
of its scope. The weather shell's texture limit was read that way, so every
satellite frame threw a ReferenceError in the built app and the layer showed
"Weather imagery unavailable"; the leader and card reveal took their default
time the same way. A test now refuses the form anywhere under src/.
2026-11-19 18:59:10 -08:00
Sameh Khamis 7f2dc81cf6 Merge pull request #1872 from bilawalsidhu/samehkhamis/omnibar-centred
Centre the phone Omnibar when no language picker sits beside it
2026-11-19 17:42:36 -08:00
Sameh Khamis 93c68281d9 Merge branch 'main' into samehkhamis/omnibar-centred 2026-11-19 17:10:42 -08:00
Sameh Khamis 9523bb18f5 Merge pull request #1870 from bilawalsidhu/samehkhamis/find-it
Find a selected vessel or aircraft again from its card
2026-11-19 17:10:37 -08:00
Sameh Khamis 17bfc203c5 Merge branch 'main' into samehkhamis/find-it 2026-11-19 16:56:33 -08:00
Sameh Khamis 41e988606c Add the changelog entry for #1872 2026-11-19 16:56:19 -08:00
Sameh Khamis ff7b8e68c5 Centre the phone Omnibar when no language picker sits beside it
On a phone the field kept 60px on its right for the language picker even
where the application shows none, so it sat left of centre. It now keeps
16px either side, and leaves the picker its room only while it is there.
2026-11-19 16:56:10 -08:00
Sameh Khamis 9d5e10ddb1 Merge pull request #1871 from bilawalsidhu/samehkhamis/street-level-photo-followups
Street Level photo viewer: settle every open and mount, one viewer drawn, a stated contract
2026-11-19 16:50:15 -08:00
Sameh KhamisandManjunath Paparaju 80999ff007 Add the changelog entry for #1871
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 16:36:54 -08:00
Sameh Khamis eb7d92db66 Merge remote-tracking branch 'origin/main' into samehkhamis/street-level-photo-followups 2026-11-19 16:32:27 -08:00
Sameh KhamisandManjunath Paparaju 8c40eb957b Street Level photo viewer: take a moved-off canvas back, and close a mount unmounted in its first draw
A canvas the panorama moved off (a second view drew its own) is no longer
ignored for good: its draws are counted, so an open waiting on one goes on,
and once a single view is left its canvas is taken back. Before, after the
second view left, the next 360° open waited forever and the panorama stayed
on the departed view's canvas.

A mount whose view unmounts it inside its first draw now fails as closed,
as every other unmounted mount does, rather than with a TypeError.

Both found in review; each new test fails without its fix.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 16:31:34 -08:00
Sameh KhamisandManjunath Paparaju 22485dcb01 Street Level photo viewer: a failed mount spares the next, stable keyless ranks
Second review follow-ups:

- A mount woken without being drawn unmounts only its own presentation:
  an earlier mount overtaken by a second mount of the same viewer fails
  as closed and leaves the second one mounted and presented.
- A mount whose last view left fails only if no view has subscribed
  since; one subscribed in the same tick draws it.
- Mount keys come from photoViewers.js's nextViewKey(), and a keyless
  presentation is stamped from the same counter when any picker first
  sees it, kept until it presents null: its rank no longer depends on the
  picker's lifetime or the order it subscribes in.
- A canvas handed back while a panorama's open waits on its draw takes
  the panorama: the open builds its renderer there instead of falling
  back to the front view. A canvas the panorama moved off is not moved
  back to, so two views drawing their own cannot take it in turns.
- The guard test also refuses compound writes (+=, ||=, ??=, &&=…),
  destructuring writes to properties, Object.assign (other than onto a
  new Error), Object.defineProperty and Reflect.set, and a catch binding
  that shadows loadImage's image.

Nothing changes in the running app.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 16:23:42 -08:00
Sameh Khamis 820257cd85 Merge pull request #1867 from bilawalsidhu/samehkhamis/start-layers
A host names the layers a bare address starts with
2026-11-19 16:07:40 -08:00
Sameh KhamisandManjunath Paparaju e6f21777ba Street Level photo viewer: keyless ranking, closed waits, a moved canvas
Review follow-ups to the previous commit:

- photoViewers.js ranks a presentation without a mountKey as mounted when
  it began presenting (after the latest key seen, before any later mount),
  so a photo viewer mounting while a keyless one shows is drawn and the
  keyless one superseded; supersede is queued whenever more than one
  presents after any change, not only when the pick changes.
- A panorama's open still waiting on a draw when the last view leaves
  fails as closed and leaves no photo shown, instead of uploading to a
  canvas never drawn. A mount waiting on its first draw then also fails as
  closed and is unmounted, so a view subscribing later sees nothing.
- A view handing back another canvas element than the renderer's drops
  the renderer and draws the panorama again on the new one, as after a
  lost context.
- The guard test allows a .src write in loadImage only on the one `image`
  binding, created by new Image() and never rebound or shadowed, and
  refuses `(expr).src =` and bracket property writes anywhere.
- The test fakes' shared view is reset before each test
  (resetPhotoView), so a viewer left by an earlier test is neither drawn
  with nor superseded by a later test's.

Nothing changes in the running app.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 16:04:21 -08:00
Sameh Khamis 250a78c0f9 Merge branch 'main' into samehkhamis/start-layers 2026-11-19 15:54:31 -08:00
Sameh Khamis 8c0a812578 Merge pull request #1869 from bilawalsidhu/samehkhamis/kit-sweep-final-scan
Vue kit: the view scan forbids any hand-written button, glyph, checkbox or range
2026-11-19 15:51:09 -08:00
Sameh KhamisandManjunath Paparaju 33ac0545ef Street Level photo viewer: settle opens, a gapless picker, a stated contract
Follow-ups to the photo viewer's move to a Vue view (#1868):

- A panorama's open waits for a draw of the canvas counted from before it
  is shown, so a view that draws at once inside its listener no longer
  leaves the open pending; and when the last view unsubscribes, an open
  waiting on a draw goes on instead of hanging.
- photoViewers.js supersedes the mounts not drawn on a microtask, after
  the winning presentation has reached every subscriber: a second
  subscriber sees the earlier mount, then the later one, never null
  between.
- A presentation without a mountKey counts as the latest mount (among
  several without, the one that began presenting last), and one without
  actions or supersede is passed over without throwing. Both fields are
  documented on ViewerAdapter.subscribeView in registry.js and in the
  store's comment.
- The guard test also refuses .width, .height, .ariaLabel, .id and .value
  writes in photoViewer.js, and .src writes outside loadImage, where only
  the off-page Image it creates may take one.
- The test fakes draw every viewer through one shared view behind
  photoViewers.js's picker, as the application does, so provider and
  layer tests see supersede.

Nothing changes in the running app.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 15:48:50 -08:00
Sameh Khamis c586087147 Add the changelog entry for #1870 2026-11-19 15:40:48 -08:00
Sameh Khamis 22e9c58d84 Find a selected vessel or aircraft again from its card
While a selected vessel, aircraft or military aircraft is off screen, behind
the globe or out of its layer's feed, its Context card shows Find it. One
still in its feed is flown to (an aircraft followed). One out of its feed is
looked up on its own track at the layer's time (the world clock's while the
layer follows it), the card moves to that reading and says how old it is, and
the camera flies there; once the feed has it again its layer selects it again.
With no reading at or before the time the card says so and the camera stays.

A vessel its layer announces is named by its own id, as a click names it,
not by the context store's.
2026-11-19 15:40:31 -08:00
Sameh Khamis 5258f1b2a4 Merge branch 'main' into samehkhamis/start-layers 2026-11-19 15:39:50 -08:00
Sameh Khamis 34ed83537a Merge remote-tracking branch 'origin/samehkhamis/kit-sweep-final-scan' into samehkhamis/kit-sweep-final-scan 2026-11-19 15:32:16 -08:00
Sameh Khamis 19369349b0 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-final-scan 2026-11-19 15:31:56 -08:00
Sameh KhamisandManjunath Paparaju 559a7cec71 Vue kit: the view scan reads SFC scripts, string markup and bound types
Following review, the scan now also:
- reads every SFC's script blocks, not only modules;
- matches a createElement call Prettier wraps over lines, and any case of
  the tag name;
- fails on a button, select, input or textarea written as markup in a
  string, comments aside, apart from the globe panel's standalone page
  (plain HTML a host serves, with no Vue or kit), which the test names and
  requires to still be the reason;
- catches a Material class built in a template string;
- reads an input's type when bound to a quoted literal or named in a
  v-bind object, in any case, and unquoted before `/>`;
- catches a Material class named in a v-bind object.
Each new path was confirmed to fail when its violation is put back.

docs/VUE-MIGRATION.md now names the globe panel page as the exception,
lists the two text areas among the native fields left, and notes that the
scene dialog's field takes text-like types from its callers only.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 15:31:47 -08:00
German Khokhlov 12dc0de20d Merge pull request #1360 from ch-bas/feat/alpr-model-specs
feat(alpr): show datasheet specs for mapped ALPR camera models
2026-11-20 03:29:51 +04:00
Sameh Khamis db19dae2f9 Merge branch 'main' into samehkhamis/start-layers 2026-11-19 15:24:39 -08:00
Sameh Khamis 407adcc500 Merge branch 'main' into samehkhamis/kit-sweep-final-scan 2026-11-19 15:21:13 -08:00
German Khokhlov aa5ab7d387 Merge branch 'main' into feat/alpr-model-specs 2026-11-20 03:17:38 +04:00
Sameh Khamis 644f8cf3f0 Merge pull request #1866 from bilawalsidhu/samehkhamis/no-focus-zoom
A phone no longer zooms the page when a text field gets focus
2026-11-19 15:16:03 -08:00
Sameh Khamis 54b6ba827e Merge branch 'main' into samehkhamis/start-layers 2026-11-19 15:12:01 -08:00
Sameh KhamisandManjunath Paparaju 91e42b887f Add the changelog entry for #1869
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 15:04:57 -08:00