Commit Graph
4899 Commits
Author SHA1 Message Date
Sameh KhamisandManjunath Paparaju 31a7b6a0a5 Add the changelog entry for #1837
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 22:32:50 -08:00
Sameh KhamisandManjunath Paparaju 8b055a1423 fix(ui): panel rails keep clear of an obstacle across the middle of the window
An obstacle that crossed the middle of the window (the World Timeline, the
voice control or a card in a window under about 520px tall) was neither
above nor below it, so neither rail counted it and panels could be laid out
over it. Such an obstacle now puts the panels on whichever side of it has
more room. When neither side has room, the rails keep their existing
minimum (the right rail's empty band, the left rail's minimum lane height).

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 22:32:40 -08:00
Sameh Khamis ec1fc6bc09 Merge pull request #1831 from bilawalsidhu/samehkhamis/omnibar-reading-fixes
Read more Omnibar lines the way they are meant
2026-11-18 22:26:52 -08:00
Sameh Khamis edf595f69f Merge branch 'main' into samehkhamis/omnibar-reading-fixes 2026-11-18 22:14:08 -08:00
Sameh Khamis 0534dcebf6 Merge pull request #1830 from bilawalsidhu/samehkhamis/place-privacy-2
Keep spelled-out emails, IP addresses, recovery phrases and lower-case codes from the place service
2026-11-18 22:13:59 -08:00
Sameh Khamis f6f1ee2a3a Merge branch 'main' into samehkhamis/place-privacy-2 2026-11-18 22:02:01 -08:00
Sameh Khamis e9fd19acb3 Merge pull request #1829 from bilawalsidhu/samehkhamis/space-missions-fixes
Finish the Space Missions shutdown, and let label clicks reach every layer
2026-11-18 22:01:51 -08:00
Sameh Khamis a5b18f3718 Merge branch 'main' into samehkhamis/space-missions-fixes 2026-11-18 21:49:21 -08:00
Sameh Khamis 6b45ea12cf Merge pull request #1836 from bilawalsidhu/fix-delayed-clock-test
Hold the clock still in the delayed-live aircraft icon test
2026-11-18 21:34:15 -08:00
Sameh KhamisandManjunath Paparaju b5018b8cc2 Let the cockpit focus test reach its check
The test's camera and rendering doubles now carry what focusing a mission
uses, so without the cockpit guard the test fails on the camera flight
rather than on a missing double.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 21:25:05 -08:00
Sameh Khamis 14bf0de2a2 Merge branch 'main' into fix-delayed-clock-test 2026-11-18 21:22:35 -08:00
Sameh Khamis b56c019df7 Merge pull request #1835 from bilawalsidhu/fix-icon-near-plane-flicker
Icons drawn over depth no longer flicker
2026-11-18 21:22:21 -08:00
Sameh Khamis 64e474f85e Add the changelog entry for #1836 2026-11-18 21:10:17 -08:00
Sameh Khamis 5e0842ad81 Add the changelog entry for #1835 2026-11-18 21:10:13 -08:00
Sameh Khamis 06aff17004 test(flights): hold the clock still while the delayed-live icon test compares drawn and read positions
The contact moves about half a metre per millisecond, and the drawn and read
positions each read Date.now(); on a busy machine the two readings landed far
enough apart to fail 'same place'.
2026-11-18 21:09:42 -08:00
Sameh Khamis 6a86102336 fix(render): icons drawn over depth no longer flicker
An icon drawn over depth set its log depth to exactly the near plane (1.0).
Interpolated across the quad, that value can arrive a rounding step or two
under czm_writeLogDepth's 0.9999999 cut, which discards the fragment, so a
moving icon vanished for a frame now and then, most visibly far away in dense
clusters. It now sits 1e-4 m past the near plane, still in front of
everything.
2026-11-18 21:09:42 -08:00
Sameh KhamisandManjunath Paparaju b363f9b09b Catch a recovery phrase quoted »like this« or ‚like this‘
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:58:22 -08:00
Sameh KhamisandManjunath Paparaju 6f959fc3cc Read "clear … except" from the map only when it clears every other layer
"clear all flights except ships from the map" no longer offers to turn
Ships on.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:58:18 -08:00
Sameh KhamisandManjunath Paparaju cdde80f3ad Never fly to a mission while the cockpit holds the camera
Focusing a mission does nothing in the cockpit, so the layer row's arrows
select the next mission without moving the camera, as its label and dot
already do.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:58:17 -08:00
Sameh KhamisandManjunath Paparaju bf1e313301 Catch a recovery phrase in curly or angle quotes
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:39:01 -08:00
Sameh KhamisandManjunath Paparaju 038915bc0b Take "from the map" off after "clear" only when what is left clears the whole map
"clear all flights from the map" no longer offers to turn Flights on, and
"clear the layers from the map" clears the layers.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:38:56 -08:00
Sameh KhamisandManjunath Paparaju 6c960eb3c9 Keep the camera still in the cockpit when a mission's dot is clicked or its orbit arrives
The cockpit holds the camera: the mission dot, like its label, selects the
mission there without flying to it, and a mission picked in the cockpit is
not flown to when the active satellite lookup returns.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:37:53 -08:00
Sameh KhamisandManjunath Paparaju 813c6b23ea Say that an explicit Satellites action lets the saved state go after a busy restore
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:28:58 -08:00
Sameh KhamisandManjunath Paparaju a29efa12c4 Let a mission label select its mission in the cockpit, and say what the merged click rule does
Under the card-on-top rule a mission label is the card on top for the
cockpit too, so the label no longer steps aside there: it selects its
mission without moving the camera the cockpit holds. Tests and docs no
longer claim a covered click reaches what lies under the label, and the
busy-restore note says an explicit Satellites action lets the saved state
go.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:24:16 -08:00
Sameh KhamisandManjunath Paparaju 406a5003e0 Keep a code private before "thanks," with a trailing comma
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:17:39 -08:00
Sameh KhamisandManjunath Paparaju 3a5b10a1f6 Take "from the map" off after "clear" only for the whole map
"clear flights from the map" no longer offers to turn Flights on.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:07:18 -08:00
Sameh KhamisandManjunath Paparaju 9b6683a9cd Read requests about a map as requests, catch quoted or dash-joined phrases, and an en dash before "thanks"
Words a request about a map is made of (near, today, open, find …) count
with the map words, so "find good food open now near this area today"
is a request; a phrase is let through about once in a hundred. Phrases
quoted, numbered "1:", "#1" or "[1]", or joined by dashes, pipes,
slashes or dots are caught, and a code before " – thanks" is private.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:06:35 -08:00
Sameh Khamis d2dac41668 Merge pull request #1833 from bilawalsidhu/samehkhamis/sonar-minimal-fixes
Keep the HUD corners clear of the credits, and carry Minimal + Sonar in links and scenes
2026-11-18 20:01:53 -08:00
Sameh KhamisandManjunath Paparaju 0e5c5e624c Merge origin/main into space-missions-fixes
Main's single click rule (the card or label on top takes the click, read
once per click through clickCard and isUnderOtherCard in
src/data/pickRegistry.js) covers a click on a Space Missions label: a
mission marker label is an interactive world-overlay entry, so the
host's hit test names it as the card on top for every other layer. The
per-layer label guards in CCTV, Drone Airspace, FIRMS, Ghost Maps, News,
Perimeters, Shipwrecks, Vessels, Wildlife Sightings, ALPR, Local ADS-B
and the cockpit orbital focus are dropped for main's versions.

The mission-label tests are kept on main's API: fakeInputUnderLabel now
also names the label as the card on top, and each test shows a click on
the label never acts on the card, camera, vessel, fire, reader, aircraft
or report under it, and leaves the selection as it is. A launches test
checks that a mission label is interactive and is the card on top for
every other layer. Docs, changelog and the dispatcher's `overlay` note
describe the merged behaviour.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:00:25 -08:00
Sameh KhamisandManjunath Paparaju 71f40c9655 Keep phone and clean-view credits as they were, and lift narrow corners over the World Timeline
The Cesium credit box's width cap and right-to-left placement apply from
1200px as before, and in the Omnibar layout at every width, so the phone
shell, clean view, recording and scene playback keep their own layout.
Narrower than 1120px the coordinates and the Tactical readout sit above
the World Timeline while it shows. The scene format notes that a build
from before `sonar` refuses a project that has it.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 19:45:47 -08:00
Sameh KhamisandManjunath Paparaju c49cf5168e Add the changelog entry for #1833
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 19:45:47 -08:00
Sameh KhamisandManjunath Paparaju 40e2998466 Carry Sonar with the Minimal HUD layout in links and scene shots
A link or scene shot made in Minimal with Sonar on played back with Sonar
off, and turned off the viewer's own. Tactical with Sonar keeps the `cyber`
layout code, which older readers understand; Minimal with Sonar now carries
an explicit mark beside its layout: flag bit 5 (`hudSonar`, default off) of
a compact link, `hs=1` in the long form, and `hud.sonar: true` in a scene
shot. A restore turns Sonar on when the state names Cyber or carries the
mark, so a state made before it restores exactly as it did.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 19:45:47 -08:00
Sameh KhamisandManjunath Paparaju c69a421678 Keep the HUD corners, the dock and a wrapped credit line apart at every width
The credit line now wraps at every width instead of running under the
corner row, and right to left it takes the bottom right at every width. A
small watcher keeps its height in --credit-line-height, so the coordinates
(and, right to left, the Tactical readout) stay above it however many lines
it wraps onto, and the dock and World Timeline rise when it is taller than
their usual clearance. Narrower than 1120px the dock leaves no room between
the bottom corners, so the coordinates and the readout sit above the dock
instead of under it. Outside the Omnibar layout, the coordinate rule meant
for 981 to 1199px no longer overrides the two-row dock's placement at 980px
and below.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 19:45:47 -08:00
Sameh KhamisandManjunath Paparaju 3d31126c72 Read "from the map" only after hide, remove, turn off or clear
"show me the view from the map" is a question again, not a place search.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 19:45:38 -08:00
Sameh KhamisandManjunath Paparaju 49ad1b7b73 Catch a recovery phrase numbered "(1) … (2) …"
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 19:45:38 -08:00
Sameh KhamisandManjunath Paparaju 94dcadf54f Tell lists of places from recovery phrases by four map words in any twelve, keep " - thanks" codes private, and trim long tails at once
The map words cover 108 BIP39 words for places, buildings, vehicles and
the land; twelve list words in a row with four of them are a list of
places, which a random phrase is about once in three hundred. A code
followed by " - thanks" is private again, and the IPv6 and bearer trims
no longer slow on long runs of commas or brackets.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 19:34:48 -08:00
Sameh KhamisandManjunath Paparaju 06eb60faab Read "from the map" after "please" is dropped
"hide flights from the map please" and "please clear everything except
flights from the map" read as they do without "please".

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 19:33:50 -08:00
Sameh Khamis 8ed14efdbf Merge pull request #1781 from manjunath22466/fix/earthquake-click-details
fix(earthquakes): make quakes clickable, with card click arbitration
2026-11-18 19:19:51 -08:00
Sameh KhamisandManjunath Paparaju f75f42d3ca Read lists of places as places, not recovery phrases, and keep code tails fast
Twelve BIP39 words in a row with three words for places or things on a map
("coffee, bar, hotel, museum, park …") are a list, not a phrase; a random
phrase has three of them about once in two hundred. A code's value and the
courtesy word after it no longer overlap, and trailing punctuation is
trimmed from a word's end only, so a long run of hyphens is read at once.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 19:13:04 -08:00
Sameh KhamisandManjunath Paparaju cd5a4443a2 Read "from the map" after any switch or clear verb, before anything else
"clear everything except flights from the map" and "hide everything
from the map" now read as they do without the ending, instead of only
offering Ask GEV or a place search.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 19:10:54 -08:00
Sameh Khamis 35c5ee5deb Merge remote-tracking branch 'origin/main' into fix/earthquake-click-details 2026-11-18 18:58:33 -08:00
Sameh Khamis e87aa5190d Merge main into fix/earthquake-click-details
Resolves conflicts with main: a world focus target's own range past its
framed radius replaces the kind's range (#1832), so a quake asks for its
own range only past M6 and the earthquake framing stays its floor; FIRMS
keeps main's marker stand-in under the card-on-top rule; launches keep
main's label click and also read the card on top through the pick
registry.
2026-11-18 18:58:07 -08:00
Sameh Khamis 2a94067f5b Merge pull request #1834 from bilawalsidhu/imagery-decoded-frames
Renderer contract: decoded imagery, finished tile images handed over by the application
2026-11-18 18:52:51 -08:00
Sameh KhamisandManjunath Paparaju 3f5221b837 Withhold an SSN's last four, a code before ", thanks" and a recovery phrase written with commas or numbers
"ssn ending 1234" and "ssn last four 1234" are private again, as before
this change; a code may be followed by a comma, "cheers", "thanks a
lot" or more than one "!"; a recovery phrase is twelve BIP39 words in a
row, so commas, numbering, a closing period or "my seed is" before it no
longer hide it. The spelled-out email patterns start only at a word, which
keeps long inputs fast.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 18:38:13 -08:00
Sameh Khamis 1b03039438 Changelog entry for decoded imagery 2026-11-18 18:37:44 -08:00
Sameh Khamis 4ee0aba82e Renderer contract: decoded imagery, tiles the application hands over as finished images
A timed source of kind 'decoded' (capability imageryDecoded) names the slot a
time shows (slotAt), the slots to hold ahead (prefetch) and answers each tile
of a slot with an image, missing or defer. The Cesium renderer draws each held
slot as an imagery layer of its own, as it draws frames; the stub shows the
slot. The check globe.imagery.decoded covers it.
2026-11-18 18:37:23 -08:00
Sameh KhamisandManjunath Paparaju 81192cfa50 Keep plans for places that begin with a kind of place, and keep Satellites with Space Missions only while missions are on
A keyword is read as the start of a name only when what follows is one
word for a kind of place alone ("Radio City", "Traffic Island"), so
"traffic city hall" and "earthquakes valley forge" keep their plans.
"except space missions" keeps Satellites only while Space Missions is
on, and "from the map" is read before "except".

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 18:36:26 -08:00
Sameh Khamis bb3bf9858b fix(click): the card or label on top takes the click in every layer
Review fixes for #1781:

- One rule for cards: the world-overlay host hands its hit test to the
  pick registry, and every click handler reads the topmost interactive
  card or label once per click (`clickCard`, `isUnderOtherCard` in
  src/data/pickRegistry.js), so all handlers agree in any listener order.
  A layer whose own card or label is on top acts on it whatever is drawn
  under it; a layer under another layer's card neither acts nor treats
  the click as empty space (a tracked aircraft stays tracked, a selection
  stays selected); Context names nothing under a card. A selected news
  card over a vessel no longer opens the link and selects the vessel.
- With one rule, the per-owner arbitration options are no longer read
  and are removed: `passive`, `expanded` and `declinesClick` pick owners,
  `rememberClickPickActions`, `isActedOnByOtherLayer`, card backgrounds
  and `cardKeepsClick`. The dispatcher is unchanged from main.
- A drag that ends on a quake disc, label or card does nothing; opening
  the USGS page or clearing the selection needs a clean click.
- A click on the map under another layer's card opens no Street Level
  ground image.
- A CCTV card that is going away is still not the scene under it.
- Docs and changelog describe the new rule.
2026-11-18 18:23:41 -08:00
Sameh KhamisandManjunath Paparaju 2487500927 Read recovery phrases against the BIP39 list, and fix four more privacy readings
A recovery phrase is now twelve to twenty-four words that are all on the
BIP39 English list, so a long request ("show every plane over london then
…") reaches Ask GEV while a phrase holding "find" or "please" is still
caught. A time in brackets is no IPv6 address (only a bracketed host after
"//" is), "St 123456 A" is no National Insurance number (spaced in pairs or
not at all), "my, ID 12345" keeps its owner, a partial "ssn 1" stays
private while typed, any CVV value is private, and a code followed by
"thanks" or "now" is still a code. Idaho's reading no longer slows down on
very long lines.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 18:17:22 -08:00
Sameh KhamisandManjunath Paparaju 859aa172e7 Keep Space Missions with Satellites in "except", leave "turn off the screen" alone, and part places after a compound country
"hide everything except space missions" (or "satellites") keeps both, as
switching either off takes the other. "turn off the screen" is no longer
read as a switch with "off the screen" taken off it, which left a place
search. A place joined after a compound country is another place ("near
Trinidad and Tobago and Barbados"), and a compound country after another
place stays whole ("near Paris and Trinidad and Tobago"). Only a word for a
kind of place written after a name ("Island", "City") drops a plan, so
"earthquakes lake tahoe" and "traffic tower bridge" keep theirs. Two doc
comments are back above their code.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 18:11:18 -08:00