Describe the view the camera stops at, after a jump too

A share link or restored view moves the camera without a moveEnd, and the
once-a-second read of camera changes dropped the last one, so Context named
a point from the fly-in. A last read now follows the final change.

Co-authored-by: Manjunath Paparaju <[email protected]>
This commit is contained in:
Sameh KhamisandManjunath Paparaju committed 2026-11-16 14:59:17 -08:00
1 parent 90510bf9e6
commit ee22aace8d
1 file changed
+18 -4
+18 -4
View File
@@ -186,13 +186,26 @@ export function installEntityContext({
};
const removeMoveEnd = viewer.camera.moveEnd.addEventListener(readView);
// A camera that keeps moving (following an aircraft, a long fly-to) never
// settles, so also read it on large changes, at most once a second.
// settles, and a jump (a share link, a restored view) raises no moveEnd,
// so also read it on large changes: at most once a second, and once more
// after the last change, so the view it stops at is the one described.
let lastRead = 0;
let trailing = null;
const removeChanged = viewer.camera.changed.addEventListener(() => {
clearTimeout(trailing);
const now = performance.now();
if (now - lastRead < 1000) return;
lastRead = now;
readView();
if (now - lastRead >= 1000) {
lastRead = now;
readView();
return;
}
trailing = setTimeout(
() => {
lastRead = performance.now();
readView();
},
1000 - (now - lastRead),
);
});
setTimeout(readView, 0);
@@ -284,6 +297,7 @@ export function installEntityContext({
handler.destroy();
removeMoveEnd();
removeChanged();
clearTimeout(trailing);
removeTrackedChanged();
clearTimeout(trackCheck);
globalThis.removeEventListener?.('gev:entity-selected', onSelected);