fix(models): tracked and emergency tints mix into aircraft paint instead of multiplying it

Aircraft models multiplied their tint into the shaded paint (HIGHLIGHT).
A saturated tint zeroes every channel it lacks: the tracked cyan (no red)
drew a red helicopter solid black, day or night, and a white Cessna one
flat cyan. Tinted models now mix the colour in at 30%
(AIRCRAFT_MODEL_TINT_MIX), so the paint stays readable and the colour
still marks them; untinted models still draw their own colours, and the
IR boost stays flat white.

Neither the multi-part models nor the part shader were involved: old and
new GLBs, with and without the shader, render the same pixels, and an
untinted model at night is lit by the default ambient term.

The new conformance check draw.models.paint draws a model painted with
COLOR_0 under a fixed sun and reads its colour by day, at night, and
under a tint mixed in. The parts test model can now carry vertex paint.
This commit is contained in:
Sameh Khamis committed 2026-11-17 16:50:52 -08:00
1 parent 953af60e1d
commit e83c1672dd
9 files changed
+221 -12

No files matched your search

+3
View File
@@ -318,6 +318,9 @@ opaque command and before the translucent pass, which blends
order-independently and would undo the addition; ground commands keep their
pass and stencil and only blend differently. The checks `draw.sets.blend`
(points, icons, lines, shapes) and `draw.models.blend` read the pixels.
`draw.models.paint` reads a lit model's vertex paint (`COLOR_0`) at a fixed
sun: its colour by day, still its colour (not black) with the sun below the
horizon, and its paint kept under a tint mixed in.
A model item may bring its glTF bytes (`gltf`): the renderer builds it from
them and never fetches its `url`, which stays the model's identity, so a