mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-18 01:02:23 +00:00
Merge pull request #1792 from bilawalsidhu/fix/parts-check-while-spinning
draw.models.parts: wait for frames while a part spins
This commit is contained in:
2 files changed
+7
-2
No files matched your search
@@ -0,0 +1,2 @@
|
||||
- Fix the model parts conformance check timing out while a part spins: it
|
||||
waits for drawn frames instead of a settled scene (samehkhamis, #1792).
|
||||
@@ -4284,13 +4284,16 @@ export function portChecks() {
|
||||
ok(pickedAt(armAt(forward)), 'and stays ahead');
|
||||
}
|
||||
|
||||
await show(
|
||||
// A spinning part asks for frames for as long as it spins, so the
|
||||
// scene never settles; wait for frames to be drawn instead.
|
||||
set.upsert([
|
||||
model('m', {
|
||||
spin: { pod: 90 },
|
||||
deploy: { pod: 1, missing: 1 },
|
||||
poses: { pod: { highlight: true }, missing: { hidden: true } },
|
||||
}),
|
||||
);
|
||||
]);
|
||||
await drawn(h, r, 3);
|
||||
if (picks) ok(pickedAt(pos), 'spinning and highlighted, where it is');
|
||||
await show(model('m'));
|
||||
if (picks) ok(pickedAt(pos), 'back at rest');
|
||||
|
||||
Reference in new issue
Block a user