Street Level: a link whose source has no working key says why

changelog.d/1113-show-street-level.md

@@ -7,9 +7,9 @@
   `sl=google` link never loads a billed panorama by itself: it arms Street
   View and leaves the load to OPEN GOOGLE STREET VIEW; embedded views open it,
   and so does the God's Eye View panel for a result issued in the last five
-  minutes. A request stops when the user navigates or hides the panel before
-  its photo loads; a new photo replaces the open one in place, so EXPAND
-  stays. When nothing is found and a 360°, flat or SINCE filter is on, the
+  minutes; a link whose source has no working key says so. A request stops
+  when the user navigates or hides the panel before its photo loads; a new
+  photo replaces the open one in place, so EXPAND stays. When nothing is found and a 360°, flat or SINCE filter is on, the
   answer names the filter. An unavailable map stack now reports the
   controller's own reason instead of always asking for a Cesium ion token
   (Said Turksever, @asturksever, #1113).

docs/CURRENT-STATE.md

@@ -5329,7 +5329,8 @@ and a plain link runs it once restored (one shot: the rewritten hash drops
   screen centre is within 1 km of it (`ARMED_REACH_M`) or cannot be picked; a
   sky centre refuses; any other lookup, open, close, disable, the source
   switched off or its map leaving drops it), opens the panel and shows a toast
-  pointing at OPEN GOOGLE STREET VIEW.
+  pointing at OPEN GOOGLE STREET VIEW. A link whose source has no working
+  key here changes nothing and says so in a toast (not in a frame).
 - **Who may open.** Posted views, and the panel page's own link (inline embed)
   for a tool result issued in the last 5 minutes, open the photo:
   `show_in_gods_eye_view` stamps a street-level result `issued_at`, every

src/app/embed.js

@@ -207,6 +207,14 @@ function armedToast() {
   });
 }
 
+/** Why a link's photo stays shut: its source has no working key here. */
+function keyToast(result) {
+  return t(
+    "{source} cannot open this link's street-level photo without a working key",
+    { source: translateKnown(result.providerName || 'Street Level') },
+  );
+}
+
 /**
  * Make the app show a view: style and map, exactly the view's layers,
  * annotations, the camera, and the followed entity. Each step runs through the
@@ -378,6 +386,12 @@ export function installViews({
       streetLevelArgs(streetLevel, { autoOpen }),
       { origin: 'programmatic' },
     );
+    // A source without a working key changes nothing: say why, or the link
+    // looks broken. In a frame the host reads the result instead.
+    if (result?.stage === 'key' && !isEmbedded(location)) {
+      shell._showToast?.(keyToast(result));
+      return;
+    }
     // OPEN must be in view, but embed mode hides the rail that holds it: in
     // a frame a posted view is the way to open a photo.
     if (result?.armed === true && !isEmbedded(location)) {

src/app/embed.test.mjs

@@ -518,7 +518,7 @@ test('a link to street-level photos opens them after it restores', async () => {
     [[], []],
     'an opened photo needs no toast or panel nudge',
   );
-  // A failure (no key) is not an armed state either.
+  // A failure (no key) is not an armed state either: it says why instead.
   const failed = recorder({
     show_street_level: () => ({
       ok: false,
@@ -542,7 +542,16 @@ test('a link to street-level photos opens them after it restores', async () => {
     windowRef: new EventTarget(),
   });
   await new Promise((resolve) => setTimeout(resolve, 0));
-  assert.deepEqual([toasts, panels], [[], []]);
+  assert.deepEqual(
+    [toasts, panels],
+    [
+      [
+        "Street Level cannot open this link's street-level photo without a working key",
+      ],
+      [],
+    ],
+    'it says why, and nothing to press opens',
+  );
 });
 
 test('a link that follows an entity keeps the camera: its photos are not opened', async () => {
@@ -592,6 +601,54 @@ test('a failing link step does not take the next one with it', async () => {
   assert.deepEqual(calls, ['annotate_map', 'show_street_level']);
 });
 
+test('a link whose source has no working key says why instead of doing nothing; a frame stays quiet', async () => {
+  for (const embed of [false, true]) {
+    const toasts = [];
+    const { calls, run } = recorder({
+      show_street_level: () => ({
+        ok: false,
+        stage: 'key',
+        provider: 'google',
+        providerName: 'Google Street View',
+        error: 'Google Street View needs its key',
+      }),
+    });
+    const windowRef = new EventTarget();
+    if (embed) {
+      windowRef.document = { body: { classList: { add() {} } } };
+      windowRef.parent = { postMessage() {} };
+    }
+    installViews({
+      shell: {
+        initialRestorePromise: Promise.resolve(),
+        setCleanView() {},
+        _showToast: (text) => toasts.push(text),
+        setPanelCollapsed() {
+          throw new Error('nothing to arm');
+        },
+      },
+      viewer: fakeViewer(),
+      dataManager: fakeLayers(new Set()),
+      run,
+      location: {
+        search: embed ? '?embed=1' : '',
+        hash: '#v=2&lat=1&lon=2&map=photoreal&sl=google,38.57986,-121.49372',
+      },
+      windowRef,
+    });
+    await new Promise((resolve) => setTimeout(resolve, 0));
+    assert.equal(calls[0][0], 'show_street_level');
+    assert.deepEqual(
+      toasts,
+      embed
+        ? []
+        : [
+            "Google Street View cannot open this link's street-level photo without a working key",
+          ],
+    );
+  }
+});
+
 test('a plain link never auto-loads a billed photo: it arms the panel and says so; an embedded view opens', async () => {
   const toasts = [];
   const panels = [];

src/i18n/locales/ar.json

@@ -3744,6 +3744,7 @@
   "Switching map": "جارٍ تبديل الخريطة",
   "Opening imagery": "جارٍ فتح الصور",
   "Street View is ready: press {open} to load it": "Street View جاهز: اضغط «{open}» لتحميله",
+  "{source} cannot open this link's street-level photo without a working key": "لا يمكن لـ {source} فتح صورة مستوى الشارع في هذا الرابط بدون مفتاح صالح",
   "Street-level photos are hidden in the current view. Leave it first.": "صور مستوى الشارع مخفية في العرض الحالي. اخرج منه أولًا.",
   "STATIONS": "المحطات",
   "Crewed stations and the craft that visit them": "المحطات المأهولة والمركبات التي تزورها",

src/i18n/locales/de.json

@@ -3420,6 +3420,7 @@
   "Switching map": "Karte wird gewechselt",
   "Opening imagery": "Bilder werden geöffnet",
   "Street View is ready: press {open} to load it": "Street View ist bereit: Auf {open} klicken, um es zu laden",
+  "{source} cannot open this link's street-level photo without a working key": "{source} kann das Straßenfoto dieses Links ohne gültigen Schlüssel nicht öffnen",
   "Street-level photos are hidden in the current view. Leave it first.": "Fotos auf Straßenebene sind in dieser Ansicht ausgeblendet. Zuerst die Ansicht verlassen.",
   "STATIONS": "STATIONEN",
   "Crewed stations and the craft that visit them": "Bemannte Stationen und die Raumfahrzeuge, die sie anfliegen",

src/i18n/locales/es.json

@@ -3501,6 +3501,7 @@
   "Switching map": "Cambiando de mapa",
   "Opening imagery": "Abriendo imágenes",
   "Street View is ready: press {open} to load it": "Street View está listo: pulsa {open} para cargarlo",
+  "{source} cannot open this link's street-level photo without a working key": "{source} no puede abrir la foto a pie de calle de este enlace sin una clave válida",
   "Street-level photos are hidden in the current view. Leave it first.": "Las fotos a pie de calle están ocultas en la vista actual. Sal de ella primero.",
   "STATIONS": "ESTACIONES",
   "Crewed stations and the craft that visit them": "Estaciones tripuladas y las naves que las visitan",

src/i18n/locales/fr.json

@@ -3501,6 +3501,7 @@
   "Switching map": "Changement de carte",
   "Opening imagery": "Ouverture des images",
   "Street View is ready: press {open} to load it": "Street View est prêt : appuyez sur {open} pour le charger",
+  "{source} cannot open this link's street-level photo without a working key": "{source} ne peut pas ouvrir la photo au niveau de la rue de ce lien sans clé valide",
   "Street-level photos are hidden in the current view. Leave it first.": "Les photos au niveau de la rue sont masquées dans la vue actuelle. Quittez-la d’abord.",
   "STATIONS": "STATIONS",
   "Crewed stations and the craft that visit them": "Stations habitées et les vaisseaux qui s'y rendent",

src/i18n/locales/he.json

@@ -3302,6 +3302,7 @@
   "Switching map": "מחליף מפה",
   "Opening imagery": "פותח צילומים",
   "Street View is ready: press {open} to load it": "Street View מוכן: לחץ על {open} כדי לטעון אותו",
+  "{source} cannot open this link's street-level photo without a working key": "{source} לא יכול לפתוח את תמונת רמת הרחוב של הקישור הזה בלי מפתח תקף",
   "Street-level photos are hidden in the current view. Leave it first.": "תמונות ברמת הרחוב מוסתרות בתצוגה הנוכחית. צא ממנה קודם.",
   "Ship bridge view": "תצוגת גשר האונייה",
   "Satellite orbital view": "התצוגה המסלולית של הלוויין",

src/i18n/locales/it.json

@@ -3501,6 +3501,7 @@
   "Switching map": "Cambio mappa",
   "Opening imagery": "Apertura delle immagini",
   "Street View is ready: press {open} to load it": "Street View è pronto: premi {open} per caricarlo",
+  "{source} cannot open this link's street-level photo without a working key": "{source} non può aprire la foto a livello stradale di questo link senza una chiave valida",
   "Street-level photos are hidden in the current view. Leave it first.": "Le foto a livello stradale sono nascoste nella vista attuale. Esci prima da questa vista.",
   "STATIONS": "STAZIONI",
   "Crewed stations and the craft that visit them": "Stazioni con equipaggio e i veicoli che le visitano",

src/i18n/locales/ja.json

@@ -3339,6 +3339,7 @@
   "Switching map": "地図を切り替え中",
   "Opening imagery": "画像を開いています",
   "Street View is ready: press {open} to load it": "ストリートビューの準備ができました：{open} を押して読み込みます",
+  "{source} cannot open this link's street-level photo without a working key": "{source} は有効なキーがないため、このリンクのストリートレベル写真を開けません",
   "Street-level photos are hidden in the current view. Leave it first.": "現在の表示ではストリートレベルの写真は非表示です。先にこの表示を終了してください。",
   "STATIONS": "ステーション",
   "Crewed stations and the craft that visit them": "有人宇宙ステーションと、そこを訪れる宇宙機",

src/i18n/locales/pt.json

@@ -3501,6 +3501,7 @@
   "Switching map": "Mudando de mapa",
   "Opening imagery": "Abrindo imagens",
   "Street View is ready: press {open} to load it": "O Street View está pronto: clique em {open} para carregar",
+  "{source} cannot open this link's street-level photo without a working key": "{source} não pode abrir a foto ao nível da rua deste link sem uma chave válida",
   "Street-level photos are hidden in the current view. Leave it first.": "As fotos ao nível da rua estão ocultas na vista atual. Saia dela primeiro.",
   "STATIONS": "ESTAÇÕES",
   "Crewed stations and the craft that visit them": "Estações tripuladas e as naves que as visitam",

src/i18n/locales/ru.json

@@ -3582,6 +3582,7 @@
   "Switching map": "Смена карты",
   "Opening imagery": "Открытие снимков",
   "Street View is ready: press {open} to load it": "Просмотр улиц готов: нажмите {open}, чтобы загрузить",
+  "{source} cannot open this link's street-level photo without a working key": "{source} не может открыть уличное фото по этой ссылке без рабочего ключа",
   "Street-level photos are hidden in the current view. Leave it first.": "Уличные снимки скрыты в текущем режиме. Сначала выйдите из него.",
   "STATIONS": "СТАНЦИИ",
   "Crewed stations and the craft that visit them": "Пилотируемые станции и прилетающие к ним корабли",

src/i18n/locales/uk.json

@@ -3582,6 +3582,7 @@
   "Switching map": "Перемикання карти",
   "Opening imagery": "Відкриття знімків",
   "Street View is ready: press {open} to load it": "Перегляд вулиць готовий: натисніть {open}, щоб завантажити",
+  "{source} cannot open this link's street-level photo without a working key": "{source} не може відкрити вуличне фото за цим посиланням без робочого ключа",
   "Street-level photos are hidden in the current view. Leave it first.": "Вуличні знімки приховані в поточному режимі. Спершу вийдіть із нього.",
   "STATIONS": "СТАНЦІЇ",
   "Crewed stations and the craft that visit them": "Пілотовані станції та кораблі, що до них прилітають",

src/i18n/locales/zh-CN.json

@@ -3339,6 +3339,7 @@
   "Switching map": "正在切换地图",
   "Opening imagery": "正在打开影像",
   "Street View is ready: press {open} to load it": "街景已就绪：按 {open} 加载",
+  "{source} cannot open this link's street-level photo without a working key": "没有有效密钥，{source} 无法打开此链接的街景照片",
   "Street-level photos are hidden in the current view. Leave it first.": "当前视图隐藏了街景照片。请先退出该视图。",
   "STATIONS": "空间站",
   "Crewed stations and the craft that visit them": "载人空间站及来访飞行器",

src/i18n/locales/zh-Hant.json

@@ -3339,6 +3339,7 @@
   "Switching map": "正在切換地圖",
   "Opening imagery": "正在打開影像",
   "Street View is ready: press {open} to load it": "街景已就緒：按 {open} 載入",
+  "{source} cannot open this link's street-level photo without a working key": "沒有有效金鑰，{source} 無法開啟此連結的街景照片",
   "Street-level photos are hidden in the current view. Leave it first.": "目前的檢視隱藏了街景照片。請先離開此檢視。",
   "STATIONS": "太空站",
   "Crewed stations and the craft that visit them": "載人太空站及來訪飛行器",