mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
fix(globe): tighten the Cesium engine after review
Map sources are applied through one src/maps/sceneApply.js helper shared by MapSourceController and engine.maps (live layer kept for an unchanged provider, providers cached per source). The contract gains flyTo endTransform and rectangle destinations, flyToSphere easing, drillPick width/height and pick content, with Cesium's own flyToSphere range. Input skips listeners removed during dispatch and stays inert after destroy.
This commit is contained in:
1 parent
d831cbd23a
commit
ab2368f3f3
18 files changed
+658
-117
No files matched your search
@@ -36,7 +36,7 @@ test('drillPick passes the limit and normalises every result', () => {
|
||||
viewer.calls.push({ name: 'scene.drillPick', args });
|
||||
return [{ id: 'a', primitive: 1 }, { primitive: 2 }];
|
||||
};
|
||||
const drilled = picker.drillPick(geo.cartesian2.create(1, 1), 3);
|
||||
const drilled = picker.drillPick(geo.cartesian2.create(1, 1), 3, 5, 7);
|
||||
assert.deepEqual(
|
||||
drilled.map(({ id, primitive }) => [id, primitive]),
|
||||
[
|
||||
@@ -45,9 +45,10 @@ test('drillPick passes the limit and normalises every result', () => {
|
||||
],
|
||||
);
|
||||
assert.ok('id' in drilled[1]);
|
||||
const [screen, limit] = viewer.callsOf('scene.drillPick')[0].args;
|
||||
const [screen, limit, width, height] =
|
||||
viewer.callsOf('scene.drillPick')[0].args;
|
||||
assert.ok(screen instanceof Cesium.Cartesian2);
|
||||
assert.equal(limit, 3);
|
||||
assert.deepEqual([limit, width, height], [3, 5, 7]);
|
||||
});
|
||||
|
||||
test('pickPosition passes a new Cesium.Cartesian2 per call and returns geo', () => {
|
||||
@@ -78,3 +79,16 @@ test('pickPositionSupported follows the scene', () => {
|
||||
assert.equal(picker.pickPositionSupported, false);
|
||||
assert.equal(picker.pickPosition(geo.cartesian2.create(1, 1)), undefined);
|
||||
});
|
||||
|
||||
test('pick results carry 3D tile content for surface checks', () => {
|
||||
const { picker, scene } = setup();
|
||||
const content = { name: 'tile content' };
|
||||
const tileset = { isCesium3DTileset: true };
|
||||
scene.pick = () => ({ content, primitive: tileset });
|
||||
const picked = picker.pick(geo.cartesian2.create(1, 1));
|
||||
assert.equal(picked.content, content);
|
||||
assert.equal(picked.id, undefined);
|
||||
assert.equal(picked.primitive, tileset);
|
||||
scene.pick = () => ({ id: 'entity', primitive: {} });
|
||||
assert.equal(picker.pick(geo.cartesian2.create(1, 1)).content, undefined);
|
||||
});
|
||||
Reference in new issue
Block a user