Move QA scripts to the shared harness, batch 4 of 4

As in the previous batches. Scripts launching Chrome themselves go from
99 to 8 (all outside this conversion), fixed pauses from 86 to 69 and
Cesium-only reads from 75 to 46; the QA harness baseline records them.
This commit is contained in:
German Khokhlov committed 2026-11-10 16:43:58 +04:00
1 parent 53b07ba91f
commit 6c416f3fe6
25 files changed
+1006 -1171

No files matched your search

+26 -21
View File
@@ -1,3 +1,4 @@
import { whenFramesDrawn } from './qa/ready.mjs';
export function transitQaBase(value) {
if (!value) throw new Error('Transit QA requires an explicit QA_BASE_URL');
const url = new URL(value);
@@ -21,12 +22,15 @@ export function boundPageEvaluations(page, defaultTimeoutMs = 30000) {
);
const label = String(fn).slice(0, 120).replace(/\s+/g, ' ');
return evaluate(
async (source, values, timeoutMs, label) => {
async (source, values, timeoutMs, label, isFunction) => {
let timer;
try {
return await Promise.race([
// Puppeteer callbacks are standalone functions, just as in evaluate.
Promise.resolve().then(() => (0, eval)(`(${source})`)(...values)),
Promise.resolve().then(() => {
const result = (0, eval)(`(${source})`);
return isFunction ? result(...values) : result;
}),
new Promise((_, reject) => {
timer = setTimeout(
() =>
@@ -47,6 +51,7 @@ export function boundPageEvaluations(page, defaultTimeoutMs = 30000) {
args,
timeoutMs,
label,
typeof fn === 'function',
);
};
}
@@ -62,8 +67,8 @@ export async function reportTransitVisibility(page, label) {
visible: state._visible.size,
moving: state._moving.size,
held: state._renderHeld,
requestRenderMode: app.viewer.scene.requestRenderMode,
renderLoop: app.viewer.useDefaultRenderLoop,
requestRenderMode: !app.engine.render.isContinuous(),
renderLoop: !app.engine.isDestroyed(),
renderErrors: window.__transitRenderErrors || [],
bounds: state._viewBounds,
hidden: layer._transitVisibilityForTest().filter((e) => !e.shown),
@@ -76,13 +81,14 @@ export async function reportTransitVisibility(page, label) {
);
if (result.renderLoop === false || result.renderErrors.length)
throw new Error(
`${label}: Cesium render loop stopped or raised an error: ${JSON.stringify(result.renderErrors)}`,
`${label}: render loop stopped or raised an error: ${JSON.stringify(result.renderErrors)}`,
);
await whenFramesDrawn(page);
return result;
}
/** Intersect primed histories with the new snapshot; disappearance is availability. */
export async function restoreRetainedTransit(retained) {
export async function restoreRetainedTransit(qaGeo, retained) {
if (!retained.length)
return {
error: 'No multi-fix history observed during the probe',
@@ -117,9 +123,8 @@ export async function restoreRetainedTransit(retained) {
const entry = state._vehicles.get(
`${history.feedId || 'mbta'}:${history.vehicleId}`,
);
const camera = app.viewer.camera,
C = camera.positionCartographic.constructor;
camera.setView({
const C = qaGeo.cartographic;
window.__godsEyeView.engine.camera.setView({
destination: C.toCartesian(
C.fromDegrees(entry.record.lon, entry.record.lat, 600),
),
@@ -173,14 +178,12 @@ export async function sampleTransitPixels(page, palette) {
);
}, 5000);
const remove =
window.__godsEyeView.viewer.scene.postRender.addEventListener(() => {
window.__godsEyeView.engine.frames.postRender.addEventListener(() => {
const app = window.__godsEyeView;
const layer = app.dataManager.layers.get('transit').module;
const state = layer._transitStateForTest();
const scene = app.viewer.scene;
const canvas = scene.canvas;
const view = scene.camera.viewMatrix;
const proj = scene.camera.frustum.projectionMatrix;
const { engine } = app;
const canvas = window.__godsEyeView.engine.host.canvas;
const mul = (m, v) => [
m[0] * v[0] + m[4] * v[1] + m[8] * v[2] + m[12] * v[3],
m[1] * v[0] + m[5] * v[1] + m[9] * v[2] + m[13] * v[3],
@@ -269,9 +272,12 @@ export async function sampleTransitPixels(page, palette) {
for (const entry of state._vehicles.values()) {
if (!entry.marker || entry.marker.show === false) continue;
const p = entry.marker.position;
const clip = mul(proj, mul(view, [p.x, p.y, p.z, 1]));
const clip = mul(
window.__godsEyeView.engine.projector.viewProjection(),
[p.x, p.y, p.z, 1],
);
if (!(clip[3] > 0)) continue;
const screen = entry.marker.computeScreenSpacePosition?.(scene) || {
const screen = {
x: ((clip[0] / clip[3]) * 0.5 + 0.5) * width,
y: (1 - ((clip[1] / clip[3]) * 0.5 + 0.5)) * height,
};
@@ -492,7 +498,7 @@ export async function sampleTransitPixels(page, palette) {
// label or sprite must not masquerade as a dim sensor signature.
// Check the whole sampled core, not just its centre pick.
let coreOwned = true;
if (scene.pick) {
{
const framebuffer = gl.getParameter?.(gl.FRAMEBUFFER_BINDING);
for (const core of corePoints) {
let u = core.x / width,
@@ -519,13 +525,12 @@ export async function sampleTransitPixels(page, palette) {
v) *
intensity;
}
const picked = scene.pick(
const picked = engine.picker.pick(
{ x: u * width, y: (1 - v) * height },
1,
1,
);
if (picked?.id !== s.key && picked?.primitive?.id !== s.key)
coreOwned = false;
if (picked?.id !== s.key) coreOwned = false;
}
if (gl.bindFramebuffer)
gl.bindFramebuffer(gl.FRAMEBUFFER, framebuffer);
@@ -657,7 +662,7 @@ export async function sampleTransitPixels(page, palette) {
);
resolve(out);
});
window.__godsEyeView.viewer.scene.requestRender();
window.__godsEyeView.engine.render.request();
});
}, palette);
}