fix: address review feedback for PR #1026

This commit is contained in:
Rudy Celekli committed 2026-10-14 14:17:46 -04:00
1 parent 2c5fb039ce
commit 615ba9a008
2 files changed
+4 -6

No files matched your search

+2 -5
View File
@@ -73,6 +73,8 @@ Windows/Claude Desktop Cowork confirmation remains outstanding (#927).
## Tools and local MCP server — October 1, 2026
Tool argument string lengths follow JSON Schema Unicode code-point counts, so supplementary characters count once rather than as two UTF-16 units.
`gods-eye-view/tools` defines queries that answer questions from the app's data,
and `gods-eye-view/tools/mcp` exposes a composed catalog over the Model Context
Protocol. `npm run mcp` serves Core's tools over stdio to a local MCP client,
@@ -5310,8 +5312,3 @@ datacenters, dams and the Nepal locator retain that shared credit while displaye
Military fragments stitch by source identity. Different mapped parcels merge only
when their footprints touch or contain one another, never across a seam tolerance gap.
### fix(tools): enforce string schema lengths by Unicode code point
Count code points for minLength and maxLength, preserving ASCII behavior and regular-expression validation.
+2 -1
View File
@@ -106,7 +106,8 @@ export function validateValue(schema, value, path = 'arguments') {
fail('must be a string');
break;
}
const length = [...value].length;
let length = 0;
for (const character of value) length += 1;
if (schema.minLength != null && length < schema.minLength)
fail(`must be at least ${schema.minLength} characters`);
if (schema.maxLength != null && length > schema.maxLength)