i18n: fix the repeat-review findings

- Status pieces translate in one place (src/ui/statusText.js): a Local
  ADS-B error with a single piece now translates, and the analyst card
  splits empty-layer notes into pieces (Transit, Local ADS-B).
- Translate the ALPR retry chip text, the ECCC error on the Air quality
  card, "Upstream response too large" and the "entry {n}" feed label.
- The unmarked-text check also sees error/loadingLabel/statusMessage/
  status assignments, `status:` properties and showToast?.( /
  this._showToast( calls; the scene import preview marks its pack
  statuses, data and model-facing text carry i18n-ignore with a reason.
- Tests check the real code: the HUD locality formatter moves to
  src/hudLocalityFormat.js, the unsaved-keys test pins the teardown.
- One copy each: city names come from src/cityPois.js, the GNSS HTTP
  template and wind "field unavailable" texts; dead fallbacks removed.
- Leftovers of the reverted vessel-label change and the reformatting of
  detectionHost.test.mjs / keySetup.test.mjs are back to main.

Catalogs: es/ru 2617 messages each, complete.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

scripts/i18n.mjs

@@ -217,8 +217,14 @@ const JS_SINKS = [
   /\bsetAttribute\(\s*['"](?:title|aria-label|aria-valuetext|placeholder|alt)['"]\s*,\s*/g,
   /\b(?:createTextNode|insertAdjacentText)\(\s*(?:['"][a-z]+['"]\s*,\s*)?/g,
   /\binsertAdjacentHTML\(\s*['"][a-z]+['"]\s*,\s*/g,
-  /\b(?:showToast|toast|setHint|announce|say)\(\s*/g,
-  /(?:^|[{,\s])(?:label|title|tooltip|placeholder|hint|ariaLabel|accessibilityLabel|caption|subtitle|kicker|emptyText|blurb|countLabel)\s*:\s*/gm,
+  // Also showToast?.(…) and this._showToast(…).
+  /\b_?(?:showToast|toast|setHint|announce|say)(?:\?\.)?\(\s*/g,
+  // `status` values are often codes ('ok', 'auth-failed'); visibleText drops
+  // those, so only readable text is reported.
+  /(?:^|[{,\s])(?:label|title|tooltip|placeholder|hint|ariaLabel|accessibilityLabel|caption|subtitle|kicker|emptyText|blurb|countLabel|status|loadingLabel|statusMessage)\s*:\s*/gm,
+  // Layer status set by assignment: this._error = …, stats.loadingLabel = ….
+  // A declared local (`const error = …`) is scratch, not a status field.
+  /(?<![\w$])(?<!\b(?:const|let|var)\s+)_?(?:error|loadingLabel|statusMessage|status)\s*(?:\?\?|\|\|)?=(?![=>])\s*/g,
 ];
 const MARKERS = /\b(?:t|tn|msg)\(/y;
 

scripts/package-boundaries.json

@@ -469,7 +469,8 @@
       "src/i18n/locales/es.json",
       "src/i18n/locales/ru.json",
       "src/ui/unitLabels.js",
-      "src/ui/keyGuidance.js"
+      "src/ui/keyGuidance.js",
+      "src/ui/statusText.js"
     ],
     "external": []
   },
@@ -737,7 +738,8 @@
       "src/i18n/locales/ru.json",
       "src/ui/unitLabels.js",
       "src/ui/keyGuidance.js",
-      "src/ui/layerNames.js"
+      "src/ui/layerNames.js",
+      "src/ui/statusText.js"
     ],
     "external": ["cesium"]
   },
@@ -1570,6 +1572,7 @@
       "src/voice/referents.js",
       "src/voice/layerManifest.js",
       "src/voice/speech.js",
+      "src/cityPois.js",
       "src/ui/layerNames.js",
       "src/ui/unitLabels.js",
       "src/ui/placeNames.js",
@@ -1580,7 +1583,8 @@
       "src/i18n/index.js",
       "src/i18n/locale.js",
       "src/i18n/locales/es.json",
-      "src/i18n/locales/ru.json"
+      "src/i18n/locales/ru.json",
+      "src/ui/statusText.js"
     ],
     "external": []
   },
@@ -1794,6 +1798,7 @@
       "src/firstRunExperience.js",
       "src/hud.js",
       "src/hudLocality.js",
+      "src/hudLocalityFormat.js",
       "src/hudSummaryResponse.js",
       "src/keySetup.js",
       "src/keySetupCore.mjs",
@@ -2020,6 +2025,7 @@
       "src/loadingFeedback.js",
       "src/locationStatus.js",
       "src/locations.js",
+      "src/cityPois.js",
       "src/logoGaze.js",
       "src/mapStackChips.js",
       "src/mapStackController.js",
@@ -2436,7 +2442,8 @@
       "src/app/layers/airQuality.js",
       "src/layers/airQuality/index.js",
       "src/layers/airQuality/model.js",
-      "src/layers/airQuality/source.js"
+      "src/layers/airQuality/source.js",
+      "src/ui/statusText.js"
     ],
     "external": [
       "hls.js",
@@ -2792,6 +2799,7 @@
       "src/layers/vessels/testing.js",
       "src/layers/vessels/tracking.js",
       "src/locations.js",
+      "src/cityPois.js",
       "src/navigationPolicy.js",
       "src/overlays/worldOverlay.js",
       "src/overlays/worldOverlayDraw.js",
@@ -3000,7 +3008,11 @@
       "src/app/layers/airQuality.js",
       "src/layers/airQuality/index.js",
       "src/layers/airQuality/model.js",
-      "src/layers/airQuality/source.js"
+      "src/layers/airQuality/source.js",
+      "src/ui/statusText.js",
+      "src/ui/layerNames.js",
+      "src/layers/wind/source.js",
+      "src/sources/windBody.js"
     ],
     "external": [
       "hls.js",
@@ -3039,6 +3051,7 @@
       "src/keylessGeocoder.js",
       "src/layers/firms/anchors.js",
       "src/locations.js",
+      "src/cityPois.js",
       "src/cameraGroundGuard.js",
       "src/search/alpsGeocoder.js",
       "src/search/defaults.js",
@@ -3299,13 +3312,15 @@
       "src/voice/referents.js",
       "src/voice/layerManifest.js",
       "src/voice/speech.js",
+      "src/cityPois.js",
       "src/ui/layerNames.js",
       "src/ui/unitLabels.js",
       "src/voice/pointerReticle.js",
       "src/i18n/index.js",
       "src/i18n/locale.js",
       "src/i18n/locales/es.json",
-      "src/i18n/locales/ru.json"
+      "src/i18n/locales/ru.json",
+      "src/ui/statusText.js"
     ],
     "external": []
   },
@@ -3647,7 +3662,9 @@
       "src/i18n/index.js",
       "src/i18n/locale.js",
       "src/i18n/locales/es.json",
-      "src/i18n/locales/ru.json"
+      "src/i18n/locales/ru.json",
+      "src/ui/statusText.js",
+      "src/ui/layerNames.js"
     ],
     "external": ["cesium"]
   },
@@ -3825,7 +3842,9 @@
       "src/i18n/index.js",
       "src/i18n/locale.js",
       "src/i18n/locales/es.json",
-      "src/i18n/locales/ru.json"
+      "src/i18n/locales/ru.json",
+      "src/ui/statusText.js",
+      "src/ui/layerNames.js"
     ],
     "external": ["cesium"]
   },