mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-18 09:12:18 +00:00
i18n: plural forms and contexts the catalogs could only work around
The last translation review left four kinds of problem it could only
reword around in the catalogs. They are fixed in the code now, and the
catalogs go back to natural wording.
- Counts shown with plain t() are tn() plurals: the wildlife count, the
Data Library "Showing {shown} of {total}", the News time window (which
offers 1 h) and the GhostMaps event age (which offers 1 day). The
English keys stay; the catalogs get real forms, as in "Última 1 h" and
"Últimas 24 h", or "1 Tag" and "7 Tage".
- The bridge radar range and ring spacing are tn() plurals too. The
spacing is fractional at the short ranges, and Intl.PluralRules gives
0.75 and 1.5 their own form: ru "0,75 МОР. МИЛИ", "12 МОР. МИЛЬ".
- Street level no longer passes "the view centre" or "this spot" as
{place}: each case has a message of its own, so a preposition no
longer meets a phrase in the wrong case. The progress line had the
same leak and showed the English phrase.
- Latest, FOCUS, CONFIRMED and "{label} · COURSE {heading}°" are split
with a context where one key served two places: the News heading, the
orbital site status, the Wildlife chip and a ship's course.
"CURRENTLY OVER" ended in a preposition that a country name in the
nominative cannot follow in uk, de, it and pt. It reads "under the
satellite" there now, as ru already did.
I18N.md gains the two rules behind these fixes.
This commit is contained in:
1 parent
42540ad85e
commit
209b135ff1
37 files changed
+1124
-196
No files matched your search
@@ -1,6 +1,7 @@
|
||||
import '../testSupport/registerDom.mjs';
|
||||
import test from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { setLocale, t as translate } from '../i18n/index.js';
|
||||
import { createNewsPanel } from './newsPanel.js';
|
||||
import {
|
||||
NEWS_CATEGORIES,
|
||||
@@ -385,6 +386,55 @@ test('the window choice offers shorter windows; the longest is the server window
|
||||
assert.deepEqual(calls.at(-1)[1], { filters: { hours: null } });
|
||||
});
|
||||
|
||||
test('the time window agrees with its number of hours', (t) => {
|
||||
t.after(() => setLocale('en'));
|
||||
setLocale('es');
|
||||
const { news, panel } = fixture();
|
||||
news.update(view({ windowHours: 24, windowChoices: [24, 12, 6, 3, 1] }));
|
||||
const choice = panel.querySelector(
|
||||
'select.news-readout__window-choice, .news-readout__window-choice select',
|
||||
);
|
||||
assert.deepEqual(
|
||||
[...choice.options].map((option) => option.textContent),
|
||||
['Últimas 24 h', 'Últimas 12 h', 'Últimas 6 h', 'Últimas 3 h', 'Última 1 h'],
|
||||
);
|
||||
news.update(view({ windowHours: 1, items: [], hasMore: false }));
|
||||
assert.equal(
|
||||
panel.querySelector('.news-readout__window').textContent,
|
||||
'Última 1 h',
|
||||
);
|
||||
assert.equal(
|
||||
panel.querySelector('.news-readout').getAttribute('aria-label'),
|
||||
'Noticias de la última 1 hora',
|
||||
);
|
||||
assert.match(
|
||||
panel.textContent,
|
||||
/En la última 1 h no hay noticias que coincidan con estos filtros/,
|
||||
);
|
||||
setLocale('ru');
|
||||
news.update(view({ windowHours: 1, items: [], hasMore: false }));
|
||||
assert.equal(
|
||||
panel.querySelector('.news-readout').getAttribute('aria-label'),
|
||||
'Новости за последний 1 час',
|
||||
);
|
||||
news.update(view({ windowHours: 12, items: [], hasMore: false }));
|
||||
assert.equal(
|
||||
panel.querySelector('.news-readout').getAttribute('aria-label'),
|
||||
'Новости за последние 12 часов',
|
||||
);
|
||||
news.destroy();
|
||||
});
|
||||
|
||||
test('the Latest news heading is worded apart from the timeline button (fr)', (t) => {
|
||||
t.after(() => setLocale('en'));
|
||||
setLocale('fr');
|
||||
const { news, panel } = fixture();
|
||||
news.update(view());
|
||||
assert.equal(panel.querySelector('.news-readout__head').textContent, 'Dernières');
|
||||
assert.equal(translate('Latest'), 'Dernière', 'the timeline keeps its own');
|
||||
news.destroy();
|
||||
});
|
||||
|
||||
test('the panel names the window the server serves', () => {
|
||||
const { news, panel } = fixture();
|
||||
news.update(view({ windowHours: 12 }));
|
||||
|
||||
Reference in new issue
Block a user