benmichael/gods-eye-view
1
0 Fork 0
mirror of https://github.com/bilawalsidhu/gods-eye-view.git synced 2026-11-04 10:24:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(street-level): probe KartaView's nearest photos side by side

Browse Source 
Six candidates at once on photo storage (not the API host): the nearest
showable one wins. Jakarta line clicks opened 5/8 (0/5 before the QA
round; the rest are archived and say so), Detroit 8/8.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
Said TurkseverandClaude Opus 5.5 committed 2026-10-13 19:49:51 +01:00
1 parent 454e261256
commit 1a2fbda464
2 files changed
+10 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/layers/streetLevel/providers/kartaview/index.js
+8 -2
View File
@@ -440,8 +440,14 @@ export function createKartaViewProvider({
if (metres <= NEAREST_RADIUS_M) near.push({ photo, metres });
}
near.sort((a, b) => a.metres - b.metres);
for (const { photo } of near.slice(0, NEAREST_PROBES))
if (await showable(photo, { signal })) return photo.id;
// Probed side by side (photo storage is not the API host): the
// nearest one that answers wins.
const candidates = near.slice(0, NEAREST_PROBES);
const answers = await Promise.all(
candidates.map(({ photo }) => showable(photo, { signal })),
);
const hit = candidates.find((_, i) => answers[i]);
if (hit) return hit.photo.id;
if (near.length) throw new Error(ARCHIVED_MESSAGE);
return null;
},
src/layers/streetLevel/providers/kartaview/policy.js
+2 -2
View File
@@ -71,8 +71,8 @@ export const PAGE_TIMEOUT_MS = 30_000;
export const IMAGE_TIMEOUT_MS = 15_000;
/** Whether a photo file is there (not archived): headers only. */
export const IMAGE_PROBE_TIMEOUT_MS = 8_000;
/** Nearest photos tried before giving up on archived ones. */
export const NEAREST_PROBES = 4;
/** Nearest photos probed (at once) before giving up on archived ones; ‹ › skip this many. */
export const NEAREST_PROBES = 6;
export const ARCHIVED_MESSAGE =
'KartaView’s photos here are archived and cannot be shown';