gods-eye-view/src/data/militaryInstallationData.test.mjs

import test from 'node:test';
import assert from 'node:assert/strict';
import {
  humanizeInstallationClass,
  isValidInstallationBoundingBox,
  normalizeMilitaryInstallations,
} from './militaryInstallationData.js';

test('normalizes allowed OSM installation features and deduplicates ids', () => {
  const result = normalizeMilitaryInstallations({ elements: [
    { type: 'way', id: 7, center: { lat: 12, lon: 77 }, tags: { military: 'airfield', name: 'Example' }, geometry: [{ lat: 12, lon: 77 }, { lat: 12.1, lon: 77 }, { lat: 12, lon: 77.1 }] },
    { type: 'way', id: 7, center: { lat: 12, lon: 77 }, tags: { military: 'airfield' } },
    { type: 'node', id: 8, lat: 0, lon: 179.9, tags: { landuse: 'military' } },
  ] }, '2026-07-21T00:00:00.000Z');
  assert.equal(result.records.length, 2);
  assert.equal(result.records[0].class, 'airfield');
  assert.deepEqual(result.records[0].footprint[0], [77, 12]);
  assert.equal(result.records[1].longitude, 179.9);
  assert.equal(result.droppedCount, 1);
});

test('drops malformed and unsupported OSM features', () => {
  const result = normalizeMilitaryInstallations({ elements: [
    { type: 'node', id: 1, lat: 95, lon: 0, tags: { military: 'range' } },
    { type: 'node', id: 2, lat: 1, lon: 2, tags: { military: 'radar' } },
  ] });
  assert.deepEqual(result.records, []);
  assert.equal(result.droppedCount, 2);
});

test('an unnamed feature reads as its class, never as a raw OSM id', () => {
  const result = normalizeMilitaryInstallations({ elements: [
    { type: 'way', id: 10981656305, center: { lat: 30.2, lon: -97.7 }, tags: { military: 'range' } },
    { type: 'way', id: 22, center: { lat: 30.3, lon: -97.6 }, tags: { military: 'airfield' } },
    { type: 'node', id: 33, lat: 30.4, lon: -97.5, tags: { military: 'naval_base' } },
    { type: 'node', id: 44, lat: 30.5, lon: -97.4, tags: { landuse: 'military' } },
    // A blank OSM name must fall through to the class, not to an empty label.
    { type: 'node', id: 55, lat: 30.6, lon: -97.3, tags: { military: 'range', name: '   ' } },
  ] }, '2026-08-18T00:00:00.000Z');

  assert.deepEqual(
    result.records.map((record) => record.name),
    ['Firing range', 'Military airfield', 'Naval base', 'Military land', 'Firing range'],
  );
  for (const record of result.records) {
    assert.doesNotMatch(record.name, /\d/, `label must carry no OSM id: ${record.name}`);
    assert.doesNotMatch(record.name, /[()]/, `label must carry no id parenthetical: ${record.name}`);
  }
  // The id is not lost — attribution and the details panel still resolve it.
  assert.equal(result.records[0].id, 'osm:way:10981656305');
  assert.deepEqual(result.records[0].sources, [
    { name: 'OpenStreetMap', id: 'way/10981656305', retrievedAt: '2026-08-18T00:00:00.000Z' },
  ]);
});

test('a real OSM name always wins over the class label', () => {
  const result = normalizeMilitaryInstallations({ elements: [
    { type: 'way', id: 1, center: { lat: 30, lon: -97 }, tags: { military: 'range', name: 'Camp Swift' } },
    { type: 'way', id: 2, center: { lat: 30.1, lon: -97.1 }, tags: { military: 'airfield', 'name:en': 'Bergstrom' } },
  ] });
  assert.deepEqual(result.records.map((record) => record.name), ['Camp Swift', 'Bergstrom']);
});

test('an unmapped class title-cases instead of leaking an underscored tag', () => {
  assert.equal(humanizeInstallationClass('danger_area'), 'Danger area');
  assert.equal(humanizeInstallationClass('checkpoint'), 'Checkpoint');
  assert.equal(humanizeInstallationClass('training_area_north'), 'Training area north');
  assert.equal(humanizeInstallationClass(''), 'Mapped installation');
  assert.equal(humanizeInstallationClass(null), 'Mapped installation');
});

test('accepts only small non-dateline request bboxes', () => {
  assert.equal(isValidInstallationBoundingBox({ south: -1, west: 170, north: 1, east: 179 }), true);
  assert.equal(isValidInstallationBoundingBox({ south: -1, west: 179, north: 1, east: -179 }), false);
  assert.equal(isValidInstallationBoundingBox({ south: -20, west: 0, north: 20, east: 1 }), false);
});

test('a way with only bounds is kept, at the midpoint of that box', () => {
  // The proxy asks for `out center tags geom` and Overpass honours only the
  // LAST geometry mode, so `center` is never emitted and every way/relation
  // arrives carrying `bounds` instead. Dropping those rendered nodes and
  // nothing else — an empty screen over mapped installations.
  const result = normalizeMilitaryInstallations({ elements: [
    { type: 'way', id: 92701457, bounds: { minlat: 51.94, minlon: 7.98, maxlat: 51.96, maxlon: 8.02 },
      tags: { military: 'barracks', name: 'Sportschule der Bundeswehr' } },
  ] }, '2026-08-28T00:00:00.000Z');

  assert.equal(result.records.length, 1);
  assert.equal(result.droppedCount, 0);
  assert.equal(result.records[0].latitude, 51.95);
  assert.equal(result.records[0].longitude, 8.00);
});

test('a relation with only bounds is kept — it carries no geometry at all', () => {
  const result = normalizeMilitaryInstallations({ elements: [
    { type: 'relation', id: 5, bounds: { minlat: -1, minlon: -2, maxlat: 1, maxlon: 2 },
      tags: { landuse: 'military' } },
  ] });
  assert.equal(result.records.length, 1);
  assert.equal(result.records[0].latitude, 0);
  assert.equal(result.records[0].longitude, 0);
});

test('an explicit centre still wins over bounds', () => {
  const result = normalizeMilitaryInstallations({ elements: [
    { type: 'way', id: 6, center: { lat: 30.2, lon: -97.7 },
      bounds: { minlat: 0, minlon: 0, maxlat: 60, maxlon: 60 },
      tags: { military: 'airfield' } },
  ] });
  assert.equal(result.records[0].latitude, 30.2);
  assert.equal(result.records[0].longitude, -97.7);
});

test('an out-of-range or incomplete bounds box is dropped, not averaged', () => {
  const result = normalizeMilitaryInstallations({ elements: [
    // latitude past the pole
    { type: 'way', id: 1, bounds: { minlat: 80, minlon: 0, maxlat: 95, maxlon: 1 }, tags: { military: 'range' } },
    // longitude past the antimeridian
    { type: 'way', id: 2, bounds: { minlat: 0, minlon: 170, maxlat: 1, maxlon: 181 }, tags: { military: 'range' } },
    // a half-filled box would average to a plausible-looking lie
    { type: 'way', id: 3, bounds: { minlat: 10, maxlat: 12 }, tags: { military: 'range' } },
    { type: 'way', id: 4, bounds: {}, tags: { military: 'range' } },
    { type: 'way', id: 5, tags: { military: 'range' } },
  ] });
  assert.deepEqual(result.records, []);
  assert.equal(result.droppedCount, 5);
});

test('non-numeric bounds never coerce into a mapped site at zero', () => {
  for (const value of [null, false, '', '0']) {
    const result = normalizeMilitaryInstallations({ elements: [{
      type: 'way', id: 90, tags: { military: 'barracks' },
      bounds: { minlat: value, minlon: value, maxlat: value, maxlon: value },
    }] });
    assert.equal(result.records.length, 0);
    assert.equal(result.droppedCount, 1);
  }
});

test('an inverted or dateline-spanning bounds box is dropped rather than midpointed', () => {
  const result = normalizeMilitaryInstallations({ elements: [
    // south above north
    { type: 'way', id: 6, bounds: { minlat: 10, minlon: 0, maxlat: 8, maxlon: 1 }, tags: { military: 'range' } },
    // west east of east: a dateline-spanning box would midpoint to longitude 0
    { type: 'way', id: 7, bounds: { minlat: 5, minlon: 179, maxlat: 6, maxlon: -179 }, tags: { military: 'range' } },
    // ascending but implausibly wide: Overpass reports an antimeridian feature
    // as minlon -179 / maxlon 179, which also midpoints to longitude 0
    { type: 'way', id: 8, bounds: { minlat: 5, minlon: -179, maxlat: 6, maxlon: 179 }, tags: { military: 'range' } },
  ] });
  assert.deepEqual(result.records, []);
  assert.equal(result.droppedCount, 3);
});