mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
The Context header carried a Radio icon that opened a second, compact Radio player on top of the panel, duplicating the Radio section that already lives inside Context. Remove the icon, the compact player and everything that kept the two in step. Radio stays in Context as its own section with one Enable control; Cockpit's compact Radio is unchanged. Context itself was hard to read: 7-8 px labels at low contrast, a dashed placeholder box, and a glow halo. The two modes are now one segmented control, labels and guidance are 10 px at higher contrast, the standby hint is plain text, section titles use --text-secondary, and the panel draws no glow. Unused translations are pruned, tests and QA harnesses that pinned the compact player are updated or retired, and CURRENT-STATE and the changelog describe the new header.
174 lines
4.6 KiB
JavaScript
174 lines
4.6 KiB
JavaScript
import assert from 'node:assert/strict';
|
|
import { test } from 'node:test';
|
|
import { RadioControls } from './radioControls.js';
|
|
|
|
class Element extends EventTarget {
|
|
constructor() {
|
|
super();
|
|
this.attrs = new Map();
|
|
this.classes = new Set();
|
|
this.focusCount = 0;
|
|
this.isConnected = true;
|
|
this.classList = {
|
|
add: (...names) => names.forEach((n) => this.classes.add(n)),
|
|
remove: (...names) => names.forEach((n) => this.classes.delete(n)),
|
|
contains: (name) => this.classes.has(name),
|
|
toggle: (name, enabled) =>
|
|
enabled ? this.classes.add(name) : this.classes.delete(name),
|
|
};
|
|
}
|
|
setAttribute(name, value) {
|
|
this.attrs.set(name, String(value));
|
|
}
|
|
getAttribute(name) {
|
|
return this.attrs.get(name);
|
|
}
|
|
querySelector() {
|
|
return null;
|
|
}
|
|
focus() {
|
|
this.focusCount++;
|
|
}
|
|
}
|
|
|
|
function fixture() {
|
|
const prior = { document: globalThis.document, window: globalThis.window };
|
|
const document = new EventTarget();
|
|
document.getElementById = () => null;
|
|
globalThis.document = document;
|
|
globalThis.window = new EventTarget();
|
|
const panel = new Element();
|
|
const enable = new Element();
|
|
const next = new Element();
|
|
const calls = [];
|
|
const subscribers = [];
|
|
const radio = {
|
|
subscribe(callback) {
|
|
subscribers.push(callback);
|
|
calls.push('subscribe');
|
|
return () => calls.push('unsubscribe');
|
|
},
|
|
endTuning() {
|
|
calls.push('endTuning');
|
|
},
|
|
cycleStation(direction) {
|
|
calls.push(['cycle', direction]);
|
|
return true;
|
|
},
|
|
};
|
|
const actions = {
|
|
isRegistered: () => true,
|
|
isEnabled: () => false,
|
|
runUserAction: (operation) => operation(),
|
|
setEnabled: async () => true,
|
|
setPanelCollapsed: (...args) => calls.push(['panel', ...args]),
|
|
layoutCockpit() {},
|
|
isCockpitActive: () => false,
|
|
scheduleLayout() {},
|
|
getLifecycle: () => null,
|
|
preservePanelStateDuringClear: () => false,
|
|
};
|
|
const controls = new RadioControls({
|
|
elements: {
|
|
_radioPanel: panel,
|
|
_radioEnableBtn: enable,
|
|
_radioNextBtn: next,
|
|
},
|
|
radio,
|
|
actions,
|
|
canvas: new Element(),
|
|
});
|
|
return {
|
|
controls,
|
|
enable,
|
|
next,
|
|
actions,
|
|
calls,
|
|
subscribers,
|
|
document,
|
|
cleanup() {
|
|
controls.destroy();
|
|
Object.assign(globalThis, prior);
|
|
},
|
|
};
|
|
}
|
|
|
|
test('Radio listeners and subscriptions are revoked once before tuning teardown', () => {
|
|
const f = fixture();
|
|
try {
|
|
f.controls.connect();
|
|
f.next.dispatchEvent(new Event('click'));
|
|
assert.deepEqual(f.calls, ['subscribe', ['cycle', 1]]);
|
|
f.controls.destroy();
|
|
f.controls.destroy();
|
|
const snapshot = structuredClone(f.calls);
|
|
f.controls._setCockpitDisclosure('display', true);
|
|
f.next.dispatchEvent(new Event('click'));
|
|
f.document.dispatchEvent(new Event('gev:radio-selected'));
|
|
f.subscribers[0]({ enabled: true });
|
|
f.controls.connect();
|
|
assert.deepEqual(f.calls, snapshot);
|
|
assert.deepEqual(f.calls.slice(-2), ['unsubscribe', 'endTuning']);
|
|
} finally {
|
|
f.cleanup();
|
|
}
|
|
});
|
|
|
|
test('Radio reconnect removes its previous state subscription', () => {
|
|
const f = fixture();
|
|
try {
|
|
f.controls.connect();
|
|
f.controls.connect();
|
|
assert.deepEqual(f.calls, ['subscribe', 'unsubscribe', 'subscribe']);
|
|
} finally {
|
|
f.cleanup();
|
|
}
|
|
});
|
|
|
|
test('a delayed Radio enable cannot reveal or refocus controls after destruction', async () => {
|
|
const f = fixture();
|
|
let resolve;
|
|
const pending = new Promise((done) => {
|
|
resolve = done;
|
|
});
|
|
try {
|
|
f.actions.setEnabled = () => pending;
|
|
f.enable.dispatchEvent(new Event('click'));
|
|
assert.equal(f.enable.getAttribute('aria-busy'), 'true');
|
|
f.controls.destroy();
|
|
const attrs = new Map(f.enable.attrs);
|
|
resolve(true);
|
|
await pending;
|
|
await new Promise((done) => setImmediate(done));
|
|
assert.deepEqual(f.enable.attrs, attrs);
|
|
assert.equal(f.enable.focusCount, 0);
|
|
assert.equal(
|
|
f.calls.some((call) => Array.isArray(call) && call[0] === 'panel'),
|
|
false,
|
|
);
|
|
} finally {
|
|
f.cleanup();
|
|
}
|
|
});
|
|
|
|
test('destruction releases an active tuner pointer after revoking listeners', () => {
|
|
const f = fixture();
|
|
try {
|
|
const released = [];
|
|
f.controls._radioTunerSlider = {
|
|
releasePointerCapture(id) {
|
|
assert.equal(f.controls.listeners.signal.aborted, true);
|
|
released.push(id);
|
|
},
|
|
};
|
|
f.controls._radioTunerPointerId = 7;
|
|
f.controls._radioTunerDragging = true;
|
|
f.controls.destroy();
|
|
assert.deepEqual(released, [7]);
|
|
assert.equal(f.controls._radioTunerDragging, false);
|
|
assert.equal(f.controls._radioTunerPointerId, null);
|
|
} finally {
|
|
f.cleanup();
|
|
}
|
|
});
|