Files
gods-eye-view/scripts/qa-camera-controls.mjs
T
Said Turksever f29b0b2639 Keep the CCTV panel through Context isolation, and collapse through the panel chrome
Contacts and Space Missions switch CCTV off to isolate themselves and restore
it on the way out: the panel and its share preference now stay as they are for
that round trip, as they do for Clear selected data layers. The controls no
longer read the collapsed class before asking: the panel chrome tells a panel
the accordion folded from one whose saved state is closed.

The camera controls gate asserts the collapse, reopens CCTV from the right
rail before switching it back on, and runs a Contacts entry and exit with the
panel open.
2026-11-13 17:46:43 +00:00

492 lines
16 KiB
JavaScript

#!/usr/bin/env node
/** Camera-panel browser acceptance with controlled sources, images and terrain. */
import fs from 'node:fs';
import puppeteer from 'puppeteer';
const origin = process.env.QA_BASE_URL || 'http://localhost:4173';
const selectAllModifier = process.platform === 'darwin' ? 'Meta' : 'Control';
const sources = [
{
id: 'qa-camera-a',
name: 'QA Camera A',
lat: 30.2747,
lon: -97.7403,
headingDeg: 30,
},
{
id: 'qa-camera-b',
name: 'QA Camera B',
lat: 30.2672,
lon: -97.7431,
headingDeg: 200,
},
].map((camera) => ({
...camera,
city: 'Austin',
cityId: 'austin',
provider: 'QA camera fixture',
feedType: 'snapshot',
feedConfigured: true,
pitchDeg: -18,
fovDeg: 60,
rangeM: 300,
mountHeightM: 8,
}));
const browser = await puppeteer.launch({
headless: true,
args: [
'--no-sandbox',
...(process.platform === 'darwin'
? ['--use-angle=metal', '--enable-gpu']
: ['--use-gl=angle', '--use-angle=swiftshader']),
],
});
const page = await browser.newPage();
const errors = [];
page.on('pageerror', (error) => errors.push(error.message));
let failures = 0;
const check = (name, ok, detail) => {
console.log(
`[${ok ? 'PASS' : 'FAIL'}] ${name}${detail ? ` — ${JSON.stringify(detail)}` : ''}`,
);
if (!ok) failures++;
};
let delayCameraA = false;
const delayedFrames = new Set();
try {
await page.setViewport({ width: 1440, height: 900 });
await page.setRequestInterception(true);
page.on('request', (request) => {
const url = new URL(request.url());
if (url.origin !== new URL(origin).origin) return void request.continue();
const json = (body) =>
request.respond({
status: 200,
contentType: 'application/json',
body: JSON.stringify(body),
});
if (url.pathname === '/api/cctv/sources') return void json({ sources });
if (url.pathname === '/api/cctv/health')
return void json({
cameras: sources.map((camera) => ({
id: camera.id,
status: 'ok',
sourceKind: 'snapshot',
label: 'QA camera fixture',
})),
});
if (url.pathname.startsWith('/api/cctv/frame/')) {
const cameraA = url.pathname.endsWith('qa-camera-a');
const respond = () =>
request
.respond({
status: 200,
contentType: 'image/svg+xml',
headers: { 'Cache-Control': 'no-store' },
body: `<svg xmlns="http://www.w3.org/2000/svg" width="640" height="360"><rect width="640" height="360" fill="${cameraA ? '#16364d' : '#254b32'}"/><path d="M0 260L640 130M240 0L420 360" stroke="#97acb7" stroke-width="26"/><text x="30" y="55" fill="white" font-size="30">QA CAMERA ${cameraA ? 'A' : 'B'}</text></svg>`,
})
.catch(() => {});
if (cameraA && delayCameraA) delayedFrames.add(respond);
else void respond();
return;
}
if (url.pathname === '/api/terrain/heights') {
const points = (url.searchParams.get('points') || '')
.split(';')
.filter(Boolean);
return void json({
results: points.map((point) => {
const [lon, lat] = point.split(',').map(Number);
return { lon, lat, elevation: 0, geoid: 0, ellipsoid: 0 };
}),
});
}
if (url.pathname === '/api/openai/hud-summary')
return void json({ summary: 'QA camera controls' });
void request.continue();
});
await page.goto(`${origin}/?welcome=0`, { waitUntil: 'domcontentloaded' });
await page.waitForFunction(
() =>
window.__godsEyeView?.styleManager?._cctvControls &&
window.__godsEyeView?.dataManager?.layers?.has('cctv') &&
document.getElementById('loading-screen')?.classList.contains('hidden'),
{ timeout: 60000 },
);
await page.$eval('[data-collapse-target="cctv-panel"]', (button) =>
button.click(),
);
await page.click('#cctv-enable-btn');
await page.waitForFunction(
() =>
window.__godsEyeView.dataManager.layers.get('cctv').module.getUIState()
.cameras.length === 2 &&
!document.getElementById('cctv-camera-select').disabled,
{ timeout: 30000 },
);
check(
'CCTV enable uses the supplied two-camera catalog',
await page.$eval(
'#cctv-camera-select',
(select) => select.options.length === 2 && !select.disabled,
),
);
await page.select('#cctv-camera-select', 'qa-camera-a');
await page.waitForFunction(
() =>
document.getElementById('cctv-frame').dataset.cameraId ===
'qa-camera-a' &&
document
.getElementById('cctv-frame-wrap')
.classList.contains('has-frame'),
);
const state = () =>
page.evaluate(() =>
window.__godsEyeView.dataManager.layers.get('cctv').module.getUIState(),
);
check(
'selected camera, decoded preview and source label agree',
await page.evaluate(() => {
const camera = window.__godsEyeView.dataManager.layers
.get('cctv')
.module.getUIState().activeCamera;
return (
camera.id === 'qa-camera-a' &&
document.getElementById('cctv-frame').src.includes('qa-camera-a') &&
document
.getElementById('cctv-meta')
.textContent.includes('QA camera fixture')
);
}),
);
const coverage = (await state()).coverageMode;
const modes = [];
for (let i = 0; i < 3; i++) {
await page.click('#cctv-coverage-btn');
modes.push((await state()).coverageMode);
}
check(
'coverage cycles through all three modes and returns to its starting state',
new Set(modes).size === 3 && modes.at(-1) === coverage,
modes,
);
const projection = (await state()).showProjection;
await page.click('#cctv-projection-btn');
check(
'projection control updates the layer state',
(await state()).showProjection === !projection,
);
await page.click('#cctv-projection-btn');
await page.click('#cctv-next-btn');
await page.waitForFunction(
() =>
window.__godsEyeView.dataManager.layers.get('cctv').module.getUIState()
.activeCameraId === 'qa-camera-b',
);
await page.click('#cctv-prev-btn');
await page.waitForFunction(
() =>
window.__godsEyeView.dataManager.layers.get('cctv').module.getUIState()
.activeCameraId === 'qa-camera-a',
);
check(
'native Next and Previous return to the original camera',
(await state()).activeCameraId === 'qa-camera-a',
);
for (const [selector, key] of [
['#cctv-auto-hop-btn', 'autoHop'],
['#cctv-adjust-btn', 'calibrationMode'],
]) {
const before = (await state())[key];
await page.click(selector);
const changed = (await state())[key] === !before;
await page.click(selector);
check(
`${key} control changes and restores the layer setting`,
changed && (await state())[key] === before,
);
}
// Auto Hop can legitimately advance immediately; restore the calibration target.
await page.select('#cctv-camera-select', 'qa-camera-a');
await page.waitForFunction(
() =>
window.__godsEyeView.dataManager.layers.get('cctv').module.getUIState()
.activeCameraId === 'qa-camera-a',
);
const heading = (await state()).activeCamera.headingDeg;
const chip = '.cctv-cal-value[data-cal-field="heading"]';
await page.click(chip);
await page.focus(`${chip} input`);
await page.keyboard.down(selectAllModifier);
await page.keyboard.press('a');
await page.keyboard.up(selectAllModifier);
await page.keyboard.type(String(heading + 10));
await page.keyboard.press('Enter');
check(
'native calibration editing commits an offset for the selected camera',
Math.abs((await state()).activeCamera.headingDeg - (heading + 10)) < 0.01,
);
await page.click('#cctv-calib-save-btn');
check(
'Save persists the selected camera calibration',
await page.evaluate(() =>
Boolean(
JSON.parse(
localStorage.getItem('godsEyeView.cctv.calibration.v2') || '{}',
)['qa-camera-a'],
),
),
);
await page.click('#cctv-calib-reset-btn');
check(
'Reset restores the original pose',
Math.abs((await state()).activeCamera.headingDeg - heading) < 0.01,
);
await page.click(chip);
await page.focus(`${chip} input`);
await page.keyboard.down(selectAllModifier);
await page.keyboard.press('a');
await page.keyboard.up(selectAllModifier);
await page.keyboard.type('110');
await page.keyboard.press('Escape');
check(
'Escape cancels editing without collapsing CCTV',
(await page.evaluate(
() =>
!document.querySelector('.cctv-cal-input') &&
!document.getElementById('cctv-panel').classList.contains('collapsed'),
)) && Math.abs((await state()).activeCamera.headingDeg - heading) < 0.01,
);
await page.click(chip);
await page.evaluate(() => {
const input = document.querySelector('.cctv-cal-input');
input.value = '110';
window.__godsEyeView.dataManager.layers
.get('cctv')
.module.selectCamera('qa-camera-b');
input.dispatchEvent(new Event('blur'));
});
check(
'an external camera selection cancels the prior calibration editor',
(await state()).activeCamera.id === 'qa-camera-b' &&
Math.abs((await state()).activeCamera.headingDeg - 200) < 0.01 &&
(await page.$('.cctv-cal-input')) === null,
);
await page.waitForFunction(
() =>
document.getElementById('cctv-frame').dataset.cameraId ===
'qa-camera-b' &&
document
.getElementById('cctv-frame-wrap')
.classList.contains('has-frame'),
);
await page.setCacheEnabled(false);
delayCameraA = true;
await page.select('#cctv-camera-select', 'qa-camera-a');
await page.waitForFunction(
() =>
document.getElementById('cctv-frame').dataset.cameraId ===
'qa-camera-a' &&
document.getElementById('cctv-frame').dataset.loading === 'true',
);
await page.evaluate(() => {
const image =
window.__godsEyeView.styleManager._cctvControls._cctvFramePreloader;
window.__qaLateCctvImage = image;
window.__qaLateCctvImageLoaded = false;
image.addEventListener(
'load',
() => {
window.__qaLateCctvImageLoaded = true;
},
{ once: true },
);
});
check(
'a newly selected camera clears old pixels while its frame loads',
await page.$eval(
'#cctv-frame-wrap',
(element) => !element.classList.contains('has-frame'),
),
);
await page.select('#cctv-camera-select', 'qa-camera-b');
await page.waitForFunction(
() =>
document.getElementById('cctv-frame').dataset.cameraId ===
'qa-camera-b' &&
document
.getElementById('cctv-frame-wrap')
.classList.contains('has-frame'),
);
delayCameraA = false;
await Promise.all([...delayedFrames].map((respond) => respond()));
delayedFrames.clear();
await page.waitForFunction(() => window.__qaLateCctvImageLoaded);
check(
'late frames cannot overwrite the latest camera selection',
await page.$eval(
'#cctv-frame',
(image) =>
image.dataset.cameraId === 'qa-camera-b' &&
image.src.includes('qa-camera-b'),
),
);
delayCameraA = false;
await page.click('#cctv-enable-btn');
await page.waitForFunction(
() => !window.__godsEyeView.dataManager.isEnabled('cctv'),
);
const disabledCleanly = await page.$eval(
'#cctv-frame',
(image) => !image.getAttribute('src') && image.dataset.cameraId === '',
);
// The address bar follows the share state after a short delay: wait for the
// CCTV panel token (1 collapsed, 0 open) the step expects.
const panelState = async (expectedToken) => {
const settled = await page
.waitForFunction(
(token) =>
new RegExp(`(?:^|_)v\\.c\\.${token}(?:_|$)`).test(
new URLSearchParams(location.hash.slice(1)).get('ui') || '',
),
{ timeout: 5000 },
expectedToken,
)
.then(
() => true,
() => false,
);
return page.evaluate(
(shared) => ({
collapsed: document
.getElementById('cctv-panel')
.classList.contains('collapsed'),
shared,
ui: new URLSearchParams(location.hash.slice(1)).get('ui'),
}),
settled ? expectedToken : null,
);
};
const closedOnDisable = await panelState('1');
check(
'disable collapses the panel and its share preference',
closedOnDisable.collapsed && closedOnDisable.shared === '1',
JSON.stringify(closedOnDisable),
);
// The switch sits inside the collapsed panel: reopen it from the right rail.
await page.click('[data-rail-item="cctv-panel"]');
await page.waitForFunction(
() =>
!document.getElementById('cctv-panel').classList.contains('collapsed'),
);
await page.click('#cctv-enable-btn');
await page.waitForFunction(
() =>
window.__godsEyeView.dataManager.isEnabled('cctv') &&
document
.getElementById('cctv-frame-wrap')
.classList.contains('has-frame'),
);
check(
'disable clears the preview and re-enable reacquires the camera frame',
disabledCleanly,
);
// Contacts switches CCTV off to isolate itself and restores it on the way
// out: the open panel and its share preference survive the round trip.
const cameraBeforeContacts = await page.evaluate(
() =>
window.__godsEyeView.styleManager._cctvControls.getState()
?.activeCameraId,
);
const entered = await page.evaluate(() =>
window.__godsEyeView.styleManager.setContextMode('flights'),
);
await page.waitForFunction(
() => !window.__godsEyeView.dataManager.isEnabled('cctv'),
);
const duringContacts = await panelState('0');
await page.evaluate(() =>
window.__godsEyeView.styleManager.setContextMode(null),
);
await page.waitForFunction(() =>
window.__godsEyeView.dataManager.isEnabled('cctv'),
);
const afterContacts = await panelState('0');
check(
'Contacts isolation keeps the open CCTV panel and restores its camera',
entered?.ok === true &&
!duringContacts.collapsed &&
duringContacts.shared === '0' &&
!afterContacts.collapsed &&
afterContacts.shared === '0' &&
(await page.evaluate(
(cameraId) =>
window.__godsEyeView.styleManager._cctvControls.getState()
?.activeCameraId === cameraId,
cameraBeforeContacts,
)),
JSON.stringify({ entered, duringContacts, afterContacts }),
);
await page.$eval('#cctv-frame', (image) =>
image.scrollIntoView({ block: 'nearest' }),
);
fs.mkdirSync('qa-shots/camera-controls', { recursive: true });
await page.screenshot({ path: 'qa-shots/camera-controls/desktop.png' });
await page.evaluate(() => {
const camera = window.__godsEyeView.viewer.camera;
camera.setView({
orientation: {
heading: camera.heading + Math.PI / 3,
pitch: -0.6,
roll: 0,
},
});
});
await new Promise((resolve) => setTimeout(resolve, 700));
await page.screenshot({ path: 'qa-shots/camera-controls/angle.png' });
await page.setViewport({ width: 390, height: 844 });
await new Promise((resolve) => setTimeout(resolve, 700));
// Phones present CCTV in the Cameras tab's sheet.
await page.click('#mobile-tab-bar [data-mobile-sheet="cameras"]');
await new Promise((resolve) => setTimeout(resolve, 400));
await page.screenshot({ path: 'qa-shots/camera-controls/narrow.png' });
check(
'narrow camera panel remains within the viewport',
await page.$eval('#cctv-panel', (panel) => {
const rect = panel.getBoundingClientRect();
return rect.width > 0 && rect.left >= 0 && rect.right <= innerWidth + 1;
}),
);
check(
'rebuilding Radio preserves the active camera controller and subscription',
await page.evaluate(() => {
const ui = window.__godsEyeView.styleManager;
const camera = ui._cctvControls;
const cameraId = camera.getState()?.activeCameraId;
ui._initRadioPanel();
ui._radioControls.connect();
return (
ui._cctvControls === camera &&
!camera.destroyed &&
Boolean(camera._cctvUnsubscribe) &&
camera.getState()?.activeCameraId === cameraId
);
}),
);
await page.evaluate(() => window.__godsEyeView.styleManager.dispose());
check(
'CCTV controller is destroyed with the real UI',
await page.evaluate(
() => window.__godsEyeView.styleManager._cctvControls.destroyed,
),
);
check(
'camera controls produce no uncaught browser errors',
errors.length === 0,
errors,
);
} finally {
await Promise.all([...delayedFrames].map((respond) => respond()));
await browser.close();
}
if (failures) process.exitCode = 1;