mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-04 18:34:02 +00:00
quanticsoul4772andSameh Khamis
1c234ce027
Read OpenSky OAuth credentials from OPENSKY_CREDENTIALS_FILE and stop sending retired Basic authentication. Update setup diagnostics and guidance. Keep credential-file warnings free of parser excerpts and filesystem error details, cover both failure paths with a regression test, and use a launcher-compatible absolute path example. Original contribution by quanticsoul4772, with credential-warning and documentation follow-up by Sameh Khamis. Co-authored-by: quanticsoul4772 <[email protected]> Co-authored-by: Sameh Khamis <[email protected]>
82 lines
2.8 KiB
JavaScript
82 lines
2.8 KiB
JavaScript
import test from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import os from 'node:os';
|
|
import path from 'node:path';
|
|
import { openSkyClientCredentials } from './opensky.js';
|
|
|
|
const file = (contents) => (filePath) => {
|
|
file.read = filePath;
|
|
if (contents instanceof Error) throw contents;
|
|
return contents;
|
|
};
|
|
|
|
test('OpenSky client env vars come first', () => {
|
|
const read = () => assert.fail('the file is not read when env vars are set');
|
|
assert.deepEqual(
|
|
openSkyClientCredentials(
|
|
{
|
|
OPENSKY_CLIENT_ID: ' id ',
|
|
OPENSKY_CLIENT_SECRET: 'secret',
|
|
OPENSKY_CREDENTIALS_FILE: 'credentials.json',
|
|
},
|
|
read,
|
|
),
|
|
{ clientId: 'id', clientSecret: 'secret' },
|
|
);
|
|
});
|
|
|
|
test('OPENSKY_CREDENTIALS_FILE supplies the client when env vars are empty', () => {
|
|
const env = {
|
|
OPENSKY_CLIENT_ID: '',
|
|
OPENSKY_CREDENTIALS_FILE: '~/Downloads/credentials.json',
|
|
};
|
|
// The file OpenSky's account page downloads uses camelCase keys.
|
|
assert.deepEqual(
|
|
openSkyClientCredentials(
|
|
env,
|
|
file('{"clientId":"cid","clientSecret":"csecret"}'),
|
|
),
|
|
{ clientId: 'cid', clientSecret: 'csecret' },
|
|
);
|
|
assert.equal(
|
|
path.normalize(file.read),
|
|
path.normalize(path.join(os.homedir(), 'Downloads/credentials.json')),
|
|
);
|
|
assert.deepEqual(
|
|
openSkyClientCredentials(
|
|
env,
|
|
file('{"client_id":"cid","client_secret":"csecret"}'),
|
|
),
|
|
{ clientId: 'cid', clientSecret: 'csecret' },
|
|
);
|
|
});
|
|
|
|
test('a missing, unreadable or incomplete credentials file means no client', () => {
|
|
assert.equal(openSkyClientCredentials({}, file('{}')), null);
|
|
const env = { OPENSKY_CREDENTIALS_FILE: 'credentials.json' };
|
|
const missing = Object.assign(new Error('nope'), { code: 'ENOENT' });
|
|
assert.equal(openSkyClientCredentials(env, file(missing)), null);
|
|
assert.equal(openSkyClientCredentials(env, file('not json')), null);
|
|
assert.equal(openSkyClientCredentials(env, file('{"clientId":"cid"}')), null);
|
|
});
|
|
|
|
test('credential file warnings never expose file contents or read errors', async (t) => {
|
|
const warnings = [];
|
|
t.mock.method(console, 'warn', (message) => warnings.push(message));
|
|
for (const contents of [
|
|
'{"clientId":"id","clientSecret":FAKE_SECRET_123}',
|
|
new Error('could not read FAKE_SECRET_123'),
|
|
]) {
|
|
const { openSkyClientCredentials: resolve } = await import(
|
|
`./opensky.js?warning=${warnings.length}`
|
|
);
|
|
const env = { OPENSKY_CREDENTIALS_FILE: '/synthetic/credentials.json' };
|
|
assert.equal(resolve(env, file(contents)), null);
|
|
assert.equal(resolve(env, file(contents)), null);
|
|
}
|
|
assert.deepEqual(warnings, [
|
|
'[OpenSky] OPENSKY_CREDENTIALS_FILE could not be read or parsed as JSON.',
|
|
'[OpenSky] OPENSKY_CREDENTIALS_FILE could not be read or parsed as JSON.',
|
|
]);
|
|
});
|