mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-04 02:14:01 +00:00
Sameh Khamis
eed7657516
A panel a feature opens (Street Level's viewer, a selected radio station) now becomes its side's open panel instead of being collapsed again by the next layout pass. Cockpit keeps showing its collapsed Data Layers strip, which Cyber's Cockpit layout aligns to, and Cyber's focus layout no longer re-shows collapsed left panels. Both sidebars share one accordion helper.
73 lines
2.9 KiB
JavaScript
73 lines
2.9 KiB
JavaScript
import { readStylesheet } from './testSupport/readStylesheet.mjs';
|
|
import assert from 'node:assert/strict';
|
|
import { readFileSync } from 'node:fs';
|
|
import test from 'node:test';
|
|
import { shouldExpandGlobalContextPanel } from './rightRailPolicy.js';
|
|
|
|
test('desktop side rails hide collapsed panels in every HUD layout, never on phones or beside Cockpit', () => {
|
|
const right = readFileSync(new URL('./ui/rightPanelRail.js', import.meta.url), 'utf8');
|
|
const left = readFileSync(new URL('./ui/leftPanelRail.js', import.meta.url), 'utf8');
|
|
const css = readStylesheet(new URL('../style.css', import.meta.url));
|
|
for (const ui of [right, left]) {
|
|
assert.match(ui, /const isMobile = windowRef\.matchMedia\('\(max-width: 720px\)'\)\.matches/);
|
|
assert.match(ui, /if \(exclusive && panel\.classList\.contains\('collapsed'\)\)\s*panel\.setAttribute\('aria-hidden', 'true'\)/);
|
|
assert.doesNotMatch(ui, /hud\.variant === 'cyber'/);
|
|
}
|
|
assert.match(right, /const exclusive = !isMobile;/);
|
|
// Cockpit keeps its collapsed Data Layers strip, which its layout aligns to.
|
|
assert.match(
|
|
left,
|
|
/const exclusive =\s*!isMobile && !documentRef\?\.body\?\.classList\?\.contains\('cockpit-mode'\);/,
|
|
);
|
|
assert.match(css, /#right-context-rail\.layout-exclusive > \[data-panel-id\]\.collapsed \{/);
|
|
assert.match(css, /#left-panel-stack\.layout-exclusive > \[data-panel-id\]\.collapsed \{/);
|
|
});
|
|
|
|
test('explicit Contacts, Space Missions, and Cockpit actions expand Global Context after success', () => {
|
|
for (const action of ['contacts', 'space-missions', 'cockpit']) {
|
|
assert.equal(shouldExpandGlobalContextPanel({
|
|
action,
|
|
explicitUserAction: true,
|
|
succeeded: true,
|
|
}), true, `${action} should reveal its supporting context`);
|
|
}
|
|
});
|
|
|
|
test('Cockpit expansion is independent of whether a track was already selected', () => {
|
|
for (const selectedTrack of [null, 'UAL649']) {
|
|
assert.equal(shouldExpandGlobalContextPanel({
|
|
action: 'cockpit',
|
|
explicitUserAction: true,
|
|
succeeded: true,
|
|
selectedTrack,
|
|
}), true);
|
|
}
|
|
});
|
|
|
|
test('restoration and programmatic replay preserve the saved Global Context collapse state', () => {
|
|
assert.equal(shouldExpandGlobalContextPanel({
|
|
action: 'contacts',
|
|
explicitUserAction: false,
|
|
succeeded: true,
|
|
}), false);
|
|
assert.equal(shouldExpandGlobalContextPanel({
|
|
action: 'space-missions',
|
|
explicitUserAction: true,
|
|
succeeded: true,
|
|
restoring: true,
|
|
}), false);
|
|
});
|
|
|
|
test('failed or unrelated actions never expand Global Context', () => {
|
|
assert.equal(shouldExpandGlobalContextPanel({
|
|
action: 'contacts',
|
|
explicitUserAction: true,
|
|
succeeded: false,
|
|
}), false, 'a failed transition must preserve the prior panel state for rollback');
|
|
assert.equal(shouldExpandGlobalContextPanel({
|
|
action: 'search-nearby',
|
|
explicitUserAction: true,
|
|
succeeded: true,
|
|
}), false);
|
|
});
|