mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-04 18:34:02 +00:00
Said TurkseverandClaude Opus 5.5
b1efd22f02
- One provider is lit at a time: lighting a chip darkens the others, and a chip click records every registered provider's switch in one update so the share link keeps the swap (also off Google 3D, where Street View is not listed). The layer starts with the first default-on provider (Mapillary, free); params that light several keep the one already on, so reapplying them never flips (litByParams). The now-unreachable "several lit" chip paths are gone. - Leaving Google 3D during a Street View lookup ends it without an error or a stuck loading state (openImage's early return resets it; the lookup loop rechecks availability). - A source swap during a lookup no longer reports "no imagery". - Street View lit off Google 3D says the panel needs the Google 3D map. - Comments trimmed to the why; keySetupCore.test.mjs back to upstream's formatting plus the one new test (was a 551-line reformat). Co-Authored-By: Claude Opus 5.5 <[email protected]>
57 lines
1.9 KiB
JavaScript
57 lines
1.9 KiB
JavaScript
import * as Cesium from 'cesium';
|
|
import { GROUND_CLICK_MAX_HEIGHT_M } from './policy.js';
|
|
import { cameraHeightAboveGround } from './view.js';
|
|
|
|
/** Whether the camera is low enough for a click on the ground to mean a street. */
|
|
export function groundClickHeightOk(viewer, groundAt) {
|
|
if (!viewer?.camera?.positionCartographic) return false;
|
|
return (
|
|
cameraHeightAboveGround(viewer, { groundAt }) <= GROUND_CLICK_MAX_HEIGHT_M
|
|
);
|
|
}
|
|
|
|
/**
|
|
* A click on the map itself at street zoom opens the nearest image of the
|
|
* active `groundClick` providers, without moving the camera. The height is
|
|
* measured at the click, not read from the cached flag.
|
|
* @param {{state: object, openNearest: Function, isAvailable: (entry: object) => boolean, groundAt?: Function}} options
|
|
* @returns {(screenPosition: {x: number, y: number}, picked?: object) => Promise<boolean>|false}
|
|
*/
|
|
export function createGroundClick({
|
|
state,
|
|
openNearest,
|
|
isAvailable,
|
|
groundAt = null,
|
|
}) {
|
|
return function openAtGround(screenPosition, picked) {
|
|
const scenePick = state.services.scenePick;
|
|
if (!state.enabled || !state.viewer || !scenePick?.pickGroundPosition)
|
|
return false;
|
|
if (
|
|
!scenePick.isSurfacePick(picked) ||
|
|
!groundClickHeightOk(state.viewer, groundAt)
|
|
)
|
|
return false;
|
|
const providerIds = [...state.providers.values()]
|
|
.filter(
|
|
(entry) =>
|
|
entry.on &&
|
|
entry.def.groundClick &&
|
|
entry.status?.configured &&
|
|
isAvailable(entry),
|
|
)
|
|
.map((entry) => entry.def.id);
|
|
if (!providerIds.length) return false;
|
|
const position = scenePick.pickGroundPosition(state.viewer, screenPosition);
|
|
const carto = position && Cesium.Cartographic.fromCartesian(position);
|
|
if (!carto) return false;
|
|
return openNearest(
|
|
{
|
|
lon: Cesium.Math.toDegrees(carto.longitude),
|
|
lat: Cesium.Math.toDegrees(carto.latitude),
|
|
},
|
|
{ providerIds, frame: false },
|
|
);
|
|
};
|
|
}
|