Files
gods-eye-view/src/ui/creditsView.test.mjs
T
Sameh Khamis a7fe3eebc6 Credits keep their linked words: only the words a source linked are the link
A credit read from markup keeps the first link's own words as linkText, and the Cesium credit display and the credit line link just those words, as the source wrote them (Street Level's "© Mapillary contributors" links Mapillary only). The Street Level gate reads a drawn item's pick id from its draw-set id.
2026-11-15 20:12:14 -08:00

155 lines
5.6 KiB
JavaScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
import '../testSupport/registerDom.mjs';
import test from 'node:test';
import assert from 'node:assert/strict';
import { mountCreditsView } from './creditsView.js';
import { bindRenderer } from '../render/rendererOf.js';
import { createStubRenderer } from '../render/stub/index.js';
function scene() {
document.body.replaceChildren();
const renderer = createStubRenderer();
const viewer = {};
bindRenderer(viewer, renderer);
return { viewer, renderer };
}
test("the renderer's credits show on the line, and the rest in the list it opens", () => {
const { viewer, renderer } = scene();
renderer.credits.addStatic({
text: 'Google',
href: 'https://maps.google.com',
inline: true,
});
const off = mountCreditsView(viewer);
const line = document.querySelector('#gev-credits .gev-credits-line');
assert.equal(line.textContent, 'Google');
assert.equal(line.querySelector('a').href, 'https://maps.google.com/');
const expand = document.querySelector('.gev-credits-expand');
assert.equal(expand.hidden, true, 'nothing to list yet');
const remove = renderer.credits.addStatic({ text: 'Wildlife: iNaturalist' });
renderer.credits.addStatic({ text: 'Wildlife: iNaturalist' });
renderer.credits.addStatic({ text: 'OSM', href: 'javascript:alert(1)' });
assert.equal(expand.hidden, false);
assert.equal(expand.textContent, 'Data attribution');
const panel = document.getElementById('gev-credits-panel');
assert.equal(panel.hidden, true);
expand.click();
assert.equal(panel.hidden, false);
assert.equal(expand.getAttribute('aria-expanded'), 'true');
const items = [...panel.querySelectorAll('li')].map((li) => li.textContent);
assert.deepEqual(items, ['Wildlife: iNaturalist', 'OSM'], 'once each');
assert.equal(panel.querySelector('li:last-child a'), null, 'unsafe link');
panel.dispatchEvent(
new KeyboardEvent('keydown', { key: 'Escape', bubbles: true }),
);
assert.equal(panel.hidden, true);
assert.equal(document.activeElement, expand, 'focus goes back');
remove();
assert.equal(
[...panel.querySelectorAll('li')].length,
2,
'a duplicate still credits it',
);
off();
assert.equal(document.getElementById('gev-credits'), null);
assert.equal(document.getElementById('gev-credits-panel'), null);
});
test('a credit with a logo is drawn as the logo, named by its text', () => {
const { viewer, renderer } = scene();
renderer.credits.addStatic({
text: 'Google',
logoUrl: 'https://example.com/logo.png',
inline: true,
});
const off = mountCreditsView(viewer);
const credit = document.querySelector('#gev-credits .gev-credit');
const logo = credit.querySelector('img');
assert.equal(logo.src, 'https://example.com/logo.png');
assert.equal(logo.alt, 'Google', 'screen readers and copies keep the name');
assert.equal(credit.textContent, '', 'the logo stands in place of the text');
off();
});
test('a viewer with no renderer shows no credits line', () => {
document.body.replaceChildren();
const off = mountCreditsView({});
assert.equal(document.getElementById('gev-credits'), null);
off();
});
test('the credits line is placed wherever the renderer’s own display is', async () => {
const { readFileSync, readdirSync } = await import('node:fs');
const dir = new URL('./styles/', import.meta.url);
const missing = [];
for (const name of readdirSync(dir).filter((f) => f.endsWith('.css'))) {
const css = readFileSync(new URL(name, dir), 'utf8').replace(
/\/\*[\s\S]*?\*\//g,
'',
);
const parts = [...css.matchAll(/([^{};]+)\{/g)]
.map((match) => match[1].replace(/\s+/g, ' ').trim())
.filter((selector) => !selector.startsWith('@'))
.flatMap((selector) =>
selector.split(/,(?![^(]*\))/).map((part) => part.trim()),
);
// The display's own selectors, without its inner parts, each with the
// line's counterpart in the same stylesheet.
for (const part of parts)
if (
/#cesium-credits$/.test(part) &&
!parts.includes(part.replace('#cesium-credits', '#gev-credits'))
)
missing.push(`${name}: ${part}`);
}
assert.deepEqual(missing, []);
});
test('focus in the list stays in it as it redraws, and goes to the line as it empties', () => {
const { viewer, renderer } = scene();
renderer.credits.addStatic({ text: 'Esri', inline: true });
const remove = renderer.credits.addStatic({
text: 'OSM',
href: 'https://www.openstreetmap.org/copyright',
});
const off = mountCreditsView(viewer);
const panel = document.getElementById('gev-credits-panel');
document.querySelector('.gev-credits-expand').click();
panel.querySelector('li a').focus();
const removeOther = renderer.credits.addStatic({ text: 'NOAA' });
assert.equal(panel.hidden, false);
assert.ok(panel.contains(document.activeElement), 'still in the list');
remove();
removeOther();
assert.equal(panel.hidden, true);
assert.equal(
document.activeElement,
document.getElementById('gev-credits'),
'a line with no link takes it',
);
off();
});
test('a credit with linked words links only those words', () => {
const { viewer, renderer } = scene();
renderer.credits.addStatic({
text: 'Street Level: imagery © Mapillary contributors, CC BY-SA 4.0',
href: 'https://www.mapillary.com/',
linkText: 'Mapillary',
inline: true,
});
const off = mountCreditsView(viewer);
const credit = document.querySelector('#gev-credits .gev-credit');
const link = credit.querySelector('a');
assert.equal(link.textContent, 'Mapillary');
assert.equal(link.href, 'https://www.mapillary.com/');
assert.equal(
credit.textContent,
'Street Level: imagery © Mapillary contributors, CC BY-SA 4.0',
);
off();
});