mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
Review fixes for gekh's #1113 round: - a link runs show_street_level with origin 'programmatic', so its source switch and layer are not saved as the recipient's preferences; - with no place named, the action looks under the screen centre (aim 'screen-centre', armed false), keeps the sky refusal and leaves a link's armed point alone; - an armed OPEN aimed at the sky opens nothing instead of the far link point; - an imagery-stage failure is spoken as an error, missing imagery as missing (street.nearestOutcome); the card says "the view centre" in the interface language; - every photo the action opens reveals its panel, and revealPanel scrolls the panel into view in the phone sheet; - embed: EXPAND survives embed's own clean view, the lifted photo hides in cockpit, recording and scene playback, and a failed photo step closes the earlier photo before the view flies; - links pasted into an open tab run their street-level step after the restore settles; a superseded start link does not; - Mapillary's nearest search gives up after 12 s, body included.
141 lines
5.3 KiB
JavaScript
141 lines
5.3 KiB
JavaScript
import assert from 'node:assert/strict';
|
|
import fs from 'node:fs';
|
|
import path from 'node:path';
|
|
import test from 'node:test';
|
|
import { fileURLToPath } from 'node:url';
|
|
import { renderApplicationHtml } from './testSupport/applicationHtml.mjs';
|
|
import { readStylesheet } from './testSupport/readStylesheet.mjs';
|
|
|
|
const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
|
|
const read = (file) => fs.readFileSync(path.join(ROOT, file), 'utf8');
|
|
|
|
const html = await renderApplicationHtml(read('index.html'));
|
|
const css = readStylesheet(path.join(ROOT, 'style.css'));
|
|
const panelCss = read('src/ui/styles/street-level.css');
|
|
const panelChrome = read('src/ui/panelChrome.js');
|
|
const layoutController = read('src/ui/panelLayoutController.js');
|
|
|
|
test('Street Level is a collapsible right-rail panel that starts collapsed', () => {
|
|
assert.match(
|
|
html,
|
|
/<div id="street-level-panel" class="ui-panel panel-collapsible collapsed" data-panel-id="street-level-panel">/,
|
|
);
|
|
assert.match(
|
|
html,
|
|
/<button type="button" class="[^"]*\bpanel-collapse-btn\b[^"]*"[^>]*data-collapse-target="street-level-panel"/,
|
|
);
|
|
assert.match(
|
|
html,
|
|
/<span class="ui-panel__title panel-title">STREET LEVEL<\/span>/,
|
|
);
|
|
// Provider-neutral header: no vendor mark; the inner restores its scroll.
|
|
assert.doesNotMatch(html, /sl-mark|mly-mark/);
|
|
assert.match(
|
|
html,
|
|
/<div class="street-level-panel-inner ui-scroll" data-rail-scroller>/,
|
|
);
|
|
assert.doesNotMatch(
|
|
html,
|
|
/mapillary-dock|sl-minimized|sl-3d-btn|sl-photoreal-btn/,
|
|
);
|
|
});
|
|
|
|
test('the panel is registered with panel chrome, cockpit entry and the right rail', () => {
|
|
assert.match(panelChrome, /\{ id: 'street-level-panel' \}/);
|
|
assert.match(
|
|
panelChrome,
|
|
/COCKPIT_ENTRY_COLLAPSE_PANEL_IDS = Object\.freeze\(\[[\s\S]*'street-level-panel'/,
|
|
);
|
|
// A right-rail panel's collapse button opens sideways (◀ / ▶).
|
|
assert.match(
|
|
read('src/ui/views/panels/StreetLevelPanel.vue'),
|
|
/<RailPanel id="street-level-panel"[^>]*\bsideways\b/,
|
|
);
|
|
assert.match(
|
|
layoutController,
|
|
/for \(const panel of \[[\s\S]*?this\._streetLevelPanel,[\s\S]*?\]\) \{[\s\S]*?stack\.insertBefore\(panel, globalContextPanel\)/,
|
|
);
|
|
assert.ok(css.includes('#right-context-rail > #street-level-panel'));
|
|
});
|
|
|
|
test('the key gate holds every filter, with the error line outside it', () => {
|
|
const start = html.indexOf('<fieldset id="sl-controls"');
|
|
assert.ok(start > 0);
|
|
const gate = html.slice(start, html.indexOf('</fieldset>', start));
|
|
assert.match(gate, /data-sl-pano="all"/);
|
|
assert.match(gate, /id="sl-since"/);
|
|
assert.ok(html.indexOf('id="sl-error"') < start);
|
|
// The chips stay outside the gate, so their key tooltip is reachable.
|
|
assert.match(html, /<div id="sl-provider-chips" class="sl-chips"><\/div>/);
|
|
assert.doesNotMatch(gate, /sl-provider-chips/);
|
|
assert.match(html, /id="sl-error"[^>]*role="alert"/);
|
|
});
|
|
|
|
test('each radiogroup is one tab stop, on its checked button', () => {
|
|
for (const [group, checked] of [
|
|
['data-sl-render', 'letterbox'],
|
|
['data-sl-pano', 'all'],
|
|
]) {
|
|
const radios = [
|
|
...html.matchAll(
|
|
new RegExp(`<button [^>]*${group}="([a-z]+)"[^>]*>`, 'g'),
|
|
),
|
|
];
|
|
assert.ok(radios.length >= 2, group);
|
|
for (const [tag, value] of radios)
|
|
assert.equal(
|
|
/tabindex="-1"/.test(tag),
|
|
value !== checked,
|
|
`${group}="${value}" roving tab stop`,
|
|
);
|
|
}
|
|
});
|
|
|
|
test('the Cyber theme frames the Street Level panel like its rail peers (P3)', () => {
|
|
const cyber = read('src/ui/styles/cyber.css');
|
|
const inner = (cyber.match(/\.recent-imagery-panel-inner,/g) || []).length;
|
|
const panel = (cyber.match(/#recent-imagery-panel,/g) || []).length;
|
|
assert.ok(inner > 0 && panel > 0);
|
|
assert.equal(
|
|
(cyber.match(/\.street-level-panel-inner,/g) || []).length,
|
|
inner,
|
|
);
|
|
assert.equal((cyber.match(/#street-level-panel,/g) || []).length, panel);
|
|
// A theme header rule must be able to outrank the panel's own.
|
|
assert.doesNotMatch(panelCss, /#street-level-panel \.panel-header/);
|
|
});
|
|
|
|
test('OPEN STREET VIEW keeps its width beside a long coverage line', () => {
|
|
// .scene-btn grows and shrinks (flex: 1) and loads after this stylesheet:
|
|
// only a more specific rule keeps the button from being squeezed.
|
|
assert.match(css, /\.scene-btn \{[^}]*flex: 1;/);
|
|
assert.match(
|
|
panelCss,
|
|
/\.sl-meta-row \.sl-nearest-btn \{\s*flex: 0 0 auto;\s*\}/,
|
|
);
|
|
assert.match(panelCss, /\.sl-meta-row \.sl-meta \{[^}]*min-width: 0;/);
|
|
});
|
|
|
|
test('embed mode shows an open photo over the globe, filling the overlay', () => {
|
|
const overlay = css.match(
|
|
/body\.ui-embed \.sl-viewer-wrap-embed \{([^}]*)\}/,
|
|
);
|
|
assert.ok(overlay, 'embed styles the viewer it moves over the globe');
|
|
for (const rule of ['position: fixed', 'inset: 12px', 'z-index: 1000'])
|
|
assert.ok(overlay[1].includes(rule), rule);
|
|
// Cockpit, recording and scene playback own the screen: the photo hides.
|
|
for (const mode of ['cockpit-mode', 'recording-mode', 'scene-playback-mode'])
|
|
assert.match(
|
|
css,
|
|
new RegExp(
|
|
`body\\.ui-embed\\.${mode} \\.sl-viewer-wrap-embed[^{]*\\{[^}]*display: none`,
|
|
),
|
|
mode,
|
|
);
|
|
// The photo takes the overlay's height, as it does full screen.
|
|
assert.match(
|
|
css,
|
|
/body\.ui-embed \.sl-viewer-wrap-embed \.sl-viewer \{[^}]*flex: 1 1 auto/,
|
|
);
|
|
});
|