mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-04 10:24:02 +00:00
Tom-NeverwinterandClaude Opus 5
56d52e284f
`qa:map-source-tray` failed on a clean checkout at "Enter opens the tray and hands focus to a Map Source tile". The gate was right: this is a real keyboard-accessibility bug, not a flaky assertion. Opening the tray schedules the focus hand-off to a Map Source tile 240ms later (scheduleMapSourceFocus). The tray itself fades in behind a 180ms `visibility` transition on .dock-popover-content, and a chip inside it cannot take focus until that transition lands. Those two timers race. When the machine is slow enough that the fade has not finished at the 240ms mark, `chip.focus()` is called on a `visibility: hidden` element — which is a SILENT no-op — and nothing retries. The tray sits open with keyboard focus stranded on the disclosure, unreachable. Instrumenting HTMLElement.prototype.focus during a failing run showed exactly that: focus() called once on the photoreal chip, the chip connected and not disabled, computed visibility `hidden`, activeElement unchanged. Fix the hand-off rather than the delay: - focusMapSource now reports whether focus actually landed (activeElement === chip) instead of assuming .focus() worked. - scheduleMapSourceFocus retries on a 30ms cadence until it lands, bounded to ~720ms past the first attempt so a permanently hidden tray cannot spin. Also stop the QA gate racing the same timers. Its keyboard checks slept a fixed 300ms and asserted focus had already moved; they now wait on controller truth (aria-expanded plus where focus landed), the way the Bing-switch check already did. That replaces four fixed sleeps, not just the long-Enter-hold one the issue named. The wait only settles state — the check() below each one is still the assertion, so a swallowed timeout surfaces as that check failing with real values rather than an opaque puppeteer error. Verified against a preview build: `qa:map-source-tray` goes from 3 failures to 20/20 passing, twice in a row. Unit suite unchanged (2674 passing). The #44 half of the original work is intentionally dropped: upstream's track-regression.mjs already fixed the ground-3d sampleHeight floor, and more thoroughly — it pins no absolute call count at all and adds a guard against a timed-out driver falsely looking flat. Closes #54. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01Q6VRsPswjNtZfv4jzgkCUf