mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-20 10:12:18 +00:00
- Without opencc-js the zh-Hant check says to run npm ci, and the other
checks still run.
- --prune handles zh-CN before zh-Hant: shippedLocales() sorts, since
git lists untracked catalogs first.
- A key missing from zh-Hant is reported once, with "run npm run i18n --
--zh-hant" when zh-CN has it; a zh-Hant entry still in English points
to zh-CN and same-as-english.json.
- 並道 -> 併道 applies only to entries whose English key says merge, so
并 (and) before 道路 or 道謝 stays 並.
- Two more corrections for strings main has added: 箇中 -> 個中 after a
count (全部 {n} 個中), and 宣佈 -> 宣布 like 發佈 and 公佈.
- zh-hant-cli.test.mjs runs the command in a throwaway repository, with
opencc-js linked as a junction, so Windows needs no symlink privilege.
zh-Hant.json does not change.
400 lines
14 KiB
JavaScript
400 lines
14 KiB
JavaScript
import { test } from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
|
|
import {
|
|
checkCatalog,
|
|
checkZhHant,
|
|
extractMessages,
|
|
findUnmarked,
|
|
markedTemplate,
|
|
readCatalog,
|
|
shippedLocales,
|
|
toZhHant,
|
|
unmarkedMarkup,
|
|
unmarkedScript,
|
|
zhHantCatalog,
|
|
} from '../../scripts/i18n.mjs';
|
|
import { LOCALES } from './locale.js';
|
|
|
|
const messages = extractMessages();
|
|
|
|
test('every catalog file is a shipped locale and every non-English locale has a catalog', () => {
|
|
assert.deepEqual(
|
|
shippedLocales().sort(),
|
|
LOCALES.filter((locale) => locale !== 'en').sort(),
|
|
);
|
|
});
|
|
|
|
for (const locale of shippedLocales()) {
|
|
test(`${locale} catalog matches the code (npm run i18n)`, () => {
|
|
const { missing, stale, errors } = checkCatalog(
|
|
locale,
|
|
readCatalog(locale),
|
|
messages,
|
|
);
|
|
assert.deepEqual(
|
|
{ missing, stale, errors },
|
|
{ missing: [], stale: [], errors: [] },
|
|
);
|
|
});
|
|
}
|
|
|
|
test('zh-Hant is zh-CN converted to Traditional characters (npm run i18n -- --zh-hant)', () => {
|
|
assert.deepEqual(
|
|
checkZhHant(readCatalog('zh-CN'), readCatalog('zh-Hant')),
|
|
[],
|
|
);
|
|
});
|
|
|
|
test('toZhHant converts characters, not vocabulary, and fixes what s2tw picks wrongly', () => {
|
|
// s2twp would write 影片, 伺服器 and 載入; zh-Hant keeps the zh-CN words.
|
|
assert.equal(toZhHant('视频'), '視頻');
|
|
assert.equal(toZhHant('服务器'), '服務器');
|
|
assert.equal(toZhHant('加载'), '加載');
|
|
assert.equal(toZhHant('50 年历史'), '50 年歷史');
|
|
assert.equal(toZhHant('发布于 {date}'), '發布於 {date}');
|
|
assert.equal(toZhHant('1 周/秒'), '1 週/秒');
|
|
assert.equal(toZhHant('已宣布紧急情况'), '已宣布緊急情況');
|
|
assert.equal(toZhHant('全部 {n} 个中'), '全部 {n} 個中');
|
|
// 併道 only where the English key is about merging.
|
|
assert.equal(toZhHant('前方并道路段', 'Merge ahead'), '前方併道路段');
|
|
assert.equal(
|
|
toZhHant('事故并道路封闭', 'Crash, road closed'),
|
|
'事故並道路封閉',
|
|
);
|
|
assert.equal(toZhHant('挥手并道谢', 'Waved and thanked'), '揮手並道謝');
|
|
assert.deepEqual(
|
|
zhHantCatalog({
|
|
'Merge {direction} onto {road}': '{direction}并道,进入 {road}',
|
|
'maneuver|Merge': '并道',
|
|
'Closed and apologized': '已关闭并道歉',
|
|
}),
|
|
{
|
|
'Merge {direction} onto {road}': '{direction}併道,進入 {road}',
|
|
'maneuver|Merge': '併道',
|
|
'Closed and apologized': '已關閉並道歉',
|
|
},
|
|
);
|
|
});
|
|
|
|
test('checkZhHant names each entry that is not the conversion of zh-CN', () => {
|
|
const zhCN = {
|
|
Video: '视频',
|
|
Server: '服务器',
|
|
'{count} ships': { other: '{count} 艘船' },
|
|
};
|
|
const generated = zhHantCatalog(zhCN);
|
|
assert.deepEqual(generated, {
|
|
Video: '視頻',
|
|
Server: '服務器',
|
|
'{count} ships': { other: '{count} 艘船' },
|
|
});
|
|
assert.deepEqual(checkZhHant(zhCN, generated), []);
|
|
|
|
const fix =
|
|
'zh-Hant is generated: edit zh-CN, then run npm run i18n -- --zh-hant';
|
|
const { Server, ...withoutServer } = generated;
|
|
assert.deepEqual(
|
|
checkZhHant(zhCN, {
|
|
...withoutServer,
|
|
Video: '影片',
|
|
'{count} ships': { other: '{count} 艘船隻' },
|
|
Extra: '多餘',
|
|
}),
|
|
[
|
|
`"Video" is "影片", not zh-CN converted ("視頻"). ${fix}`,
|
|
`"Server" is in zh-CN but not here. ${fix}`,
|
|
`"{count} ships" is {"other":"{count} 艘船隻"}, not zh-CN converted ({"other":"{count} 艘船"}). ${fix}`,
|
|
`"Extra" is not in zh-CN. ${fix}`,
|
|
],
|
|
);
|
|
assert.deepEqual(checkZhHant(zhCN, { Server, ...withoutServer }), [
|
|
'entries leave the zh-CN order at "Video": run npm run i18n -- --zh-hant',
|
|
]);
|
|
// A key checkCatalog already lists as missing is not reported twice.
|
|
assert.deepEqual(checkZhHant(zhCN, withoutServer, new Set(['Server'])), []);
|
|
});
|
|
|
|
test('a zh-Hant entry still in English points to zh-CN and its same-as-English line', () => {
|
|
const fixture = new Map([['Bloom', { plural: false }]]);
|
|
const errors = (locale) =>
|
|
checkCatalog(locale, { Bloom: 'Bloom' }, fixture, new Set()).errors;
|
|
assert.deepEqual(errors('zh-Hant'), [
|
|
'"Bloom" is still English: translate it in zh-CN and run npm run i18n -- --zh-hant, or list it under "zh-Hant" in src/i18n/same-as-english.json as under "zh-CN"',
|
|
]);
|
|
assert.match(
|
|
errors('zh-CN')[0],
|
|
/^"Bloom" is still English: translate it, or/,
|
|
);
|
|
});
|
|
|
|
test('every UI string is marked for translation or kept on purpose (npm run i18n)', () => {
|
|
assert.deepEqual(
|
|
findUnmarked().map(({ where, text }) => `${where} ${text}`),
|
|
[],
|
|
);
|
|
});
|
|
|
|
test('checkCatalog reports missing, stale, placeholder and plural problems', () => {
|
|
const fixture = new Map([
|
|
['Saved {name}', { plural: false }],
|
|
['{count} keys', { plural: true, one: '{count} key' }],
|
|
['Untranslated', { plural: false }],
|
|
]);
|
|
const result = checkCatalog(
|
|
'ru',
|
|
{
|
|
'Saved {name}': 'Сохранено {nmae}',
|
|
'{count} keys': {
|
|
one: '{count} ключ',
|
|
few: '{count} ключа',
|
|
many: '{count} ключей',
|
|
},
|
|
Removed: 'Удалено',
|
|
},
|
|
fixture,
|
|
);
|
|
assert.deepEqual(result.missing, ['Untranslated']);
|
|
assert.deepEqual(result.stale, ['Removed']);
|
|
assert.equal(result.errors.length, 2);
|
|
});
|
|
|
|
test('checkCatalog reports a translation left in English unless it is allowed', () => {
|
|
const fixture = new Map([
|
|
['Bloom', { plural: false }],
|
|
['HDG', { plural: false }],
|
|
['voice|READY', { plural: false }],
|
|
['{state} · {source}', { plural: false }],
|
|
]);
|
|
const catalog = {
|
|
Bloom: 'Bloom',
|
|
HDG: 'HDG',
|
|
'voice|READY': 'READY',
|
|
'{state} · {source}': '{state} · {source}',
|
|
};
|
|
const errors = (allowed) =>
|
|
checkCatalog('es', catalog, fixture, new Set(allowed)).errors;
|
|
assert.deepEqual(
|
|
errors([]).map((error) => error.split(' is still English')[0]),
|
|
['"Bloom"', '"HDG"', '"voice|READY"'],
|
|
);
|
|
assert.deepEqual(errors(['Bloom', 'HDG', 'voice|READY']), []);
|
|
});
|
|
|
|
test('unmarkedMarkup finds text and attributes without data-i18n*', () => {
|
|
const texts = (html) => unmarkedMarkup('f.html', html).map((f) => f.text);
|
|
assert.deepEqual(texts('<span>Close</span>'), ['Close']);
|
|
assert.deepEqual(texts('<span data-i18n>Close</span>'), []);
|
|
assert.deepEqual(texts('<button title="Pin it">x</button>'), [
|
|
'title="Pin it"',
|
|
]);
|
|
assert.deepEqual(
|
|
texts('<button title="Pin it" data-i18n-title>x</button>'),
|
|
[],
|
|
);
|
|
assert.deepEqual(
|
|
texts('<select translate="no"><option>0.9 dB</option></select>'),
|
|
[],
|
|
);
|
|
assert.deepEqual(texts('<b data-i18n-runtime><i>OFF</i></b>'), []);
|
|
assert.deepEqual(
|
|
texts('<span class="material-symbols-outlined">public</span>'),
|
|
[],
|
|
);
|
|
assert.deepEqual(texts('<!-- Note --><span>— 42 —</span>'), []);
|
|
});
|
|
|
|
test('markedTemplate rejects data-i18n* attributes in a Vue template', () => {
|
|
const view = [
|
|
'<script setup>',
|
|
"const note = 'data-i18n';",
|
|
'</script>',
|
|
'<template>',
|
|
' <!-- no data-i18n here -->',
|
|
' <span data-i18n>Normal</span>',
|
|
' <b title="Explains data-i18n" data-i18n-title>{{ t(\'Go\') }}</b>',
|
|
' <i :data-i18n="true" />',
|
|
'</template>',
|
|
].join('\n');
|
|
assert.deepEqual(markedTemplate('View.vue', view), [
|
|
{ where: 'View.vue:6', text: 'data-i18n: use t() in a Vue template' },
|
|
{ where: 'View.vue:7', text: 'data-i18n-title: use t() in a Vue template' },
|
|
{ where: 'View.vue:8', text: 'data-i18n: use t() in a Vue template' },
|
|
]);
|
|
assert.deepEqual(
|
|
markedTemplate(
|
|
'View.vue',
|
|
'<template><b :title="t(\'Pin\')">x</b></template>',
|
|
),
|
|
[],
|
|
);
|
|
});
|
|
|
|
test('unmarkedScript finds literals that reach the page without t/tn/msg', () => {
|
|
const texts = (js) => unmarkedScript('f.js', js).map((f) => f.text);
|
|
assert.deepEqual(texts("el.textContent = 'Saved';"), ['Saved']);
|
|
assert.deepEqual(texts("el.textContent = t('Saved');"), []);
|
|
assert.deepEqual(texts("el.textContent = on ? 'On air' : 'Off air';"), [
|
|
'On air',
|
|
'Off air',
|
|
]);
|
|
assert.deepEqual(texts("el.setAttribute('aria-label', `Open ${name}`);"), [
|
|
'Open',
|
|
]);
|
|
assert.deepEqual(
|
|
texts("const row = { label: msg('Wind'), id: 'wind' };"),
|
|
[],
|
|
);
|
|
assert.deepEqual(texts("const row = { label: 'Wind' };"), ['Wind']);
|
|
assert.deepEqual(texts("el.textContent = labelFor('flights');"), []);
|
|
assert.deepEqual(texts("el.className = 'is-active';"), []);
|
|
assert.deepEqual(texts("el.title = mode === 'Auto mode' ? a : b;"), []);
|
|
assert.deepEqual(texts("// el.textContent = 'Old copy';"), []);
|
|
assert.deepEqual(
|
|
texts("// i18n-ignore: product name\nel.textContent = 'OpenSky';"),
|
|
[],
|
|
);
|
|
});
|
|
|
|
test('unmarkedScript sees toasts behind optional calls and private helpers', () => {
|
|
const texts = (js) => unmarkedScript('f.js', js).map((f) => f.text);
|
|
assert.deepEqual(texts("showToast?.('North up');"), ['North up']);
|
|
assert.deepEqual(texts("this._showToast('Search failed');"), [
|
|
'Search failed',
|
|
]);
|
|
assert.deepEqual(texts("this.showToast('Link copied');"), ['Link copied']);
|
|
assert.deepEqual(texts("this.actions.showToast?.('Tilted view');"), [
|
|
'Tilted view',
|
|
]);
|
|
assert.deepEqual(texts("showToast?.(t('North up'));"), []);
|
|
assert.deepEqual(texts("this._showToast(t('Search failed'));"), []);
|
|
});
|
|
|
|
test('unmarkedScript sees status text assigned to layer errors and labels', () => {
|
|
const texts = (js) => unmarkedScript('f.js', js).map((f) => f.text);
|
|
assert.deepEqual(texts("layerState._error = 'live feed unavailable';"), [
|
|
'live feed unavailable',
|
|
]);
|
|
assert.deepEqual(
|
|
texts("this._error = err?.message || 'TeleGeography load failed';"),
|
|
['TeleGeography load failed'],
|
|
);
|
|
assert.deepEqual(texts("_error = 'Route request failed';"), [
|
|
'Route request failed',
|
|
]);
|
|
assert.deepEqual(texts("error ??= 'Feed closed';"), ['Feed closed']);
|
|
assert.deepEqual(texts('stats.error = `${name} fetch error`;'), [
|
|
'fetch error',
|
|
]);
|
|
assert.deepEqual(texts("loadingLabel = 'loading coverage...';"), [
|
|
'loading coverage...',
|
|
]);
|
|
assert.deepEqual(texts("state._loadingLabel = 'Loading cables';"), [
|
|
'Loading cables',
|
|
]);
|
|
assert.deepEqual(texts("stats.statusMessage = 'Add a key in Settings';"), [
|
|
'Add a key in Settings',
|
|
]);
|
|
assert.deepEqual(texts("this.status = 'Scene not saved';"), [
|
|
'Scene not saved',
|
|
]);
|
|
assert.deepEqual(
|
|
texts("layerState._error = msg('live feed unavailable');"),
|
|
[],
|
|
);
|
|
assert.deepEqual(texts("stats.error = t('GBFS fetch error');"), []);
|
|
// Machine values, comparisons and local scratch variables are not UI text.
|
|
assert.deepEqual(texts("status = 'missing-key';"), []);
|
|
assert.deepEqual(texts("if (error === 'Feed closed') stop();"), []);
|
|
assert.deepEqual(texts("const error = log() || 'Unknown shader error';"), []);
|
|
assert.deepEqual(texts('stats.error = new Error(`HTTP ${code}`);'), []);
|
|
});
|
|
|
|
test('unmarkedScript sees human-readable status, loadingLabel and statusMessage fields', () => {
|
|
const texts = (js) => unmarkedScript('f.js', js).map((f) => f.text);
|
|
assert.deepEqual(
|
|
texts("return { status: 'Scene not saved — storage unavailable' };"),
|
|
['Scene not saved — storage unavailable'],
|
|
);
|
|
assert.deepEqual(
|
|
texts("return { status: ok ? 'Ready' : 'Source unavailable' };"),
|
|
['Ready', 'Source unavailable'],
|
|
);
|
|
assert.deepEqual(texts("return { loadingLabel: 'Loading feeds' };"), [
|
|
'Loading feeds',
|
|
]);
|
|
assert.deepEqual(texts("return { statusMessage: 'connect a receiver' };"), [
|
|
'connect a receiver',
|
|
]);
|
|
assert.deepEqual(texts("return { status: 'streaming', code: 'ok' };"), []);
|
|
assert.deepEqual(texts("return { status: 'auth-failed' };"), []);
|
|
assert.deepEqual(texts("return { status: msg('Source unavailable') };"), []);
|
|
});
|
|
|
|
// The Layers panel shows `stats.error || stats.lastError`, so a
|
|
// lastError is status text like error.
|
|
test('unmarkedScript sees status text assigned to lastError', () => {
|
|
const texts = (js) => unmarkedScript('f.js', js).map((f) => f.text);
|
|
assert.deepEqual(
|
|
texts(
|
|
"state.coverage.lastError = error?.message || 'Coverage tile failed';",
|
|
),
|
|
['Coverage tile failed'],
|
|
);
|
|
assert.deepEqual(texts("layerState._lastError = 'CelesTrak unreachable';"), [
|
|
'CelesTrak unreachable',
|
|
]);
|
|
assert.deepEqual(
|
|
texts(
|
|
"state.coverage.lastError = error?.message || msg('Coverage tile failed');",
|
|
),
|
|
[],
|
|
);
|
|
assert.deepEqual(texts('this._lastError = message;'), []);
|
|
});
|
|
|
|
test('unmarkedScript skips default values and ternary branches, not later assignments', () => {
|
|
const texts = (js) => unmarkedScript('f.js', js).map((f) => f.text);
|
|
// A default value in a parameter list or destructuring is a local's.
|
|
assert.deepEqual(texts("function f(error = 'Feed went away') {}"), []);
|
|
assert.deepEqual(texts("const f = (status = 'Not ready', x) => x;"), []);
|
|
assert.deepEqual(
|
|
texts("function f(\n status = 'Not ready',\n x,\n) {}"),
|
|
[],
|
|
);
|
|
assert.deepEqual(texts("const { status = 'Ready now' } = options;"), []);
|
|
assert.deepEqual(
|
|
texts("const {\n error = 'No data yet',\n} = options;"),
|
|
[],
|
|
);
|
|
assert.deepEqual(
|
|
texts("for (const [id, status = 'Waiting'] of rows) {}"),
|
|
[],
|
|
);
|
|
// A name right after `?` is a ternary branch, not a `status:` property.
|
|
assert.deepEqual(texts("const s = ok ? status : 'Source unavailable';"), []);
|
|
assert.deepEqual(texts("const s = ok\n ? title\n : 'Untitled view';"), []);
|
|
// …while the property itself still is.
|
|
assert.deepEqual(texts("return { title: x ? title : 'Untitled view' };"), [
|
|
'Untitled view',
|
|
]);
|
|
// A later assignment is checked even when the name is a declared local:
|
|
// a layer keeps its status in `let error` (wind, AIS watchdog) and builds
|
|
// `loadingLabel` in a `let` before returning it (FIRMS).
|
|
assert.deepEqual(
|
|
texts(
|
|
"function f() {\n let error = null;\n if (x) error = 'Feed closed';\n}",
|
|
),
|
|
['Feed closed'],
|
|
);
|
|
assert.deepEqual(
|
|
texts(
|
|
"let loadingLabel = '';\nif (x) {\n loadingLabel = 'KEY REQUIRED';\n}",
|
|
),
|
|
['KEY REQUIRED'],
|
|
);
|
|
assert.deepEqual(texts("let a = 1,\n error = 'Feed closed';"), [
|
|
'Feed closed',
|
|
]);
|
|
});
|