mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-17 08:42:21 +00:00
The Natural Earth and neighborhood packs were loaded with a JSON-attributed
import(). The Vite dev server answers that request with a JavaScript module,
which the browser rejects, so every analyst region scope failed and fell
through to a geocode lookup that could take 12-28 s.
- src/data/bundledJson.js fetches the pack from a new URL(..., import.meta.url)
asset in the browser; under Node the caller's attributed import runs.
- resolveRegionRingForQuery caps the geocode + admin-boundary rung at 3 s and
returns { error: 'region-timeout' }; the lookup keeps running and fills the
cache. The analyst query reports it as code 'region-timeout'. The Nepal
locator opts out of the budget.
- Unit tests for the loader, the timeout and the analyst error; the behavior
harness checks the Gulf of Mexico scope and retries Texas on region-timeout.
Co-authored-by: Bilawal Sidhu <[email protected]>
87 lines
2.4 KiB
JavaScript
87 lines
2.4 KiB
JavaScript
import { test } from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import { FEATURE_SOURCE_METHODS } from '../sources/featureSource.js';
|
|
import { createAnnotationResolver } from './resolver.js';
|
|
|
|
function featureSource(overrides = {}) {
|
|
const source = {};
|
|
for (const method of FEATURE_SOURCE_METHODS)
|
|
source[method] = async () => null;
|
|
return Object.assign(source, overrides);
|
|
}
|
|
|
|
const texasGeocode = {
|
|
async geocode() {
|
|
return {
|
|
place: {
|
|
lat: 31.0,
|
|
lng: -99.9,
|
|
label: 'Texas, USA',
|
|
name: 'Texas',
|
|
types: ['administrative_area_level_1', 'political'],
|
|
},
|
|
};
|
|
},
|
|
};
|
|
|
|
test('region ring: Natural Earth names resolve without a geocoder', async () => {
|
|
const { resolveRegionRingForQuery } = createAnnotationResolver({
|
|
featureSource: featureSource(),
|
|
});
|
|
for (const name of ['Gulf of Mexico', 'the Alps']) {
|
|
const region = await resolveRegionRingForQuery(name);
|
|
assert.ok(region?.ring?.length >= 3, `${name} resolves to a ring`);
|
|
assert.equal(region.error, undefined);
|
|
}
|
|
});
|
|
|
|
test('region ring: a slow admin-boundary lookup returns region-timeout within the budget', async () => {
|
|
let adminSignal;
|
|
let release;
|
|
const { resolveRegionRingForQuery } = createAnnotationResolver({
|
|
featureSource: featureSource({
|
|
getAdministrativeAreas(_point, { signal }) {
|
|
adminSignal = signal;
|
|
return new Promise((resolve) => {
|
|
release = resolve;
|
|
});
|
|
},
|
|
}),
|
|
});
|
|
const started = Date.now();
|
|
const region = await resolveRegionRingForQuery(
|
|
'Texas',
|
|
undefined,
|
|
texasGeocode,
|
|
{ budgetMs: 50 },
|
|
);
|
|
assert.deepEqual(region, {
|
|
name: 'Texas',
|
|
ring: null,
|
|
error: 'region-timeout',
|
|
});
|
|
assert.ok(
|
|
Date.now() - started < 1000,
|
|
'returns at the budget, not the lookup',
|
|
);
|
|
// The lookup is left running so it can fill the boundary cache.
|
|
assert.equal(adminSignal?.aborted ?? false, false);
|
|
release(null);
|
|
});
|
|
|
|
test('region ring: an unbounded budget waits for the lookup', async () => {
|
|
const { resolveRegionRingForQuery } = createAnnotationResolver({
|
|
featureSource: featureSource({
|
|
getAdministrativeAreas: () =>
|
|
new Promise((resolve) => setTimeout(() => resolve(null), 30)),
|
|
}),
|
|
});
|
|
const region = await resolveRegionRingForQuery(
|
|
'Texas',
|
|
undefined,
|
|
texasGeocode,
|
|
{ budgetMs: Infinity },
|
|
);
|
|
assert.equal(region, null);
|
|
});
|