mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
From the IC8 review of #768, each with tests that fail before: - P1: closing a photo, switching the layer off or destroying it stops the 1.6 s framing flight toward that photo. The flight is claimed with a token before flyToBoundingSphere and released by its complete/cancel callbacks, so cancelFraming() calls camera.cancelFlight() only while the flight is still Street Level's: a newer navigation flight (a search result, a scene) is never cancelled. Turning FOLLOW on also stops it, so the tween cannot overwrite the follow view. - P2: an older nearest-photo lookup can no longer replace a newer choice. The core owns one AbortController per lookup, aborted by a newer lookup, a direct open or cone click, closing the viewer, disable and destroy; the signal reaches source.nearestImages through the provider, and an aborted lookup never surfaces as an error. Co-Authored-By: Claude Opus 5.5 <[email protected]>
161 lines
5.0 KiB
JavaScript
161 lines
5.0 KiB
JavaScript
import assert from 'node:assert/strict';
|
||
import test from 'node:test';
|
||
import * as Cesium from 'cesium';
|
||
import { createCameraFollow } from './cameraFollow.js';
|
||
import { FOLLOW_EYE_HEIGHT_M } from './policy.js';
|
||
|
||
/** Height (m) of a Cartesian above the WGS84 ellipsoid. */
|
||
const heightOf = (cartesian) =>
|
||
Cesium.Cartographic.fromCartesian(cartesian).height;
|
||
|
||
/**
|
||
* A camera with Cesium's flight bookkeeping: starting a flight cancels the
|
||
* current one (calling its `cancel`), `cancelFlight` cancels whichever flight
|
||
* is current, whoever started it, and `land()` completes it. `cancelled`
|
||
* counts the flights `cancelFlight` stopped.
|
||
*/
|
||
function flightCamera(flights, views) {
|
||
let current = null;
|
||
function stop() {
|
||
const flight = current;
|
||
current = null;
|
||
flight?.options.cancel?.();
|
||
return Boolean(flight);
|
||
}
|
||
const camera = {
|
||
cancelled: 0,
|
||
flyToBoundingSphere(sphere, options = {}) {
|
||
stop();
|
||
current = { sphere, options };
|
||
flights.push(current);
|
||
},
|
||
cancelFlight() {
|
||
if (stop()) camera.cancelled++;
|
||
},
|
||
land() {
|
||
const flight = current;
|
||
current = null;
|
||
flight?.options.complete?.();
|
||
},
|
||
setView: (view) => views.push(view),
|
||
};
|
||
return camera;
|
||
}
|
||
|
||
/**
|
||
* A viewer whose scene sample is `sampled` (the Austin case: −14,886 m before
|
||
* the tiles under the photo had loaded) and whose bare earth is `dem`.
|
||
*/
|
||
function setup({ sampled, dem = null, globe = null, altitude = 149 }) {
|
||
const flights = [];
|
||
const views = [];
|
||
const state = {
|
||
services: {},
|
||
street: {
|
||
position: { lon: -97.7364, lat: 30.2672 },
|
||
bearing: 105,
|
||
tilt: -10,
|
||
altitude,
|
||
follow: false,
|
||
followAvailable: true,
|
||
},
|
||
viewer: {
|
||
scene: {
|
||
sampleHeightSupported: true,
|
||
sampleHeight: () => sampled,
|
||
globe: { getHeight: () => globe },
|
||
},
|
||
camera: flightCamera(flights, views),
|
||
},
|
||
};
|
||
const parts = {
|
||
groundCaster: dem === null ? null : { groundAt: () => dem, prepare() {} },
|
||
};
|
||
return {
|
||
follow: createCameraFollow({ state, parts }),
|
||
state,
|
||
flights,
|
||
views,
|
||
};
|
||
}
|
||
|
||
test('framing a photo ignores a sample kilometres underground and uses bare earth', () => {
|
||
const { follow, flights } = setup({ sampled: -14_886, dem: 117 });
|
||
follow.lookAtPosition();
|
||
assert.equal(flights.length, 1);
|
||
const centre = heightOf(flights[0].sphere.center);
|
||
assert.ok(
|
||
Math.abs(centre - 119) < 0.01,
|
||
`centre at ${centre} m, not underground`,
|
||
);
|
||
});
|
||
|
||
test('a plausible mesh sample near bare earth wins (a street, or a modest roof)', () => {
|
||
const { follow, flights } = setup({ sampled: 121, dem: 117 });
|
||
follow.lookAtPosition();
|
||
assert.ok(Math.abs(heightOf(flights[0].sphere.center) - 123) < 0.01);
|
||
});
|
||
|
||
test('without bare earth an absurd sample falls back to the image altitude, never below the surface range', () => {
|
||
const { follow, flights } = setup({
|
||
sampled: -14_886,
|
||
dem: null,
|
||
globe: undefined,
|
||
altitude: 149,
|
||
});
|
||
follow.lookAtPosition();
|
||
assert.ok(Math.abs(heightOf(flights[0].sphere.center) - 151) < 0.01);
|
||
});
|
||
|
||
test('following stands the camera at eye height above the checked ground', () => {
|
||
const { follow, state, views } = setup({ sampled: -14_886, dem: 117 });
|
||
state.street.follow = true;
|
||
follow.followCamera();
|
||
assert.equal(views.length, 1);
|
||
assert.ok(
|
||
Math.abs(heightOf(views[0].destination) - (117 + FOLLOW_EYE_HEIGHT_M)) <
|
||
0.01,
|
||
);
|
||
});
|
||
|
||
test('cancelFraming stops the framing flight while it is still ours (review IC8 P1)', () => {
|
||
const { follow, state } = setup({ sampled: 121, dem: 117 });
|
||
const { camera } = state.viewer;
|
||
follow.lookAtPosition();
|
||
follow.cancelFraming();
|
||
assert.equal(camera.cancelled, 1, 'the flight toward the closed photo stops');
|
||
follow.cancelFraming();
|
||
assert.equal(camera.cancelled, 1, 'and only once');
|
||
|
||
// Re-framing (the next photo) supersedes the first flight, not the claim.
|
||
follow.lookAtPosition();
|
||
follow.lookAtPosition();
|
||
follow.cancelFraming();
|
||
assert.equal(camera.cancelled, 2);
|
||
});
|
||
|
||
test('cancelFraming leaves a landed flight and a newer navigation flight alone (review IC8 P1)', () => {
|
||
const { follow, state, flights } = setup({ sampled: 121, dem: 117 });
|
||
const { camera } = state.viewer;
|
||
follow.lookAtPosition();
|
||
camera.land();
|
||
follow.cancelFraming();
|
||
assert.equal(camera.cancelled, 0, 'landed: nothing to stop');
|
||
|
||
follow.lookAtPosition();
|
||
// A search result flies the globe elsewhere; Cesium cancels ours first.
|
||
camera.flyToBoundingSphere(null, {});
|
||
assert.equal(flights.length, 3);
|
||
follow.cancelFraming();
|
||
assert.equal(camera.cancelled, 0, 'the newer flight keeps going');
|
||
});
|
||
|
||
test('turning FOLLOW on stops the framing flight so it cannot fight the follow view', () => {
|
||
const { follow, state, views } = setup({ sampled: 121, dem: 117 });
|
||
const { camera } = state.viewer;
|
||
follow.lookAtPosition();
|
||
follow.setFollow(true);
|
||
assert.equal(camera.cancelled, 1, 'the framing tween stops');
|
||
assert.equal(views.length, 1, 'and the camera stands at the photo');
|
||
});
|