Commit Graph
4549 Commits
Author SHA1 Message Date
Sameh Khamis f7f18c2823 Merge pull request #1772 from bilawalsidhu/stories/gev-stories
Stories: GEV scenes as stories on the live globe (#1724 with review fixes)
2026-11-16 14:47:57 -08:00
Sameh Khamis 56bd14d5f2 Merge remote-tracking branch 'origin/main' into stories/gev-stories 2026-11-16 14:28:09 -08:00
Sameh Khamis 471f3d618c Merge pull request #1771 from bilawalsidhu/render/frame-time
Idle frame rate in the app, timed line batching, KEY REQUIRED status
2026-11-16 14:22:44 -08:00
Sameh Khamis 2788a9f667 Docs: the timeline waits at a shot's end while a restarted clip plays 2026-11-16 14:20:55 -08:00
Sameh Khamis 186f8b76d9 Scenes: a clip restarted without a media gate plays its hold out
A resumed hold waited only its rest unless the layer gave a media gate,
and only trimmed clips have one, so an untrimmed clip started again (as
on Gyirong) was cut short. The layer now says when a run going on from a
seek started its clip again, and the hold then plays out as from its
start: through the media gate when there is one, else for the whole hold.
2026-11-16 14:20:55 -08:00
Sameh Khamis 5cce9d0705 Nepal evidence: a seek in the hold places a camera-led shot's sequence
For a shot whose path runs during the camera move, a seek in the hold
showed its evidence sequence at the start and a resumed run jumped to
its end. The sequence now stands where its own clock has it (after the
clip and its exit), and a resumed run carries on from there.
2026-11-16 14:18:21 -08:00
Sameh Khamis c3b8013038 Stories: format the corner-controls test 2026-11-16 14:15:15 -08:00
Sameh Khamis 9e6207d7f2 Stories: the button sits left of elements marked data-stories-corner
The corner controls are the ACTIVE STYLE readout and any element marked
with data-stories-corner, looked for again for 20 s after Stories mounts,
in place of an element id this app never has.
2026-11-16 14:14:27 -08:00
Sameh Khamis 78b8d8dc78 Stories: read whether the story was playing before the press stops it
The director's own pointerdown listener, added first, stops a run whose
camera it drives before Stories heard the press, so the tap still played
the story again. Stories now reads the press in the capture phase, and
its tap listeners are removed on teardown.
2026-11-16 14:13:06 -08:00
Sameh Khamis 0ed6cde956 Idle frame rate in the app, timed line batching, KEY REQUIRED status
Three fixes to how the globe draws and reports loading.

**The idle frame rate is the app's rule.** The Cesium frame port capped the loop at `IDLE_FRAME_RATE` whenever nothing held it, so the rule lived inside the renderer. The render governor now sets the rate: the display's own while the loop is held, `IDLE_FRAME_RATE` while not. The frame port gains `onHeldChange(cb)`, which says when its first hold is taken and its last released (animated visual styles included), so the governor hears every hold. The quality setting's frame-rate cap is kept apart from the governor's rate, and the loop draws at the lower of the two, so neither overwrites the other.

**Line batching is timed.** A line set waited 30 drawn frames before its unchanged lines settled into a static batch (300 for the long wait), so the batch built twice as fast at 120 Hz as at 60 Hz, and took seconds at the idle rate. It now waits `SETTLE_MS` (500 ms) and `LONG_SETTLE_MS` (5 s), and moved shapes go back into their batches on the same timing.

**KEY REQUIRED.** A layer that cannot load without a provider key ended the global status chip LOAD FAILED. The chip now has a KEY REQUIRED outcome, ranked below a real failure: a layer whose stats say `keyRequired` ends KEY REQUIRED, any other failure still ends LOAD FAILED. Vessels report a missing AISStream key as `keyRequired` and name the key in the panel; a later outage clears it, as it is no longer the key that is missing.

Checked: the full suite (new tests for `onHeldChange`, the quality cap against the governor's rate, timed settling, and the chip with and without a key), format, boundaries, build, the stub renderer boot and the Cesium conformance run; in the browser, the idle and held frame rates; and the first-run check now asserts that with no keys set the chip never says LOAD FAILED.
2026-11-16 14:10:01 -08:00
Sameh Khamis 40f537a8b9 Stories: drop the Live chip and filter no story can show
No GEV story is live, so the LIVE card chip, the Live topic filter, the
catalog's live field and their styles are removed.
2026-11-16 14:01:56 -08:00
Sameh Khamis 095e4161d8 Scene document: accept the Stories fields from version 6 again
Early Stories builds wrote stories, storyThumb and storyTags in version 6
projects, so those projects load again; the fields stay refused before
version 6. The version 6 round trip is tested again.
2026-11-16 14:00:30 -08:00
Sameh Khamis 807e872731 Stories: a tap pauses a story whose camera move stopped on the press
A camera move the scene drives frame by frame (an authored move, or a
flight resumed partway) stops the run on pointerdown, so the story read
as stopped when the tap ended and the tap played it again. The tap now
goes by whether the story was playing when it began.
2026-11-16 14:00:09 -08:00
Sameh Khamis 8f2155d6c7 Scenes: startup selects the first scene after shot-pack upgrades
An upgrade of a later scene's pack selected that scene; the first scene
and shot are now selected once the upgrades are done.
2026-11-16 13:59:09 -08:00
Sameh Khamis 82475bced3 Stories: an entry for a deleted story drops its ?story= in any mode
Back or Forward into such an entry from Explore or an open story clears
the story and its time from the address and the entry's history state,
keeping the globe hash and, when the entry is Explore, Explore itself.
2026-11-16 13:57:23 -08:00
Sameh Khamis 6904ce0e7a Scenes: a hold resumed partway waits for the clip it started again
The resumed hold reads scene media like any hold: a clip still playing
is waited for, and only without one does it wait out the rest of the
hold.
2026-11-16 13:55:07 -08:00
Sameh Khamis b2c7144cce Scenes: a run resumed inside a hold plays its layers on from that moment
After placing the layers at the seek's moment, the hold settles them
without the seek, so the reveal continues from where the seek put it and
a clip the moment falls in starts again from its beginning (a clip
cannot be joined partway); one the moment is past stays finished.
2026-11-16 13:54:40 -08:00
Sameh Khamis 87b6a4d0c8 Scenes: a revocation also covers the release a stopped run reaches later
A run or LOAD takes the release authority when it starts, so cleanup it
reaches after revokeSceneRelease() turns no layer off.
2026-11-16 13:50:39 -08:00
Sameh Khamis 84d3e7b5ce Merge pull request #1770 from bilawalsidhu/vessels/track-head
Vessel tracks end at the vessel
2026-11-16 13:49:17 -08:00
Sameh Khamis a9990018ea Stories: name the Opened in GEV toast for what it is 2026-11-16 13:48:14 -08:00
Sameh Khamis a5065743d9 Merge remote-tracking branch 'origin/main' into stories/gev-stories 2026-11-16 13:41:09 -08:00
Sameh Khamis 1f6fc86c1a QA: Play on a paused story link goes on from its time 2026-11-16 13:41:09 -08:00
Sameh Khamis 20f6ceb74c Scene document: accept the Stories fields only from version 7
stories, storyThumb and storyTags arrived with version 7, so they are
gated by version like anchors and dataPacks.
2026-11-16 13:40:17 -08:00
Sameh Khamis 1fa053e22d Share link: restore() reports false when the hash is not a share state 2026-11-16 13:38:42 -08:00
Sameh Khamis de0be208da Scenes: an import counts appended packs as built in, as drafts do 2026-11-16 13:37:51 -08:00
Sameh Khamis c8b440dded Scenes: SAVE TO STORIES and tags roll back when the project cannot be saved 2026-11-16 13:37:21 -08:00
Sameh Khamis 85c9f95838 Stories: Back into a deleted story's entry clears ?story= from the address 2026-11-16 13:36:13 -08:00
Sameh Khamis 26893ae37e Vessel tracks end at the vessel
The selected vessel's track drew every fix it held. Following the world
clock, it ran ahead of the icon to the vessel's newest fix; live, it
stopped at the last fix while the icon moved on from it. A change of time
restarted it from a single point until the track at the new time arrived,
so it went blank at every step.

- The track draws the fixes at or before the time the vessel is drawn at;
  live, every fix.
- Each frame a head joins its last drawn fix to the icon where it is drawn,
  as flight tracks do; none past TRAIL_HEAD_MAX_M (20 km), where the clock
  has moved beyond the fixes the track holds.
- A change of time keeps the track, drawn up to the new time, until the
  track at that time replaces it.
2026-11-16 13:35:38 -08:00
Sameh Khamis 7a0b649bf5 Stories: remove unreachable prototype paths
GEV stories never explore, carry no world time and are never live:
drop the resume play state, Jump to live, the exploring branches and
world-time arguments, the overridden play button rules, and the hidden
rail and fill. The legend reads a plain field instead of a mock one.
2026-11-16 13:35:05 -08:00
Sameh Khamis f4b535d89e Stories: remove the Mute button, which controlled nothing
Scene media plays muted and offers no audio control to wire it to.
2026-11-16 13:32:38 -08:00
Sameh Khamis 4fa80fb18c Stories: a teardown that times out cannot undo the restored view
directorSettled now tells a timeout from settlement, and on a timeout
revokes the scene's layer cleanup still in flight before Close puts the
view back.
2026-11-16 13:31:51 -08:00
Sameh Khamis 0a39b05cdb Authoring: pick any scene again, and select the first scene on load
Restores the scene picker and its selection on load, after a delete and
after an import, so PLAY and NEXT work after a reload. Open in GEV
selecting a shot and NEW SCENE stay as they are.
2026-11-16 13:30:22 -08:00
Sameh Khamis 1cb3e88027 Scenes: drop a wall-clock check from the resumed-hold test 2026-11-16 13:29:58 -08:00
Sameh Khamis 76d203c8f1 fix(vessels): back at live, drop a snapshot still loading at a time so the live poll goes out at once (#1769)
Pressing Live while a timed snapshot load was in flight left the live poll
waiting on that load. The live poll returned early, so the map showed no
vessels until the next refresh. The live poll now drops a timed load still
in flight, and loadAt shares the same dropLoad helper.
2026-11-16 13:28:17 -08:00
Sameh Khamis 8734f5e515 Stories: Play resumes at the exact paused or sought moment
startScene takes fromProgress and starts partway into a shot: the camera
goes on along the rest of the flight, the hold waits only what is left
and the scene clock carries on from the same point.
2026-11-16 13:24:59 -08:00
Manjunath fec84dbf78 Address Stories review feedback 2026-11-16 22:35:07 +05:30
Manjunath 2edcd5bc69 Fix Stories history and paused playback 2026-11-16 21:38:14 +05:30
Sameh Khamis 3d49ba588f Merge pull request #1762 from bilawalsidhu/perf/vessel-motion-segments
Vessel playback moves icons on the renderer's clock
2026-11-16 08:06:26 -08:00
Manjunath 472cc35c47 Stories: phone entry, centred framing, review follow-ups
- On GEV's phone layout, where neither the style readout nor the account
  avatar shows, the Stories button goes icon-only under the corner-actions
  column instead of covering the top row of icon buttons.
- Explore frames its start view and a picked story in the middle of the
  map it leaves visible (beside the feed, above the phone sheet), with one
  short correction if that area moved during the flight.
- The share icon stays visible in icon-only header buttons.
- A world clock nothing moved while Stories was open (no jump, same mode
  and rate) is left alone on Close.
- Card images use the globe's own Esri tile URL; the credit list keeps the
  application's full-screen placement on phones.
- Tests cover the live and playing clock restores, the clock coming back
  after the share state, the tile-settling hold being released (settled,
  10 s, Close), the visible-map aim, and the near-end Play fix in the
  director's real order. One changelog fragment covers the PR.
2026-11-16 21:08:23 +05:30
Kevin Rajan 8a0953c35d fix(stories): retain the last shot when replaying near the end (#1724)
Focused follow-up to manjunath22466's Stories contribution.
A paused share link in the final 250 ms is not a completed scene.
Add node:test coverage for near-end Play and true-end replay; update
current-state documentation and the #1724 changelog fragment.
2026-11-16 20:45:25 +05:30
Manjunath b8e622aac8 Stories: reach the globe through the renderer's ports
Main now keeps Cesium behind the renderer contract, so Stories stops
reaching Cesium and the viewer directly.

- Camera: flights, the -60 degree story framing, cancel, the pose saved
  on open and put back on Close go through the camera port; a follow is
  released with stopFollowing.
- Pins: placed in the frame port's postRender from the query port's
  projection and horizon test, still written straight to each pin's
  transform on every drawn frame.
- Tile settling: a continuous-render hold until the globe port reports
  the base settled, for at most 10 s.
- Clock: Close and Back to Explore put back the page's world clock (live,
  or the time it showed, playing on), and leave a clock that is still
  where it should be alone.
- Card images: drawn from Esri World Imagery's own Web Mercator tiles
  while the Esri map stack is active, read as images; no Cesium imagery
  provider is touched.
- THUMBNAIL: the director hands captureStoryThumb the frame port and the
  renderer's canvas, so the scene document's module stays renderer-free.
- Credits: Stories places and keeps visible the application's credit
  line (#gev-credits) and its list as well as the renderer's own display.
- Tests fake the ports instead of a Cesium viewer, and cover pins per
  frame, the flights, the settling bound and the clock restore; the
  share link tests Stories added build their manager over a camera port.
2026-11-16 20:43:53 +05:30
Manjunath 9e9ce1db22 Fix Stories navigation, sharing, and voice entry 2026-11-16 20:12:10 +05:30
Manjunath 5418438339 Stories: GEV scenes as stories on the live globe
A Stories button (top right) opens Explore: a feed of GEV scenes over
GEV's own Cesium globe, with a pin per story. Explore opens at country
level over the first story and, while idle, flies on from story to story
for a minute. A picked story is framed in the middle of the view; a pin
plays its story on a second click. The Story page plays the scene through
SceneDirector with a timeline, chapters, key moments, sources and
background, then Close (or Back) puts the person's camera, clock, layers,
style and AUTHORING selection back. Open in GEV hands the scene to the
Scenes panel at its current shot.

Stories lists the scenes GEV ships with a camera path (while they are in
the project), the scenes saved with SAVE TO STORIES in AUTHORING, and the
person's other scenes as drafts. The person's own stories live in the
project on this device, so they have no Share; a link to a story that is
not here opens Explore and says so. Each shipped story's
context comes from what GEV knows: what it shows, the place each shot goes,
and each layer's data sources as DATA_SOURCES.md lists them; the Nepal
story carries the event pack's facts and CC BY-NC sources. Card images are
a captured THUMBNAIL or drawn from the keyless Esri World Imagery.

AUTHORING has no scene picker: it starts with no scene, NEW SCENE (or
CAPTURE SHOT) makes one, and Stories' Open in GEV selects one. Before SAVE
TO STORIES it offers topic tags and THUMBNAIL. A scene's stories flag,
storyThumb and storyTags are saved with the project and kept through
export and import.

Only the closed state loads with the page; the screens, styles, story data
and controller load on first open. Stories keeps its place in the query
(one history entry per screen) and holds the share link's hash writes
while open. Keyboard input and voice tools stay with Stories while it is
open. Explore's pins move on every drawn frame without asking for frames;
the idle tour and tile settling are bounded.

All strings are translated in the 13 locales.
2026-11-16 20:12:10 +05:30
Sameh Khamis 0a0c6a0e5b Vessel playback moves icons on the renderer's clock
While the timeline plays or is scrubbed, each vessel icon is handed to the
renderer as a motion segment along its track (a straight piece of at most
10 km between two fixes, on the scene clock), as aircraft already are. The
layer writes an icon again only when its segment runs out or the time
moves back before it, instead of moving every icon on the CPU every frame.

Behaviour is kept:
- Icons follow the same great-circle track between fixes (a 10 km chord
  stays within 2 m of it) with the same course.
- A vessel still appears TIMELINE_UNSEEN_MS before its first fix and
  hides again when the time moves back before that.
- Cards, the selected vessel, ship models and the vessel the bridge camera
  rides are read where they are every frame; the rest within
  HIDDEN_FOLLOW_MS, as before.
- Position reads (getAllPositions, getNearby, the focus pass, the
  detection overlay, single-vessel lookups) return where the icon is drawn
  at the world time.
- Going live, each icon holds where its segment last drew it, unless a
  live update has drawn it since.
- Trails are unchanged: they are built from the feed's fixes, not from the
  per-frame position.
- Live mode and renderers without the motionSegments capability take the
  previous path unchanged.
2026-11-15 23:56:03 -08:00
Sameh Khamis da81cf743b Merge pull request #1760 from bilawalsidhu/render/renderer-seam
Renderer ports: layers draw, pick and move the camera through a renderer contract
2026-11-15 20:30:44 -08:00
Sameh Khamis a7fe3eebc6 Credits keep their linked words: only the words a source linked are the link
A credit read from markup keeps the first link's own words as linkText, and the Cesium credit display and the credit line link just those words, as the source wrote them (Street Level's "© Mapillary contributors" links Mapillary only). The Street Level gate reads a drawn item's pick id from its draw-set id.
2026-11-15 20:12:14 -08:00
Sameh Khamis 74673f3c85 World overlay: the distance curve is computed in the projection pass, so its result is never boxed
On Node 26 the engine inlined the projection pass's helpers in another order and left distanceScale out, so every label's paint scale allocated a number: 158 B per candidate per frame against the 154 B budget, where main measures 136 B. The curve now sits beside the altitude curve in snapshotAndProject, with the same arithmetic.
2026-11-15 20:12:14 -08:00
Sameh Khamis 256e992372 The contract text speaks of the renderer 2026-11-15 19:20:48 -08:00
Sameh Khamis 9862b2a165 Contract and docs text describe the ports and the Cesium renderer only 2026-11-15 19:08:46 -08:00
Sameh Khamis 1fdf52198d CONTACTS: a selected vessel's subject is labelled as its selection is; test doubles without the new lookup still activate 2026-11-15 18:42:06 -08:00