Commit Graph
6 Commits
Author SHA1 Message Date
manjunath22466 e7325685e5 docs: restore GitHub handles in the #835 changelog credit
Recent fragments credit as name, handle and PR number; keep that form.
2026-11-10 13:30:41 +05:30
manjunath22466 fd2200effa docs: credit viewport diagnostics contributors (#835) 2026-11-10 12:36:22 +05:30
manjunath22466 df37c9360d test(voice): pin diagnostics wiring and in-flight crop dedupe; tighten docs
Third review pass on #835. No runtime change.

- Controller test: viewport decisions reach the controller's debug log.
- Policy test: a second request for a snapshot still being captured is
  logged pointer-already-requested and is not captured twice.
- CURRENT-STATE: pointer-not-fresh also covers a missing snapshot,
  already-requested covers an earlier attempt that threw, and the image
  step runs when any tool output of the response was sent.
- Changelog: describe what is recorded rather than a fixed miscount.
2026-11-06 23:12:20 +05:30
manjunath22466 d0a612786a fix(voice): log a real send before bookkeeping; document decision reasons
Second review pass on #835's diagnostics. Behaviour is unchanged.

- Report viewport_context.result as soon as the send returns, so a throw
  in the retained-frame bookkeeping cannot log a real send as "error".
- List the decision reasons and when each field is present in
  CURRENT-STATE, note that the rate limit can split a pair, and say which
  codes are defensive.
- Changelog: the decision is logged when an entity-context answer reaches
  the image step, not for every answer.
2026-11-06 22:47:09 +05:30
manjunath22466 27823d7d05 fix(voice): make viewport escalation diagnostics truthful and paired
Review follow-up for #835. What is captured, sent and kept is unchanged.

- Log nothing for tool results other than get_entity_context, so other
  tools stop spending the shared debug-log budget.
- Give every decision and outcome the same contextId and image kind, so
  overlapping requests pair up.
- Log why a crop decision did not send (stale, off ground, off screen,
  expired, pose changed, already requested) instead of leaving a lone
  "pointer-ground-crop" that reads as sent.
- Split capture-invalidated into session-reset, superseded, channel-lost
  and frame-stale.
- Close the pair with "error" when a step throws, then rethrow.
- Document the events in CURRENT-STATE and reword the changelog fragment.
2026-11-06 22:37:41 +05:30
Kevin Rajan 8c02f5852f fix(voice): preserve pointer crops in viewport escalation diagnostics
Reconcile origin #835 with merged voice core #837. Classify pointer crop separately from full screenshots, retain existing session/camera freshness guards, and log bounded static reason codes. Add dispatch regressions and changelog fragment.

Credit: asturksever identified the incompatibility; preserve #837 authorship.
2026-10-16 23:36:00 -05:00