- The flight after a count click checks the frame on both axes and at the
height of the highest mount, so a group on a slope or in a very wide
window stays in view; when it cannot, it flies to the nearest cell with
two or more cameras, never to a lone camera that joined the count.
- A count takes a click over a background fill no layer owns (earthquake
discs, fire perimeters), and still yields to a scene item another layer
registered.
- A count crossing the HUD edge refreshes the view only when the active
icon or a lone camera depends on it, and never mid-motion, so panning no
longer runs extra full view passes.
- A count restored at the HUD edge keeps the lone cameras its outline
covers, and leaves the others as icons.
Fixes from review of the move to StreetLevelPhotoViewer:
- Each mount and each panorama canvas now takes a key no viewer reuses,
and the view keys its root by the mount. Before, switching KartaView and
Panoramax in one tick let Vue patch the old viewer's canvas, whose
destroyed renderer had lost its context, into the new one, so 360°
photos fell back to their front view.
- Of the viewers mounting in the host, the view draws the one mounted
last, by mount key (photoViewers.js, which subscribePhotoViewer() now
uses), whatever order they present in. A viewer still mounting when a
later one is drawn is superseded: it unmounts and its mount fails as
closed, rather than staying pending and being drawn once the later one
goes.
- A panorama's first image is uploaded once the view has drawn its canvas
shown (the view hands the canvas back on every draw), so it is never
sized into a hidden canvas.
- The tests' fake view now draws as Vue does: once per tick with the final
value, keeping elements while their keys are unchanged and handing every
element back on each draw. StreetLevelPhotoViewer.test.mjs covers the
switch in one tick and the overtaken mount with the real view.
- The guard test's check that the photo viewer writes no DOM covers
inserting, moving, removing and replacing elements, attributes, classes,
styles and the hidden, disabled and text properties.
Co-authored-by: Manjunath Paparaju <[email protected]>
The photo viewer KartaView and Panoramax share (photoViewer.js) no longer
builds its root, picture, panorama canvas and ‹ › buttons in script. It
presents them through subscribeView(), which the street-level layer
gathers in subscribePhotoViewer(); the application shell publishes that
to the gev-street-level-photo store, and StreetLevelPhotoViewer, beside
the Street Level panel in the layer panels, teleports the viewer into the
viewer host with the same classes, data attributes, labels and order. Its
‹ and › are ghost UiButtons. The view forwards keys, pointers, wheel, the
step clicks and a lost WebGL context to the viewer and hands each element
back: the canvas the panorama is drawn on (a fresh, keyed one after a lost
context, which an open now waits for), and the frame, picture, root and
buttons the viewer measures and keeps focus with. The viewer keeps every
decision: loading, upgrades, size limits, keys, drag, pinch, zoom, Esc on
the viewer's box and focus when a step button disables. The street-level
layer still needs no Vue; with no view subscribed these photos cannot
mount, which docs/VUE-MIGRATION.md records.
The provider and viewer tests draw the viewer with a fake view in
kartaViewFakes.mjs; StreetLevelPhotoViewer.test.mjs runs the real view on
a page, and streetLevelPhotoControls.test.mjs pins the kit controls. The
panel page's lost-graphics notice in globePanelRuntime.js stays built in
script, as the document now says.
Co-authored-by: Manjunath Paparaju <[email protected]>
The picker preselected the active camera, and a native select fires no
change for the option it already shows. So while CCTV was still following
the view, choosing the camera the picker showed did nothing, and the next
pan switched to another camera.
The layer now reports whether the active camera is the opening one
(activeCameraProvisional). While it is, the picker shows that camera from
a hidden, disabled first option, so choosing it from the list is a change
and ends automatic selection; closing the list keeps it. A same-camera
pick that ends the opening pick notifies listeners so the picker drops the
hidden option, and reopenNearestCamera passes { opening: true } so its own
notification already carries the opening state.
docs/CURRENT-STATE.md now says when automatic selection ends. Tests cover
the hidden option, confirming and dismissing the picker before a pan, the
notification, and focusNearestToPoint, which is now on main.
A card click on an unprobed day follows that day while the automatic
preview stays on the map. If the automatic day then probed empty, the
hand-over to the next ranked day overwrote that follow, so neither the
picked day nor the successor draped when their probes came back
present. The hand-over now leaves the slot to a day the user picked that
is still being probed or waiting out the arrow-key debounce.
Also covers the off-screen successor with empty days shown: once the
visible days probe empty, the successor's probe is queued (the re-request
that came with the merge from main) and the day drapes when present.
Layer choices saved in local storage were restored whenever the address carried
no link, so clearing the address and loading the bare URL brought the last
session's layers back and there was no way to a reset view. Start-up no longer
reads them: a link restores what its hash carries, and a bare address starts
from the defaults.
Below 150 km Cesium sizes a zoom step from the depth it picks at the canvas
centre. Since #1835 an icon drawn over depth wrote a depth just past the near
plane, which that pick took for a surface a near plane's distance from the
camera: zooming in returned early and zooming out moved by centimetres.
Over-depth rows now write a depth of exactly 0 in the fragment shader. It is
never discarded (the flicker #1835 fixed stays fixed) and the depth pick
reads it as nothing drawn, keeping the ground under the icon.
Adds scripts/qa-zoom-under-icon.mjs (real browser) and a source-level unit
test.
The drag-fixture framing looked the gizmo up in viewer.entities, which main no
longer populates, so it did nothing and five drag checks stayed inconclusive.
It now reads the arrow from the layer's drawn state and records the framed
shaft length as a check.
Tarktee and Lithuania read their two catalogs through one helper,
readCatalogsTogether, so both get the shared deadline, sibling abort and the
release of a response that arrives after the other feed failed.
An Ontario error response has its body released, and tests pin the refused
redirect and system-code log labels.
Conflicts: the locale catalogs, package boundaries and format scope are
three-way merges (entries main removed, such as displayPanelScroll.js,
stay removed); applicationShell.js and ContextView.vue keep main's Space
Missions panel and the STATION and LIVE wiring, moved back into
_initGlobalContextPanel; installations take main's feedback module, and
their label box joins main's card-on-top click rule; ports.test.mjs lists
modelParts and modelNodes; CURRENT-STATE.md keeps both edits.
zh-Hant is regenerated from zh-CN, as main now requires. "Below" keeps
main's translations.
Main moved the screen annotation renderer onto the renderer ports, so the
height culling now goes through them too: the frustum test uses
frustumPlanes/sphereOutside from src/geo/frustum.js on the camera pose,
the horizon tests use the query port's isOccluded, and the file imports no
Cesium. The sampling tests run on main's scene doubles with their
assertions unchanged; the outside-frustum step turns the test camera
instead of stubbing the culling volume.
Drop the per-peer lease budget and the lease-to-address binding. Main's
keyless same-site gate already refuses cross-site media requests, while
the budget capped a shared address (Docker gateway, reverse proxy, NAT)
at 8 leases across both sessions and still let one address hold both.
A lease now keeps working when its viewer reconnects from a new address.
Add a middleware test that drives the HLS playlist, segment and DELETE
for viewers on one shared address, on distinct addresses and after an
address change, and fold the media cases (segment read, DELETE, no
catalog request) into the cross-site table test. Remove the redundant
puppeteer flag, the CURRENT-STATE paragraph and the changelog fragment,
which no longer describe a change.
An endpoint outside the frustum is not sampled and projects at its 0 m
stand-in height. The horizon test then judged that stand-in, so an arrow
whose far end lies beyond the sea-level horizon but above it at its real
height disappeared with its label. Such an endpoint now skips the point
horizon test; the height-range test still drops endpoints that are
provably hidden, and settled or in-frustum anchors keep the point test.
Adds a regression with a real frustum and occluder (camera 100 m up, far
end 56 km away on 100 m terrain). CURRENT-STATE and the changelog now say
the 32-sample budget applies per projection pass, and the redundant helper
comment in the test is gone.
The fallback keeps the catalog position but takes heading, field of view
and pitch from the request again, as before, clamped as before. A catalog
camera with no pose (every world-cameras row on main) otherwise asked
Google for heading 0, pitch 0, FOV 80 while the browser draws it at the
id-hash heading, pitch -17 and FOV 74, and a calibrated camera lost its
calibration. Cost and the per-IP budget are unchanged.
- The Street View budget is built per proxy, so tests no longer depend on
GEV_RATELIMIT_GOOGLE_PER_MIN in the shell; the fixture pins it.
- New tests: a pose-less catalog camera, and the per-IP budget (no call
without a key, the cap, a separate budget per address).
- The client no longer sends lat/lon on /frame.
- CURRENT-STATE, the changelog fragment and SECURITY.md say the fallback
has its own per-client limit, and that unlisted (seed) cameras get the
placeholder.
Each Tarktee DATEX feed now reads its body as soon as its headers arrive, so a
failed or oversized body aborts the other request at once instead of waiting
for its headers up to the shared 30 s deadline. Status and redirect errors
name the feed again.
Ontario failures log the error class and system code, never the key-bearing
URL or upstream text. DATA_SOURCES.md and the camera licence field use the
Open Government Licence – Ontario statement the credit shows, and a test pins
that credit.
The focus-release rendering test now uses main's icon renderer and its
isVideoFeedCamera contract. The Tarktee cancellation tests disable the 30 s
deadline and time out after 2 s, so a regression fails fast instead of passing
late or hanging; a duplicated older test and an unused import are gone.
This PR's notes move into changelog.d/1266-cctv-shared-fix-batch.md: the 1133
fragment described main's tracking probe and terrain check, not this branch.
Above the compass block the centred row covered the DEST route-direction
label and chevron at 320-390 px, and its fixed +182px offset pushed it off
the top of short landscape screens. Place it between the roll scale and the
reticle from a viewport-aware visor inset instead, keep it on screen below
the vision controls on short landscape phones, and centre Cyber's expanded
panel on the Reset/Exit axis.
The unit test now asserts the pointer-events contract and Cyber centring;
the browser QA adds the DEST cue to the clearance check, hit-tests each
launcher glyph and covers 740x360 and 667x240.
Every Google route now sets no-store right after the same-site gate and
switches to private, max-age=300 only on a confirmed answer, so the
proxy's own 400, 405, 429 and 502 replies are no longer left without a
header. Both Places routes answer an unreadable 200 body with 502 instead
of caching an empty result, as the geocode routes already did. The test
pins the allowlist with OVER_DAILY_LIMIT and UNKNOWN_ERROR and covers the
unreadable and empty Places bodies; the changelog fragment is shorter.
The still preview gate looked only at the CCTV panel, so the Context
camera card, which reads the same frame, stopped updating while the
panel was collapsed or another phone sheet was open. A mounted card now
counts itself in the CCTV store, and the still is requested while the
panel or a card is shown; live video still follows the panel only.
Review follow-ups in the same area:
- visiblePoints is registered once, in createCesiumPorts, and drops
checks for input that cannot happen; the contract documents
horizonMarginM and when it answers false or null.
- The layer passes the mount and the four corners once each and asks
findCamera for the port.
- Phone sheet names come from a shared module instead of literals.
- Layer tests cover the fetch gate; the geometry cases moved to the
camera port tests. Comments and CURRENT-STATE match the code.
- Join a space-separated negative latitude to --origin before parseArgs,
so `--origin -33.86,151.21,0` works as the usage and docs show.
- Read the input through one descriptor, regular files only, at most one
byte past the 5 MiB scene limit.
- Use geodetic ENU axes at the origin (ellipsoid normal at its lat/lon,
raised to its height) instead of Cesium's frame at the raised point.
- Reuse the shots already resolved, serialize the sampled shot table
directly, and drop the typeof-only export test.
- Docs: timing matches Director seeking, with the playback differences;
add a manual OpenUSD/Blender check; shorten the overview and test list.
- Name the G3 record "AutoVu SharpV G3" and the SharpX record "XGA", so a
bare SharpV or SharpX tag shows no specs without a separate wrapper.
- Reuse the CCTV layer's Bosch MIC-7522-Z30 record instead of a copy.
- Drop the brand from the SPEC line when the equipment line already names
it, so long lines fit the card; pass the summary to entity properties.
- Fall back to the OSM `brand` tag when `manufacturer` is missing.
- Reject non-string or overlong model/manufacturer values before matching.
- Remove the unused `brandAliases` parameter; shorten JSDoc and comments.
- Cover the tile `model` path and the megapixel summary in tests; fold
duplicate tests into existing ones.
- Docs and changelog: the default hourly extract has no `model`; any
source that supplies it shows the SPEC line.
Resolve the conflicts by keeping main's keyless CCTV gate, which already
refuses cross-site requests on every /api/cctv route and keeps the routes
reachable behind a reverse proxy, instead of the strict gate on /media/.
Keep the per-request client id the lease calls use, and both sides of the
CURRENT-STATE paragraphs and the media tests.
Main released #1228 and #1233 and deleted their changelog fragments, so they
stay deleted here. Main also rewrote the tracking arrival probe in
scripts/track-regression.mjs, which supersedes this branch's version; main's
file is kept unchanged.
- A count click stands aside when an overlay label or another layer's card
already took the click, and CCTV now claims a count click in the shared
pick registry, so the flights layer no longer reads it as an empty-map
click and keeps tracking its aircraft.
- The flight to a group halves the distance only while the group stays in
frame; otherwise it flies to the nearest ground cell of the group, so a
tilted click no longer ends with no camera on screen.
- Counts hidden under the HUD no longer push the active icon aside, and a
lone camera that would move a merged count under the HUD leaves the
original count and its icon as they were.
- Cameras on one mount are spread before counts merge, so a spread icon no
longer slides under a neighbouring count.
- The ground module comment says how a camera without a batch height takes
the drawn terrain.
- When F or a panel's collapse button folds a panel that holds the focus,
the focus moves to that panel's visible rail entry. The same happens when
opening Data Layers folds a peer panel that held it, and in Cockpit the
focus moves to Contact's expand button when that card folds.
- The `shownBy: 'active'` rail gate is gone: nothing removes `.active` from
Data Layers any more, so a rail entry now follows `panel.hidden`.
- CURRENT-STATE says what F does, and the panel catalog comment no longer
says F toggles `.active`.
findPlace looked at the detail tiles only when no city had the typed name,
so a village called Paris in view lost to Paris, France. With
includeSmallPlaces it now reads the places near the view as well and takes
the nearest place of the name there, city or not. With none near, the
largest city of the name still wins.
Co-authored-by: Manjunath Paparaju <[email protected]>
An obstacle that crossed the middle of the window (the World Timeline, the
voice control or a card in a window under about 520px tall) was neither
above nor below it, so neither rail counted it and panels could be laid out
over it. Such an obstacle now puts the panels on whichever side of it has
more room. When neither side has room, the rails keep their existing
minimum (the right rail's empty band, the left rail's minimum lane height).
Co-authored-by: Manjunath Paparaju <[email protected]>
Focusing a mission does nothing in the cockpit, so the layer row's arrows
select the next mission without moving the camera, as its label and dot
already do.
Co-authored-by: Manjunath Paparaju <[email protected]>
"clear all flights from the map" no longer offers to turn Flights on, and
"clear the layers from the map" clears the layers.
Co-authored-by: Manjunath Paparaju <[email protected]>
The cockpit holds the camera: the mission dot, like its label, selects the
mission there without flying to it, and a mission picked in the cockpit is
not flown to when the active satellite lookup returns.
Co-authored-by: Manjunath Paparaju <[email protected]>
Under the card-on-top rule a mission label is the card on top for the
cockpit too, so the label no longer steps aside there: it selects its
mission without moving the camera the cockpit holds. Tests and docs no
longer claim a covered click reaches what lies under the label, and the
busy-restore note says an explicit Satellites action lets the saved state
go.
Co-authored-by: Manjunath Paparaju <[email protected]>