Commit Graph
5091 Commits
Author SHA1 Message Date
Sameh Khamis 9d5e10ddb1 Merge pull request #1871 from bilawalsidhu/samehkhamis/street-level-photo-followups
Street Level photo viewer: settle every open and mount, one viewer drawn, a stated contract
2026-11-19 16:50:15 -08:00
Sameh KhamisandManjunath Paparaju 80999ff007 Add the changelog entry for #1871
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 16:36:54 -08:00
Sameh Khamis eb7d92db66 Merge remote-tracking branch 'origin/main' into samehkhamis/street-level-photo-followups 2026-11-19 16:32:27 -08:00
Sameh KhamisandManjunath Paparaju 8c40eb957b Street Level photo viewer: take a moved-off canvas back, and close a mount unmounted in its first draw
A canvas the panorama moved off (a second view drew its own) is no longer
ignored for good: its draws are counted, so an open waiting on one goes on,
and once a single view is left its canvas is taken back. Before, after the
second view left, the next 360° open waited forever and the panorama stayed
on the departed view's canvas.

A mount whose view unmounts it inside its first draw now fails as closed,
as every other unmounted mount does, rather than with a TypeError.

Both found in review; each new test fails without its fix.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 16:31:34 -08:00
Sameh KhamisandManjunath Paparaju 22485dcb01 Street Level photo viewer: a failed mount spares the next, stable keyless ranks
Second review follow-ups:

- A mount woken without being drawn unmounts only its own presentation:
  an earlier mount overtaken by a second mount of the same viewer fails
  as closed and leaves the second one mounted and presented.
- A mount whose last view left fails only if no view has subscribed
  since; one subscribed in the same tick draws it.
- Mount keys come from photoViewers.js's nextViewKey(), and a keyless
  presentation is stamped from the same counter when any picker first
  sees it, kept until it presents null: its rank no longer depends on the
  picker's lifetime or the order it subscribes in.
- A canvas handed back while a panorama's open waits on its draw takes
  the panorama: the open builds its renderer there instead of falling
  back to the front view. A canvas the panorama moved off is not moved
  back to, so two views drawing their own cannot take it in turns.
- The guard test also refuses compound writes (+=, ||=, ??=, &&=…),
  destructuring writes to properties, Object.assign (other than onto a
  new Error), Object.defineProperty and Reflect.set, and a catch binding
  that shadows loadImage's image.

Nothing changes in the running app.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 16:23:42 -08:00
Sameh Khamis 820257cd85 Merge pull request #1867 from bilawalsidhu/samehkhamis/start-layers
A host names the layers a bare address starts with
2026-11-19 16:07:40 -08:00
Sameh KhamisandManjunath Paparaju e6f21777ba Street Level photo viewer: keyless ranking, closed waits, a moved canvas
Review follow-ups to the previous commit:

- photoViewers.js ranks a presentation without a mountKey as mounted when
  it began presenting (after the latest key seen, before any later mount),
  so a photo viewer mounting while a keyless one shows is drawn and the
  keyless one superseded; supersede is queued whenever more than one
  presents after any change, not only when the pick changes.
- A panorama's open still waiting on a draw when the last view leaves
  fails as closed and leaves no photo shown, instead of uploading to a
  canvas never drawn. A mount waiting on its first draw then also fails as
  closed and is unmounted, so a view subscribing later sees nothing.
- A view handing back another canvas element than the renderer's drops
  the renderer and draws the panorama again on the new one, as after a
  lost context.
- The guard test allows a .src write in loadImage only on the one `image`
  binding, created by new Image() and never rebound or shadowed, and
  refuses `(expr).src =` and bracket property writes anywhere.
- The test fakes' shared view is reset before each test
  (resetPhotoView), so a viewer left by an earlier test is neither drawn
  with nor superseded by a later test's.

Nothing changes in the running app.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 16:04:21 -08:00
Sameh Khamis 250a78c0f9 Merge branch 'main' into samehkhamis/start-layers 2026-11-19 15:54:31 -08:00
Sameh Khamis 8c0a812578 Merge pull request #1869 from bilawalsidhu/samehkhamis/kit-sweep-final-scan
Vue kit: the view scan forbids any hand-written button, glyph, checkbox or range
2026-11-19 15:51:09 -08:00
Sameh KhamisandManjunath Paparaju 33ac0545ef Street Level photo viewer: settle opens, a gapless picker, a stated contract
Follow-ups to the photo viewer's move to a Vue view (#1868):

- A panorama's open waits for a draw of the canvas counted from before it
  is shown, so a view that draws at once inside its listener no longer
  leaves the open pending; and when the last view unsubscribes, an open
  waiting on a draw goes on instead of hanging.
- photoViewers.js supersedes the mounts not drawn on a microtask, after
  the winning presentation has reached every subscriber: a second
  subscriber sees the earlier mount, then the later one, never null
  between.
- A presentation without a mountKey counts as the latest mount (among
  several without, the one that began presenting last), and one without
  actions or supersede is passed over without throwing. Both fields are
  documented on ViewerAdapter.subscribeView in registry.js and in the
  store's comment.
- The guard test also refuses .width, .height, .ariaLabel, .id and .value
  writes in photoViewer.js, and .src writes outside loadImage, where only
  the off-page Image it creates may take one.
- The test fakes draw every viewer through one shared view behind
  photoViewers.js's picker, as the application does, so provider and
  layer tests see supersede.

Nothing changes in the running app.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 15:48:50 -08:00
Sameh Khamis 5258f1b2a4 Merge branch 'main' into samehkhamis/start-layers 2026-11-19 15:39:50 -08:00
Sameh Khamis 34ed83537a Merge remote-tracking branch 'origin/samehkhamis/kit-sweep-final-scan' into samehkhamis/kit-sweep-final-scan 2026-11-19 15:32:16 -08:00
Sameh Khamis 19369349b0 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-final-scan 2026-11-19 15:31:56 -08:00
Sameh KhamisandManjunath Paparaju 559a7cec71 Vue kit: the view scan reads SFC scripts, string markup and bound types
Following review, the scan now also:
- reads every SFC's script blocks, not only modules;
- matches a createElement call Prettier wraps over lines, and any case of
  the tag name;
- fails on a button, select, input or textarea written as markup in a
  string, comments aside, apart from the globe panel's standalone page
  (plain HTML a host serves, with no Vue or kit), which the test names and
  requires to still be the reason;
- catches a Material class built in a template string;
- reads an input's type when bound to a quoted literal or named in a
  v-bind object, in any case, and unquoted before `/>`;
- catches a Material class named in a v-bind object.
Each new path was confirmed to fail when its violation is put back.

docs/VUE-MIGRATION.md now names the globe panel page as the exception,
lists the two text areas among the native fields left, and notes that the
scene dialog's field takes text-like types from its callers only.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 15:31:47 -08:00
German Khokhlov 12dc0de20d Merge pull request #1360 from ch-bas/feat/alpr-model-specs
feat(alpr): show datasheet specs for mapped ALPR camera models
2026-11-20 03:29:51 +04:00
Sameh Khamis db19dae2f9 Merge branch 'main' into samehkhamis/start-layers 2026-11-19 15:24:39 -08:00
Sameh Khamis 407adcc500 Merge branch 'main' into samehkhamis/kit-sweep-final-scan 2026-11-19 15:21:13 -08:00
German Khokhlov aa5ab7d387 Merge branch 'main' into feat/alpr-model-specs 2026-11-20 03:17:38 +04:00
Sameh Khamis 644f8cf3f0 Merge pull request #1866 from bilawalsidhu/samehkhamis/no-focus-zoom
A phone no longer zooms the page when a text field gets focus
2026-11-19 15:16:03 -08:00
Sameh Khamis 54b6ba827e Merge branch 'main' into samehkhamis/start-layers 2026-11-19 15:12:01 -08:00
Sameh KhamisandManjunath Paparaju 91e42b887f Add the changelog entry for #1869
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 15:04:57 -08:00
Sameh Khamis efc03a3f6e Merge branch 'main' into samehkhamis/no-focus-zoom 2026-11-19 15:01:04 -08:00
Sameh KhamisandManjunath Paparaju 591650d786 Vue kit: the view scan forbids any hand-written button, glyph, checkbox or range
viewControls.test.mjs now reads every SFC outside the kit for a raw
<button>, a tag whose class (static or bound) names a Material Symbols
style, a native checkbox, and a native range other than the radio tuner's
and the world timeline's. It also reads every module under src outside the
kit, tests and test support for a button, select, input or textarea built
with createElement, or a Material Symbols class written in script. Every
check passes on main as it stands; each was confirmed to fail when its
violation is put back (a button, a glyph span, a checkbox, a range, a
script-built button and a script-written glyph class).

docs/VUE-MIGRATION.md says that no view hand-writes a control the kit has,
names the native fields left and points at the scan.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 14:59:16 -08:00
Sameh Khamis b57d50fe18 Merge pull request #1868 from bilawalsidhu/samehkhamis/kit-sweep-photo-globe
Vue kit: Street Level's photo viewer is a Vue view
2026-11-19 14:57:16 -08:00
Sameh Khamis c2e5ed271e Merge branch 'main' into samehkhamis/no-focus-zoom 2026-11-19 14:48:02 -08:00
Sameh Khamis cc73059f2b Merge branch 'main' into samehkhamis/kit-sweep-photo-globe 2026-11-19 14:45:25 -08:00
German Khokhlov 99ba768c49 Merge pull request #1808 from bilawalsidhu/german/cctv-camera-counts
Show how many cameras a thinned CCTV marker stands for
2026-11-20 02:43:00 +04:00
Sameh Khamis e4df80cb09 Merge branch 'main' into samehkhamis/no-focus-zoom 2026-11-19 14:32:41 -08:00
Sameh Khamis be1a0ae837 Merge branch 'main' into samehkhamis/start-layers 2026-11-19 14:32:26 -08:00
Sameh KhamisandManjunath Paparaju 9c6152911a Add the changelog entry for #1868
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 14:31:45 -08:00
German Khokhlov 374efbedc1 Merge branch 'main' into german/cctv-camera-counts 2026-11-20 02:29:12 +04:00
Sameh Khamis 848d528316 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-photo-globe
# Conflicts:
#	docs/VUE-MIGRATION.md
#	scripts/format-scope.json
2026-11-19 14:25:42 -08:00
Sameh Khamis 1e049c5eec Merge pull request #1865 from bilawalsidhu/samehkhamis/kit-sweep-bhote-koshi
Vue kit: Bhote Koshi's buttons and media cards are kit controls and a view
2026-11-19 14:25:37 -08:00
Sameh Khamis 23837768e1 Add the changelog entry for #1867 2026-11-19 14:19:55 -08:00
Sameh Khamis ca98ed1919 feat(app): a host names the layers a bare address starts with
createApplicationControls takes startLayers, the layer ids that turn on when
the address carries no link (none by default). They restore through the
passive start-up path, so they are never written as the user's own choice, and
a link's own layers always win.
2026-11-19 14:19:45 -08:00
Sameh Khamis 03301082fe Add the changelog entry for #1866 2026-11-19 14:17:31 -08:00
Sameh Khamis 340f3b59ab fix(ui): a phone no longer zooms the page when a text field gets focus
iPhone Safari zooms the page in whenever a text field under 16 px gets focus,
and every field in the app is under 16 px, so tapping the search box left the
page zoomed in with its buttons out of reach. The viewport now has a maximum
scale of 1, as map pages usually do: the map handles pinch zoom itself, and
iPhones still let a pinch zoom the page.
2026-11-19 14:17:23 -08:00
Sameh KhamisandManjunath Paparaju 017f1988df Add the changelog entry for #1865
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 14:11:41 -08:00
Sameh Khamis 36ef856ca2 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-bhote-koshi
# Conflicts:
#	scripts/format-scope.json
2026-11-19 14:07:36 -08:00
Sameh Khamis e02f6c6e39 Merge pull request #1864 from bilawalsidhu/samehkhamis/kit-sweep-missions-radio
Vue kit: missions', Contacts', Radio's and key setup's buttons and glyphs are kit controls
2026-11-19 14:07:24 -08:00
German Khokhlov b322ac1df9 Merge remote-tracking branch 'origin/main' into german/cctv-camera-counts 2026-11-20 02:02:08 +04:00
German Khokhlov aba4c9e533 fix(cctv): keep a clicked group in frame and let counts take clicks over plain fills
- The flight after a count click checks the frame on both axes and at the
  height of the highest mount, so a group on a slope or in a very wide
  window stays in view; when it cannot, it flies to the nearest cell with
  two or more cameras, never to a lone camera that joined the count.
- A count takes a click over a background fill no layer owns (earthquake
  discs, fire perimeters), and still yields to a scene item another layer
  registered.
- A count crossing the HUD edge refreshes the view only when the active
  icon or a lone camera depends on it, and never mid-motion, so panning no
  longer runs extra full view passes.
- A count restored at the HUD edge keeps the lone cameras its outline
  covers, and leaves the others as icons.
2026-11-20 02:02:06 +04:00
Sameh KhamisandManjunath Paparaju 92010a3b5e Add the changelog entry for #1864
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 13:55:11 -08:00
Sameh KhamisandManjunath Paparaju 2a0e21774b Street Level photo viewer: fresh elements per mount, and one viewer drawn
Fixes from review of the move to StreetLevelPhotoViewer:

- Each mount and each panorama canvas now takes a key no viewer reuses,
  and the view keys its root by the mount. Before, switching KartaView and
  Panoramax in one tick let Vue patch the old viewer's canvas, whose
  destroyed renderer had lost its context, into the new one, so 360°
  photos fell back to their front view.
- Of the viewers mounting in the host, the view draws the one mounted
  last, by mount key (photoViewers.js, which subscribePhotoViewer() now
  uses), whatever order they present in. A viewer still mounting when a
  later one is drawn is superseded: it unmounts and its mount fails as
  closed, rather than staying pending and being drawn once the later one
  goes.
- A panorama's first image is uploaded once the view has drawn its canvas
  shown (the view hands the canvas back on every draw), so it is never
  sized into a hidden canvas.
- The tests' fake view now draws as Vue does: once per tick with the final
  value, keeping elements while their keys are unchanged and handing every
  element back on each draw. StreetLevelPhotoViewer.test.mjs covers the
  switch in one tick and the overtaken mount with the real view.
- The guard test's check that the photo viewer writes no DOM covers
  inserting, moving, removing and replacing elements, attributes, classes,
  styles and the hidden, disabled and text properties.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 13:52:36 -08:00
Sameh Khamis 0f6db03e12 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-missions-radio
# Conflicts:
#	docs/VUE-MIGRATION.md
#	scripts/format-scope.json
2026-11-19 13:50:26 -08:00
Sameh Khamis 6f339b5377 Merge pull request #1863 from bilawalsidhu/samehkhamis/kit-sweep-draw
Vue kit: Draw's and Import's buttons and glyphs are kit controls
2026-11-19 13:50:22 -08:00
Sameh KhamisandManjunath Paparaju 13e8ceab1c Add the changelog entry for #1863
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 13:36:31 -08:00
Sameh KhamisandManjunath Paparaju 766364f691 Vue kit: Street Level's photo viewer is a view with kit buttons
The photo viewer KartaView and Panoramax share (photoViewer.js) no longer
builds its root, picture, panorama canvas and ‹ › buttons in script. It
presents them through subscribeView(), which the street-level layer
gathers in subscribePhotoViewer(); the application shell publishes that
to the gev-street-level-photo store, and StreetLevelPhotoViewer, beside
the Street Level panel in the layer panels, teleports the viewer into the
viewer host with the same classes, data attributes, labels and order. Its
‹ and › are ghost UiButtons. The view forwards keys, pointers, wheel, the
step clicks and a lost WebGL context to the viewer and hands each element
back: the canvas the panorama is drawn on (a fresh, keyed one after a lost
context, which an open now waits for), and the frame, picture, root and
buttons the viewer measures and keeps focus with. The viewer keeps every
decision: loading, upgrades, size limits, keys, drag, pinch, zoom, Esc on
the viewer's box and focus when a step button disables. The street-level
layer still needs no Vue; with no view subscribed these photos cannot
mount, which docs/VUE-MIGRATION.md records.

The provider and viewer tests draw the viewer with a fake view in
kartaViewFakes.mjs; StreetLevelPhotoViewer.test.mjs runs the real view on
a page, and streetLevelPhotoControls.test.mjs pins the kit controls. The
panel page's lost-graphics notice in globePanelRuntime.js stays built in
script, as the document now says.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 13:33:58 -08:00
Sameh Khamis 25cbd124d5 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-draw
# Conflicts:
#	docs/VUE-MIGRATION.md
2026-11-19 13:29:56 -08:00
Sameh Khamis cbb108d40c Merge pull request #1862 from bilawalsidhu/samehkhamis/kit-sweep-chat-voice
Vue kit: the chat panel's and voice control's buttons and glyphs are kit controls
2026-11-19 13:29:53 -08:00