Commit Graph
3719 Commits
Author SHA1 Message Date
German Khokhlov 1b78f86b17 Merge remote-tracking branch 'origin/main' into fix/cockpit-utility-phone-row 2026-11-20 13:14:11 +04:00
German Khokhlov 17cec5a8bb Merge branch 'main' into feat/paraguay-acaray-yacyreta 2026-11-20 12:19:38 +04:00
German Khokhlov 49785e423d fix(cockpit): scope the centred phone row and keep Stories unread in Cockpit
The centred Display/Radio row now applies only inside the phone shell
(720 px and below) on flight and bridge views; satellite and provider
cockpits, narrow short windows (under 390x450) and very short windows
(under 240 px) keep main's right-anchored place, so the row no longer
lands on the desktop rail, orbital zoom, LOOK AHEAD, Reset or the Stories
button. The row sizes to its launchers instead of spanning the width.

The first-visit Stories announcement stays hidden and unread while
Cockpit is open: a Stories tap that Cockpit refuses no longer marks it
seen, so it shows again after Exit.

The unit tests and the Cockpit QA cover the phone boundary, glyph and
side taps, the destination cue, short and narrow windows and the
announcement's return.
2026-11-20 11:39:45 +04:00
Sameh Khamis 763b892716 Merge branch 'main' into samehkhamis/grounded-military-height 2026-11-19 20:49:31 -08:00
Sameh Khamis 22275814fb Merge branch 'main' into samehkhamis/grounded-military-height 2026-11-19 20:34:59 -08:00
Sameh Khamis 91dee5dabe Merge remote-tracking branch 'origin/main' into samehkhamis/omnibar-above-timeline 2026-11-19 20:32:04 -08:00
Sameh Khamis 9b10489454 Keep a landed aircraft on the ground, not at its approach height
A grounded row with no altitude fell back to the aircraft's sticky
altitude, which straight after a landing is still the approach height.
Military contacts then hung there for as long as they stayed on the
ground (the grounded floor only ever raises a height); civil contacts
held it until the ground cell under them warmed, which for a contact far
from the viewer is never. The 3D model is ground-snapped on its own, so
the plane dropped when the model took over.

A grounded contact with no altitude now uses only an altitude it gave
on the ground, else the ground fallback. Labels, the tracked readout
and the follow distance read "On the ground" / no flight level instead
of the approach altitude.
2026-11-19 20:22:33 -08:00
Sameh Khamis 893bc5b5f3 The search dock sits above the World Timeline on desktop
The bar takes the dock's floor and the dock, with the search field, rises by
the bar's height while it shows, as the dock does outside the search layout.
The bar no longer hides while search results or the chat and voice panels
open, since they open upward from the dock and no longer cover it.
2026-11-19 20:15:49 -08:00
Sameh Khamis 65778a173c Merge branch 'main' into samehkhamis/imagery-shows 2026-11-19 20:09:35 -08:00
Sameh Khamis edd51d58fd Weather imagery and shells say what they show
An imagery spec and a raster shell take an optional `shows`, such as
'clouds' or 'radar'. Drawing never depends on it; a renderer may use it
to tell such a layer apart. The weather layer sets it for every product,
'clouds' for both cloud products.
2026-11-19 19:45:20 -08:00
Sameh Khamis 11cfc560d8 Merge branch 'main' into samehkhamis/video-check-starts-red 2026-11-19 19:34:09 -08:00
Sameh Khamis c9a78153ac globe.imagery.video: paint the test video red before recording starts
The check recorded a canvas that stayed blank until its first 20 ms paint
tick, so on a loaded runner the video's opening frames were dark and the
pixel early in the segment read (28, 54) instead of red: main failed once
after #1872 and passed on the runs around it.
2026-11-19 19:21:10 -08:00
Sameh Khamis e3a17c527b Parameter defaults test: name the forms that break, and read single-file components and .mjs modules too 2026-11-19 19:02:10 -08:00
Sameh Khamis 84b60a92e0 Read the weather texture limit and the reveal time in the body, not in a parameter default
esbuild compiles an optional method call reached through an optional chain
(`a?.b?.()`) in a parameter's default, for browsers it lowers optional
chaining for (Chrome and Edge before 91), into code that reads a variable out
of its scope. The weather shell's texture limit was read that way, so every
satellite frame threw a ReferenceError in the built app and the layer showed
"Weather imagery unavailable"; the leader and card reveal took their default
time the same way. A test now refuses the form anywhere under src/.
2026-11-19 18:59:10 -08:00
Sameh Khamis 93c68281d9 Merge branch 'main' into samehkhamis/omnibar-centred 2026-11-19 17:10:42 -08:00
Sameh Khamis 17bfc203c5 Merge branch 'main' into samehkhamis/find-it 2026-11-19 16:56:33 -08:00
Sameh Khamis ff7b8e68c5 Centre the phone Omnibar when no language picker sits beside it
On a phone the field kept 60px on its right for the language picker even
where the application shows none, so it sat left of centre. It now keeps
16px either side, and leaves the picker its room only while it is there.
2026-11-19 16:56:10 -08:00
Sameh Khamis eb7d92db66 Merge remote-tracking branch 'origin/main' into samehkhamis/street-level-photo-followups 2026-11-19 16:32:27 -08:00
Sameh KhamisandManjunath Paparaju 8c40eb957b Street Level photo viewer: take a moved-off canvas back, and close a mount unmounted in its first draw
A canvas the panorama moved off (a second view drew its own) is no longer
ignored for good: its draws are counted, so an open waiting on one goes on,
and once a single view is left its canvas is taken back. Before, after the
second view left, the next 360° open waited forever and the panorama stayed
on the departed view's canvas.

A mount whose view unmounts it inside its first draw now fails as closed,
as every other unmounted mount does, rather than with a TypeError.

Both found in review; each new test fails without its fix.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 16:31:34 -08:00
Sameh KhamisandManjunath Paparaju 22485dcb01 Street Level photo viewer: a failed mount spares the next, stable keyless ranks
Second review follow-ups:

- A mount woken without being drawn unmounts only its own presentation:
  an earlier mount overtaken by a second mount of the same viewer fails
  as closed and leaves the second one mounted and presented.
- A mount whose last view left fails only if no view has subscribed
  since; one subscribed in the same tick draws it.
- Mount keys come from photoViewers.js's nextViewKey(), and a keyless
  presentation is stamped from the same counter when any picker first
  sees it, kept until it presents null: its rank no longer depends on the
  picker's lifetime or the order it subscribes in.
- A canvas handed back while a panorama's open waits on its draw takes
  the panorama: the open builds its renderer there instead of falling
  back to the front view. A canvas the panorama moved off is not moved
  back to, so two views drawing their own cannot take it in turns.
- The guard test also refuses compound writes (+=, ||=, ??=, &&=…),
  destructuring writes to properties, Object.assign (other than onto a
  new Error), Object.defineProperty and Reflect.set, and a catch binding
  that shadows loadImage's image.

Nothing changes in the running app.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 16:23:42 -08:00
Sameh KhamisandManjunath Paparaju e6f21777ba Street Level photo viewer: keyless ranking, closed waits, a moved canvas
Review follow-ups to the previous commit:

- photoViewers.js ranks a presentation without a mountKey as mounted when
  it began presenting (after the latest key seen, before any later mount),
  so a photo viewer mounting while a keyless one shows is drawn and the
  keyless one superseded; supersede is queued whenever more than one
  presents after any change, not only when the pick changes.
- A panorama's open still waiting on a draw when the last view leaves
  fails as closed and leaves no photo shown, instead of uploading to a
  canvas never drawn. A mount waiting on its first draw then also fails as
  closed and is unmounted, so a view subscribing later sees nothing.
- A view handing back another canvas element than the renderer's drops
  the renderer and draws the panorama again on the new one, as after a
  lost context.
- The guard test allows a .src write in loadImage only on the one `image`
  binding, created by new Image() and never rebound or shadowed, and
  refuses `(expr).src =` and bracket property writes anywhere.
- The test fakes' shared view is reset before each test
  (resetPhotoView), so a viewer left by an earlier test is neither drawn
  with nor superseded by a later test's.

Nothing changes in the running app.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 16:04:21 -08:00
Sameh Khamis 250a78c0f9 Merge branch 'main' into samehkhamis/start-layers 2026-11-19 15:54:31 -08:00
Sameh KhamisandManjunath Paparaju 33ac0545ef Street Level photo viewer: settle opens, a gapless picker, a stated contract
Follow-ups to the photo viewer's move to a Vue view (#1868):

- A panorama's open waits for a draw of the canvas counted from before it
  is shown, so a view that draws at once inside its listener no longer
  leaves the open pending; and when the last view unsubscribes, an open
  waiting on a draw goes on instead of hanging.
- photoViewers.js supersedes the mounts not drawn on a microtask, after
  the winning presentation has reached every subscriber: a second
  subscriber sees the earlier mount, then the later one, never null
  between.
- A presentation without a mountKey counts as the latest mount (among
  several without, the one that began presenting last), and one without
  actions or supersede is passed over without throwing. Both fields are
  documented on ViewerAdapter.subscribeView in registry.js and in the
  store's comment.
- The guard test also refuses .width, .height, .ariaLabel, .id and .value
  writes in photoViewer.js, and .src writes outside loadImage, where only
  the off-page Image it creates may take one.
- The test fakes draw every viewer through one shared view behind
  photoViewers.js's picker, as the application does, so provider and
  layer tests see supersede.

Nothing changes in the running app.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 15:48:50 -08:00
Sameh Khamis 22e9c58d84 Find a selected vessel or aircraft again from its card
While a selected vessel, aircraft or military aircraft is off screen, behind
the globe or out of its layer's feed, its Context card shows Find it. One
still in its feed is flown to (an aircraft followed). One out of its feed is
looked up on its own track at the layer's time (the world clock's while the
layer follows it), the card moves to that reading and says how old it is, and
the camera flies there; once the feed has it again its layer selects it again.
With no reading at or before the time the card says so and the camera stays.

A vessel its layer announces is named by its own id, as a click names it,
not by the context store's.
2026-11-19 15:40:31 -08:00
Sameh Khamis 5258f1b2a4 Merge branch 'main' into samehkhamis/start-layers 2026-11-19 15:39:50 -08:00
German Khokhlov fa4b4adeae test(dams): run the Acaray and Yacyretá layer check on main's test doubles
The separate layer test built a fake viewer with the old Cesium interface,
which fails on current main. Move it into src/data/infrastructure.test.mjs on
the fake ground renderer and input port, with one table and one parse of
dams.geojsonl for both checks. Compare source_url exactly and check
retrieved_at, and cover the dams attribution and both new records in the
find_infrastructure tests.

Also trim the dataset README section (keep both dams as polygons), drop the
outdated "does not refresh or relicense" sentence, keep provenance out of the
License cell, rename the changelog fragment after the change, and restore the
accent in the test name.
2026-11-20 03:36:30 +04:00
Sameh Khamis 19369349b0 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-final-scan 2026-11-19 15:31:56 -08:00
Sameh KhamisandManjunath Paparaju 559a7cec71 Vue kit: the view scan reads SFC scripts, string markup and bound types
Following review, the scan now also:
- reads every SFC's script blocks, not only modules;
- matches a createElement call Prettier wraps over lines, and any case of
  the tag name;
- fails on a button, select, input or textarea written as markup in a
  string, comments aside, apart from the globe panel's standalone page
  (plain HTML a host serves, with no Vue or kit), which the test names and
  requires to still be the reason;
- catches a Material class built in a template string;
- reads an input's type when bound to a quoted literal or named in a
  v-bind object, in any case, and unquoted before `/>`;
- catches a Material class named in a v-bind object.
Each new path was confirmed to fail when its violation is put back.

docs/VUE-MIGRATION.md now names the globe panel page as the exception,
lists the two text areas among the native fields left, and notes that the
scene dialog's field takes text-like types from its callers only.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 15:31:47 -08:00
German Khokhlov aa5ab7d387 Merge branch 'main' into feat/alpr-model-specs 2026-11-20 03:17:38 +04:00
Sameh Khamis 54b6ba827e Merge branch 'main' into samehkhamis/start-layers 2026-11-19 15:12:01 -08:00
Sameh KhamisandManjunath Paparaju 591650d786 Vue kit: the view scan forbids any hand-written button, glyph, checkbox or range
viewControls.test.mjs now reads every SFC outside the kit for a raw
<button>, a tag whose class (static or bound) names a Material Symbols
style, a native checkbox, and a native range other than the radio tuner's
and the world timeline's. It also reads every module under src outside the
kit, tests and test support for a button, select, input or textarea built
with createElement, or a Material Symbols class written in script. Every
check passes on main as it stands; each was confirmed to fail when its
violation is put back (a button, a glyph span, a checkbox, a range, a
script-built button and a script-written glyph class).

docs/VUE-MIGRATION.md says that no view hand-writes a control the kit has,
names the native fields left and points at the scan.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 14:59:16 -08:00
Sameh Khamis cc73059f2b Merge branch 'main' into samehkhamis/kit-sweep-photo-globe 2026-11-19 14:45:25 -08:00
Sameh Khamis be1a0ae837 Merge branch 'main' into samehkhamis/start-layers 2026-11-19 14:32:26 -08:00
German Khokhlov 374efbedc1 Merge branch 'main' into german/cctv-camera-counts 2026-11-20 02:29:12 +04:00
Sameh Khamis 848d528316 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-photo-globe
# Conflicts:
#	docs/VUE-MIGRATION.md
#	scripts/format-scope.json
2026-11-19 14:25:42 -08:00
Sameh Khamis ca98ed1919 feat(app): a host names the layers a bare address starts with
createApplicationControls takes startLayers, the layer ids that turn on when
the address carries no link (none by default). They restore through the
passive start-up path, so they are never written as the user's own choice, and
a link's own layers always win.
2026-11-19 14:19:45 -08:00
Sameh Khamis 36ef856ca2 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-bhote-koshi
# Conflicts:
#	scripts/format-scope.json
2026-11-19 14:07:36 -08:00
German Khokhlov b322ac1df9 Merge remote-tracking branch 'origin/main' into german/cctv-camera-counts 2026-11-20 02:02:08 +04:00
German Khokhlov aba4c9e533 fix(cctv): keep a clicked group in frame and let counts take clicks over plain fills
- The flight after a count click checks the frame on both axes and at the
  height of the highest mount, so a group on a slope or in a very wide
  window stays in view; when it cannot, it flies to the nearest cell with
  two or more cameras, never to a lone camera that joined the count.
- A count takes a click over a background fill no layer owns (earthquake
  discs, fire perimeters), and still yields to a scene item another layer
  registered.
- A count crossing the HUD edge refreshes the view only when the active
  icon or a lone camera depends on it, and never mid-motion, so panning no
  longer runs extra full view passes.
- A count restored at the HUD edge keeps the lone cameras its outline
  covers, and leaves the others as icons.
2026-11-20 02:02:06 +04:00
Sameh KhamisandManjunath Paparaju 2a0e21774b Street Level photo viewer: fresh elements per mount, and one viewer drawn
Fixes from review of the move to StreetLevelPhotoViewer:

- Each mount and each panorama canvas now takes a key no viewer reuses,
  and the view keys its root by the mount. Before, switching KartaView and
  Panoramax in one tick let Vue patch the old viewer's canvas, whose
  destroyed renderer had lost its context, into the new one, so 360°
  photos fell back to their front view.
- Of the viewers mounting in the host, the view draws the one mounted
  last, by mount key (photoViewers.js, which subscribePhotoViewer() now
  uses), whatever order they present in. A viewer still mounting when a
  later one is drawn is superseded: it unmounts and its mount fails as
  closed, rather than staying pending and being drawn once the later one
  goes.
- A panorama's first image is uploaded once the view has drawn its canvas
  shown (the view hands the canvas back on every draw), so it is never
  sized into a hidden canvas.
- The tests' fake view now draws as Vue does: once per tick with the final
  value, keeping elements while their keys are unchanged and handing every
  element back on each draw. StreetLevelPhotoViewer.test.mjs covers the
  switch in one tick and the overtaken mount with the real view.
- The guard test's check that the photo viewer writes no DOM covers
  inserting, moving, removing and replacing elements, attributes, classes,
  styles and the hidden, disabled and text properties.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 13:52:36 -08:00
Sameh Khamis 0f6db03e12 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-missions-radio
# Conflicts:
#	docs/VUE-MIGRATION.md
#	scripts/format-scope.json
2026-11-19 13:50:26 -08:00
Sameh KhamisandManjunath Paparaju 766364f691 Vue kit: Street Level's photo viewer is a view with kit buttons
The photo viewer KartaView and Panoramax share (photoViewer.js) no longer
builds its root, picture, panorama canvas and ‹ › buttons in script. It
presents them through subscribeView(), which the street-level layer
gathers in subscribePhotoViewer(); the application shell publishes that
to the gev-street-level-photo store, and StreetLevelPhotoViewer, beside
the Street Level panel in the layer panels, teleports the viewer into the
viewer host with the same classes, data attributes, labels and order. Its
‹ and › are ghost UiButtons. The view forwards keys, pointers, wheel, the
step clicks and a lost WebGL context to the viewer and hands each element
back: the canvas the panorama is drawn on (a fresh, keyed one after a lost
context, which an open now waits for), and the frame, picture, root and
buttons the viewer measures and keeps focus with. The viewer keeps every
decision: loading, upgrades, size limits, keys, drag, pinch, zoom, Esc on
the viewer's box and focus when a step button disables. The street-level
layer still needs no Vue; with no view subscribed these photos cannot
mount, which docs/VUE-MIGRATION.md records.

The provider and viewer tests draw the viewer with a fake view in
kartaViewFakes.mjs; StreetLevelPhotoViewer.test.mjs runs the real view on
a page, and streetLevelPhotoControls.test.mjs pins the kit controls. The
panel page's lost-graphics notice in globePanelRuntime.js stays built in
script, as the document now says.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 13:33:58 -08:00
Sameh Khamis 25cbd124d5 Merge remote-tracking branch 'origin/main' into samehkhamis/kit-sweep-draw
# Conflicts:
#	docs/VUE-MIGRATION.md
2026-11-19 13:29:56 -08:00
Sameh Khamis b95c913130 Merge branch 'main' into samehkhamis/kit-sweep-chat-voice 2026-11-19 13:16:28 -08:00
Sameh KhamisandManjunath Paparaju d93d430516 Test that the Bhote Koshi cinematic button is pressed while it owns the camera
The event layer's tests now check the button's pressed state: true once a replay claims the camera, false once the operator releases it. Before, only the panel view's test covered it, with hand-built records.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 13:08:25 -08:00
Sameh Khamis e3a1223090 Merge branch 'main' into samehkhamis/kit-sweep-chat-voice 2026-11-19 13:03:17 -08:00
Sameh KhamisandManjunath Paparaju 545beaee87 Vue kit: Bhote Koshi's buttons and media cards are kit controls and a view
The reconstruction panel's buttons (previous and next beat, Play, Play
scene, Cinematic, Full story, Open original, Lower gorge, the field
reports and Open public map) are ghost UiButtons that keep their
data-action hooks. Cinematic is a pressed toggle: the event layer now
presents its state as the record's `pressed` instead of writing an
aria-pressed attribute, so it is no longer an exception in
viewControls.test.mjs; bhote-koshi.css still reads aria-pressed, so it
takes no pressed class.

The embedded media cards (frame, leader line, title, status, original
link) and the hidden YouTube preload are drawn by BhoteKoshiMediaCards,
which bhoteKoshiEmbeddedMedia.js renders into its overlay root with h()
and render() on every change and on a locale change, in place of the
markup it built with createElement and innerHTML. Placement after each
frame, provider loading, preloads, timers and teardown are unchanged. The
script still builds the SDK script and preconnect tags, the overlay root
and the Facebook player node, which is warmed hidden before its card
exists and carried loaded into the card, where the SDK replaces it.

bhoteKoshiControls.test.mjs pins it; the media tests run on a DOM.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-19 13:01:28 -08:00
Sameh Khamis 488a980315 Merge branch 'main' into samehkhamis/bare-address-defaults 2026-11-19 12:54:40 -08:00
German Khokhlov 17b75e8896 Merge main into feat/paraguay-acaray-yacyreta
Resolve the counter conflicts: 4,352 datacenters from main and 706 dams from
this branch; keep main's CURRENT-STATE source table and README layout.
2026-11-20 00:44:20 +04:00
Sameh Khamis 222c152360 Merge branch 'main' into fix/zoom-freeze-under-icons 2026-11-19 12:41:34 -08:00