The event layer's tests now check the button's pressed state: true once a replay claims the camera, false once the operator releases it. Before, only the panel view's test covered it, with hand-built records.
Co-authored-by: Manjunath Paparaju <[email protected]>
The reconstruction panel's buttons (previous and next beat, Play, Play
scene, Cinematic, Full story, Open original, Lower gorge, the field
reports and Open public map) are ghost UiButtons that keep their
data-action hooks. Cinematic is a pressed toggle: the event layer now
presents its state as the record's `pressed` instead of writing an
aria-pressed attribute, so it is no longer an exception in
viewControls.test.mjs; bhote-koshi.css still reads aria-pressed, so it
takes no pressed class.
The embedded media cards (frame, leader line, title, status, original
link) and the hidden YouTube preload are drawn by BhoteKoshiMediaCards,
which bhoteKoshiEmbeddedMedia.js renders into its overlay root with h()
and render() on every change and on a locale change, in place of the
markup it built with createElement and innerHTML. Placement after each
frame, provider loading, preloads, timers and teardown are unchanged. The
script still builds the SDK script and preconnect tags, the overlay root
and the Facebook player node, which is warmed hidden before its card
exists and carried loaded into the card, where the SDK replaces it.
bhoteKoshiControls.test.mjs pins it; the media tests run on a DOM.
Co-authored-by: Manjunath Paparaju <[email protected]>
The Space Missions panel's buttons (a mission's roster row, FOCUS, the
replay's pause, PREV, NEXT and SHOW ALL / DESELECT, beside REPLAY ASCENT
and the two closes that already were), the Contacts panel's PREV, FOCUS,
NEXT and contact rows, the Radio panel's PREV, PLAY, NEXT and STOP, the
RTL-SDR card's Locate, Change device, Tune and the two seeks, and the key
setup's POWER UP chip, REMOVE, voice auth toggle and SAVE KEYS are ghost
UiButtons keeping their ids, classes, data-*, aria-*, titles and
listeners. PLAY and Locate keep their own active class (their words
change with their state), so they gain no aria-pressed. The chip's bolt
is a UiIcon with :size="null", so provider-settings.css still sizes it.
The card's FM frequency stays a native number field (the kit has none)
and the radio tuner's range stays native, as documented. None of these
owners renders synchronously, so no slot needs redrawWithView.
src/ui/kit/missionsRadioControls.test.mjs pins it; docs/VUE-MIGRATION.md
describes the surface and no longer calls the key setup chip a plain
button. radioPanel.test.mjs reads PLAY's Core classes without the kit's.
Co-authored-by: Manjunath Paparaju <[email protected]>
Layer choices saved in local storage were restored whenever the address carried
no link, so clearing the address and loading the bare URL brought the last
session's layers back and there was no way to a reset view. Start-up no longer
reads them: a link restores what its hash carries, and a bare address starts
from the defaults.
UTILITIES ▸ Draw and Import no longer hand-write a button or a Material
Symbols span. Clear and Import are ghost UiButtons (Draw already was), and
the Draw and Import glyphs are UiIcons that keep pp-icon, with
:size="null" so controls.css still sizes them. Draw's five colour swatches
(in the toolbar and in a drawn shape's row) are ghost UiButtons that keep
role="radio", aria-checked and their own active class; they are not
pressed toggles. A drawn shape's row (its swatch, show/hide, the
application's row actions and fly to) is on the kit too, beside the remove
UiCloseButton it already had; its glyphs are UiIcons with :size="null".
Show/hide keeps naming itself Show … / Hide … rather than becoming a
pressed toggle.
Template refs that now hold a component reach the button through $el:
the swatches' arrow-key focus and Import's focus fallback when the last
imported file goes.
The Street Level panel's controls were already kit controls (its ⤢ ⤡ and
⚠ are text characters), so its template is unchanged; the new guard test
pins it with Draw and Import.
src/ui/kit/drawControls.test.mjs pins it: no hand-written button, select,
checkbox, range or Material span in DrawControls, DrawSwatches,
DrawMarkList, GeoImport or StreetLevelPanel; the kit counts per file;
Draw a pressed toggle with active; the swatches radios rather than
pressed; :size="null" on every glyph; and the $el refs.
docs/VUE-MIGRATION.md describes the surface.
Co-authored-by: Manjunath Paparaju <[email protected]>
Every hand-written button in the AI chat panel (Settings, the quick
prompts, an attachment's remove, Attach layer, Attach a file, Expand
conversation, the command suggestions, Expand chat, Add attachment and
Send / Stop reply) and in the voice control (Open AI chat, Back to chat,
Back to voice, the Preview and Settings tabs and the error tray's
DISMISS) is a ghost UiButton keeping its id, classes, aria and data
attributes, title and listeners. The Settings and tab Material glyphs are
UiIcons with :size="null", so voice-cost.css and voice-card.css still
size them. The tabs keep role="tab" and aria-selected; DISMISS is a text
button, so it stays a UiButton rather than a UiCloseButton. The inline
SVG glyphs, the message box, the file picker and the minutes field stay
as they are.
src/ui/kit/chatVoiceControls.test.mjs pins it: no hand-written button or
Material span in the chat, voice, voice card, panel layout and visualizer
templates, kit counts per file, the pressed toggles through :pressed, the
icons' :size="null", the native fields left, and no button built in script
by the voice modules. docs/VUE-MIGRATION.md describes the surface.
Co-authored-by: Manjunath Paparaju <[email protected]>
Below 150 km Cesium sizes a zoom step from the depth it picks at the canvas
centre. Since #1835 an icon drawn over depth wrote a depth just past the near
plane, which that pick took for a surface a near plane's distance from the
camera: zooming in returned early and zooming out moved by centimetres.
Over-depth rows now write a depth of exactly 0 in the fragment shader. It is
never discarded (the flicker #1835 fixed stays fixed) and the depth pick
reads it as nothing drawn, keeping the ground under the icon.
Adds scripts/qa-zoom-under-icon.mjs (real browser) and a source-level unit
test.
Every hand-written button in the Cockpit HUD (CockpitView, the utility
strip, the briefing and Contact cards, the signal rows, the orbital view
and the bridge radar) is a ghost UiButton that keeps its id, classes,
data and aria attributes, title and listeners, so the Cockpit controller
and the cockpit stylesheets still find it. Radio's Enable, the briefing's
Auto and the Contact card's Weather are pressed toggles written as
:pressed="Boolean(...)". Every Material Symbols span (the rim pointers,
reticle, heading caret, vision and card chevrons, panel glyphs, the
contact and route arrows, the rail and view switcher glyphs) is a UiIcon
with :size="null", so the cockpit rules still size it.
The orbital view's focus hand-off reads each UiButton ref's $el. The
heading caret's rule now reads `.cockpit-compass .cockpit-heading-caret`
so it still outranks kit.css's `.ui-icon` display and line height, which
load after cockpit.css. The Cockpit markup test reads the Reset and Exit
buttons' attributes in any order.
src/ui/kit/cockpitControls.test.mjs pins it: no hand-written button,
Material span, select, checkbox or range in the Cockpit views, the kit
counts per file, the pressed toggles and the caret rule.
Co-authored-by: Manjunath Paparaju <[email protected]>
Every hand-written <button> in the locale picker, phone tab bar, globe
actions (Clear, Share, Reset) and compass, imagery divider handle, scene
sharing dialog, layer group index, title logo, Exit clean view, the HUD's
cockpit entry, News card face, rail card header, layer row toggle, credits
line's Data attribution and the camera calibration chips is a ghost
UiButton keeping its id, classes, data-*, aria-* and listeners. Their
Material Symbols spans (tab icons, globe actions, compass needle, cockpit
entry, celestial ring sun and moon) are UiIcons with :size="null".
The Omnibar guide's extra rings, one per further target of a step, are now
drawn by OmnibarGuide.vue from view.subRings instead of being built in
script; startGuide() still reads them from the rendered tree and sets
their boxes each frame.
A UiButton's slot renders inside the button, so under an owner that
patches synchronously (News cards, rail cards, the credits line, the
Omnibar guide's Skip, Offer and Next) a change the button's attributes do
not carry would land a tick late. Those slots are given under a named
condition that is always true (v-if="redrawWithView"), which Vue redraws
with the view.
src/ui/kit/smallSurfacesControls.test.mjs pins it; docs/VUE-MIGRATION.md
describes the surface and the conditional slot.
Co-authored-by: Manjunath Paparaju <[email protected]>
The command dock's six style buttons, its two tray toggles, Location's
collapse and the search toggle are ghost UiButtons. The style buttons are
pressed toggles with `active` as their pressed class (Normal is pressed
until a style is published), so they now carry aria-pressed.
The Context panel's two tabs, Contacts, the cockpit entry and SEARCH
NEARBY SITES are ghost UiButtons; the tabs and Contacts stay role="tab"
controls with aria-selected and their own active class. The view context
it shows while nothing is picked (an off layer's worldwide tile, an
item's row, the place and layer chips and Ask GEV) is on the kit too; the
worldwide tile is a div or a UiButton rather than a dynamic component.
Every Material glyph in the three templates is a UiIcon with
:size="null", so the site rules still size them; an item's motion glyph
keeps role="img" and its name, with the kit's aria-hidden taken off.
src/ui/kit/commandDockControls.test.mjs pins it; the markup tests that
matched the old button source or class text read the kit's markup, and
docs/VUE-MIGRATION.md describes the surface.
Co-authored-by: Manjunath Paparaju <[email protected]>
docs/VUE-MIGRATION.md says every select is a UiSelect, every close button
a UiCloseButton and (nearly) every pressed toggle a UiButton. Make those
true in code, correct the sentences that were not, and pin them.
Selects: Story Explore's sort, the chat's layer picker and a layer row's
range ends are UiSelects. The range ends take `hold`, since the layer
panel repaints the row on a later frame.
Close buttons: the space mission replay's Cancel is a bare UiCloseButton.
An imported file's row actions (show or hide, fly to, remove) are icon
UiButtons drawing the icon the file import names, so Remove stays one of
them; the presenter's `pressed` is now a boolean.
Pressed toggles: the tilt-map button, the scene action buttons, the chat
and voice panels' dock (and its minimize), the Context header's search
and expand, Recent Imagery's day chips, SWAP and ZOOM IN, the rail row
lists and the rail cards' action chips are UiButtons with `pressed` (and
`pressed-class="active"` where their active class came from the same
state). Their Material glyphs, and the rail chips' icons, are UiIcons
with `:size="null"`. Bhote Koshi's cinematic button keeps the attributes
its layer writes, and Explore's story cards stay role="button" elements.
Docs: the kit list gains UiPanelToggle and UiPanelEdge; the pressed-toggle,
chips, Stories search fields, role="dialog", close button, range and
source-reading-tests sentences now say what the code does.
Tests: src/ui/kit/viewControls.test.mjs walks every .vue outside the kit
and fails on a raw select, a hand-written aria-pressed on a button,
UiButton or role="button" element (outside the two documented
exceptions), or a hand-written close glyph button. closeButtons.test.mjs
also catches a × inside a span.
Co-authored-by: Manjunath Paparaju <[email protected]>
- Name the G3 record "AutoVu SharpV G3" and the SharpX record "XGA", so a
bare SharpV or SharpX tag shows no specs without a separate wrapper.
- Reuse the CCTV layer's Bosch MIC-7522-Z30 record instead of a copy.
- Drop the brand from the SPEC line when the equipment line already names
it, so long lines fit the card; pass the summary to entity properties.
- Fall back to the OSM `brand` tag when `manufacturer` is missing.
- Reject non-string or overlong model/manufacturer values before matching.
- Remove the unused `brandAliases` parameter; shorten JSDoc and comments.
- Cover the tile `model` path and the megapixel summary in tests; fold
duplicate tests into existing ones.
- Docs and changelog: the default hourly extract has no `model`; any
source that supplies it shows the SPEC line.
- A count click stands aside when an overlay label or another layer's card
already took the click, and CCTV now claims a count click in the shared
pick registry, so the flights layer no longer reads it as an empty-map
click and keeps tracking its aircraft.
- The flight to a group halves the distance only while the group stays in
frame; otherwise it flies to the nearest ground cell of the group, so a
tilted click no longer ends with no camera on screen.
- Counts hidden under the HUD no longer push the active icon aside, and a
lone camera that would move a merged count under the HUD leaves the
original count and its icon as they were.
- Cameras on one mount are spread before counts merge, so a spread icon no
longer slides under a neighbouring count.
- The ground module comment says how a camera without a batch height takes
the drawn terrain.