Commit Graph
1916 Commits
Author SHA1 Message Date
Sameh Khamis 4fae7fb278 fix(gbfs): adapt redirect hardening to provider modules and bound body reads 2026-09-12 15:13:14 -07:00
Tom-NeverwinterandClaude Sonnet 5 feba5af0b9 Add OpenSeaMap / OpenSnowMap overlay layers (#10)
Two independently toggleable open-data raster overlays — OpenSeaMap
sea marks (buoys, lighthouses, ports) and OpenSnowMap ski pistes —
drawn as Cesium.ImageryLayers directly on the Cesium globe surface.
Same "small array of descriptors" shape as MAP_STACKS in
mapStackController.js.

Visible on the osm/bing-aerial/bing-labels map stacks and invisible
(not broken — the layer's stats say so in plain text) on the default
photoreal stack, since Google Photorealistic 3D Tiles render with the
globe hidden.

OpenRailwayMap and OpenInfraMap, also requested in #10, are
deliberately NOT included in this pass: OpenRailwayMap's public tile
server enforces a Referer allowlist scoped to its own site (confirmed
by direct request — every other Referer, including none, 403s), and
OpenInfraMap serves MapLibre GL vector tiles, not raster XYZ — that
would need a genuine vector-tile rendering pipeline, not a
Cesium.ImageryLayer drop-in. Worth its own dedicated pass.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
2026-09-12 17:07:33 -05:00
DESTAQandSameh Khamis db49edf363 fix(terrain): keep cold height requests within the browser deadline (#348)
Use 64-point browser and upstream terrain batches to reduce cold-cache timeouts. Preserve successful chunk results, distinguish absent readings from malformed responses, and reject fabricated zero heights.

Original terrain resilience contribution by ItzDESTAQ, with browser batching, validation and regression follow-up by Sameh Khamis.

Validated with unit/build/format/boundary checks, 108 tracking checks, 5 terrain-outage checks, controlled slow-upstream comparison and live browser checks.

Co-authored-by: ItzDESTAQ <[email protected]>
Co-authored-by: Sameh Khamis <[email protected]>
2026-09-12 14:04:08 -07:00
Sameh Khamis 5223b6df5b style: format extracted local services 2026-09-12 13:01:49 -07:00
Sameh Khamis 233285fe12 test: retain radio schema and voice mutation checks after formatting 2026-09-12 13:01:49 -07:00
Sameh Khamis a64a622b6d test: pin voice schemas independently of source formatting 2026-09-12 13:00:43 -07:00
Sameh Khamis cd92855f88 refactor: isolate standalone key setup and service composition 2026-09-12 12:59:39 -07:00
Sameh Khamis 638902296a refactor: separate local voice handlers and instructions 2026-09-12 12:59:39 -07:00
Sameh Khamis 280fc00a51 fix: return JSON errors for unmatched local API routes
Test development and built-preview route registration, preserve development-only credential editing, and document local preview configuration.
2026-09-12 12:43:54 -07:00
Sameh Khamis c69416ff6b style: adopt formatting for CCTV and radio provider modules 2026-09-12 12:09:04 -07:00
Sameh Khamis 79b4929b88 refactor: extract CCTV media and radio directory providers 2026-09-12 12:09:02 -07:00
Sameh Khamis c6462be066 fix: simplify Google Maps provider setup 2026-09-12 11:36:23 -07:00
Sameh Khamis eadeac6c10 test: follow extracted FIRMS aggregation code 2026-09-11 22:01:12 -07:00
Sameh Khamis a2d6461b52 style: format terrain traffic fire and bike-share modules 2026-09-11 21:57:51 -07:00
Sameh Khamis f4054469d5 refactor: split terrain traffic fire and bike-share providers 2026-09-11 21:57:50 -07:00
Sameh Khamis 290afd808d style: format satellite and launch provider modules 2026-09-11 21:22:41 -07:00
Sameh Khamis 9a4b98700e refactor: split satellite and launch provider modules 2026-09-11 21:22:15 -07:00
Sameh Khamis 38b591863c fix: preserve landmark identity when resolving annotation outlines 2026-09-11 21:07:32 -07:00
Sameh Khamis 7e6d89d8f5 style: format extracted place and route modules 2026-09-11 19:57:22 -07:00
Sameh Khamis 2793d7a8df refactor: extract place-search and routing provider modules 2026-09-11 19:56:48 -07:00
Sameh Khamis 2e3cb6270a test: keep provider fixtures independent of calendar time 2026-09-11 19:08:02 -07:00
Sameh Khamis f9a85528fe style: format extracted live provider modules 2026-09-11 19:06:10 -07:00
Sameh Khamis 0e221441b4 refactor: separate aircraft and vessel server providers 2026-09-11 19:06:09 -07:00
Sameh Khamis fb67024f43 style: format standalone configuration and build boundaries 2026-09-11 18:08:26 -07:00
Sameh Khamis 8de1018c21 refactor: separate standalone Vite wiring and provider middleware 2026-09-11 18:08:01 -07:00
Sameh Khamis 8666705e12 style: adopt application modules into scoped formatting 2026-09-11 17:03:35 -07:00
Sameh Khamis 4d37760314 refactor: extract application construction and lifecycle 2026-09-11 17:02:54 -07:00
Sameh Khamis f70b5a3631 style: format the reusable infrastructure component 2026-09-11 16:07:53 -07:00
Sameh Khamis 04f4d54bfe test: allow line wrapping in the stem buffer regression pin 2026-09-11 16:07:53 -07:00
Sameh Khamis 76ddc6a9ef chore: enforce scoped formatting and browser package boundaries 2026-09-11 16:06:35 -07:00
Tom-NeverwinterandSameh Khamis 205c58efbd fix: separate Google browser and server keys (#110)
Use a separate optional server key for Places and Street View, with consistent local and Pinokio configuration, server-first CLI selection, and credential isolation checks.

Original contribution by Tom-Neverwinter; reviewed and completed by Sameh Khamis.

Co-authored-by: Tom-Neverwinter <[email protected]>
Co-authored-by: Sameh Khamis <[email protected]>
2026-09-11 15:08:23 -07:00
Sameh Khamis ed15c5b38e style: remove inherited trailing whitespace from extracted layer 2026-09-11 13:35:52 -07:00
Sameh Khamis 106a794afa fix: preserve standalone overlay defaults for undefined overrides 2026-09-11 13:32:49 -07:00
Sameh Khamis 4688eca9af test: verify infrastructure consumer asset paths and imports 2026-09-11 13:28:55 -07:00
Sameh Khamis 142bf583f8 refactor: export infrastructure layers with explicit application callbacks 2026-09-11 13:21:22 -07:00
Sameh Khamis e465197cee fix: dispose pending infrastructure loads and entity contexts 2026-09-11 13:18:59 -07:00
Sameh Khamis 412ee211b5 fix(infrastructure): follow refined terrain after initial sampling 2026-09-11 09:05:41 -07:00
Sameh Khamis b5568de9fa fix(infrastructure): stop idle republishing and respect settled terrain
Skip unchanged overlay cohorts while detecting moved positions and lifecycle changes. Defer ground sampling until visible terrain settles, retain the loaded surface as a floor, and preserve roof heights and bounded retries. Keep regression and idle-render gates intact.
2026-09-11 08:59:32 -07:00
Bilawal Sidhu 6dd00d1e76 fix(infrastructure): declutter stems and correct close-up sizing 2026-09-11 08:59:32 -07:00
manjunath22466 5228ab9e40 fix: preserve keyboard focus and separate Space activation from voice
Keep focus visible across controls and stable during Contacts, Cockpit and mission roster updates. Preserve native short Space activation, and claim push-to-talk only after a 500 ms hold. Add panel Escape handling and keyboard-accessible attribution controls.

Retains the Map Source foundation contributed in https://github.com/bilawalsidhu/gods-eye-view/pull/171.
2026-09-10 23:48:12 -07:00
Sameh Khamis f47cd792d1 fix: share CCTV startup and keep proxy diagnostics bounded 2026-09-10 23:01:51 -07:00
Sameh Khamis 231d339e92 test(a11y): cover delayed and interrupted Map Source focus
Keep the Esri settlement assertion exact, verify selected-source focus and Tab departure in Chromium, cancel pending work during disposal, and document the focused behavior.
2026-09-10 22:12:48 -07:00
manjunath22466 60812df34c fix(a11y): keep Map Source focus on the selected source and cancel stale requests
Build on Tom-Neverwinter’s Map Source focus retry. Prefer the selected tile, and revoke delayed focus when the user moves focus, clicks, or closes the tray.
2026-09-10 22:08:49 -07:00
Sameh Khamis 5dfef8e891 Merge main and narrow the change to Map Source focus and QA 2026-09-10 22:07:41 -07:00
Sameh Khamis 3d526f208d Merge main and narrow accessible input names to useful controls 2026-09-10 21:33:45 -07:00
mwilliamsGH e7cb08f5f6 fix(firms): record source success after aggregation (#181)
Record FIRMS source success after appending its rows so aggregation failures do not produce contradictory source status. Cover large feeds, filtering, ordering and source failures with regression tests.
2026-09-10 21:13:46 -07:00
Malek 87a92c8bc4 fix(radio): resolve common country exonyms Intl.DisplayNames omits (#232)
Recognize common country names and exonyms in Radio country requests and station filtering. Keep ambiguous country names rejected.
2026-09-10 21:01:39 -07:00
onionviolet a4b6dbb41f fix(launches): preserve unknown payload details 2026-09-10 23:29:55 -04:00
Sameh Khamis ac3926c7db fix(earthquakes): reject malformed feature properties 2026-09-10 19:56:01 -07:00
Tom-NeverwinterandClaude Opus 5 0584a1d71d fix: sanitize proxy error payloads, loopback dev-cctv, drop doc drift
Four small, independently-verified issues from the audit backlog:

- #262/#263: the celestrak, terrain-heights, adsbdb and launch-library
  proxies put raw `err.message` / raw upstream error bodies into HTTP
  responses, contradicting the sanitized-error property KNOWN-ISSUES.md
  documents. They now log the real error server-side (matching the GBFS
  and CCTV proxy convention) and return a generic message.
- #265: scripts/dev-cctv.sh defaulted to HOST=0.0.0.0 while dev-fresh.sh
  and dev-secure.sh default to loopback. Now loopback, opt in with
  HOST=0.0.0.0.
- #274: naturalEarthRegions.js's internal haversineKm took (lon, lat,
  lon, lat) while every other haversineKm in src/ takes (lat, lon, lat,
  lon). Same name, same signature shape, opposite order — a silent
  wrong-distance landmine. Reordered to match; the one call site was
  updated, so behavior is unchanged.
- #270: removed CCTV_AUTO_CALIBRATE and CCTV_DRAPE_MESH from
  .env.example; no code anywhere reads them.

Not done: deduplicating the ~10 haversine implementations into one
shared utility. That is issue #188's scope and a far larger diff;
removing the argument-order landmine is what makes the current state
safe.

Verified: npm test (2705 pass / 0 fail), npm run build green.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01C3eGYgDYBo2BCUeDGwGvrp
2026-09-10 15:24:57 -05:00