Commit Graph
44 Commits
Author SHA1 Message Date
Sameh KhamisandManjunath Paparaju b363f9b09b Catch a recovery phrase quoted »like this« or ‚like this‘
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:58:22 -08:00
Sameh KhamisandManjunath Paparaju bf1e313301 Catch a recovery phrase in curly or angle quotes
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:39:01 -08:00
Sameh KhamisandManjunath Paparaju 406a5003e0 Keep a code private before "thanks," with a trailing comma
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:17:39 -08:00
Sameh KhamisandManjunath Paparaju 9b6683a9cd Read requests about a map as requests, catch quoted or dash-joined phrases, and an en dash before "thanks"
Words a request about a map is made of (near, today, open, find …) count
with the map words, so "find good food open now near this area today"
is a request; a phrase is let through about once in a hundred. Phrases
quoted, numbered "1:", "#1" or "[1]", or joined by dashes, pipes,
slashes or dots are caught, and a code before " – thanks" is private.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 20:06:35 -08:00
Sameh KhamisandManjunath Paparaju 49ad1b7b73 Catch a recovery phrase numbered "(1) … (2) …"
Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 19:45:38 -08:00
Sameh KhamisandManjunath Paparaju 94dcadf54f Tell lists of places from recovery phrases by four map words in any twelve, keep " - thanks" codes private, and trim long tails at once
The map words cover 108 BIP39 words for places, buildings, vehicles and
the land; twelve list words in a row with four of them are a list of
places, which a random phrase is about once in three hundred. A code
followed by " - thanks" is private again, and the IPv6 and bearer trims
no longer slow on long runs of commas or brackets.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 19:34:48 -08:00
Sameh KhamisandManjunath Paparaju f75f42d3ca Read lists of places as places, not recovery phrases, and keep code tails fast
Twelve BIP39 words in a row with three words for places or things on a map
("coffee, bar, hotel, museum, park …") are a list, not a phrase; a random
phrase has three of them about once in two hundred. A code's value and the
courtesy word after it no longer overlap, and trailing punctuation is
trimmed from a word's end only, so a long run of hyphens is read at once.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 19:13:04 -08:00
Sameh KhamisandManjunath Paparaju 3f5221b837 Withhold an SSN's last four, a code before ", thanks" and a recovery phrase written with commas or numbers
"ssn ending 1234" and "ssn last four 1234" are private again, as before
this change; a code may be followed by a comma, "cheers", "thanks a
lot" or more than one "!"; a recovery phrase is twelve BIP39 words in a
row, so commas, numbering, a closing period or "my seed is" before it no
longer hide it. The spelled-out email patterns start only at a word, which
keeps long inputs fast.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 18:38:13 -08:00
Sameh KhamisandManjunath Paparaju 2487500927 Read recovery phrases against the BIP39 list, and fix four more privacy readings
A recovery phrase is now twelve to twenty-four words that are all on the
BIP39 English list, so a long request ("show every plane over london then
…") reaches Ask GEV while a phrase holding "find" or "please" is still
caught. A time in brackets is no IPv6 address (only a bracketed host after
"//" is), "St 123456 A" is no National Insurance number (spaced in pairs or
not at all), "my, ID 12345" keeps its owner, a partial "ssn 1" stays
private while typed, any CVV value is private, and a code followed by
"thanks" or "now" is still a code. Idaho's reading no longer slows down on
very long lines.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 18:17:22 -08:00
Sameh KhamisandManjunath Paparaju 2a4079e9f8 Keep SSNs with "is", "Bearer:" values and codes in capitals private, and let West Point through
"ssn is 123456" and a masked "ssn: xxx-xx-1234", "Bearer: island", codes
in capitals after their label ("OTP ABCDEF", "PIN ABCD", any CVV), a
document number or ID right after its colon, "lockbox number 4821", a UK
National Insurance number in lower case and an IPv6 host in a link are
private. A recovery phrase starting with "find" or holding "please" (both
on its word list) is caught. "Point" is not read as a spelled dot, so
"meet at West Point tomorrow" is looked up, and Idaho's code follows a town
written in any case ("BOISE ID 83702", "Coeur d'Alene ID 83814").

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 17:21:32 -08:00
Sameh KhamisandManjunath Paparaju 200c788ac1 Let Idaho, questions and long place names through, and keep more tokens and codes private
"Boise ID 83702" names Idaho rather than an identity number. A long question
for the assistant is no recovery phrase: a phrase holds none of the common
words its list lacks ("the", "and", "are"). A long lower-case place name
is no passphrase, an address of up to ten words is sent as the Omnibar reads
it, and "mfa boston", "otp bank" and "security code plaza" are names.

"Authorization: Bearer" and any value after "bearer" but a place word are
tokens, and so are GitLab, Hugging Face and SendGrid keys and a code in a
link. Door, alarm and lockbox numbers (not a zip or area code), a spaced UK
National Insurance number, "my id is …", and emails spelled with "punto",
"period", a spaced dot or letter by letter are private too.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 17:13:12 -08:00
Sameh KhamisandManjunath Paparaju 35049fd7f7 Keep more shapes of phones, codes, tokens, emails and IP addresses private
Review found "Alice 555-0100" sent as a Japanese postcode, recovery phrases
with a repeated word, a capitalised bearer token, codes after a lower-case
label in other cases ("verification code Abc", "PIN aBcD"), "john at
gmail.com" and "(dot)" forms, passport numbers of digits only, "ID AB123"
and IPv6 addresses. They now stay in the browser, and the suggester never
sends a line of more than eight words. "Bearer Island, Canada", "bearer
island", a ZIP+4 after two spaces and a Japanese postcode after Japanese
script are looked up again.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 16:59:35 -08:00
Sameh KhamisandManjunath Paparaju 8885177e2e Keep spelled-out emails, IP addresses, recovery phrases and lower-case codes from the place service
Place suggestions still sent "john(at)gmail.com", "10.0.0.1", a wallet's
recovery phrase, a passphrase run together, "license ABC1234", lower-case
codes after a code label ("otp abcdef", "cvv abc") and short phone numbers
read as an address ("Jo 12345-6789", "Mo 0171 12345"), and a phone's three
and four digits could still be searched as a place on purpose. They now stay
in the browser. Real places that only looked private are looked up again:
Akiak, Bearer Island, SSN Station, Shibuya 150-0002. A suggested house is
named in its country's order ("Hauptstraße 12"), and one without a street
keeps its number.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 16:50:46 -08:00
Sameh KhamisandManjunath Paparaju 3404730d41 Let streets named for keys and codes through, and share a request in flight
From review of the first pass:
- Places again: "Secret Key Lake", "Access Token Road", "GATE CODE LANE",
  "OTP Bank", "Auth Code ABCD Street", "California 90210-1234",
  "Cambridge MA. 02139-4307", "12, 10115 Berlin". A key after a space must
  be long, a bare code must hold a digit or be capitals after a label
  that is not and end the line, and ZIP+4 follows a state's code or name.
- Private now: "gate code: abcd", "PIN A7B2", "OTP-ABCDEF", "login code
  ab-12-cd", "auth_token=abc".
- The same text asked while its request is out waits for that answer,
  however slow it is.
- A street without a house number is not named by the street alone.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 14:45:05 -08:00
Sameh KhamisandManjunath Paparaju b7a9fa1c21 Keep more private text from place suggestions, and name houses by their street
- Not sent any more: "john @Gmail.com" (a capital after "@"), "030 12345"
  and "Alice 12345-6789" (read as a house number and postcode),
  "access_token=abcdef", a key in quotes or brackets, and letter codes
  after a code label ("OTP: ABCDEF", "verification code ABCDEF").
- Sent now: "10 Downing Street SW1A2AA, London" (the comma hid the
  postcode). "Pin Oak" and "Gate Code Lane" stay places.
- A house Photon returns without a name is named by its number and street,
  so 10 and 12 Downing Street are two suggestions, not one "London".
- The same text asked twice at once is sent once.
- The village pack's build finds twins near the poles and across 180°;
  the shipped tiles are unchanged.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 14:45:05 -08:00
Sameh KhamisandManjunath Paparaju c06aa37ce2 Keep the place suggester's fair-use and privacy promises
- One spacing, pause and cache for the whole tab, so a search box put up
  again does not start afresh.
- A failed request or a timeout pauses suggestions for a minute, as a
  refusal does.
- A number named as a card, a phone or an account keeps its digits
  together, so no address is read out of them; a UK postcode written
  without its space is a place, not a password.
- The docs say exactly what is sent.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 12:20:42 -08:00
Manjunath PaparajuandSameh Khamis bd7b389cef Suggest places from Photon while a place is typed
The suggester asks Photon, the place search's keyless geocoder, for
candidates as a place is typed: at most one request every 500 ms, a six
second limit, and none for a minute after a refusal. Text that may be
private (an email address, seven or more digits however separated, an
IBAN shape, a password, PIN, token or key) is never sent. It also lists a
region's bundled cities and tells whether a place lies in an extent, for
the search box's place strip. The browser's Photon setting is read in one
place.

Co-authored-by: Sameh Khamis <[email protected]>
2026-11-18 12:20:42 -08:00
Sameh Khamis 6a4202242d MGRS squares touching the antimeridian read: the zone check compares longitudes unwrapped 2026-11-15 09:50:44 -08:00
Sameh Khamis 262de71fec Grid references decline dates and short words in capitals: MGRS to 100 m or finer, within its zone, not spelling a month; UTM N reads as the northern hemisphere 2026-11-15 09:48:35 -08:00
Sameh Khamis 4a61c755d9 Search reads degrees-minutes-seconds, UTM, MGRS and plus codes 2026-11-15 09:41:01 -08:00
daikaginza a64b41b3f0 Merge upstream/main 73c14ac74 2026-11-04 11:21:01 +07:00
manjunath 3824b4ebfc keep cancelled outline and search asks free during the Nominatim probe
Recheck the caller's signal right after the capability probe on every path, so an ask cleared while the probe is pending starts no outline or last-resort search request, whether the probe says configured, unknown or not configured.
2026-10-30 23:27:17 +05:30
manjunath f32ab5446b skip Nominatim lookups when the server has none configured
Add GET /api/geocode/status ({configured}), like /api/overpass/status. The outline client and the last-resort place search ask it once per page and send no lookup a server without a Nominatim endpoint would refuse, so a default install no longer logs a 503 on its first named landmark or grounds ask. An older server or a failed probe leaves the capability unknown and lookups proceed as before.
2026-10-30 22:33:55 +05:30
manjunath d4434aa6d7 feat(outlines): restore voice outlines without public Overpass
use bundled place boundaries and shared OpenFreeMap tiles before a guarded Nominatim fallback

preserve multipart shapes, holes and cancellation,
and keep pending annotations visible while ground sampling finishes across frames

keep non-Latin name distinctions when selecting provider results,
and retain an outline anchor only when it lies in filled geometry
2026-10-27 13:24:02 +00:00
Rudy Mizrahi Celekli b07352ea6a fix(search): read hemisphere letters separated from the number (#1340)
Support spaced hemisphere coordinates while rejecting malformed numeric fragments and ambiguous component assignments. Include regression tests and runtime documentation.

Contribution by @rudycelekli.
2026-10-24 23:39:51 -07:00
daikaginza 1133e6327a Merge upstream/main 93ea088f4 2026-10-18 13:36:40 +07:00
Sameh Khamis f0a04fbbaa Move the changelog entry into changelog.d and watch the Google geocode proxy in QA
Main now takes release notes as one fragment per pull request (#787). The browser asks Google through /api/google/geocode, so the no-geocoder-request check now watches that route.
2026-10-16 16:39:28 -07:00
Sameh Khamis ac258e98d9 Merge branch 'main' into feature/geo-uri-search
# Conflicts:
#	CHANGELOG.md
2026-10-16 16:39:21 -07:00
daikaginza 46717548c4 Merge remote-tracking branch 'upstream/main' into fix/api-method-guard
main renamed /api/opensky to /api/flights and /api/adsblol/mil to
/api/military, and each mount now also matches its /track route, handing it on
with next(). The GET check therefore sits after that hand-off, so a /track
request is never answered with the snapshot route's 405; a new test pins that,
and fails if the check is moved above the hand-off. Tests and notes use the new
paths.
2026-10-16 09:31:49 +07:00
Said TurkseverandClaude Opus 5.5 1fffdf7600 Merge upstream/main into fix/363-geocode-proxy
Resolve SECURITY.md against the Street View provider (#966): the browser
key now loads the Maps JavaScript API as well as Map Tiles, so the
'Map Tiles only' guidance becomes 'Map Tiles + Maps JavaScript API'
here and in CHANGELOG, CURRENT-STATE and google-key.js. The CHANGELOG
entry moves to [Unreleased]; its old section shipped in 0.2.0.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-15 14:28:26 +01:00
Rudy Celekli fa53eec53d fix(search): refuse empty coordinate components instead of silently dropping them 2026-10-12 11:10:42 -04:00
cj-vana 11bc2ec0ae feat(search): resolve two-dimensional geo URIs offline 2026-10-11 20:58:02 -06:00
manjunath22466 0343b4495e fix the remaining voice review gaps
keep analyst counts, speech, cards, cancellation, pointer capture, tool schema boundaries, and session lifetime consistent
add the exact Alps fallback and focused regression coverage
2026-10-05 04:37:28 +05:30
Niccolò Saggese 5083a74413 Merge remote-tracking branch 'upstream/main' into fix/363-geocode-proxy
# Conflicts:
#	CHANGELOG.md
2026-09-29 19:16:15 +02:00
daikaginza b09db55149 fix(server): declare the method contract on the three read-only query proxies
/api/opensky, /api/adsblol/mil and /api/route answered any verb with the same
body while ignoring the request entirely. Measured against a running server
before the change: POST /api/opensky returned 200 with 833,759 bytes of live
state vectors, POST /api/adsblol/mil returned 47,372 bytes. Their siblings do
not: /api/geocode, /api/weather and /api/transit answer 405, and /api/overpass
is deliberately POST-only.

These three are read-only query proxies, so they now answer 405 to anything but
GET, using the wording and shape /api/geocode already uses. The refusal comes
first, before rate limiting and before any upstream call, which the tests
assert by stubbing fetch to throw.

Scope, stated plainly: this is a consistency and intent fix. No rate limiter
was being bypassed — /api/route already limits every request regardless of
verb, and the two aircraft routes have no limiter at all, only 9s and 12s
server-side caches that bound upstream cost for any method.

One existing fixture in src/search/geospatial.test.mjs built a request without
a method, which a real Node request always has; it now sets GET.

Verified on a running server after the change: GET still 200 on all three,
POST 405 on all three, /api/overpass and the other proxies unchanged.
Suite goes from 5090 to 5092 tests, 0 failures.
2026-09-29 10:52:26 +07:00
Bilawal Sidhu 9559e7a282 feat(outlines): voice outlines without Overpass — bundled US places and neighborhoods, guarded Nominatim, OpenFreeMap streets and buildings 2026-09-28 22:49:23 -05:00
f4fcf267c6 fix(osm): stop using public Overpass by default (#648) (#742)
Traffic roads come from OpenFreeMap vector tiles, or TomTom flow tiles with a
key (Hybrid by default). Military areas use OpenFreeMap polygons with a bundled
worldwide name index; wide views show named points. ALPR reads an hourly
OpenStreetMap extract. Cockpit place context and country, state and US county
outlines use bundled Natural Earth and US Census data. Overpass is used only
when an operator configures their own endpoint.

Also: camera arrivals no longer land below ground, keyless terrain retries on
429, bounded relation geometry for configured Overpass, one shared
OpenStreetMap credit, and separate tile and API transports for embedders.

Co-authored-by: theGaryLarson <[email protected]>
Co-authored-by: Milan Khanal <[email protected]>
2026-09-28 19:07:57 -05:00
Niccolò Saggese c5b1d41cba fix(search): geocode through the server, not the browser
- Google's Geocoding web service refuses referrer-restricted keys, so the
  browser call forced GOOGLE_MAPS_API_KEY to ship unrestricted
- add /api/google/geocode and /api/google/reverse-geocode, using the server
  key like Places and Street View already do
- the browser key now needs the Map Tiles API only
2026-09-21 11:30:49 +02:00
Sameh Khamis a79208181f refactor: separate Nominatim transport from search composition 2026-09-14 22:14:51 -07:00
Sameh Khamis 66eb6d6a7c refactor: add configurable Nominatim adapter and portable source helpers 2026-09-14 22:08:16 -07:00
Bilawal Sidhuandsendmebits 7fa0cfbb26 feat(search): Nominatim as the last-resort geocoder (#573)
Supersedes #350 by @sendmebits, ported onto the current component layout with fixes from review.

Verified before merge: format, package boundaries, unit suite, build, and the browser tracking suite; a browser harness for the change where one applies; adversarial review applied.

Co-authored-by: sendmebits <[email protected]>
2026-09-14 21:22:08 -05:00
Bilawal SidhuandKuraPiee cca6442997 feat(search): coordinates and bundled presets resolve keyless (#572)
Supersedes #388 by @KuraPiee, ported onto the current component layout with fixes from review.

Verified before merge: format, package boundaries, unit suite, build, and the browser tracking suite; a browser harness for the change where one applies; adversarial review applied.

Co-authored-by: KuraPiee <[email protected]>
2026-09-14 21:18:07 -05:00
Sameh Khamis 8b36c28b06 refactor: compose configurable geocoding and route services 2026-09-13 21:23:13 -07:00
Sameh Khamis 57d7f9fc23 feat(search): compose Google and Photon through an explicit provider service 2026-09-12 15:38:43 -07:00