Releasing the tuning dial always started the chosen station, plus tuning
static, even when nothing was playing. It now follows the Previous/Next
rule: the release plays only if a stream was loading, buffering or playing
when the drag began; otherwise it just selects the station.
The privacy note no longer lists finishing tuning as a way to connect and
now names voice instead, in all locales. Docs, changelog and comments are
tightened to match.
- Selections take the playback fallback as a `playFallback` option and
set it after releasing a stale stream, instead of callers arming state
that the release then had to save and restore.
- Move the tuner `station-unavailable` release and the Pause label while
a stream connects out of this branch: both were wrong on main already
and go in a separate change.
- Share the Radio layer test setup in src/testSupport/radioLayerHarness.mjs
and fold overlapping Next/Previous tests (13 to 7).
- One-line comments and a two-line changelog entry.
Review follow-ups for HAL-722. A Next or Previous that only selects a
station now leaves nothing of the previous stream behind:
- Selecting another station without playing stops a paused or failed
stream, so the panel, Stop, voice summaries and the audio element agree
on "stopped". A fallback the caller armed for the new selection is kept.
- A silent UI step arms no broadcaster fallback, and a user Play of the
selected station drops one left by a cancelled voice step. Voice steps
pass `fallback: true` because voice starts the prepared playback later.
- A user step to another station emits a `select` playback control, and
the realtime voice handoff treats it like Pause and Stop.
- A tuner release onto a station the directory no longer has stops the
stream the drag paused, publishing one state with the gesture's origin,
so the button reads PLAY and a voice handoff is cancelled.
- The transport buttons offer Pause while a stream connects, matching
what a click does.
- The privacy note names every action that connects to a broadcaster
(play, finishing tuning, choosing a station on the globe) in all
locales.
The Next/Previous layer tests live in src/data/radioNextState.test.mjs.
The proxy now skips malformed upstream rows individually but counts
them, capped at 10,000, in the catalog metadata and the /stations
envelope (rejectedStationCount). The count never fails health policy,
so an otherwise healthy generation is still accepted. The client
validates the field, adds its own rejected rows after admission, and
reports degraded coverage when either side skipped rows. Adds an
end-to-end proxy-to-client test and aligns DATA_SOURCES.md and
CURRENT-STATE.md.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
An ESLint no-unused-vars scan over src, server, scripts, tools, build
and pinokio, repeated until it is stable, reported these.
Runtime modules keep every call and drop only the unread binding:
- src/ui/cockpitInput.js: the unread result of enter()/exit().
- src/layers/launches/rendering.js: the unread entity returned by
entities.add().
- src/layers/radio/rendering.js: the unread map key in the horizon scan,
which now iterates the map's values.
QA scripts and tools drop an unused helper, two unused in-page module
imports, unused counters and destructured fields, and an unread wait
result. Tests drop source files read into variables that no assertion
uses, redundant StyleManager imports (the shell-source helper already
imports it), and unused destructured fields.
The one remaining report is the `_` loop variable in src/tools/schema.js,
which counts iterations and is intentional.