With the Omnibar's lifted dock the right column rises level with the left
one, under the NEW GEV Stories card, whose buttons then took clicks meant
for the panel's controls (Street Level's FIT and FILL). The card is now an
obstacle for the right column, and its arrival or departure lays the
column out again.
Co-authored-by: Manjunath Paparaju <[email protected]>
Bugs:
- Cameras on one mount stay side by side after their geometry is built,
so a click or a settled view no longer folds them back into one icon.
- A count click yields to a card drawn over the marker and to another
layer's object under it, waits while the cockpit or tracking holds the
view, and flies at most halfway, so a long chain of cameras still splits.
- The active camera's icon is never covered by a count, transparent
corners of the marker no longer catch clicks, and a count hidden under
the HUD keeps its lone cameras.
- A lone camera joins only its nearest count and never bridges two; cameras
close enough to draw as icons take part too, at their drawn icon size.
- Groups across the antimeridian keep their longitude; the flight frames
the highest mount; markers on ground below the ellipsoid stay visible;
counts fade outside the Scope circle.
- Mounts less than a metre apart count as one mount.
- A drawn-terrain height survives a late fallback answer, is read for an
unresolved camera and for one projected off the window, is re-read when
the terrain under it finishes loading or the terrain source changes, and
the read budget no longer goes to the same misses each pass.
Cleanup: the glyph draws from one green SVG sprite instead of recolouring
pixels, marker-only constants move next to their use, layout tests check
behaviour rather than formulas, and docs and comments match the code.
docs/I18N.md names the one fixed notation of count badges as an exception.
From review:
- An error goes when a chip is chosen, and a search's error shows only
under the line it was for: a lookup that fails after the line was edited
says nothing under the new text.
- With voice on the field is hidden: "/" and Cmd/Ctrl+K no longer focus
it, and nothing is looked up for it.
- Without the action runner a refused or cancelled search keeps the line,
as the plan path does (only true is success).
- Text an input method is still composing is read when it is committed.
- A held or repeated Enter does not restart the same line over its flight.
- A city chip for the city whose landmarks are open flies there instead
of folding the landmarks.
- "villages around here" is looked up again for the current view.
- Data Layers takes the full lane only where the desktop dock is laid out,
by the condition omnibar-dock.css uses.
- On short phones the HUD readout moves under the field it shared a row
with.
- CURRENT-STATE says the phone gains a field and which places are kept.
Co-authored-by: Manjunath Paparaju <[email protected]>
A place row sent its name with its coordinates, and a name that matches a
city preset wins over them: "Paris, Texas" flew to Paris, France. Only the
coordinates go now. The bar's styles and dock tests join the format scope
and the bar its package.
Co-authored-by: Manjunath Paparaju <[email protected]>
On desktop the dock becomes one search bar (Omnibar.vue) that shows the
rows the line-reading pipeline makes: places with nearby suggestions,
coordinates, map items, layers, commands, plans such as "go to Austin and
show flights", guided walks through the real controls, and Ask GEV for
questions. Enter runs only what the line asks for outright. The map
credits move below the bar onto the Power Up row, the voice waveform
shows in the bar while voice is on, and the dock's Location and Visual
trays are hidden in this layout. The phone layout is unchanged. Long
place names are kept out of automatic Ask GEV.
Co-authored-by: Sameh Khamis <[email protected]>
From review of the first pass:
- Places again: "Secret Key Lake", "Access Token Road", "GATE CODE LANE",
"OTP Bank", "Auth Code ABCD Street", "California 90210-1234",
"Cambridge MA. 02139-4307", "12, 10115 Berlin". A key after a space must
be long, a bare code must hold a digit or be capitals after a label
that is not and end the line, and ZIP+4 follows a state's code or name.
- Private now: "gate code: abcd", "PIN A7B2", "OTP-ABCDEF", "login code
ab-12-cd", "auth_token=abc".
- The same text asked while its request is out waits for that answer,
however slow it is.
- A street without a house number is not named by the street alone.
Co-authored-by: Manjunath Paparaju <[email protected]>
- Not sent any more: "john @Gmail.com" (a capital after "@"), "030 12345"
and "Alice 12345-6789" (read as a house number and postcode),
"access_token=abcdef", a key in quotes or brackets, and letter codes
after a code label ("OTP: ABCDEF", "verification code ABCDEF").
- Sent now: "10 Downing Street SW1A2AA, London" (the comma hid the
postcode). "Pin Oak" and "Gate Code Lane" stay places.
- A house Photon returns without a name is named by its number and street,
so 10 and 12 Downing Street are two suggestions, not one "London".
- The same text asked twice at once is sent once.
- The village pack's build finds twins near the poles and across 180°;
the shipped tiles are unchanged.
Co-authored-by: Manjunath Paparaju <[email protected]>
- "hide flights near Left Bank, Paris" closed the left panel: a side is
closed only when the clause names nothing but the side.
- "flights near Trinidad and Tobago" looked up Trinidad alone, and "take me
to New York City NY" nothing (the command's words counted against the
name): the whole place is looked up, and the limit counts its words.
- "flights near 30.27, +97.74" and "30.27; -97.74" were split at the sign or
semicolon; both stay coordinates.
- "hide flights, show ships" listed "No layers are on": several requests in
a line are read as one plan, as with "and".
Co-authored-by: Manjunath Paparaju <[email protected]>
- "go to 30.27, -97.74", "go to 14R PU 2090 4906" and "flights near
30.27, -97.74" were refused as private (their digits) or sent to the
place service as text; coordinates named as the line's place are now a
spot to fly to, and the rest of the line is what the privacy rules read.
- A count ("flights over Texas") is offered only for a layer in or near
a place: "Ship Bottom", "Radio City Music Hall" and "radio settings"
are no longer counts that Enter would run.
- "go to ," sends nothing to the place service.
Co-authored-by: Manjunath Paparaju <[email protected]>
A pure pipeline the search box will show its rows from: omnibarIntent.js
parses a line (a place, a layer, a verb, a question, a panel's text),
omnibarEnter.js picks what Enter does, omnibarGuide.js answers "how do
I" for each feature, and omnibarRows.js turns all of it into rows. Its
strings are translated into every shipped language.
Co-authored-by: Sameh Khamis <[email protected]>
The fire layer module exports filterFires and DEFAULT_FIRE_FILTER, the filter its markers use, so an application drawing the same detections another way hides the same fires.
- A tile that cannot be read is left out of placesNear's answer instead of
failing it; without the pack's index the cities are still the answer.
- The build no longer inlines the small tiles into one chunk that loaded
with the first lookup: all 732 are their own files.
- A row at latitude 90 or longitude 180 is tiled where the lookups read it.
- --min-population 0 is taken as 0, not as the default.
Co-authored-by: Manjunath Paparaju <[email protected]>
137,662 places of 1,000 to 14,999 people that Wikidata gives a population
and coordinates for, none already in the cities pack, in 732 tiles of
5 x 5 degrees with an index of row counts (CC0). Nothing loads with the
app: a lookup reads the index once and then only the tiles it touches.
placesNear lists the places around a point, and findPlace finds a small
place by name near the view when no city of that name is near. The cities
build script writes the tiles with --tiles; the step from rows to files is
checked offline.
Co-authored-by: Sameh Khamis <[email protected]>
- The first height that replaces the entry frame's now moves only the
anchor's height. The anchor keeps its place and its eased lift, so the
camera no longer jumps to a corrected fix or steps back.
- A detail line is measured with the title's glyph widths. They are a
little wide for its smaller type, so a long detail line is no longer
clipped.
- The first aircraft update is checked in the existing test, and the copy
is removed; test fixtures are simpler.
- Comments, the release note and CURRENT-STATE match the code.
- A clock correction starts a new epoch, and playback may first draw its
second report. The turn point now resets on a new epoch as well as on a
break, so a standing train no longer turns around after a correction.
- recallDirection and earlierFixes are gone: comparing each earlier report
with the newest turned a standing train on GPS jitter. A train bound when
its line arrives late shows no direction until it has moved 15 m.
- Tests share reportDirections, iconOf and the playback helper.
- Comments and CURRENT-STATE match the code.
- One spacing, pause and cache for the whole tab, so a search box put up
again does not start afresh.
- A failed request or a timeout pauses suggestions for a minute, as a
refusal does.
- A number named as a card, a phone or an account keeps its digits
together, so no address is read out of them; a UK postcode written
without its space is a place, not a password.
- The docs say exactly what is sent.
Co-authored-by: Manjunath Paparaju <[email protected]>
The suggester asks Photon, the place search's keyless geocoder, for
candidates as a place is typed: at most one request every 500 ms, a six
second limit, and none for a minute after a refusal. Text that may be
private (an email address, seven or more digits however separated, an
IBAN shape, a password, PIN, token or key) is never sent. It also lists a
region's bundled cities and tells whether a place lies in an extent, for
the search box's place strip. The browser's Photon setting is read in one
place.
Co-authored-by: Sameh Khamis <[email protected]>
When the terrain height batch loses a chunk to the rate limit, the cameras
in it keep a sea-level fallback height. In the mountains that put them far
under the surface, so the view pass judged them by a point that was not
where they are drawn: a tilted view dropped the count marker, a click on
the marker framed empty ground, and icons drifted on tilt and pan.
- A camera with no real ground height takes the height of the terrain the
globe draws once it is near the screen (up to 300 reads a pass, through
the height service), and a later answer from the batch replaces it.
- A count marker is anchored to the drawn terrain under its centre, and a
click frames that ground.
- Cameras on one mount draw side by side, 30 px apart, each with its own
callout, instead of as one icon with several callouts.
The photoreal map stack is not covered: terrain is not the surface there.
A ground cell with one camera always drew its icon, so at some zooms a
camera poked out from under a count marker with its own callout.
An icon closer than the merge gap to a count marker now joins that marker:
the count grows by one and the icon, its callout and its card are not drawn.
Two lone cameras with no count beside them stay two icons, and the active
camera always keeps its own icon.
createApplicationTools({ library: { fetchImpl } }) hands the fetch to the library source, so a server that wants the application's credentials on its library routes answers the catalog instead of refusing it.
- The first floor height that replaces the entry frame's height re-anchors
the camera and resets the smoothed rise, so the subject stands on the
floor within a second instead of hovering above it.
- A provider's thenable gets one rejection handler; frame fields and eye
are read once each.
- A progress label's width counts the smaller detail line and full-width
and astral glyphs.
- Tests cover the first camera update of an aircraft and a vessel, a
double-click on a selected vessel, a tone-only Live Signals change and a
getter that throws on its second read; repeated cases share helpers.
- Comments, the release note and CURRENT-STATE say which height the camera
holds while it waits for the surface and how a Live Signals row keeps
its time.
- GPS jitter under 15 m at a standing train no longer turns it, in reports
and in playback; a reversal needs at least 15 m of movement.
- A standing train keeps its operator's last bearing through reports that
leave it out.
- Playback resets its turn point at a break, so a jump to a corrected
position is not a reversal.
- A train bound while its line is still loading takes its direction from
the movement it already made.
- A vehicle in view that leaves a Transit hold goes on from its own clock
instead of rewinding.
- Tests cover the 15 m boundary, the late line, the hold release and the
icon after Transit is turned back on; duplicate jitter tests are merged.
- FOLLOW_MIN_MOVE_M is gone; comments and CURRENT-STATE match the code.