Follow-ups to the photo viewer's move to a Vue view (#1868):
- A panorama's open waits for a draw of the canvas counted from before it
is shown, so a view that draws at once inside its listener no longer
leaves the open pending; and when the last view unsubscribes, an open
waiting on a draw goes on instead of hanging.
- photoViewers.js supersedes the mounts not drawn on a microtask, after
the winning presentation has reached every subscriber: a second
subscriber sees the earlier mount, then the later one, never null
between.
- A presentation without a mountKey counts as the latest mount (among
several without, the one that began presenting last), and one without
actions or supersede is passed over without throwing. Both fields are
documented on ViewerAdapter.subscribeView in registry.js and in the
store's comment.
- The guard test also refuses .width, .height, .ariaLabel, .id and .value
writes in photoViewer.js, and .src writes outside loadImage, where only
the off-page Image it creates may take one.
- The test fakes draw every viewer through one shared view behind
photoViewers.js's picker, as the application does, so provider and
layer tests see supersede.
Nothing changes in the running app.
Co-authored-by: Manjunath Paparaju <[email protected]>
The photo viewer KartaView and Panoramax share (photoViewer.js) no longer
builds its root, picture, panorama canvas and ‹ › buttons in script. It
presents them through subscribeView(), which the street-level layer
gathers in subscribePhotoViewer(); the application shell publishes that
to the gev-street-level-photo store, and StreetLevelPhotoViewer, beside
the Street Level panel in the layer panels, teleports the viewer into the
viewer host with the same classes, data attributes, labels and order. Its
‹ and › are ghost UiButtons. The view forwards keys, pointers, wheel, the
step clicks and a lost WebGL context to the viewer and hands each element
back: the canvas the panorama is drawn on (a fresh, keyed one after a lost
context, which an open now waits for), and the frame, picture, root and
buttons the viewer measures and keeps focus with. The viewer keeps every
decision: loading, upgrades, size limits, keys, drag, pinch, zoom, Esc on
the viewer's box and focus when a step button disables. The street-level
layer still needs no Vue; with no view subscribed these photos cannot
mount, which docs/VUE-MIGRATION.md records.
The provider and viewer tests draw the viewer with a fake view in
kartaViewFakes.mjs; StreetLevelPhotoViewer.test.mjs runs the real view on
a page, and streetLevelPhotoControls.test.mjs pins the kit controls. The
panel page's lost-graphics notice in globePanelRuntime.js stays built in
script, as the document now says.
Co-authored-by: Manjunath Paparaju <[email protected]>